rack-parser 0.1.0 → 0.1.1

data/README.md

@@ -1,6 +1,6 @@
 # Rack::Parser #
 
-Rack::Parser is a Rack Middleware for parsing post body data for JSON/XML, and custom
+Rack::Parser is a Rack Middleware for parsing post body data for JSON, XML, and custom
 content types using MultiJson, MultiXML, or any thing that you want to
 use.
 
@@ -48,13 +48,9 @@ engine of your choice by setting the engine like so:
 # app.rb
 
 MultiJson.engine = :yajl  # Yajl-ruby for json decoding
-MultiXml.parser = :libxml # libxml for XML parsing
+MultiXml.parser  = :libxml # libxml for XML parsing
 
-use Rack::Parser, :content_types => {
-  'application/json' => Proc.new { |body| MultiJson.decode body     },
-  'application/xml'  => Proc.new { |body| MultiXml.decode body      },
-  'application/roll' => Proc.new { |body| 'never gonna give you up' }
-  }
+use Rack::Parser
 ```
 
 To set your own custom engine that perhaps neither MultiJson or MultiXml
@@ -63,7 +59,9 @@ support, just make it a Proc:
 
 ```ruby
 use Rack::Parser, :content_types => {
-  'application/json' => Proc.new { |body| MyCustomJsonEngine.do_it body }
+  'application/json' => Proc.new { |body| MyCustomJsonEngine.do_it body },
+  'application/xml'  => Proc.new { |body| MyCustomXmlEngine.decode body },
+  'application/roll' => Proc.new { |body| 'never gonna give you up'     }
 }
 ```
 
@@ -98,9 +96,15 @@ This project came to being because of:
 * Rack::PostBodyContentTypeParser from rack-contrib which proved to be an inspiration for both libraries.
 
 
+## External Sources/Documentations
+
+* [Sinatra book contrib](https://github.com/sinatra/sinatra-book-contrib/blob/master/middleware/rack_parser.md) - mini tutorial on using rack-parser (thanks to [Eric Gjertsen](https://github.com/ericgj))
+
+
 ## Contributors ##
 
 * [Stephen Becker IV](https://github.com/sbeckeriv) - For initial custom error response handling work.
+* [Tom May](https://github.com/tommay) - skip loading post body unless content type is set.
 
 ## Copyright
 

data/Rakefile

@@ -4,6 +4,6 @@ require 'rake/testtask'
 Rake::TestTask.new(:test) do |test|
   test.libs << 'lib' << 'test'
   test.pattern = 'test/**/*_test.rb'
+  test.warning = true
   test.verbose = true
-  test.ruby_opts << '-rubygems'
 end

data/lib/rack/parser.rb

@@ -62,9 +62,9 @@ module Rack
     end
 
     def _call(env)
-      body = env[POST_BODY].read
-      return @app.call(env) if (body.respond_to?(:empty?) ? body.empty? : !body) # Send it down the stack immediately
       content_type = Rack::Request.new(env).media_type
+      body = env[POST_BODY].read if content_type
+      return @app.call(env) if (body.respond_to?(:empty?) ? body.empty? : !body) # Send it down the stack immediately
       begin
         result = @content_types[content_type].call(body)
         env.update FORM_HASH => result, FORM_INPUT => env[POST_BODY]

data/rack-parser.gemspec

@@ -3,12 +3,12 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "rack-parser"
-  s.version     = "0.1.0"
+  s.version     = "0.1.1"
   s.authors     = ["Arthur Chiu"]
   s.email       = ["mr.arthur.chiu@gmail.com"]
   s.homepage    = "https://www.github.com/achiu/rack-parser"
   s.summary     = %q{Rack Middleware for parsing post body data}
-  s.description = %q{Rack Middleware for parsing post body data for json/xml and various content types}
+  s.description = %q{Rack Middleware for parsing post body data for json, xml and various content types}
 
   s.rubyforge_project = "rack-parser"
 

data/test/parser_test.rb

@@ -75,4 +75,11 @@ context "Rack::Parser" do
     end
   end
 
+  context "for get with no content_type" do
+    setup { get '/' }
+
+    asserts(:status).equals 200
+    asserts(:body).matches %r{Hello world}
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-parser
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-08-19 00:00:00.000000000Z
+date: 2011-09-08 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
-  requirement: &2152833180 !ruby/object:Gem::Requirement
+  requirement: &2173199560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152833180
+  version_requirements: *2173199560
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &2152832740 !ruby/object:Gem::Requirement
+  requirement: &2173199120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152832740
+  version_requirements: *2173199120
 - !ruby/object:Gem::Dependency
   name: multi_xml
-  requirement: &2152832320 !ruby/object:Gem::Requirement
+  requirement: &2173198700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152832320
+  version_requirements: *2173198700
 - !ruby/object:Gem::Dependency
   name: riot
-  requirement: &2152831900 !ruby/object:Gem::Requirement
+  requirement: &2173198280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152831900
+  version_requirements: *2173198280
 - !ruby/object:Gem::Dependency
   name: rack-test
-  requirement: &2152831480 !ruby/object:Gem::Requirement
+  requirement: &2173197860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152831480
+  version_requirements: *2173197860
 - !ruby/object:Gem::Dependency
   name: json
-  requirement: &2152831060 !ruby/object:Gem::Requirement
+  requirement: &2173197440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,9 +76,9 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152831060
-description: Rack Middleware for parsing post body data for json/xml and various content
-  types
+  version_requirements: *2173197440
+description: Rack Middleware for parsing post body data for json, xml and various
+  content types
 email:
 - mr.arthur.chiu@gmail.com
 executables: []