rack-oauth2 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7ef29bbdc348bb5195d4482e65b58f450085c212d3f1b4ad0045f1196973bacd
-  data.tar.gz: 51cadd3c2b971bf1399aeaba0957c7acd275c2d1d6409703c8006397b888e649
+  metadata.gz: cc2833ffc404397f87ef3649c867783f4492cefab8eaceccadf7c18b740cf018
+  data.tar.gz: 8bbf82e5725bbf685681cfa99ada0d6dd0652bbbf741077e240163611f2077f5
 SHA512:
-  metadata.gz: a44b88e50ca6b93c4332fe87c2e9c2c35219b64c079218a28c33964f36bc0106788fb6dfaf2ec2e7028a18717c0bdbea86a6f142f94741fb8f4bcf4895a7717a
-  data.tar.gz: 78509ce82118c157cd5ef8b7d7be261010947f07d0220d44afd34852b7cdeb2a93eacd310cbd36491dfe63d3d395d2af36f293cb313d11c42eadd532ed8d0903
+  metadata.gz: d11c97df887b9c0e784d6dc322d61d9e7c9dd20f2e89ae118b2863449bf8bc5658642eb52808facec041a3b6ad64e805e8ee3ac84032567bdf5e13335c8b6337
+  data.tar.gz: fdca45ec17029200d4d743e52614ef4b4ae5b15d5e3248805b69890644e7f2867f387bac50ebd27803bdbead21942efaf6e53de127a7093257c140156ae64327

data/CHANGELOG.md

@@ -1,13 +1,12 @@
 ## [Unreleased]
 
-## [2.0.0.rc3] - 2022-10-09
+## [2.0.1] - 2022-10-09
 
-## Changed
+### Fixed
 
-- make url-encoded the default https://github.com/nov/rack-oauth2/commit/98faf139be4f5bf9ec6134d31f65a298259d8a8b
-- let faraday encode params https://github.com/nov/rack-oauth2/commit/f399b3afb8facb3635b8842baee8584bc4d3ce73
+- changes for mTLS on faraday by @nov in https://github.com/nov/rack-oauth2/pull/92
 
-## [2.0.0.rc2] - 2022-10-09
+## [2.0.0] - 2022-10-09
 
 ### Added
 
@@ -15,4 +14,6 @@
 
 ### Changed
 
-- Switch from httpclient to faraday v2 https://github.com/nov/rack-oauth2/pull/91
+- Switch from httpclient to faraday v2 https://github.com/nov/rack-oauth2/pull/91
+- make url-encoded the default https://github.com/nov/rack-oauth2/commit/98faf139be4f5bf9ec6134d31f65a298259d8a8b
+- let faraday encode params https://github.com/nov/rack-oauth2/commit/f399b3afb8facb3635b8842baee8584bc4d3ce73

data/VERSION

@@ -1 +1 @@
-2.0.0
+2.1.0

data/lib/rack/oauth2/access_token/legacy.rb

@@ -7,7 +7,7 @@ module Rack
           self.expires_in = (
             self.expires_in ||
             attributes[:expires]
-          ).try(:to_i)
+          )&.to_i
         end
 
         def authenticate(request)

data/lib/rack/oauth2/access_token/mtls.rb

@@ -7,8 +7,8 @@ module Rack
         def initialize(attributes = {})
           super
           self.token_type = :bearer
-          httpclient.ssl_config.client_key = private_key
-          httpclient.ssl_config.client_cert = certificate
+          http_client.ssl.client_key = private_key
+          http_client.ssl.client_cert = certificate
         end
       end
     end

data/lib/rack/oauth2/access_token.rb

@@ -5,7 +5,7 @@ module Rack
       attr_required :access_token, :token_type
       attr_optional :refresh_token, :expires_in, :scope
       attr_accessor :raw_attributes
-      delegate :get, :patch, :post, :put, :delete, to: :httpclient
+      delegate :get, :patch, :post, :put, :delete, to: :http_client
 
       alias_method :to_s, :access_token
 
@@ -18,8 +18,8 @@ module Rack
         attr_missing!
       end
 
-      def httpclient
-        @httpclient ||= Rack::OAuth2.http_client("#{self.class} (#{VERSION})") do |faraday|
+      def http_client
+        @http_client ||= Rack::OAuth2.http_client("#{self.class} (#{VERSION})") do |faraday|
           Authenticator.new(self).authenticate(faraday)
         end
       end

data/lib/rack/oauth2/client.rb

@@ -68,18 +68,22 @@ module Rack
         @forced_token_type = token_type.to_s
       end
 
-      def access_token!(*args)
-        headers, params, http_client, options = authenticated_context_from(*args)
+      def access_token!(*args, &local_http_config)
+        headers, params, http_client, options = authenticated_context_from(*args, &local_http_config)
         params[:scope] = Array(options.delete(:scope)).join(' ') if options[:scope].present?
         params.merge! @grant.as_json
         params.merge! options
         handle_response do
-          http_client.post(absolute_uri_for(token_endpoint), Util.compact_hash(params), headers)
+          http_client.post(
+            absolute_uri_for(token_endpoint),
+            Util.compact_hash(params),
+            headers
+          )
         end
       end
 
-      def revoke!(*args)
-        headers, params, http_client, options = authenticated_context_from(*args)
+      def revoke!(*args, &local_http_config)
+        headers, params, http_client, options = authenticated_context_from(*args, &local_http_config)
 
         params.merge! case
         when access_token = options.delete(:access_token)
@@ -122,15 +126,15 @@ module Rack
         _endpoint_.to_s
       end
 
-      def authenticated_context_from(*args)
+      def authenticated_context_from(*args, &local_http_config)
         headers, params = {}, {}
-        http_client = Rack::OAuth2.http_client
+        http_client = Rack::OAuth2.http_client(&local_http_config)
 
         # NOTE:
         #  Using Array#extract_options! for backward compatibility.
         #  Until v1.0.5, the first argument was 'client_auth_method' in scalar.
         options = args.extract_options!
-        client_auth_method = args.first || options.delete(:client_auth_method).try(:to_sym) || :basic
+        client_auth_method = args.first || options.delete(:client_auth_method)&.to_sym || :basic
 
         case client_auth_method
         when :basic
@@ -172,8 +176,8 @@ module Rack
           params.merge!(
             client_id: identifier
           )
-          http_client.ssl_config.client_key = private_key
-          http_client.ssl_config.client_cert = certificate
+          http_client.ssl.client_key = private_key
+          http_client.ssl.client_cert = certificate
         else
           params.merge!(
             client_id: identifier,
@@ -206,7 +210,7 @@ module Rack
 
       def handle_success_response(response)
         token_hash = JSON.parse(response.body).with_indifferent_access
-        case (@forced_token_type || token_hash[:token_type]).try(:downcase)
+        case (@forced_token_type || token_hash[:token_type])&.downcase
         when 'bearer'
           AccessToken::Bearer.new(token_hash)
         when nil

data/lib/rack/oauth2/server/extension/pkce.rb

@@ -27,7 +27,7 @@ module Rack
 
             def verify_code_verifier!(code_challenge, code_challenge_method = :S256)
               if code_verifier.present? || code_challenge.present?
-                case code_challenge_method.try(:to_sym)
+                case code_challenge_method&.to_sym
                 when :S256
                   code_challenge == Util.urlsafe_base64_encode(
                     OpenSSL::Digest::SHA256.digest(code_verifier.to_s)

data/lib/rack/oauth2.rb

@@ -44,7 +44,7 @@ module Rack
       Faraday.new(headers: {user_agent: agent_name}) do |faraday|
         faraday.request :url_encoded
         faraday.request :json
-        faraday.response :logger, Rack::OAuth2.logger if debugging?
+        faraday.response :logger, Rack::OAuth2.logger, {bodies: true} if debugging?
         faraday.adapter Faraday.default_adapter
         local_http_config&.call(faraday)
         http_config&.call(faraday)

data/spec/helpers/webmock_helper.rb

@@ -13,7 +13,7 @@ module WebMockHelper
 
   def request_for(method, options = {})
     request = {}
-    params = options.try(:[], :params) || {}
+    params = options&.[](:params) || {}
     case method
     when :post, :put, :delete
       request[:body] = params

data/spec/rack/oauth2/client_spec.rb

@@ -309,6 +309,23 @@ describe Rack::OAuth2::Client do
       end
     end
 
+    context 'local_http_config handling' do
+      it do
+        mock_response(
+          :post,
+          'https://server.example.com/oauth2/token',
+          'tokens/bearer.json',
+          request_header: {
+            'Authorization' => 'Basic Y2xpZW50X2lkOmNsaWVudF9zZWNyZXQ=',
+            'X-Foo' => 'bar'
+          }
+        )
+        client.access_token! do |request|
+          request.headers.merge! 'X-Foo' => 'bar'
+        end
+      end
+    end
+
     context 'when bearer token is given' do
       before do
         client.authorization_code = 'code'
@@ -433,6 +450,28 @@ describe Rack::OAuth2::Client do
   end
 
   describe '#revoke!' do
+    context 'local_http_config handling' do
+      it do
+        mock_response(
+          :post,
+          'https://server.example.com/oauth2/revoke',
+          'blank',
+          status: 200,
+          body: {
+            token: 'access_token',
+            token_type_hint: 'access_token'
+          },
+          request_header: {
+            'Authorization' => 'Basic Y2xpZW50X2lkOmNsaWVudF9zZWNyZXQ=',
+            'X-Foo' => 'bar'
+          }
+        )
+        client.revoke!(access_token: 'access_token') do |request|
+          request.headers.merge! 'X-Foo' => 'bar'
+        end
+      end
+    end
+
     context 'when access_token given' do
       before do
         mock_response(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-oauth2
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - nov matake
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-08 00:00:00.000000000 Z
+date: 2022-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack