rack-matrix_params 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cf4767e00aeb1b82b4766eadd9e55877ac32ccfb
-  data.tar.gz: 50baaa283087567bc6bbe6fb42be87614283b0a4
+  metadata.gz: 20bad64eab7a65961c94cde25cc42c5834f85e85
+  data.tar.gz: b9798e1f98451c91b363e19c24648b94ef32e340
 SHA512:
-  metadata.gz: f469b5878fbd399e25b4821b4c53cb0bbc34e89a33aa061bfe0d1b57423aa9296e532616a693552c405762bef9212c65ad10cccbb41b2e992e1dbdd72d4f52c1
-  data.tar.gz: ad821c24001e2a3306b34eafa0c955063b35fe6111825bf31cc693dc228fd9e2de15ef9ef4e5362e563257d815705189e6579e04450d64b24a5bc70e7c7a7df5
+  metadata.gz: bb4c1c2e0b589b965ff997f5680ed60d175956d98c99399fb58e533deac4ad9161f19d8734e42eabad1a74f517eb56e575d0db81c0da5e668ad10352c47dad95
+  data.tar.gz: f85eaba14a3ec7e051612090f87a07100006bc2be72f97464f1ce844b99a570247d93ff5b777451588c4ea2ace30fcfc83f8f879a9eb2822b39843f1de61aaff

data/TODO

@@ -1 +1 @@
-* Look at the POST section - something'sweird there!
+* Look at the POST section - something's weird there!

data/VERSION

@@ -1 +1 @@
-0.0.6
+0.0.7

data/features/provides_matrix_parameters_like_query_parameters_for_rack.feature

@@ -0,0 +1,11 @@
+Feature: Provides matrix URL parameters as if they were given as GET parameters to Rack applications
+  As a developer on the rack platform
+  I want my application to be able to comprehend [matrix parameter][1] style URLs
+  So that I can ensure these parameters are considered when older WWW servers are caching HTTP requests
+
+  Scenario: Matrix parameters are present in the query parameters environment variable
+    When I make a GET request of "/normal/path/with/params;a=1;b=2/in;c=3/the/middle"
+    Then Rack's "PATH_INFO" environment variable is "/normal/path/with/params/in/the/middle"
+    And Rack's "QUERY_STRING" environment variable is "params[a]=1&params[b]=2&in[c]=3"
+
+# [1]: http://www.w3.org/DesignIssues/MatrixURIs.html "Time Berners-Lee's original description of Matrix URIs"

data/features/step_definitions/web_requests_steps.rb

@@ -0,0 +1,7 @@
+When(/^I make a GET request of "(.+)"$/) do |url|
+  get url
+end
+
+Then(/^Rack's "([^\"]+)" environment variable is "(.+)"$/) do |key, value|
+  last_request.env[key].should == value
+end

data/features/support/env.rb

@@ -0,0 +1,14 @@
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', '..', 'lib'))
+require 'rack/matrix_params'
+require 'rack/test'
+
+module AppMixin
+  include Rack::Test::Methods
+  def app
+    app = Rack::MatrixParams.new(lambda do |env|
+      [200, {'Content-Type' => 'text/plain'}, ['All good!'] ]
+    end)
+  end
+end
+
+World(AppMixin)

data/lib/rack/matrix_params.rb

@@ -70,14 +70,14 @@ module Rack
       if env['REQUEST_METHOD'] != 'POST'
 
         # Rewrite current path and query string and strip all query params from it
-        env['PATH_INFO'].gsub!(/;([^\/]*)/, '').gsub(/\?(.*)$/, '')
+        env['PATH_INFO'] = env['PATH_INFO'].gsub(/;([^\/]*)/, '').gsub(/\?(.*)$/, '')
 
-        env['QUERY_STRING'].gsub!(/;([^\/]*)/, '').freeze
+        env['QUERY_STRING'] = env['QUERY_STRING'].gsub(/;([^\/]*)/, '').freeze
         
         new_params = matrix_params.collect do |component, params|
           params.collect do |k,v|
             "#{component}[#{k}]=#{CGI::escape(v.to_s)}"
-          end
+          end.reverse
         end.flatten
 
       	# Add matrix params as a regular GET params

data/rack-matrix_params.gemspec

@@ -24,4 +24,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'bundler'
   gem.add_development_dependency 'rack-test'
   gem.add_development_dependency 'yarjuf'
+
+  gem.add_development_dependency 'cucumber'
 end

data/spec/matrix_params_spec.rb

@@ -4,10 +4,10 @@ describe Rack::MatrixParams do
 	include Rack::Test::Methods
 
 	let(:inner_app) do
-        lambda { |env| [200, {'Content-Type' => 'text/plain'}, ['All good!'] ]}
-    end
- 
-    let(:app) { described_class.new(inner_app) }
+    lambda { |env| [200, {'Content-Type' => 'text/plain'}, ['All good!'] ]}
+  end
+
+  let(:app) { described_class.new(inner_app) }
 
 	it 'should not change a normal GET query' do
 		get "/?key=value"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-matrix_params
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - JP Hastings-Spital
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-08 00:00:00.000000000 Z
+date: 2013-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -95,6 +95,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: cucumber
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Rack middleware that populates the params variable with the contents
   of matrix parameters in a URL
 email:
@@ -112,6 +126,9 @@ files:
 - Rakefile
 - TODO
 - VERSION
+- features/provides_matrix_parameters_like_query_parameters_for_rack.feature
+- features/step_definitions/web_requests_steps.rb
+- features/support/env.rb
 - lib/rack/matrix_params.rb
 - rack-matrix_params.gemspec
 - spec/matrix_params_spec.rb
@@ -141,5 +158,9 @@ signing_key:
 specification_version: 4
 summary: Allows the use of matrix URLs in a Rack environment
 test_files:
+- features/provides_matrix_parameters_like_query_parameters_for_rack.feature
+- features/step_definitions/web_requests_steps.rb
+- features/support/env.rb
 - spec/matrix_params_spec.rb
 - spec/spec_helper.rb
+has_rdoc: