rack-logs 0.0.2 → 0.1.0

data/spec/support/fixtures/log/my_log.doge

@@ -0,0 +1,6 @@
+Ignored
+
+
+
+
+Much log, such information

data/spec/support/fixtures/log/my_log_file.log

@@ -0,0 +1 @@
+LOG ENTRY 1234

data/spec/support/fixtures/log/not_log.txt

@@ -0,0 +1 @@
+Nothing to see here

data/spec/support/fixtures/log/other_log.doge

@@ -0,0 +1,6 @@
+Ignored
+
+
+
+
+Other log, such information

data/spec/support/fixtures/other_log_file.log

@@ -0,0 +1 @@
+LOG ENTRY 5678

data/spec/support/fixtures/tmp/secret_file.txt

@@ -0,0 +1 @@
+S3kr1t!

data/spec/unit/rack/logs/config_spec.rb

@@ -22,4 +22,14 @@ describe 'Rack::Logs::Config' do
       expect(config.pattern).to eq '*.doge'
     end
   end
+
+  describe '#lines' do
+    it 'defaults to 200' do
+      expect(config.lines).to eq 200
+    end
+    it 'is configurable' do
+      config.lines = 300
+      expect(config.lines).to eq 300
+    end
+  end
 end

data/spec/unit/rack/logs/viewer_spec.rb

@@ -1,8 +1,11 @@
-require 'fakefs/safe'
+require 'timeout'
 require 'rack/logs/viewer'
 
 describe 'Rack::Logs::Viewer' do
-  let(:config) { instance_double "Rack::Logs::Config", pattern: '*.doge', log_dir: './tmp' }
+  let(:config) do
+    instance_double "Rack::Logs::Config", lines: 5, pattern: '*.doge',
+      log_dir: support_path('fixtures/log')
+  end
 
   describe '#initialize' do
     it 'takes a configuration' do
@@ -12,30 +15,73 @@ describe 'Rack::Logs::Viewer' do
 
   describe '#call env' do
     let(:viewer)   { Rack::Logs::Viewer.new config }
-    let(:response) { viewer.call({}) }
+    let(:contents) { response[2].inject("") { |contents, fragment| contents + fragment } }
 
-    before do
-      FakeFS.activate!
-      FileUtils.mkdir_p('./tmp')
-      File.open('./tmp/not_log.txt','w') { |file| file.write 'Nothing to see here' }
-      File.open('./tmp/my_log.doge','w') { |file| file.write 'Much log, such information' }
+    around do |example|
+      begin
+        Timeout::timeout(0.01) { example.run }
+      rescue Timeout::Error
+        fail "Performance regression, even large files should be under .01s"
+      end
     end
-    after do
-      FakeFS.deactivate!
+
+    shared_examples_for "a rack logs response" do
+      integer_const =
+        if ENV["RUBY_VERSION"].to_f >= 2.4
+          Integer
+        else
+          Fixnum
+        end
+
+      it 'returns a rack response' do
+        expect(response[0]).to be_a integer_const
+        expect(response[1]).to be_a Hash
+        expect(response[1].keys).to include 'Content-Type'
+        expect(response[2].respond_to? :each).to be true
+      end
+
+      it 'limits itself to the last n lines' do
+        expect(contents).to_not match "Ignored"
+      end
+    end
+
+    context "for all files" do
+      let(:response) { viewer.call({}) }
+
+      it_should_behave_like "a rack logs response"
+
+      it 'returns the contents of all the logs' do
+        expect(contents).to match "log/my_log\.doge\n\n"
+        expect(contents).to match "Much log, such information"
+        expect(contents).to match "log/other_log\.doge\n\n"
+        expect(contents).to match "Other log, such information"
+      end
     end
 
-    it 'returns a rack response' do
-      expect(response[0]).to be_a Fixnum
-      expect(response[1]).to be_a Hash
-      expect(response[1].keys).to include 'Content-Type'
-      expect(response[2].respond_to? :each).to be true
+    context "for a file" do
+      let(:response) { viewer.call({ 'PATH_INFO' => '/my_log.doge' }) }
+
+      it_should_behave_like "a rack logs response"
+
+      it 'returns the contents the specific log' do
+        expect(contents).to match "log/my_log\.doge\n\n"
+        expect(contents).to match "Much log, such information"
+      end
+      it 'ignores other contents' do
+        expect(contents).to_not match "log/other_log\.doge\n\n"
+        expect(contents).to_not match "Other log, such information"
+      end
     end
-    it 'returns the contents of the logs' do
-      contents = ""
-      response[2].each do |fragment|
-        contents << fragment
+
+    context "for a forbidden file" do
+      let(:response) { viewer.call({ 'PATH_INFO' => '/../tmp/secret_file.txt' }) }
+
+      it 'returns a 404 rack response' do
+        expect(response[0]).to eq 404
+        expect(response[1]).to be_a Hash
+        expect(response[1].keys).to include 'Content-Type'
+        expect(response[2]).to eq ['No Such File']
       end
-      expect(contents).to eq "## tmp/my_log.doge\n\nMuch log, such information"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-logs
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors:
 - Jon Rowe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-03 00:00:00.000000000 Z
+date: 2020-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -16,44 +16,30 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: 2.2.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: 2.2.3
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 13.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 13.0.0
 - !ruby/object:Gem::Dependency
-  name: fakefs
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -86,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0.beta1
+        version: 3.9.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0.beta1
+        version: 3.9.0
 description: Simple rack based log viewer
 email:
 - hello@jonrowe.co.uk
@@ -110,12 +96,21 @@ files:
 - Rakefile
 - lib/rack-logs.rb
 - lib/rack/logs.rb
+- lib/rack/logs/backport.rb
 - lib/rack/logs/config.rb
 - lib/rack/logs/version.rb
 - lib/rack/logs/viewer.rb
 - rack-logs.gemspec
+- spec/integration/accessing_an_individual_log_spec.rb
 - spec/integration/running_rack_logs_via_rack_spec.rb
 - spec/spec_helper.rb
+- spec/support/fixtures/log/large_log.doge
+- spec/support/fixtures/log/my_log.doge
+- spec/support/fixtures/log/my_log_file.log
+- spec/support/fixtures/log/not_log.txt
+- spec/support/fixtures/log/other_log.doge
+- spec/support/fixtures/other_log_file.log
+- spec/support/fixtures/tmp/secret_file.txt
 - spec/unit/rack/logs/config_spec.rb
 - spec/unit/rack/logs/viewer_spec.rb
 - spec/unit/rack/logs_spec.rb
@@ -139,14 +134,21 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 3.1.3
 signing_key: 
 specification_version: 4
 summary: Simple rack based log viewer
 test_files:
+- spec/integration/accessing_an_individual_log_spec.rb
 - spec/integration/running_rack_logs_via_rack_spec.rb
 - spec/spec_helper.rb
+- spec/support/fixtures/log/large_log.doge
+- spec/support/fixtures/log/my_log.doge
+- spec/support/fixtures/log/my_log_file.log
+- spec/support/fixtures/log/not_log.txt
+- spec/support/fixtures/log/other_log.doge
+- spec/support/fixtures/other_log_file.log
+- spec/support/fixtures/tmp/secret_file.txt
 - spec/unit/rack/logs/config_spec.rb
 - spec/unit/rack/logs/viewer_spec.rb
 - spec/unit/rack/logs_spec.rb