rack-insight 0.5.19 → 0.5.20

data/CHANGELOG

@@ -1,5 +1,11 @@
 == HEAD
 
+== 0.5.20 / 2012-09-13 - Peter Boling
+
+  * Bug Fixes
+
+    * Fix panel error handling (pboling - Peter Boling)
+
 == 0.5.19 / 2012-09-13 - Peter Boling
 
   * Other

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rack-insight (0.5.17)
+    rack-insight (0.5.19)
       rack
       sqlite3 (>= 1.3.3)
       uuidtools (>= 2.1.2)

data/lib/rack/insight/panel.rb

@@ -147,9 +147,9 @@ module Rack::Insight
       end
     end
 
-    #def inspect
-    #  "M:#{self.bool_prop(:is_magic?)} T:#{self.bool_prop(:has_table?)} P:#{self.bool_prop(:is_probing?)} C:#{self.bool_prop(:has_custom_probes?)} Name: #{name}"
-    #end
+    def inspect
+      "#{self.underscored_name} Magic:#{self.bool_prop(:is_magic?)} Table:#{self.bool_prop(:has_table?)} Probe:#{self.bool_prop(:is_probing?)} Custom:#{self.bool_prop(:has_custom_probes?)}" rescue "XXX inspect failed"
+    end
 
     def bool_prop(prop)
       self.send(prop) ? 'Y' : 'N'
@@ -234,13 +234,21 @@ module Rack::Insight
         heading
       else
         num = count(number)
-        if num == 0
-          heading
+        if num.kind_of?(Numeric)
+          if num == 0
+            heading
+          else
+            "#{self.camelized_name} (#{num})"
+          end
         else
-          "#{self.camelized_name} (#{num})"
+          heading
         end
       end
-      rescue 'XXX' # no panel should need this
+    rescue Object => ex
+      nom = self.name rescue "xxx"
+"Err3: #{nom}
+  Panel: #{self.inspect}
+  #{([ex.class.name, ex.message] + ex.backtrace).join("<br/>")}"
     end
 
     def content_for_request(number)
@@ -260,16 +268,30 @@ module Rack::Insight
       else
         content
       end
-    rescue 'XXX' #XXX: no panel should need this
+    rescue Object => ex
+      nom = self.name rescue "xxx"
+"Err4: #{nom}
+  Panel: #{self.inspect}
+  #{([ex.class.name, ex.message] + ex.backtrace).join("<br/>")}"
     end
 
     def heading
       self.camelized_name
+    rescue Object => ex
+      nom = self.name rescue "xxx"
+"Err1: #{nom}
+  Panel: #{self.inspect}
+  #{([ex.class.name, ex.message] + ex.backtrace).join("<br/>")}"
     end
 
     def content
       logger.info("Rack::Insight is using default content for #{self.class}") if verbose(:med)
       render_template 'no_content', :name => self.camelized_name
+    rescue Object => ex
+      nom = self.name rescue "xxx"
+"Err2: #{nom}
+  Panel: #{self.inspect}
+  #{([ex.class.name, ex.message] + ex.backtrace).join("<br/>")}"
     end
 
     # Override in subclasses.

data/lib/rack/insight/version.rb

@@ -1,7 +1,7 @@
 module Rack
   module Insight
 
-  VERSION = '0.5.19'
+  VERSION = '0.5.20'
 
   end
 end

data/lib/rack/insight/views/headers_fragment.html.erb

@@ -13,7 +13,8 @@
       </a>
     <% end %>
   <% rescue Object => ex %>
-    Err: <%= panel.name rescue "xxx" %>
+    Err5: <%= panel.name rescue "xxx" %>
+    <!-- Panel: <%= panel.inspect %> -->
     <!-- <%= ([ex.class.name, ex.message] + ex.backtrace).join("\n") %> -->
   <% end %>
   </li>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-insight
 version: !ruby/object:Gem::Version
-  version: 0.5.19
+  version: 0.5.20
   prerelease: 
 platform: ruby
 authors: