rack-idempotent 0.1.0 → 0.2.0

data/README.md

@@ -49,6 +49,42 @@ client = Rack::Client.new do
 end
 ```
 
+### Configuration
+
+### Exponential Backoff
+
+* Defaults
+  * ```max_retries``` = 5
+  * ```min_retry_interval``` = 0.5 (seconds)
+  * ```max_retry_interval``` = 1800 (seconds)
+
+```ruby
+Rack::Client.new do
+  use Rack::Idempotent, {
+    :retry => Rack::Idempotent::ExponentialBackoff.new(
+      :max_retries        => 50,
+      :min_retry_interval => 1.0,
+      :max_retry_interval => 30,
+    ),
+  }
+  use Rack::Lint
+  run App
+end
+```
+
+### Immediate Retry
+
+```ruby
+Rack::Client.new do
+  use Rack::Idempotent, {
+    :retry => Rack::Idempotent::ImmediateRetry.new(max_retries: 50),
+  }
+  use Rack::Lint
+  run App
+end
+```
+
+
 ## Running Tests
 
     $ bundle exec rake

data/lib/rack-idempotent.rb

@@ -11,7 +11,6 @@ class Rack::Idempotent
   autoload :DefaultRescue, 'rack-idempotent/default_rescue'
 
   # Exceptions
-  autoload :HTTPException, 'rack-idempotent/http_exception'
   autoload :RetryLimitExceeded, 'rack-idempotent/retry_limit_exceeded'
   autoload :Retryable, 'rack-idempotent/retryable'
 
@@ -33,7 +32,6 @@ class Rack::Idempotent
 
       begin
         status, headers, body = @app.call(env.dup)
-        raise HTTPException.new(status, headers, body, request) if status >= 400
         response = Rack::Response.new(body, status, headers)
         next if rescue_policy.call({:response => response, :request => request})
         return [status, headers, body]

data/lib/rack-idempotent/default_rescue.rb

@@ -9,14 +9,7 @@ class Rack::Idempotent::DefaultRescue
     method = nil
 
     if exception
-      if IDEMPOTENT_ERROR_CLASSES.include?(exception.class)
-        return true
-      elsif exception.class == Rack::Idempotent::HTTPException
-        status = exception.status
-        method = exception.request.env["REQUEST_METHOD"]
-      else
-        return false
-      end
+      return IDEMPOTENT_ERROR_CLASSES.include?(exception.class)
     end
 
     unless status && method

data/lib/rack-idempotent/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class Idempotent
-    VERSION = "0.1.0"
+    VERSION = "0.2.0"
   end
 end

data/spec/rack-idempotent/default_rescue_spec.rb

@@ -32,13 +32,8 @@ describe Rack::Idempotent do
     [200, 201, 301, 302, 400, 401, 403, 404, 500].each do |status|
       it "should not retry GET requests that result in #{status}" do
         TestCall.errors = [status]
-        begin
-          client.get("http://example.org/")
-          status.should < 400
-        rescue Rack::Idempotent::HTTPException => e
-          e.status.should == status
-          e.status.should >= 400
-        end
+        client.get("http://example.org/")
+        status.should == status
         RecordRequests.requests.count.should == 1
       end
     end
@@ -60,11 +55,8 @@ describe Rack::Idempotent do
       it "should not retry POST requests that result in #{status}" do
         TestCall.errors = [status]
         begin
-          client.post("http://example.org/")
-          status.should < 400
-        rescue Rack::Idempotent::HTTPException => e
-          e.status.should == status
-          e.status.should >= 400
+          response = client.post("http://example.org/")
+          response.status.should == status
         end
         RecordRequests.requests.count.should == 1
       end

data/spec/rack-idempotent/exponential_backoff_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../spec_helper', __FILE__)
+require 'spec_helper'
 
 describe Rack::Idempotent do
   class SleepMonitor

data/spec/rack-idempotent/immediate_retry_spec.rb

@@ -15,7 +15,6 @@ describe Rack::Idempotent do
     describe "using Rack::Idempotent::ImmediateRetry with #{name}" do
       let(:client) do
         Rack::Client.new do
-          use Rack::Lint
           use Rack::Idempotent, {
             :retry => Rack::Idempotent::ImmediateRetry.new(opts)
           }

data/spec/rack-idempotent_spec.rb

@@ -171,9 +171,7 @@ describe Rack::Idempotent do
 
       it 'does not retry a POST if the status is 408' do
         TestCall.errors = [408]
-        lambda {
-          client.post("http://example.org/")
-        }.should raise_exception Rack::Idempotent::HTTPException
+        client.post("http://example.org/")
 
         RecordRequests.requests.count.should == 1
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-idempotent
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -28,7 +28,6 @@ files:
 - lib/rack-idempotent.rb
 - lib/rack-idempotent/default_rescue.rb
 - lib/rack-idempotent/exponential_backoff.rb
-- lib/rack-idempotent/http_exception.rb
 - lib/rack-idempotent/immediate_retry.rb
 - lib/rack-idempotent/retry_limit_exceeded.rb
 - lib/rack-idempotent/retryable.rb

data/lib/rack-idempotent/http_exception.rb

@@ -1,10 +0,0 @@
-class Rack::Idempotent::HTTPException < StandardError
-  attr_reader :status, :headers, :body, :request
-  def initialize(status, headers, body, request)
-    @status, @headers, @body, @request = status, headers, body, request
-  end
-
-  def to_s
-    @status.to_s
-  end
-end