rack-graphql 1.2.4 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ad72995a97636738e4bffab0a6b6e238ff977c235305c7bcae168117de59115d
-  data.tar.gz: a6f19b6371d91d7de8db37f7f40909ef639ffd7b225cfc2f45e6ea16241afd94
+  metadata.gz: 89001cf0e27af277a4e74c423e6ebaed600057a5528d9c0b850a76f704690454
+  data.tar.gz: d5250dddf85e2203701d5357f6479001294e64f7d3f28457bc10b55698e0f0c7
 SHA512:
-  metadata.gz: 8da35ce898800200e1c8b1dfea8c597c551c713c49a7699d42d0a4222b56e36f8aac189029b4b912a719367292ca5bb4a19b2ccffe661c367162ba66126093e7
-  data.tar.gz: 01f8fa1c60af82ecd4e5de10dfb56748c97f10aebcb736402a15bcbeec9e6c92e21fb1013ca2d33312b4191b559ed5c92769d83f0de707a361a922521af8e9cb
+  metadata.gz: e0975735f7f595af62aeece22cb537e454eef1608b0f012af59e0cc65e14b3015c1db2dd9b7e15402b19bbf1cf564e9982bcd8c79c22681e486d23ae2a96be25
+  data.tar.gz: 508d6a5276bfbc8914c9870e4cfa390455ef687634f7de4fc314f28f2c19feedcf7f78de7a39add4543947a44e08e1b0e2de978a1598ac3e8369e5c921c12140

data/.dependabot/config.yml

@@ -9,10 +9,3 @@ update_configs:
     allowed_updates:
       - match:
           update_type: "all"
-    automerged_updates:
-      - match:
-          dependency_type: "development"
-          update_type: "all"
-      - match:
-          dependency_type: "production"
-          update_type: "all"

data/.github/workflows/auto-approve.yml

@@ -1,7 +1,7 @@
-# automatically approve PRs submitted by Dependabot
+# automatically approve PRs submitted by Dependabot or Renofidev
 # this will allow Dependabot to automatically merge dependency update PRs where CI passes
 # from: https://github.com/hmarr/auto-approve-action
-name: Auto approve Dependabot PRs
+name: Auto approve dependency upgrades PRs
 
 on:
   pull_request
@@ -11,6 +11,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: hmarr/auto-approve-action@v2.0.0
-      if: github.actor == 'dependabot[bot]' || github.actor == 'dependabot-preview[bot]'
+      if: github.actor == 'dependabot[bot]' || github.actor == 'dependabot-preview[bot]' || github.actor == 'renofidev'
       with:
         github-token: "${{ secrets.GITHUB_TOKEN }}"

data/CHANGELOG.md

@@ -0,0 +1,10 @@
+# CHANGELOG
+
+## 2.1.0 - 2020-09-14
+
+- Add `log_exception_backtrace` option to `RackGraphql::Application`
+
+## 2.0.0 - 2020-09-14
+
+- Catch all exceptions raised by the app respond with 500 status codea and json content type
+- Add ability to not log exception backtrace with `RackGraphql.log_exception_backtrace = false`

data/Gemfile.lock

@@ -1,23 +1,23 @@
 PATH
   remote: .
   specs:
-    rack-graphql (1.2.4)
-      graphql (~> 1.9)
+    rack-graphql (2.1.0)
+      graphql (~> 1.11)
       oj
-      rack (~> 2.0)
+      rack (~> 2.2)
 
 GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.1)
     coderay (1.1.3)
-    diff-lcs (1.3)
-    graphql (1.11.1)
+    diff-lcs (1.4.4)
+    graphql (1.11.4)
     method_source (1.0.0)
-    oj (3.10.6)
+    oj (3.10.14)
     parallel (1.19.2)
-    parser (2.7.1.3)
-      ast (~> 2.4.0)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
@@ -41,21 +41,21 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.3)
-    rubocop (0.85.1)
+    rubocop (0.90.0)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 2.7.1.1)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.7)
       rexml
-      rubocop-ast (>= 0.0.3)
+      rubocop-ast (>= 0.3.0, < 1.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.0.3)
-      parser (>= 2.7.0.1)
-    rubocop-performance (1.6.1)
-      rubocop (>= 0.71.0)
-    rubocop-rspec (1.40.0)
-      rubocop (>= 0.68.1)
+    rubocop-ast (0.3.0)
+      parser (>= 2.7.1.4)
+    rubocop-performance (1.8.0)
+      rubocop (>= 0.87.0)
+    rubocop-rspec (1.43.2)
+      rubocop (~> 0.87)
     ruby-progressbar (1.10.1)
     unicode-display_width (1.7.0)
 

data/README.md

@@ -23,10 +23,12 @@ Add following to your `config.ru` file:
 
 ```ruby
 run RackGraphql::Application.call(
-  schema: YourGraqphqlSchema,                 # required
-  app_name: 'your-service-name',              # optional, used for health endpoint content
-  context_handler: YourGraphqlContextHandler, # optional, empty `proc` by default
-  health_route: true,                         # optional, true by default
+  schema: YourGraqphqlSchema,                    # required
+  app_name: 'your-service-name',                 # optional, used for health endpoint content
+  context_handler: YourGraphqlContextHandler,    # optional, empty `proc` by default
+  log_exception_backtrace: !A9n.env.production?, # optional, `true` default
+  health_route: true,                             # optional, true by default
+  logger: A9n.logger,                            # optional, not set by default
 )
 ```
 
@@ -69,6 +71,14 @@ class GraphqlContextHandler
 end
 ```
 
+### Logging exception backtrace
+
+RackGraphql catches all errors and respond with 500 code. By default it adds exception backtrace to the response body. If you don't want to have the backtrace in the response set:
+
+```
+RackGraphql.log_exception_backtrace = false
+```
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/RenoFi/rack-graphql. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.

data/lib/rack_graphql.rb

@@ -7,3 +7,11 @@ require 'rack_graphql/exceptions'
 require 'rack_graphql/health_response_builder'
 require 'rack_graphql/middleware'
 require 'rack_graphql/application'
+
+module RackGraphql
+  class << self
+    attr_accessor :log_exception_backtrace
+  end
+
+  self.log_exception_backtrace = true
+end

data/lib/rack_graphql/application.rb

@@ -1,11 +1,18 @@
 module RackGraphql
   class Application
-    def self.call(schema:, app_name: 'rack-graphql-service', logger: nil, context_handler: nil,
-      health_route: true, health_response_builder: RackGraphql::HealthResponseBuilder)
+    def self.call(
+      schema:,
+      app_name: 'rack-graphql-service',
+      logger: nil,
+      context_handler: nil,
+      log_exception_backtrace: RackGraphql.log_exception_backtrace,
+      health_route: true,
+      health_response_builder: RackGraphql::HealthResponseBuilder
+    )
 
       ::Rack::Builder.new do
         map '/graphql' do
-          run RackGraphql::Middleware.new(schema: schema, context_handler: context_handler, logger: logger)
+          run RackGraphql::Middleware.new(schema: schema, context_handler: context_handler, log_exception_backtrace: log_exception_backtrace, logger: logger)
         end
 
         if health_route

data/lib/rack_graphql/middleware.rb

@@ -1,9 +1,10 @@
 module RackGraphql
   class Middleware
-    def initialize(schema:, logger: nil, context_handler: nil)
+    def initialize(schema:, logger: nil, context_handler: nil, log_exception_backtrace: RackGraphql.log_exception_backtrace)
       @schema = schema
       @logger = logger
       @context_handler = context_handler || ->(_) {}
+      @log_exception_backtrace = log_exception_backtrace
     end
 
     def call(env)
@@ -20,17 +21,40 @@ module RackGraphql
       log("Executing with params: #{params.inspect}, operationName: #{operation_name}, variables: #{variables.inspect}")
       result = execute(params: params, operation_name: operation_name, variables: variables, context: context)
 
-      [200, response_headers(result), [response_body(result)]]
+      [
+        200,
+        response_headers(result),
+        [response_body(result)]
+      ]
     rescue AmbiguousParamError => e
-      log("Responded with #{e.class} because of #{e.message}")
-      [400, { 'Content-Type' => 'application/json' }, [Oj.dump({})]]
+      exception_string = dump_exception(e)
+      log(exception_string)
+      env[Rack::RACK_ERRORS].puts(exception_string)
+      env[Rack::RACK_ERRORS].flush
+      [
+        400,
+        { 'Content-Type' => 'application/json' },
+        [Oj.dump({})]
+      ]
+    rescue StandardError, LoadError, SyntaxError => e
+      # To respect the graphql spec, all errors need to be returned as json.
+      # It needs to take Rack::ShowExceptions role of catching all exceptions raised by the app.
+      exception_string = dump_exception(e)
+      log(exception_string)
+      env[Rack::RACK_ERRORS].puts(exception_string)
+      env[Rack::RACK_ERRORS].flush
+      [
+        500,
+        { 'Content-Type' => 'application/json' },
+        [Oj.dump(errors: [exception_hash(e)])]
+      ]
     ensure
       ActiveRecord::Base.clear_active_connections! if defined?(ActiveRecord::Base)
     end
 
     private
 
-    attr_reader :schema, :logger, :context_handler
+    attr_reader :schema, :logger, :context_handler, :log_exception_backtrace
 
     def post_request?(env)
       env['REQUEST_METHOD'] == 'POST'
@@ -124,5 +148,19 @@ module RackGraphql
       return unless logger
       logger.debug("[rack-graphql] #{message}")
     end
+
+    # Based on https://github.com/rack/rack/blob/master/lib/rack/show_exceptions.rb
+    def dump_exception(exception)
+      string = "#{exception.class}: #{exception.message}\n"
+      string << exception.backtrace.map { |l| "\t#{l}" }.join("\n") if log_exception_backtrace
+      string
+    end
+
+    def exception_hash(exception)
+      {
+        message: "#{exception.class}: #{exception.message}",
+        backtrace: log_exception_backtrace ? exception.backtrace : "[FILTERED]"
+      }
+    end
   end
 end

data/lib/rack_graphql/version.rb

@@ -1,3 +1,3 @@
 module RackGraphql
-  VERSION = '1.2.4'.freeze
+  VERSION = '2.1.0'.freeze
 end

data/rack-graphql.gemspec

@@ -24,9 +24,9 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.6'
 
-  spec.add_dependency 'graphql', '~> 1.9'
+  spec.add_dependency 'graphql', '~> 1.11'
   spec.add_dependency 'oj'
-  spec.add_dependency 'rack', '~> 2.0'
+  spec.add_dependency 'rack', '~> 2.2'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'pry'

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: rack-graphql
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 2.1.0
 platform: ruby
 authors:
 - Krzysztof Knapik
 - RenoFi Engineering Team
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-06-18 00:00:00.000000000 Z
+date: 2020-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '1.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '1.11'
 - !ruby/object:Gem::Dependency
   name: oj
   requirement: !ruby/object:Gem::Requirement
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -165,7 +165,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email:
 - knapo@knapo.net
 - engineering@renofi.com
@@ -182,6 +182,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -201,7 +202,7 @@ licenses:
 metadata:
   homepage_uri: https://github.com/RenoFi/rack-graphql
   source_code_uri: https://github.com/RenoFi/rack-graphql
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -217,7 +218,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Rack middleware implementing graphql endpoint.
 test_files: []