rack-dev-mark 0.3.0 → 0.4.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MDZhYWU3YWUzMjdiM2MxMDc2ZmY3ODdjZDA2NTlmZDBjNDMwYzY0ZQ==
+    MzNjZGU4ODkxOWUxNzNkNThkZjgxY2Y0ZmFmN2M5Yjc3MjNhZjNkNA==
   data.tar.gz: !binary |-
-    ZWIwMDliNmZmZmQ5NTg2NTNjNWNiODVlNGI3NDQ0YjM1MDQ5N2E4OA==
+    MjE2MTQ1MzZiNGFmNzYyNDk5ZjQzNzQ4ZGE1N2UxMGExY2NhN2U0OQ==
 SHA512:
   metadata.gz: !binary |-
-    OTFjY2RiMDIzMmY2MGQwNjEzZjk4ZDZmNmFhNjI5NTJlYWZmMWFjYjg0YmU0
-    ZTYzNjhjZDkwYTA0ZTA5OWFkZTRiMDlmMjA3NTdiZjQ3ZGZkNWEwZjI3ZDQ4
-    MGYyZmMxYTZiMWZjNTk3ZGNmNzhjZmJmZmQ5ZjRiZTlkNWMxMmU=
+    ZGFiYmVlMGE2ZTg3ZDQwMWNhZGZkYzQ4NWM3NDBkMGY3ZDA5ZmQzNjExNjUy
+    ZTIzNWE4NzlmYjRmN2YzMjU0ZTY2N2IxNTM0ZDYyZWJhMmM5OGI1Yzk0ZTdm
+    YzM0ZWEyMDUzYTY1NGM4MjNiM2E0NDJmNzY3ZmJmYzc4NjE1NzA=
   data.tar.gz: !binary |-
-    YzliN2QzODAzMmM2OTdkZWFmNTY5YWQzNDVmYTFhN2RjYjFhY2ZlYjI3YjAw
-    Njg1MDJlYzc1N2IxZmE0MjM1Mzk3MzAyMGZmN2RmNzljYTMyOTJkZTY2OTAy
-    OWY5ZDc1MmMzMDQ3YmUwMzM0MjkyYjY5YmRjMzc2ZDA0NzBmNmI=
+    ZTQ2Y2M1ZGVjMjAwZDlhNTgwNzVjMmU5N2VlN2M1ZDJkNzQ4MWQxMTI3OGQx
+    ODVhMDY2YTQxYmY0OGM0YzE4NDJmNWFhNWI3NTJkNDU2YWU4ZjExNTc0NTc4
+    ZWJhYmMwNjkxNWU4MWQzMzA4ZGZiYjc4OWQ2MmU0ODQ3YjMzNjA=

data/README.md

@@ -1,6 +1,6 @@
 # rack-dev-mark
 
-[![Gem Version](https://badge.fury.io/rb/rack-dev-mark.svg)](http://badge.fury.io/rb/rack-dev-mark) [![Build Status](https://secure.travis-ci.org/dtaniwaki/rack-dev-mark.png?branch=master)](http://travis-ci.org/dtaniwaki/rack-dev-mark) [![Coverage Status](https://coveralls.io/repos/dtaniwaki/rack-dev-mark/badge.png?branch=master)](https://coveralls.io/r/dtaniwaki/rack-dev-mark?branch=master)
+[![Gem Version](https://badge.fury.io/rb/rack-dev-mark.svg)](http://badge.fury.io/rb/rack-dev-mark) [![Build Status](https://secure.travis-ci.org/dtaniwaki/rack-dev-mark.png?branch=master)](http://travis-ci.org/dtaniwaki/rack-dev-mark) [![Coverage Status](https://coveralls.io/repos/dtaniwaki/rack-dev-mark/badge.png?branch=master)](https://coveralls.io/r/dtaniwaki/rack-dev-mark?branch=master) [![Code Climate](https://codeclimate.com/github/dtaniwaki/rack-dev-mark.png)](https://codeclimate.com/github/dtaniwaki/rack-dev-mark)
 
 Differentiate development environment from production.
 You can choose [themes](lib/rack/dev-mark/theme/README.md) to differentiate the page.
@@ -35,14 +35,21 @@ run MyApp
 
 ### For your Rails app
 
+In `config/environments/development.rb`
+
+```ruby
+MyApp::Application.configure do
+  config.rack_dev_mark.enable = true
+end
+```
+
+Or
 In `config/application.rb`
 
 ```ruby
 module MyApp
   class Application < Rails::Application
-    if Rails.env != 'production'
-      config.middleware.insert_before ActionDispatch::ShowExceptions, Rack::DevMark::Middleware
-    end
+    config.rack_dev_mark.enable = !Rails.env.production?
   end
 end
 ```
@@ -58,9 +65,7 @@ In `config/application.rb`
 ```ruby
 module MyApp
   class Application < Rails::Application
-    if !%w(env1 env2 env3).include?(Rails.env)
-      config.middleware.insert_before ActionDispatch::ShowExceptions, Rack::DevMark::Middleware
-    end
+    config.rack_dev_mark.enable = !%w(env1 env2 env3).include?(Rails.env)
   end
 end
 ```
@@ -73,14 +78,14 @@ Define a sub class of `Rack::DevMark::Theme::Base` somewhere in your app.
 require 'rack/dev-mark/theme/base'
 
 class NewTheme < Rack::DevMark::Theme::Base
-  def insert_into(html, env, revision)
+  def insert_into(html)
     # Do something for your theme
     html
   end
 end
 
 class AnotherTheme < Rack::DevMark::Theme::Base
-  def insert_into(html, env, revision)
+  def insert_into(html)
     # Do something for your theme
     html
   end
@@ -102,9 +107,7 @@ In `config/application.rb`
 ```ruby
 module MyApp
   class Application < Rails::Application
-    if Rails.env != 'production'
-      config.middleware.insert_before ActionDispatch::ShowExceptions, Rack::DevMark::Middleware, [NewTheme.new, AnotherTheme.new]
-    end
+    config.rack_dev_mark.custom_theme = [NewTheme.new, AnotherTheme.new]
   end
 end
 ```

data/lib/rack/dev-mark/middleware.rb

@@ -25,7 +25,7 @@ module Rack
           response.each do |b|
             begin
               new_body << insert_dev_marks(b)
-            rescue Rack::DevMark::Exception => e
+            rescue => e
               $stderr.write "Failed to insert dev marks: #{e.message}\n"
             end
           end

data/lib/rack/dev-mark/railties.rb

@@ -0,0 +1,17 @@
+require 'rails'
+
+module Rack
+  module DevMark
+    class Railtie < Rails::Railtie
+      config.rack_dev_mark = ActiveSupport::OrderedOptions.new
+
+      initializer "rack-dev-mark.configure_rails_initialization" do |app|
+        if app.config.rack_dev_mark.enable
+          racks = [ActionDispatch::ShowExceptions, Rack::DevMark::Middleware]
+          racks << app.config.rack_dev_mark.custom_theme if app.config.rack_dev_mark.custom_theme
+          app.config.app_middleware.insert_before *racks
+        end
+      end
+    end
+  end
+end

data/lib/rack/dev-mark/theme/title.rb

@@ -1,3 +1,5 @@
+require 'rack/dev-mark/theme/base'
+
 module Rack
   module DevMark
     module Theme

data/lib/rack/dev-mark/version.rb

@@ -1,5 +1,5 @@
 module Rack
   module DevMark
-    VERSION = '0.3.0'
+    VERSION = '0.4.0'
   end
 end

data/lib/rack/dev-mark.rb

@@ -16,3 +16,5 @@ module Rack
     end
   end
 end
+
+require 'rack/dev-mark/railties' if defined?(Rails)

data/spec/rack/dev-mark/middleware_spec.rb

@@ -57,4 +57,13 @@ describe Rack::DevMark::Middleware do
       expect(body).to eq(['{}'])
     end
   end
+  context "themes raise exceptions" do
+    before do
+      allow(theme).to receive(:insert_into).and_raise('something happened')
+    end
+    it "does not raise an exception but write it down in $stderr" do
+      expect($stderr).to receive(:write).with(/something happened/)
+      subject.call({})
+    end
+  end
 end

data/spec/rack/dev-mark/utils_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe Rack::DevMark::Utils do
+  subject { Class.new{ include Rack::DevMark::Utils }.new }
+
+  describe "#camelize" do
+    it "camelizes" do
+      expect(subject.camelize("test_test_test")).to eq("TestTestTest")
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-dev-mark
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Daisuke Taniwaki
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-15 00:00:00.000000000 Z
+date: 2014-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -88,6 +88,7 @@ files:
 - lib/rack/dev-mark.rb
 - lib/rack/dev-mark/error.rb
 - lib/rack/dev-mark/middleware.rb
+- lib/rack/dev-mark/railties.rb
 - lib/rack/dev-mark/theme.rb
 - lib/rack/dev-mark/theme/README.md
 - lib/rack/dev-mark/theme/base.rb
@@ -103,6 +104,7 @@ files:
 - spec/rack/dev-mark/theme/base_spec.rb
 - spec/rack/dev-mark/theme/github_fork_ribbon_spec.rb
 - spec/rack/dev-mark/theme/title_spec.rb
+- spec/rack/dev-mark/utils_spec.rb
 - spec/rack/dev-mark_spec.rb
 - spec/spec_helper.rb
 - spec/support/theme_helper.rb
@@ -137,6 +139,7 @@ test_files:
 - spec/rack/dev-mark/theme/base_spec.rb
 - spec/rack/dev-mark/theme/github_fork_ribbon_spec.rb
 - spec/rack/dev-mark/theme/title_spec.rb
+- spec/rack/dev-mark/utils_spec.rb
 - spec/rack/dev-mark_spec.rb
 - spec/spec_helper.rb
 - spec/support/theme_helper.rb