rack-cookie-monster 1.0.0 → 1.1.0

data/LICENSE

@@ -0,0 +1,20 @@
+Copyright (c) 2009 Justin DeWind
+ 
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+ 
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+ 
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+ 

data/README.rdoc

@@ -1,7 +1,6 @@
 = Rack Cookie Monster
 
-A rack middleware library that allows for cookies to be passed through form parameters. Specifically, it merges the specified
-form parameters into the Cookie header of an http request. It gets around the problem of having a flash application which interacts with a web application that uses cookie based sessions.
+A rack middleware library that allows for cookies to be passed through form parameters. Specifically, it merges the specified form parameters into the Cookie header of an http request. It gets around the problem of having a flash application which interacts with a web application that uses cookie based sessions.
 
 = Contributing
 The environment can be configured by using bundler.
@@ -52,10 +51,8 @@ The environment can be configured by using bundler.
     end
   end
 
-  Rack::CookieMonster.configure do |c|
-    c.eat :cookie_1
-    c.eat :cookie_2
-  end
-
-  use Rack::CookieMonster
+  use Rack::CookieMonster, {
+    :cookies => [:cookie_1, :cookie_2],
+    :share_with => /firefox/i
+  }
   run CookieMonsterApplication.new

data/Rakefile

@@ -0,0 +1,47 @@
+$:<< "vendor/gems/gems/rspec-1.2.9/lib" 
+$:<< "vendor/gems/gems/cucumber-0.4.4/lib"
+
+require 'spec/rake/spectask'
+require 'cucumber/rake/task'
+
+task :default => [:spec, :features]
+
+desc "Executes bundler and grabs necessary dependencies to run tests"
+task "setup:contrib" do
+  system("gem bundle")
+end
+
+Spec::Rake::SpecTask.new do |t|
+  t.spec_files = "spec/**/*_spec.rb"
+  t.spec_opts = ["-f s -c"]
+end
+
+def setup_common_cucumber_settings(task)
+  task.cucumber_opts = "--require features"
+  task.binary = 'vendor/gems/bin/cucumber'
+end
+
+Cucumber::Rake::Task.new(:features) do |t|    
+  setup_common_cucumber_settings(t)
+  t.cucumber_opts << "--color --format pretty"
+end
+
+begin
+  require 'jeweler'
+  Jeweler::Tasks.new do |s|
+    s.name = "rack-cookie-monster"
+    s.summary = "A rack middleware library that allows cookies to be passed through forms parameters."
+    s.description = "A rack middleware library that allows for cookies to be passed through form parameters. Specifically, it merges the specified form parameters into the Cookie header of an http request. It gets around the problem of having a flash application which interacts with a web application that uses cookie based sessions."
+    s.email = "dewind@atomicobject.com"
+    s.homepage = "http://github.com/dewind/rack-cookie-monster"
+    s.authors = ["Justin DeWind"]
+    s.executables = []
+    s.files =  FileList["lib/**/*.rb", "LICENSE", "Rakefile"]
+    s.test_files = FileList["spec/**/*.rb", "features/**/*"]
+    s.add_dependency "rack", ">=1.0.0"
+  end
+  
+  Jeweler::GemcutterTasks.new
+rescue LoadError
+  puts "Jeweler, or one of its dependencies, is not available. Install it with: sudo gem install technicalpickles-jeweler -s http://gems.github.com"
+end

data/features/support/celerity_startup.rb

@@ -45,7 +45,7 @@ if host_listening_on_port? "localhost", $port
   kill_test_server
 end
 
-%x(bin/rackup --require lib/rack/cookie_monster --require vendor/gems/environment --daemon --pid #{SERVER_PID} --server webrick features/monster.ru)
+%x(vendor/gems/bin/rackup --require lib/rack/cookie_monster --require vendor/gems/environment --daemon --pid #{SERVER_PID} --server webrick features/monster.ru)
 raise "Couldn't start server" unless host_listening_on_port? "localhost", $port, 10
 
 $server ||= Culerity::run_server

data/lib/rack/cookie_monster.rb

@@ -3,7 +3,7 @@ module Rack
     
     class Hungry < StandardError; end    
     
-    class<<self
+    class<<self      
       def configure
         @config ||= CookieMonsterConfig.new
         yield(@config)
@@ -36,8 +36,9 @@ module Rack
       
     end
     
-    def initialize(app)
+    def initialize(app, opts=nil)
       @app = app
+      @config = opts.nil? ? self.class : CookieMonsterConfig.new(opts)
     end
   
     def call(env)
@@ -51,9 +52,9 @@ module Rack
     private
   
     def shares_with(agent)
-      yield if self.class.snackers.empty?
+      yield if @config.snackers.empty?
     
-      any_matches = self.class.snackers.any? do |snacker|
+      any_matches = @config.snackers.any? do |snacker|
         case snacker
         when String
           snacker == agent
@@ -69,7 +70,7 @@ module Rack
       cookies = request.cookies
       new_cookies = {}
       
-      self.class.cookies.each do |cookie_name| 
+      @config.cookies.each do |cookie_name| 
         value = request.params[cookie_name.to_s]
         if value
           cookies.delete(cookie_name.to_s)
@@ -88,9 +89,9 @@ module Rack
   class CookieMonsterConfig
     attr_reader :cookies, :snackers
 
-    def initialize
-      @cookies = []
-      @snackers = []
+    def initialize(opts={})
+      @cookies = [opts[:cookies]].compact.flatten.map { |x| x.to_sym }
+      @snackers = [opts[:share_with]].compact.flatten
     end
 
     def eat(cookie)

data/spec/rack/cookie_monster_config_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+require 'rack/cookie_monster'
+require 'action_controller'
+
+describe Rack::CookieMonsterConfig do
+  subject { described_class }
+  
+  describe "#initialize" do
+    it "does not require any options by default" do
+      instance = subject.new
+      instance.cookies.should be_empty
+      instance.snackers.should be_empty
+    end
+    
+    it "can be initialized with cookies and snackers" do
+      instance = subject.new(
+        :cookies => ["oatmeal", "raisen"],
+        :share_with => ["Firefox", /flash/]
+      )
+      
+      instance.cookies.should == [:oatmeal, :raisen]
+      instance.snackers.should == ["Firefox", /flash/]
+    end
+    
+    it "a cookie and snacker can be provided optionally outside of an array" do
+      instance = subject.new(
+        :cookies => "oatmeal",
+        :share_with => "MSIE"
+      )
+      
+      instance.cookies.should == [:oatmeal]
+      instance.snackers.should == ["MSIE"]
+    end    
+  end
+  
+  describe "#eat" do
+    it "collects param names" do
+      instance = subject.new
+      [:mojo, :phoebe, :moudgie].each do |x|
+        instance.eat x
+      end
+      instance.cookies.should == [:mojo, :phoebe, :moudgie]
+    end    
+  end
+  
+  describe "#share_with" do
+    it "collects snackers" do
+      instance = subject.new      
+      ["Flash", "MSIE"].each do |x|
+        instance.share_with x
+      end
+      instance.snackers.should == ["Flash", "MSIE"]
+    end
+  end
+end

data/spec/rack/cookie_monster_spec.rb

@@ -6,7 +6,6 @@ describe Rack::CookieMonster do
   subject { Class.new(described_class) }
   
   describe ".configure" do
-    
     it "specifies what cookies are to be eaten" do
       subject.configure do |c|
         c.eat :_session_id
@@ -127,5 +126,24 @@ describe Rack::CookieMonster do
         @target.call(@environment.dup)
       end      
     end
+    
+    describe "configured through constructor" do
+      before do
+        @target = subject.new(@app, {
+          :cookies => [:oatmeal_cookie],
+          :share_with => ["Opera"]
+        })
+      end
+      
+      it "should overtake declarative configuration" do
+        @app.expects(:call).with(has_entry("HTTP_COOKIE", "oatmeal_cookie=delicious")).once
+        @app.expects(:call).with(has_entry("HTTP_COOKIE", "")).once
+        
+        @environment["HTTP_USER_AGENT"] = "Opera"
+        @target.call(@environment.dup)
+        @environment["HTTP_USER_AGENT"] = "Boom"
+        @target.call(@environment.dup)
+      end      
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,11 +1,7 @@
 here = File.expand_path(File.dirname(__FILE__))
 require File.join(here, "..", "vendor/gems/environment")
 require File.join(here, "..", "init")
-
-require 'spec/autorun'
-require 'mocha'
-require 'active_support'
-require 'rack'
+Bundler.require_env :test
 
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rack-cookie-monster
 version: !ruby/object:Gem::Version 
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors: 
 - Justin DeWind
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-12-15 00:00:00 -05:00
+date: 2009-12-23 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -22,15 +22,18 @@ dependencies:
       - !ruby/object:Gem::Version 
         version: 1.0.0
     version: 
-description: A rack middleware library that allows cookies to be passed through forms
+description: A rack middleware library that allows for cookies to be passed through form parameters. Specifically, it merges the specified form parameters into the Cookie header of an http request. It gets around the problem of having a flash application which interacts with a web application that uses cookie based sessions.
 email: dewind@atomicobject.com
 executables: []
 
 extensions: []
 
 extra_rdoc_files: 
+- LICENSE
 - README.rdoc
 files: 
+- LICENSE
+- Rakefile
 - lib/rack/cookie_monster.rb
 - README.rdoc
 has_rdoc: true
@@ -60,8 +63,9 @@ rubyforge_project:
 rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
-summary: A rack middleware library that allows cookies to be passed through forms
+summary: A rack middleware library that allows cookies to be passed through forms parameters.
 test_files: 
+- spec/rack/cookie_monster_config_spec.rb
 - spec/rack/cookie_monster_spec.rb
 - spec/spec_helper.rb
 - spec/support/stub_helpers.rb