rack-cargo 0.9.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 18247c076dabaec48022379801e52ce2c0f42b7d
-  data.tar.gz: ac28a8c8840c795e602269072b6047969b092b86
+  metadata.gz: 048340003319fa2ae901fbdbb95093b0350aa6a5
+  data.tar.gz: 1ab67a556f070ed792dacf24a0be83f989eb6bdb
 SHA512:
-  metadata.gz: 7b0c706fe67a05b6bc27555d3387c42cae772fa35c8f1f3fa62b5d43cc788dc3ce15c2bb9bd1a8d8ca9f1be8b7da031065e95c55968df3d54558a340f9fc4da0
-  data.tar.gz: 7ee5d82be0ef27a7cf6bf5946d6cd2f823c47c4d656ab1debcfe9da043be415a2600962b2f8f24334500aae936d2c25c7a63babbf82f9d373b6ce6e41a2887e5
+  metadata.gz: e8b80851dd86f64cdff6360f1b495b4e46ec6344cefc6bfc46ccd81d7d52d95e96b39a52393cfa056c1878875d71e222fbf19050de24352a0a15260bbf81dc6e
+  data.tar.gz: 2cae3f111f66c09a810f88cf3eed7045aa21584db941f43a6b76041b2878b2b70d4a8aebdebf64b3744e83a22829345f5f42548f9d8e9c52c5b3ad08f7649716

data/.travis.yml

@@ -1,6 +1,6 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.3.0
-  - 2.4.0
+  - 2.3.1
+  - 2.4.1
 before_install: gem install bundler -v 1.15.3

data/README.md

@@ -32,7 +32,9 @@ Or install it yourself as:
 
     $ gem install rack-cargo
 
-## Usage (TODO)
+## Usage
+
+Regarding individual requests, `rack-cargo` tries to follow the [Rack SPEC](https://www.rubydoc.info/github/rack/rack/file/SPEC). If you find any mismatches, feel free to open an issue or a pull request.
 
 ### Configuration
 
@@ -139,14 +141,14 @@ module MyFeeder
     state.store(:data, "Useful data to MyEater")
   end
 end
- 
+
 module MyEater
   def self.call(request, state)
     data = state.fetch(:data)
     # do something with the data
   end
 end
- 
+
 Rack::Cargo.configure do |config|
   config.processors.insert(2, MyFeeder) # insert into third position
   config.processors.insert(3, MyEater) # insert into fourth position
@@ -169,6 +171,14 @@ end
 
 Timed out requests' response is with status 504 (Gateway timeout) and with empty headers, body.
 
+### `nil` body in an individual request
+
+In case an individual requests' body is `nil`, it will be sent downstream as `""` (empty `String`).
+
+### No body in an individual response
+
+In case an individual request receives a response without a body (as empty `String`), it will be sent upstream as `nil`.
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
@@ -177,7 +187,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/rack-cargo. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/murdho/rack-cargo. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
 ## License
 
@@ -185,4 +195,4 @@ The gem is available as open source under the terms of the [MIT License](http://
 
 ## Code of Conduct
 
-Everyone interacting in the Rack::Cargo project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/[USERNAME]/rack-cargo/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the Rack::Cargo project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/murdho/rack-cargo/blob/master/CODE_OF_CONDUCT.md).

data/lib/rack/cargo/reference_resolver.rb

@@ -12,6 +12,8 @@ module Rack
       class << self
         def call(request, state)
           REFERENCING_ENABLED.each do |attribute_key|
+            next if request.fetch(attribute_key).nil?
+
             element, converted_to_json = get_json_element(request, attribute_key)
             placeholders = find_placeholders(element)
 

data/lib/rack/cargo/request_env_builder.rb

@@ -5,16 +5,29 @@ require "rack/cargo/core_ext/deep_dup"
 module Rack
   module Cargo
     module RequestEnvBuilder
-      def self.call(request, state)
-        request_env = state.fetch(:env).deep_dup
+      class << self
+        def call(request, state)
+          request_env = state.fetch(:env).deep_dup
 
-        path, query_string = request[REQUEST_PATH].split("?", 2)
-        request_env[ENV_PATH] = path
-        request_env[ENV_QUERY_STRING] = query_string || ""
-        request_env[ENV_METHOD] = request[REQUEST_METHOD]
-        request_env[ENV_INPUT] = StringIO.new(request[REQUEST_BODY].to_json)
+          path, query_string = request[REQUEST_PATH].split("?", 2)
+          request_env[ENV_PATH] = path
+          request_env[ENV_QUERY_STRING] = query_string || ""
+          request_env[ENV_METHOD] = request[REQUEST_METHOD]
+          request_env[ENV_INPUT] = StringIO.new(
+            io_input_from_request_body(request[REQUEST_BODY])
+          )
 
-        state[:request_env] = request_env
+          state[:request_env] = request_env
+        end
+
+        private
+
+        # Returns request_body as JSON if it's not nil,
+        # otherwise returns empty string.
+        def io_input_from_request_body(request_body)
+          return "" if request_body.nil?
+          request_body.to_json
+        end
       end
     end
   end

data/lib/rack/cargo/response_builder.rb

@@ -29,6 +29,7 @@ module Rack
         def response_body(app_response_body)
           response_string = ""
           app_response_body.each { |piece| response_string += piece }
+          return if response_string.empty?
 
           JSON.parse(response_string)
         end

data/lib/rack/cargo/version.rb

@@ -2,6 +2,6 @@
 
 module Rack
   module Cargo
-    VERSION = "0.9.1"
+    VERSION = "1.0.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-cargo
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Murdho
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-07-25 00:00:00.000000000 Z
+date: 2018-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler