rack-berater 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0b726fd0709ef54111d4e767fbe040ad3ab05fd0b0426bae20c67ef41f6fc869
-  data.tar.gz: 666a443527911b61660208f5e6ebf09b2a7adf298c67cb157665988c32868623
+  metadata.gz: d9e1b9ca0c696948b6d7ec973e1855c71a73fe9ca59d0833107e57295d2d9f21
+  data.tar.gz: fcbbeef6465c6f7cefa0c110401e4c80d6462ea3adc69a7a1e3975e19e9f8355
 SHA512:
-  metadata.gz: f5bfe591019a79137181785ae76f6e5603b3495cc5ef8e207eab1be88bec114988bbe190509752e093aa1458ecd2ce11dd91dcd4a31fe96b9c00e94f62a931ea
-  data.tar.gz: a83f26c06eeeb1c570233b1b84bdec1dadf501e8774a388290dd6c733fd2c095435f86974b4f27216ffbd118e261206097ac3f16187dfeb2f2da8eb03adb9657
+  metadata.gz: 6d00a14d8136ac96cac236c4bb2ff55c98871dc32cb85b30d8800b4784526cb27c53e54979703f554cb1698ea99093ea77584222dab213f4cbbbe6aeba1b2e71
+  data.tar.gz: 03b030982e003903461f929853138f7c4dcbffbfbcccb2aba1335ffac6e2aa9aeb0b265c4c13d3ebc6f1e04ef4acc1c942606c9d57f44cf2003c3a46e42b8c64

data/lib/rack/berater/prioritizer.rb

@@ -48,34 +48,16 @@ module Rack
         Thread.current[ENV_KEY] = priority
       end
 
-      @@cache_prefix = 'Berater:Rack:Prioritizer'
       def cache_key_for(env)
-        req = Rack::Request.new(env)
-
-        req_method = env[Rack::REQUEST_METHOD].downcase
-        path = ''
-
-        if defined?(Rails) && Rails.respond_to?(:application) && Rails.application
-          res = Rails.application.routes.recognize_path(
-            env[Rack::PATH_INFO],
-            method: env[Rack::REQUEST_METHOD],
-          )
-          path = res.values_at(:controller, :action).compact.join('#')
-        end
-
-        if path.empty?
-          path = env['PATH_INFO'].gsub(%r{/[0-9]+(/|$)}, '/x\1')
-        end
-
         [
-          @@cache_prefix,
-          req_method,
-          path,
+          env[Rack::REQUEST_METHOD].downcase,
+
+          # normalize RESTful paths
+          env['PATH_INFO'].gsub(%r{/[0-9]+(/|$)}, '/x\1'),
         ].join(':')
       end
 
       @@cache = {}
-
       def cache_get(key)
         synchronize { @@cache[key] }
       end

data/lib/rack/berater/rails_prioritizer.rb

@@ -0,0 +1,17 @@
+require 'action_controller/metal'
+require 'action_dispatch'
+
+module Rack
+  class Berater
+    class RailsPrioritizer < Prioritizer
+      def cache_key_for(env)
+        Rails.application.routes.recognize_path(
+          env[Rack::PATH_INFO],
+          method: env[Rack::REQUEST_METHOD],
+        ).values_at(:controller, :action).compact.join('#')
+      rescue ActionController::RoutingError
+        super
+      end
+    end
+  end
+end

data/lib/rack/berater/railtie.rb

@@ -5,7 +5,7 @@ module Rack
     class Railtie < Rails::Railtie
       initializer 'rack.berater' do |app|
         if ::Berater.middleware.include?(::Berater::Middleware::LoadShedder)
-          app.middleware.use Rack::Berater::Prioritizer
+          app.middleware.use Rack::Berater::RailsPrioritizer
         end
 
         app.middleware.use Rack::Berater

data/lib/rack/berater/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class Berater
-    VERSION = "0.3.1"
+    VERSION = "0.3.2"
   end
 end

data/lib/rack/berater.rb

@@ -6,6 +6,7 @@ require 'set'
 module Rack
   class Berater
     autoload :Prioritizer, 'rack/berater/prioritizer'
+    autoload :RailsPrioritizer, 'rack/berater/rails_prioritizer'
     autoload :Railtie, 'rack/berater/railtie'
 
     ERRORS = Set[ ::Berater::Overloaded ]

data/spec/prioritizer_spec.rb

@@ -117,12 +117,8 @@ describe Rack::Berater::Prioritizer do
     context 'with a basic env' do
       let(:env) { Rack::MockRequest.env_for('/') }
 
-      it 'has a Berater prefix' do
-        is_expected.to match /^Berater:/
-      end
-
       it 'combines the verb and path' do
-        is_expected.to match %r{:get:/$}
+        is_expected.to match %r{get:/$}
       end
     end
 
@@ -130,7 +126,7 @@ describe Rack::Berater::Prioritizer do
       let(:env) { Rack::MockRequest.env_for('/', method: 'PUT') }
 
       it 'combines the verb and path' do
-        is_expected.to match %r{:put:/$}
+        is_expected.to match %r{put:/$}
       end
     end
 
@@ -138,7 +134,7 @@ describe Rack::Berater::Prioritizer do
       let(:env) { Rack::MockRequest.env_for('/user/123') }
 
       it 'normalizes the id' do
-        is_expected.to match %r{:/user/x$}
+        is_expected.to match %r{get:/user/x$}
       end
     end
 
@@ -146,7 +142,7 @@ describe Rack::Berater::Prioritizer do
       let(:env) { Rack::MockRequest.env_for('/user/123/') }
 
       it 'normalizes the id and keeps the trailing slash' do
-        is_expected.to match %r{:/user/x/$}
+        is_expected.to match %r{get:/user/x/$}
       end
     end
 
@@ -154,7 +150,7 @@ describe Rack::Berater::Prioritizer do
       let(:env) { Rack::MockRequest.env_for('/user/123/friend/456') }
 
       it 'normalizes both ids' do
-        is_expected.to match %r{:/user/x/friend/x$}
+        is_expected.to match %r{get:/user/x/friend/x$}
       end
     end
   end
@@ -219,77 +215,4 @@ describe Rack::Berater::Prioritizer do
     #   end
     # end
   end
-
-  context 'as Rails middleware' do
-    before do
-      class EchoController < ActionController::Base
-        def index
-          render plain: Rack::Berater::Prioritizer.current_priority
-        end
-
-        def six
-          response.set_header(Rack::Berater::Prioritizer::HEADER, '6')
-          index
-        end
-
-        def nine
-          response.set_header(Rack::Berater::Prioritizer::HEADER, '9')
-          index
-        end
-      end
-
-      Rails.application = Class.new(Rails::Application) do
-        config.eager_load = false
-        config.hosts.clear # disable hostname filtering
-      end
-      Rails.application.middleware.use described_class
-      Rails.initialize!
-
-      Rails.application.routes.draw do
-        get '/' => 'echo#index'
-        get '/six' => 'echo#six'
-        post '/nine' => 'echo#nine'
-      end
-    end
-
-    let(:app) { Rails.application }
-    let(:middleware) { described_class.new(app) }
-
-    after { Rails.application = nil }
-
-    describe '#cache_key_for' do
-      subject { described_class.new(app).send(:cache_key_for, env) }
-
-      let(:env) { Rack::MockRequest.env_for('/') }
-
-      it 'uses the controller and action name' do
-        is_expected.to match %r{:echo#index$}
-      end
-    end
-
-    context 'when a priority header is sent' do
-      before { header described_class::HEADER, priority }
-
-      let(:priority) { '6' }
-
-      it 'sets the priority' do
-        expect(get('/six').body).to eq priority
-      end
-    end
-
-    context 'when the app returns a priority' do
-      it 'does not know the first time the controller is called' do
-        expect(get('/six').body).to be_empty
-        expect(post('/nine').body).to be_empty
-      end
-
-      it 'caches the repsonses for the second time' do
-        expect(get('/six').body).to be_empty
-        expect(post('/nine').body).to be_empty
-
-        expect(get('/six').body).to eq '6'
-        expect(post('/nine').body).to eq '9'
-      end
-    end
-  end
 end

data/spec/rails_prioritizer_spec.rb

@@ -0,0 +1,95 @@
+require 'rspec/rails'
+
+describe Rack::Berater::RailsPrioritizer do
+  before do
+    class EchoController < ActionController::Base
+      def index
+        render plain: Rack::Berater::Prioritizer.current_priority
+      end
+
+      def six
+        response.set_header(Rack::Berater::Prioritizer::HEADER, '6')
+        index
+      end
+
+      def nine
+        response.set_header(Rack::Berater::Prioritizer::HEADER, '9')
+        index
+      end
+    end
+
+    Rails.application = Class.new(Rails::Application) do
+      config.eager_load = false
+      config.hosts.clear # disable hostname filtering
+      # config.logger = ActiveSupport::Logger.new($stdout)
+    end
+    Rails.application.middleware.use described_class
+    Rails.initialize!
+
+    Rails.application.routes.draw do
+      get '/' => 'echo#index'
+      get '/six' => 'echo#six'
+      post '/nine' => 'echo#nine'
+    end
+  end
+
+  let(:app) { Rails.application }
+  let(:middleware) { described_class.new(app) }
+
+  after do
+    cache.clear
+    Thread.current[described_class::ENV_KEY] = nil
+    Rails.application = nil
+  end
+
+  let(:cache) { described_class.class_variable_get(:@@cache) }
+
+  describe '#cache_key_for' do
+    subject { described_class.new(app).method(:cache_key_for) }
+
+    it 'uses the controller and action name' do
+      expect(
+        subject.call(Rack::MockRequest.env_for('/'))
+      ).to match /echo#index/
+
+      expect(
+        subject.call(Rack::MockRequest.env_for('/six'))
+      ).to match /echo#six/
+
+      expect(
+        subject.call(Rack::MockRequest.env_for('/nine', method: 'POST'))
+      ).to match /echo#nine/
+    end
+
+    it 'falls back to Rack style names' do
+      expect(
+        subject.call(Rack::MockRequest.env_for('/nine'))
+      ).to match %r{get:/nine}
+    end
+  end
+
+  context 'when a priority header is sent' do
+    before { header described_class::HEADER, priority }
+
+    let(:priority) { '6' }
+
+    it 'sets the priority' do
+      expect(get('/six').body).to eq priority
+    end
+  end
+
+  context 'when the app returns a priority' do
+    it 'does not know the first time the controller is called' do
+      expect(get('/six').body).to be_empty
+      expect(post('/nine').body).to be_empty
+    end
+
+    it 'caches the repsonses for the second time' do
+      expect(get('/six').body).to be_empty
+      expect(post('/nine').body).to be_empty
+
+      expect(get('/six').body).to eq '6'
+      expect(post('/nine').body).to eq '9'
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-berater
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Daniel Pepper
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -131,10 +145,12 @@ files:
 - lib/rack-berater.rb
 - lib/rack/berater.rb
 - lib/rack/berater/prioritizer.rb
+- lib/rack/berater/rails_prioritizer.rb
 - lib/rack/berater/railtie.rb
 - lib/rack/berater/version.rb
 - spec/limiter_spec.rb
 - spec/prioritizer_spec.rb
+- spec/rails_prioritizer_spec.rb
 - spec/railtie_spec.rb
 - spec/rescuer_spec.rb
 homepage: https://github.com/dpep/rack-berater
@@ -161,6 +177,7 @@ signing_key:
 specification_version: 4
 summary: Rack::Berater
 test_files:
+- spec/rails_prioritizer_spec.rb
 - spec/railtie_spec.rb
 - spec/rescuer_spec.rb
 - spec/prioritizer_spec.rb