rack-authentication_bearer 1.0.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: c2000efcf06e8b46371252838d1ffcc886b43489
-  data.tar.gz: e0e5399e1c663f386bbffd357cfd1fac519d6b13
+SHA256:
+  metadata.gz: 3bfef1eb0eaf10a966794d416a5536c96b406f717d45a57466ff608cf5b56f38
+  data.tar.gz: db6d7f17f8ade3e6e1086ed460b4f5518b4211d22745cfb844074a9886f6ad6c
 SHA512:
-  metadata.gz: 1842781164c6e08e31694154832bf6e39e0d73316efef0f4e2947891c892d3c730780d652754dca422b817f60379fabc1b000e889038391a24f6520d74051568
-  data.tar.gz: 4f616c4c664db47ab7f5351252528bd17ccf2793048f615d565419fe0ddc57fddd1c84f786ae9102598fa2fa571929cdb5f596cee5857b04763f30d44557e762
+  metadata.gz: 82003422eb4add5675de7441b1fef5079bf643851cdfa5dc6d698957c838f73c96c1c5cf1a30aad77b33eeef502e6188583f9dfbb4eb4e7ccd17e060600cb7f4
+  data.tar.gz: 61d3040df5765dd1815e1cd0d4ce2b6a0880399e3feedadd3395fb4a28dff6b0a98562370a6c51a363c39772d36ba4accf0ab161646cb8004b72933a8b02d971

data/lib/rack/authentication_bearer.rb

@@ -1,13 +1,19 @@
 module Rack
   class AuthenticationBearer
     require_relative "authentication_bearer/version"
-    EXPRESSION = /^Bearer\s+/
+    require_relative "authentication_bearer/invalid_bearer_token_error"
+    require_relative "authentication_bearer/missing_bearer_token_error"
+    PATTERN = /^Bearer ([\w\d\.~\+\/]+=*)/
     RACK_KEY = "rack.authentication"
     AUTHENTICATION_KEY = "HTTP_AUTHENTICATION"
     AUTHORIZATION_KEY = "HTTP_AUTHORIZATION"
 
     attr_reader :process
     private :process
+    attr_reader :state
+    private :state
+    attr_reader :stack
+    private :stack
 
     def initialize(stack, &process)
       @stack = stack
@@ -17,43 +23,32 @@ module Rack
     def call(previous_state)
       @state = previous_state
 
-      if token && process
-        state[RACK_KEY] = process.call(token)
-      else
-        state[RACK_KEY] = token
+      return stack.call(state) unless state
+      return stack.call(state) unless process
+      unless present?
+        return stack.call(state.merge(RACK_KEY => Rack::AuthenticationBearer::MissingBearerTokenError))
       end
-
-      stack.call(state)
-    end
-
-    private def token
-      if authentication.respond_to?(:split) && authentication.length > 0
-        authentication.split(EXPRESSION).last
+      unless matches?
+        return stack.call(state.merge(RACK_KEY => Rack::AuthenticationBearer::InvalidBearerTokenError))
       end
-    end
-
-    private def authentication
-      state[AUTHENTICATION_KEY] || state[AUTHORIZATION_KEY]
-    end
 
-    private def stack
-      @stack
+      stack.call(state.merge(RACK_KEY => process.call(shared)))
     end
 
-    private def state
-      @state
+    private def shared
+      value.match(PATTERN)[1]
     end
 
-    private def headers
-      @headers
+    private def value
+      @value ||= state[AUTHENTICATION_KEY] || state[AUTHORIZATION_KEY]
     end
 
-    private def status
-      @status
+    private def present?
+      value.respond_to?(:length) && value.length > 0
     end
 
-    private def body
-      @body
+    private def matches?
+      value.respond_to?(:match) && value.respond_to?(:length) && value.length > 0 && value.match?(PATTERN)
     end
   end
 end

data/lib/rack/authentication_bearer/invalid_bearer_token_error.rb

@@ -0,0 +1,15 @@
+module Rack
+  class AuthenticationBearer
+    class InvalidBearerTokenError < StandardError
+      STATUS = 422
+
+      def initialize(message = nil)
+        @message = message || "The Authentication header value was malformed."
+      end
+
+      def status
+        self.const_get("STATUS")
+      end
+    end
+  end
+end

data/lib/rack/authentication_bearer/missing_bearer_token_error.rb

@@ -0,0 +1,15 @@
+module Rack
+  class AuthenticationBearer
+    class MissingBearerTokenError < StandardError
+      STATUS = 422
+
+      def initialize(message = nil)
+        @message = message || "The Authentication header value was missing."
+      end
+
+      def status
+        self.const_get("STATUS")
+      end
+    end
+  end
+end

data/lib/rack/authentication_bearer/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class AuthenticationBearer
-    VERSION = "1.0.0"
+    VERSION = "2.0.0"
   end
 end

data/spec/lib/rack/authentication_bearer_spec.rb

@@ -1,24 +1,43 @@
 require "spec_helper"
 
 describe Rack::AuthenticationBearer do
-  let(:application) { instance_double("Application") }
-  let(:middleware) { described_class.new(application) }
-  let(:verb) { "GET" }
-  let(:status) { 200 }
-  let(:headers) do
-    {
-      "REQUEST_METHOD" => verb,
-      "Content-Type" => "text/plain",
-      "Content-Length" => "0"
-    }
-  end
-  let(:body) { "" }
-
-  before(:each) do
-    allow(application).to receive(:call).and_return([status, headers, body])
-  end
+  let(:stack) { ->(a) { a } }
+  let(:process) { ->(b) { Base64.urlsafe_decode64(b) }  }
+  let(:middleware) { described_class.new(stack, &process) }
 
   describe "#call" do
+    let(:call) { middleware.call(previous_state) }
+
+    context "when the Authorization key exists and the value is valid" do
+      let(:previous_state) { {"HTTP_AUTHORIZATION" => "Bearer #{Base64.urlsafe_encode64("This Is A Secret")}"} }
+
+      it "sets the rack.authentication key with the decoded value" do
+        expect(call).to include({"rack.authentication"=> "This Is A Secret"})
+      end
+    end
+
+    context "when the Authorization key exists and the value is invalid" do
+      let(:previous_state) { {"HTTP_AUTHORIZATION" => "Bearer "} }
+
+      it "sets the key to an exception" do
+        expect(call).to include("rack.authentication" => Rack::AuthenticationBearer::InvalidBearerTokenError)
+      end
+
+      it "does not call the process" do
+        expect(process).to_not receive(:call)
+      end
+    end
+
+    context "when the Authorization key does not exist" do
+      let(:previous_state) { {} }
+
+      it "sets the key to an exception" do
+        expect(call).to include("rack.authentication" => Rack::AuthenticationBearer::MissingBearerTokenError)
+      end
 
+      it "does not call the process" do
+        expect(process).to_not receive(:call)
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,6 +1,4 @@
-require "codeclimate-test-reporter"
-CodeClimate::TestReporter.start
-
+require "base64"
 require "pry"
 require "rspec"
 require "rack/authentication_bearer"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-authentication_bearer
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
-- Kurtis Rainbolt-Greene
+- Kurtis Rainbolt-Greene <kurtis@rainbolt-greene.online>
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-26 00:00:00.000000000 Z
+date: 2018-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.1'
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.1'
+        version: '12.3'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -80,34 +80,21 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.6'
-- !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.4'
 description: Middleware for handling Bearer type Authentication
-email:
-- me@kurtisrainboltgreene.name
+email: 
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - lib/rack-authentication_bearer.rb
 - lib/rack/authentication_bearer.rb
+- lib/rack/authentication_bearer/invalid_bearer_token_error.rb
+- lib/rack/authentication_bearer/missing_bearer_token_error.rb
 - lib/rack/authentication_bearer/version.rb
 - spec/lib/rack/authentication_bearer/version_spec.rb
 - spec/lib/rack/authentication_bearer_spec.rb
 - spec/spec_helper.rb
-homepage: http://krainboltgreene.github.io/rack-authentication_bearer
+homepage: https://github.com/krainboltgreene/rack-authentication_bearer.rb
 licenses:
 - MIT
 metadata: {}
@@ -127,7 +114,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Middleware for handling Bearer type Authentication
@@ -135,4 +122,3 @@ test_files:
 - spec/lib/rack/authentication_bearer/version_spec.rb
 - spec/lib/rack/authentication_bearer_spec.rb
 - spec/spec_helper.rb
-has_rdoc: