racecar 2.8.0.rc.1 → 2.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ed2fced2308a585fa4261ecac51a459c7f9af0b7631a08fda60c34c270a05cdd
-  data.tar.gz: e34877d02caff76c9bea5919a4ec5afb095bd6607055b6d9d38178366c06bbcf
+  metadata.gz: 4cbf6ca4837bdd3893c8342936f9d5ea115a5b3a585e0c843e62171e00038e72
+  data.tar.gz: d8603c46cf801d0f41f017d5b27b35e0d2b195eec5be11a1f7b6bf77413726b4
 SHA512:
-  metadata.gz: e1873d384b62450af38808a0000b1245c75a8c1f078d51595968fae33c5a3b761cde0feff5640e29c8de7ad7f69cf69211cde97f638ddbdaba046cafaa25e3cb
-  data.tar.gz: ebe542bd6ee8f4f880b4665c3ee9a249a6ce193228bb9f101005de7b0764879b9a9d43316687e7a0dff0d78eb9309abc98b14383fb9ca5f37e56e69896fe68b4
+  metadata.gz: 78bdedfe7bd888a3716f5a29f28810f4c4d2f03e43c33b8e47ed08607155211fca1d47f4eab6a4f0def6976bb7ca3263117e52d2e0fa7f0a721c56ec70c7ee3d
+  data.tar.gz: 2bf6e2b50980add68363b59718f54403caada58abcb404a9018ac4304519bbbb7ed920578d37bcadefad63964812e7374d367298f403577725eef79af269c604

data/CHANGELOG.md

@@ -2,8 +2,14 @@
 
 ## Unreleased
 
+## v2.8.2
+* Handles ErroneousStateError, in previous versions the consumer would do several unecessary group leave/joins. The log level is also changed to WARN instead of ERROR. ([#285](https://github.com/zendesk/racecar/pull/295))
+
+## v2.8.1
+* Adds new ErroneousStateError to racecar in order to give more information on this new possible exception.
+
 ## v2.8.0
-* Update librdkafka version from 1.8.2 to 1.9.0 by upgrading from rdkafka 0.10.0 to 0.12.0. ([#283](https://github.com/zendesk/racecar/pull/286))
+* Update librdkafka version from 1.8.2 to 1.9.0 by upgrading from rdkafka 0.10.0 to 0.12.0. ([#283](https://github.com/zendesk/racecar/pull/293))
 
 ## v2.7.0
 

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    racecar (2.8.0.rc.1)
+    racecar (2.8.2.beta)
       king_konf (~> 1.0.0)
-      rdkafka (~> 0.12.0.beta.4)
+      rdkafka (~> 0.12.0)
 
 GEM
   remote: https://rubygems.org/
@@ -28,7 +28,7 @@ GEM
       coderay (~> 1.1)
       method_source (~> 1.0)
     rake (13.0.1)
-    rdkafka (0.12.0.beta.4)
+    rdkafka (0.12.0)
       ffi (~> 1.15)
       mini_portile2 (~> 2.6)
       rake (> 12)

data/lib/racecar/consumer_set.rb

@@ -49,6 +49,12 @@ module Racecar
 
     def store_offset(message)
       current.store_offset(message)
+    rescue Rdkafka::RdkafkaError => e
+      if e.code == :state # -172
+        @logger.warn "Attempted to store_offset, but we're not subscribed to it: #{ErroneousStateError.new(e)}"
+        return
+      end
+      raise e
     end
 
     def commit

data/lib/racecar/erroneous_state_error.rb

@@ -0,0 +1,34 @@
+# `rd_kafka_offsets_store()` (et.al) returns an error for any
+# partition that is not currently assigned (through `rd_kafka_*assign()`).
+# This prevents a race condition where an application would store offsets
+# after the assigned partitions had been revoked (which resets the stored
+# offset), that could cause these old stored offsets to be committed later
+# when the same partitions were assigned to this consumer again - effectively
+# overwriting any committed offsets by any consumers that were assigned the
+# same partitions previously. This would typically result in the offsets
+# rewinding and messages to be reprocessed.
+# As an extra effort to avoid this situation the stored offset is now
+# also reset when partitions are assigned (through `rd_kafka_*assign()`).
+module Racecar
+  class ErroneousStateError < StandardError
+    def initialize(rdkafka_error)
+      raise rdkafka_error unless rdkafka_error.is_a?(Rdkafka::RdkafkaError)
+
+      @rdkafka_error = rdkafka_error
+    end
+
+    attr_reader :rdkafka_error
+
+    def code
+      @rdkafka_error.code
+    end
+
+    def to_s
+      <<~EOM
+        Partition is no longer assigned to this consumer and the offset could not be stored for commit.
+        #{@rdkafka_error.to_s}
+      EOM
+    end
+
+  end
+end

data/lib/racecar/runner.rb

@@ -4,6 +4,7 @@ require "rdkafka"
 require "racecar/pause"
 require "racecar/message"
 require "racecar/message_delivery_error"
+require "racecar/erroneous_state_error"
 
 module Racecar
   class Runner

data/lib/racecar/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Racecar
-  VERSION = "2.8.0.rc.1"
+  VERSION = "2.8.2"
 end

data/racecar.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 2.6'
 
   spec.add_runtime_dependency "king_konf", "~> 1.0.0"
-  spec.add_runtime_dependency "rdkafka",   "~> 0.12.0.beta.4"
+  spec.add_runtime_dependency "rdkafka",   "~> 0.12.0"
 
   spec.add_development_dependency "bundler", [">= 1.13", "< 3"]
   spec.add_development_dependency "pry"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: racecar
 version: !ruby/object:Gem::Version
-  version: 2.8.0.rc.1
+  version: 2.8.2
 platform: ruby
 authors:
 - Daniel Schierbeck
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-05-17 00:00:00.000000000 Z
+date: 2022-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: king_konf
@@ -31,14 +31,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.12.0.beta.4
+        version: 0.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.12.0.beta.4
+        version: 0.12.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -200,6 +200,7 @@ files:
 - lib/racecar/ctl.rb
 - lib/racecar/daemon.rb
 - lib/racecar/datadog.rb
+- lib/racecar/erroneous_state_error.rb
 - lib/racecar/heroku.rb
 - lib/racecar/instrumenter.rb
 - lib/racecar/message.rb
@@ -226,9 +227,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.0.3
 signing_key: