racecar 2.0.0.beta5 → 2.0.0.beta6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f37b63d59011da69d49663e81d80b7681ab0ec703ca1641d95d8869d767ab60b
-  data.tar.gz: be70ea61f2571a4f0e5a44be4984b3126374530abb8cb0a376809d3566c73d3e
+  metadata.gz: 540436ac94ef1004699e9cab3b7219061f23c978c3d4c1ece727a7d2ac876a69
+  data.tar.gz: de7e906c2e6a704edc69512c6357bad26f3de324f5437c55f44a4be51ed944a8
 SHA512:
-  metadata.gz: b3224f3e237adff5f5d069a651708ee68c0e1ef2a2f61f95cae1eb864c0685d8bd20d9648870f147b1384d71025658852b504ebfafeeedcd9ef31dd56e23eac0
-  data.tar.gz: 1e1ddf3901371f8863798c209dda31da2901e78d4b36d072ee4f4fd9569d0538ccbac66f3bbc033da69e38d4419e1c849ef8133ad64463931bf601e5530ec824
+  metadata.gz: d37108b8609b9912fd9d0853adc1519e01dfbfe56b4e36c50281d1087c8289ce5a6e11fae3e9c33673623ea3367fc67aac2564a2c010e173fc7b6f685ac6da85
+  data.tar.gz: 6c68f0059c1c42b7f594d0dcd477dd254759f5e1c91e826e663e060cc6c7cd74b2c1b30a0b07205de0c0808365a35bee751d5d869d990a3f8f73ec28de31c491

data/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## racecar v2.0.0
 
+* Fix `max_wait_time` usage (#179).
 * Replace `ruby-kafka` with `rdkafka-ruby`
 * Removed config option `sasl_over_ssl`
 * [Racecar::Consumer] Do not pause consuming partitions on exception

data/README.md

@@ -21,6 +21,7 @@ The framework is based on [rdkafka-ruby](https://github.com/appsignal/rdkafka-ru
     7. [Handling errors](#handling-errors)
     8. [Logging](#logging)
     9. [Operations](#operations)
+    10. [Upgrading from v1 to v2](#upgrading-from-v1-to-v2)
 3. [Development](#development)
 4. [Contributing](#contributing)
 5. [Support and Discussion](#support-and-discussion)
@@ -484,6 +485,11 @@ In order to gracefully shut down a Racecar consumer process, send it the `SIGTER
 In order to introspect the configuration of a consumer process, send it the `SIGUSR1` signal. This will make Racecar print its configuration to the standard error file descriptor associated with the consumer process, so you'll need to know where that is written to.
 
 
+### Upgrading from v1 to v2
+
+In order to safely upgrade from Racecar v1 to v2, you need to completely shut down your consumer group before starting it up again with the v2 Racecar dependency. In general, you should avoid rolling deploys for consumers groups, so it is likely the case that this will just work for you, but it's a good idea to check first.
+
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rspec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/racecar/config.rb

@@ -156,6 +156,10 @@ module Racecar
 
     attr_accessor :subscriptions, :logger
 
+    def max_wait_time_ms
+      max_wait_time * 1000
+    end
+
     def initialize(env: ENV)
       super(env: env)
       @error_handler = proc {}

data/lib/racecar/consumer_set.rb

@@ -176,7 +176,7 @@ module Racecar
         "fetch.max.bytes"         => @config.max_bytes,
         "message.max.bytes"       => subscription.max_bytes_per_partition,
         "fetch.min.bytes"         => @config.fetch_min_bytes,
-        "fetch.wait.max.ms"       => @config.max_wait_time * 1000,
+        "fetch.wait.max.ms"       => @config.max_wait_time_ms,
         "group.id"                => @config.group_id,
         "heartbeat.interval.ms"   => @config.heartbeat_interval * 1000,
         "max.poll.interval.ms"    => @config.max_poll_interval * 1000,

data/lib/racecar/runner.rb

@@ -65,12 +65,12 @@ module Racecar
         @instrumenter.instrument("main_loop", instrumentation_payload) do
           case process_method
           when :batch then
-            msg_per_part = consumer.batch_poll(config.max_wait_time).group_by(&:partition)
+            msg_per_part = consumer.batch_poll(config.max_wait_time_ms).group_by(&:partition)
             msg_per_part.each_value do |messages|
               process_batch(messages)
             end
           when :single then
-            message = consumer.poll(config.max_wait_time)
+            message = consumer.poll(config.max_wait_time_ms)
             process(message) if message
           end
         end

data/lib/racecar/version.rb

@@ -1,3 +1,3 @@
 module Racecar
-  VERSION = "2.0.0.beta5"
+  VERSION = "2.0.0.beta6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: racecar
 version: !ruby/object:Gem::Version
-  version: 2.0.0.beta5
+  version: 2.0.0.beta6
 platform: ruby
 authors:
 - Daniel Schierbeck
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-05-04 00:00:00.000000000 Z
+date: 2020-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: king_konf