rabbit_jobs 0.11.5 → 0.12.0

data/spec/unit/job_consumer_spec.rb

@@ -1,4 +1,3 @@
-# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe RabbitJobs::Consumer::JobConsumer do
@@ -11,11 +10,13 @@ describe RabbitJobs::Consumer::JobConsumer do
       mock(RJ::Job).parse(payload) { job }
       consumer.process_message(:delivery_info, :properties, payload)
     end
+
     it 'reports parsing errors' do
-      payload = "some bad json data"
+      payload = 'some bad json data'
       mock(consumer).report_error(:parsing_error, payload)
       consumer.process_message(:delivery_info, :properties, payload).should == true
     end
+
     it 'skips expired jobs' do
       payload = RJ::Job.serialize(TestJob)
       job
@@ -35,22 +36,22 @@ describe RabbitJobs::Consumer::JobConsumer do
   end
 
   describe '#report_error' do
-    it "accepts error type :not_found" do
-      lambda { consumer.report_error(:not_found, 'klass_name') }.should_not raise_error
+    it 'accepts error type :not_found' do
+      -> { consumer.report_error(:not_found, 'klass_name') }.should_not raise_error
     end
 
-    it "accepts error type :parsing_error" do
-      lambda { consumer.report_error(:parsing_error, 'payload data') }.should_not raise_error
+    it 'accepts error type :parsing_error' do
+      -> { consumer.report_error(:parsing_error, 'payload data') }.should_not raise_error
     end
 
-    it "accepts error type :error" do
+    it 'accepts error type :error' do
       exception = nil
       begin
-        raise 'testing'
-      rescue Exception => e
+        fail 'testing'
+      rescue RuntimeError => e
         exception = e
       end
-      lambda { consumer.report_error(:error, exception, 'payload data') }.should_not raise_error
+      -> { consumer.report_error(:error, exception, 'payload data') }.should_not raise_error
     end
   end
 end

data/spec/unit/job_spec.rb

@@ -1,35 +1,33 @@
-# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe RabbitJobs::Job do
   it 'should parse class and params' do
-    job = RabbitJobs::Job.parse({class: 'TestJob', params: [1,2,3]}.to_json)
-    job.params.should == [1, 2, 3]
+    job, params = RabbitJobs::Job.parse({ class: 'TestJob', params: [1, 2, 3] }.to_json)
+    job.should be_is_a(TestJob)
+    params.should == [1, 2, 3]
   end
 
-  it 'should understand expires_in' do
-    job = JobWithExpire.new(1, 2, 3)
-    job.expires_in.should == 60*60
-    job.expires?.should == true
+  it 'understands expires_in option' do
+    JobWithExpire.expires_in.should eq 1.hour
   end
 
   context 'job expiration' do
     it 'should expire job by expires_in option' do
-      job = TestJob.new
-      job.opts['expires_at'] = (Time.now - 10).to_i
+      job = JobWithExpire.new
+      job.created_at = 2.hours.ago.to_i
       job.expired?.should == true
     end
 
     it 'should expire job by expires_in option in job class and current_time' do
-      job = JobWithExpire.new(1, 2, 3)
-      job.opts['created_at'] = (Time.now - job.expires_in - 10).to_i
+      job = JobWithExpire.new
+      job.created_at = (Time.now - JobWithExpire.expires_in - 10).to_i
       job.expired?.should == true
     end
 
     it 'should not be expired with default params' do
-      job = TestJob.new(1, 2, 3)
-      job.opts['created_at'] = (Time.now).to_i
+      job = TestJob.new
+      job.created_at = (Time.now).to_i
       job.expired?.should == false
     end
   end
-end
+end

data/spec/unit/rabbit_jobs_spec.rb

@@ -1,12 +1,11 @@
-# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe RabbitJobs do
   it 'should pass publish methods to publisher' do
-    mock(RJ::Publisher).publish_to('default_queue', TestJob, nil, 1, 2, "string")
-    RJ.publish_to('default_queue', TestJob, nil, 1, 2, "string")
+    mock(RJ::Publisher).publish_to('default_queue', TestJob, nil, 1, 2, 'string')
+    RJ.publish_to('default_queue', TestJob, nil, 1, 2, 'string')
 
-    mock(RJ::Publisher).direct_publish_to('default_queue', 'hello', {name: "my_exchange"})
-    RJ.direct_publish_to('default_queue', 'hello', {name: "my_exchange"})
+    mock(RJ::Publisher).direct_publish_to('default_queue', 'hello', name: 'my_exchange')
+    RJ.direct_publish_to('default_queue', 'hello', name: 'my_exchange')
   end
-end
+end

data/spec/unit/worker_spec.rb

@@ -1,4 +1,3 @@
-# -*- encoding : utf-8 -*-
 require 'spec_helper'
 
 describe RabbitJobs::Worker do
@@ -6,7 +5,7 @@ describe RabbitJobs::Worker do
   before(:each) do
     RJ.configure do |c|
       c.server 'amqp://localhost'
-      c.queue "default"
+      c.queue 'default'
     end
   end
 
@@ -15,12 +14,12 @@ describe RabbitJobs::Worker do
   describe '#consumer' do
     it 'validates consumer type' do
       old_consumer = worker.consumer
-      lambda { worker.consumer = 123 }.should raise_error
-      worker.consumer.should == old_consumer
+      -> { worker.consumer = 123 }.should raise_error
+      worker.consumer.should eq old_consumer
 
       new_consumer = TestConsumer.new
-      lambda { worker.consumer = new_consumer }.should_not raise_error
-      worker.consumer.should == new_consumer
+      -> { worker.consumer = new_consumer }.should_not raise_error
+      worker.consumer.should eq new_consumer
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rabbit_jobs
 version: !ruby/object:Gem::Version
-  version: 0.11.5
+  version: 0.12.0
 platform: ruby
 authors:
 - Pavel Lazureykis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-16 00:00:00.000000000 Z
+date: 2014-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bunny
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.6.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -136,6 +136,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Background jobs on RabbitMQ
 email:
 - lazureykis@gmail.com
@@ -157,6 +171,7 @@ files:
 - examples/configuration.rb
 - examples/worker
 - lib/rabbit_jobs.rb
+- lib/rabbit_jobs/amqp_transport.rb
 - lib/rabbit_jobs/configuration.rb
 - lib/rabbit_jobs/consumer/job_consumer.rb
 - lib/rabbit_jobs/job.rb
@@ -204,7 +219,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Background jobs on RabbitMQ