rabbit_feed 2.4.4 → 3.0.0

data/spec/lib/rabbit_feed/testing_support/rspec_matchers/publish_event_spec.rb

@@ -1,9 +1,9 @@
 module RabbitFeed
   module TestingSupport
     module RSpecMatchers
-      describe PublishEvent do
+      describe 'publish_event' do
         let(:event_name) { 'test_event' }
-        let(:event_payload) { {'field' => 'value'} }
+        let(:event_payload) { { 'field' => 'value' } }
         TestingSupport.capture_published_events self
         before do
           EventDefinitions do
@@ -23,117 +23,112 @@ module RabbitFeed
 
         it 'clears any existing published_events' do
           10.times.each do
-            RabbitFeed::Producer.publish_event event_name, event_payload
+            RabbitFeed::Producer.publish_event(event_name, event_payload)
           end
 
           expect do
-            expect {
-              RabbitFeed::Producer.publish_event event_name, event_payload
-            }.to publish_event(event_name, event_payload)
+            expect do
+              RabbitFeed::Producer.publish_event(event_name, event_payload)
+            end.to publish_event(event_name, event_payload)
           end.to change { TestingSupport.published_events.count }.from(10).to(1)
+        end
 
+        it 'traps exceptions' do
+          expect do
+            raise 'this hurts me more than it hurts you'
+          end.to_not publish_event(event_name)
         end
 
-        context 'when the expectation is met' do
-          it 'validates' do
-            expect {
-              RabbitFeed::Producer.publish_event event_name, event_payload
-            }.to publish_event(event_name, event_payload)
-          end
+        it 'validates' do
+          expect do
+            RabbitFeed::Producer.publish_event(event_name, event_payload)
+          end.to publish_event(event_name, event_payload)
 
-          it 'validates the negation' do
-            expect {
-              RabbitFeed::Producer.publish_event 'different name', {}
-            }.to_not publish_event(event_name, {})
-          end
+          expect do
+            RabbitFeed::Producer.publish_event('different name', event_payload)
+          end.to_not publish_event(event_name, event_payload)
+        end
 
-          it 'traps exceptions' do
-            expect {
-              raise 'this hurts me more than it hurts you'
-            }.to_not publish_event(event_name, {})
-          end
+        context 'when not validating the payload' do
+          it 'validates the event name' do
+            expect do
+              RabbitFeed::Producer.publish_event(event_name, event_payload)
+            end.to publish_event(event_name)
 
-          context 'when not validating the payload' do
-            it 'validates' do
-              expect {
-                RabbitFeed::Producer.publish_event event_name, event_payload
-              }.to publish_event(event_name)
-            end
-
-            it 'validates the negation' do
-              expect {
-                RabbitFeed::Producer.publish_event 'different name', {}
-              }.to_not publish_event(event_name)
-            end
+            expect do
+              RabbitFeed::Producer.publish_event('different name', {})
+            end.to_not publish_event(event_name)
           end
         end
 
-        it 'validates the event name' do
-          matcher = described_class.new(event_name, {})
-          block   = Proc.new { RabbitFeed::Producer.publish_event 'different name', {} }
-          (matcher.matches? block).should be_falsey
-        end
-
-        context 'with block' do
-          it 'validates block' do
-            expect {
-              RabbitFeed::Producer.publish_event event_name, event_payload
-            }.to publish_event(event_name, nil) do |actual_payload|
-              expect(actual_payload['field']).to eq 'value'
-            end
+        context 'when validating the payload' do
+          it 'validates the event payload' do
+            expect do
+              RabbitFeed::Producer.publish_event(event_name, 'field' => 'different value')
+            end.not_to publish_event(event_name, event_payload)
+
+            expect do
+              RabbitFeed::Producer.publish_event(event_name, event_payload)
+            end.to publish_event(event_name, event_payload)
           end
 
-          it 'validates block with `with` will be ignored' do
-            eval_block  = Proc.new {|actual_payload|
-              expect(actual_payload['field']).to eq 'value'
-            }
-            matcher = described_class.new(event_name, nil).with({field: 'different name'})
-            block   = Proc.new { RabbitFeed::Producer.publish_event event_name, {'field' => 'value'} }
+          context 'using .including' do
+            context 'when there is an earlier payload provided' do
+              it 'prefers the earlier payload' do
+                expect do
+                  RabbitFeed::Producer.publish_event(event_name, 'field' => 'different value')
+                end.not_to publish_event(event_name, event_payload).including(event_payload)
+              end
+            end
 
-            (matcher.matches? block, &eval_block).should be true
-          end
+            it 'validates the event payload' do
+              expect do
+                RabbitFeed::Producer.publish_event(event_name, event_payload)
+              end.not_to publish_event(event_name).including('field' => 'different value')
 
-          it 'does not evaluates block with {}' do
-            expect {
-              RabbitFeed::Producer.publish_event event_name, event_payload
-            }.to publish_event(event_name, nil) { |actual_payload|
-              raise 'this block should not be evaluated'
-            }
-          end
+              expect do
+                RabbitFeed::Producer.publish_event(event_name, event_payload)
+              end.to publish_event(event_name).including(event_payload)
+            end
 
-          it 'does not evaluate block if the expectation block does not return actual payload' do
-            expect {
-              nil
-            }.not_to publish_event(event_name, nil) do |actual_payload|
-              raise 'this block should not be evaluated'
+            context 'when the actual payload contains more fields than the expected payload' do
+              it 'validates the event payload' do
+                expect do
+                  RabbitFeed::Producer.publish_event(event_name, event_payload.merge('different field' => 'value'))
+                end.to publish_event(event_name).including(event_payload)
+              end
             end
-          end
-        end
 
-        context 'when validating the payload' do
-          context 'and the payload is not a Proc' do
-            it 'validates the event payload' do
-              matcher = described_class.new(event_name, event_payload)
-              block   = Proc.new { RabbitFeed::Producer.publish_event event_name, {'field' => 'different value'} }
-              (matcher.matches? block).should be_falsey
+            context 'when the expected payload contains more fields than the actual payload' do
+              it 'invalidates the event payload' do
+                expect do
+                  RabbitFeed::Producer.publish_event(event_name, event_payload)
+                end.not_to publish_event(event_name).including(event_payload.merge('different field' => 'value'))
+              end
             end
           end
 
-          context 'uses .with' do
-            context 'and it is not a Proc' do
-              it 'validates the event payload' do
-                matcher = described_class.new(event_name, nil).with(event_payload)
-                block   = Proc.new { RabbitFeed::Producer.publish_event event_name, {'field' => 'different value'} }
-                (matcher.matches? block).should be false
+          context 'using .asserting' do
+            context 'when there is an earlier payload provided' do
+              it 'prefers the earlier payload' do
+                expect do
+                  RabbitFeed::Producer.publish_event(event_name, 'field' => 'different value')
+                end.not_to publish_event(event_name, event_payload).asserting { |actual_payload| expect(actual_payload).to eq(event_payload) }
+
+                expect do
+                  RabbitFeed::Producer.publish_event(event_name, 'field' => 'different value')
+                end.not_to publish_event(event_name, event_payload).asserting { |actual_payload| expect(actual_payload).not_to eq(event_payload) }
               end
             end
 
-            context 'and it is a Proc' do
-              it 'validates the event payload' do
-                matcher = described_class.new(event_name, nil).with{event_payload}
-                block   = Proc.new { RabbitFeed::Producer.publish_event event_name, {'field' => 'different value'} }
-                (matcher.matches? block).should be false
-              end
+            it 'performs the assertion' do
+              expect do
+                RabbitFeed::Producer.publish_event(event_name, event_payload)
+              end.to publish_event(event_name).asserting { |actual_payload| expect(actual_payload).to eq(event_payload) }
+
+              expect do
+                RabbitFeed::Producer.publish_event(event_name, event_payload)
+              end.to publish_event(event_name).asserting { |actual_payload| expect(actual_payload).not_to eq('field' => 'different value') }
             end
           end
         end

data/spec/lib/rabbit_feed/testing_support/testing_helper_spec.rb

@@ -14,8 +14,8 @@ module RabbitFeed
           end
         end
 
-        let(:payload)  { {'stuff' => 'some_stuff'} }
-        let(:metadata) { {'application' => 'some_place', 'name' => 'some_event'} }
+        let(:payload)  { { 'stuff' => 'some_stuff' } }
+        let(:metadata) { { 'application' => 'some_place', 'name' => 'some_event' } }
         let(:event)    { Event.new metadata, payload }
 
         before { define_route }

data/spec/spec_helper.rb

@@ -1,27 +1,21 @@
-require 'codeclimate-test-reporter'
+require 'simplecov'
+SimpleCov.start
+
 require 'rabbit_feed'
 require 'rspec/its'
 require 'timecop'
 require 'timeout'
 
-# Send data to code climate from semaphore
-# Disable the warning messages
-CodeClimate::TestReporter.configure do |config|
-  config.logger.level = Logger::WARN
-end
-CodeClimate::TestReporter.start
-
 # Get rid of deprecation warnings
 I18n.enforce_available_locales = true
 
 # Loads the shared examples
-Dir['./spec/support/**/*.rb'].sort.each { |f| require f}
+Dir['./spec/support/**/*.rb'].sort.each { |f| require f }
 
 # Loads the step definitions
 Dir.glob('spec/features/step_definitions/**/*_steps.rb') { |f| load f, true }
 
 RSpec.configure do |config|
-
   config.expect_with :rspec do |expects|
     expects.syntax = [:should, :expect]
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rabbit_feed
 version: !ruby/object:Gem::Version
-  version: 2.4.4
+  version: 3.0.0
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-04 00:00:00.000000000 Z
+date: 2017-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bunny
@@ -19,7 +19,7 @@ dependencies:
         version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 2.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: 2.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 2.7.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -39,7 +39,7 @@ dependencies:
         version: 3.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 6.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -49,7 +49,7 @@ dependencies:
         version: 3.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 6.0.0
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
@@ -59,7 +59,7 @@ dependencies:
         version: 3.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 6.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -69,21 +69,21 @@ dependencies:
         version: 3.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 6.0.0
 - !ruby/object:Gem::Dependency
   name: pidfile
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.3'
 - !ruby/object:Gem::Dependency
   name: avro
   requirement: !ruby/object:Gem::Requirement
@@ -93,7 +93,7 @@ dependencies:
         version: 1.5.4
     - - "<"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -103,97 +103,119 @@ dependencies:
         version: 1.5.4
     - - "<"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.0
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.14.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.14.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: '3.5'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.46'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.46'
 - !ruby/object:Gem::Dependency
   name: rutabaga
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.12'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.12'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.8'
 description: A gem providing asynchronous event publish and subscribe capabilities
   with RabbitMQ.
 email:
@@ -205,6 +227,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - Brewfile
 - DEVELOPING.md
 - Gemfile
@@ -231,7 +254,6 @@ files:
 - example/rails_app/.rspec
 - example/rails_app/Gemfile
 - example/rails_app/Gemfile.lock
-- example/rails_app/README.rdoc
 - example/rails_app/Rakefile
 - example/rails_app/app/assets/images/.keep
 - example/rails_app/app/assets/javascripts/application.js

data/example/rails_app/README.rdoc

@@ -1,28 +0,0 @@
-== README
-
-This README would normally document whatever steps are necessary to get the
-application up and running.
-
-Things you may want to cover:
-
-* Ruby version
-
-* System dependencies
-
-* Configuration
-
-* Database creation
-
-* Database initialization
-
-* How to run the test suite
-
-* Services (job queues, cache servers, search engines, etc.)
-
-* Deployment instructions
-
-* ...
-
-
-Please feel free to use a different markup language if you do not plan to run
-<tt>rake doc:app</tt>.