rabbit_feed 2.4.0 → 2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b027daa2e82c9b3cca12bcec5df1cf82a9d27eec
-  data.tar.gz: a95205ed61bfc7a16b7a6fd2f5e6f33f1f4bf8f3
+  metadata.gz: 6b5abf99a3ec7c000ae4cdce1305089b50a75884
+  data.tar.gz: c4ac6137152be286d2185fce267b8b5e7a92271f
 SHA512:
-  metadata.gz: 2ac970507750197992c5fed39203a12073e0e7ac4a0cce6fe35b5363f6bbc3a52e39c3545601e3d596655378771ec689200eeda0a0de265cf442490d5e44b6dd
-  data.tar.gz: 18949fc9dc50a089032465ddf03b293ef4b759d05cd17bcd2a19afa46a86948812cd08fb52aa21b251939bf52ac5bb4f0a047bbd6e49172be6ead5200756d838
+  metadata.gz: 1782920ca72bc88963633bf1c628e8a962850b1bf65c3b31401b87545372c47bcbe0f5ebe877e581b7584ba4ae1aafe775d6d270d684f3c9915d43783d73c94c
+  data.tar.gz: 39c27c3e838126da3d186e133680c1c917758d20d9aabb1d97bd07c079f0065f516a8d138cd2d5cfe0630e7303f0ee9631d1afd658adfa4e1ac7c0979a290de3

data/example/non_rails_app/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../../
   specs:
-    rabbit_feed (2.4.0)
+    rabbit_feed (2.4.1)
       activemodel (>= 3.2.0, < 5.0.0)
       activesupport (>= 3.2.0, < 5.0.0)
       avro (>= 1.5.4, < 1.8.0)

data/example/rails_app/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../../
   specs:
-    rabbit_feed (2.4.0)
+    rabbit_feed (2.4.1)
       activemodel (>= 3.2.0, < 5.0.0)
       activesupport (>= 3.2.0, < 5.0.0)
       avro (>= 1.5.4, < 1.8.0)

data/lib/rabbit_feed.rb

@@ -37,7 +37,14 @@ module RabbitFeed
       if defined?(Airbrake::VERSION) && Airbrake::VERSION.to_i < 5
         (Airbrake.notify_or_ignore exception) if Airbrake.configuration.public?
       elsif defined?(Airbrake::AIRBRAKE_VERSION) && Airbrake::AIRBRAKE_VERSION.to_i >= 5
-        Airbrake.notify exception
+        if RabbitFeed.configuration.consumer_exit_after_fail
+          # Will need to send the notification right away, otherwise the `exit` would kill the
+          # Airbrake before the notification is sent out
+          Airbrake.notify_sync exception
+        else
+          # Airbrake notify default to sending notification asynchronously
+          Airbrake.notify exception
+        end
       end
     end
   end

data/lib/rabbit_feed/version.rb

@@ -1,3 +1,3 @@
 module RabbitFeed
-  VERSION = '2.4.0'
+  VERSION = '2.4.1'
 end

data/spec/lib/rabbit_feed/consumer_connection_spec.rb

@@ -121,9 +121,20 @@ module RabbitFeed
                 end
               end
 
-              it 'notifies airbrake' do
-                expect(Airbrake).to receive(:notify).with(an_instance_of RuntimeError)
-                expect{ subject.consume { raise 'Consuming time' } }.not_to raise_error
+              context 'and consumer_exit_after_fail is true' do
+                before { allow(RabbitFeed.configuration).to receive(:consumer_exit_after_fail).and_return(true) }
+                it 'notifies airbrake synchronously' do
+                  expect(Airbrake).to receive(:notify_sync).with(an_instance_of RuntimeError)
+                  expect{ subject.consume { raise 'Consuming time' } }.not_to raise_error
+                end
+              end
+
+              context 'and consumer_exit_after_fail is not true' do
+                before { allow(RabbitFeed.configuration).to receive(:consumer_exit_after_fail).and_return(false) }
+                it 'notifies airbrake' do
+                  expect(Airbrake).to receive(:notify).with(an_instance_of RuntimeError)
+                  expect{ subject.consume { raise 'Consuming time' } }.not_to raise_error
+                end
               end
             end
           end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rabbit_feed
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: ruby
 authors:
 - Simply Business
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-08 00:00:00.000000000 Z
+date: 2016-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bunny