ra10ke 2.0.0 → 3.0.0

data/lib/ra10ke/git_repo.rb

@@ -82,20 +82,19 @@ module Ra10ke
     #     :sha=>"fcc0532bbc5a5b65f3941738339e9cc7e3d767ce", :ref=>"refs/pull/249/head", :type=>:pull, :subtype=>:head, :name=>"249"},
     #     :sha=>"8d54891fa5df75890ee15d53080c2a81b4960f92", :ref=>"refs/pull/267/head", :type=>:pull, :subtype=>:head, :name=>"267"}]
     def all_refs
-      @all_refs ||= begin
-        remote_refs.each_with_object([]) do |line, refs|
-          sha, ref = line.split("\t")
-          next refs if line.include?('redirecting')
-          next refs if sha.eql?('ref: refs/heads/master')
-          _, type, name, subtype = ref.chomp.split('/')
-          next refs unless name
-
-          type = :tag if type.eql?('tags')
-          type = type.to_sym
-          subtype = subtype.to_sym if subtype
-          type = :branch if type.eql?(:heads)
-          refs << { sha: sha, ref: ref.chomp, type: type, subtype: subtype, name: name }
-        end
+      @all_refs ||= remote_refs.each_with_object([]) do |line, refs|
+        sha, ref = line.split("\t")
+        next refs if line.include?('redirecting')
+        next refs if sha.eql?('ref: refs/heads/master')
+
+        _, type, name, subtype = ref.chomp.split('/')
+        next refs unless name
+
+        type = :tag if type.eql?('tags')
+        type = type.to_sym
+        subtype = subtype.to_sym if subtype
+        type = :branch if type.eql?(:heads)
+        refs << { sha: sha, ref: ref.chomp, type: type, subtype: subtype, name: name }
       end
     end
 
@@ -105,10 +104,10 @@ module Ra10ke
     # @return [String] the matching ref_name or nil
     def get_ref_like(ref_name)
       return nil unless valid_url?
-      ref = all_refs.find do |ref|
+
+      all_refs.find do |ref|
         ref[:name].include?(ref_name)
       end
-      ref
     end
 
     # useful for mocking easily

data/lib/ra10ke/install.rb

@@ -1,27 +1,27 @@
 module Ra10ke::Install
   def define_task_install(*_args)
-    desc "Install modules specified in Puppetfile"
+    desc 'Install modules specified in Puppetfile'
     task :install do
       require 'r10k/puppetfile'
 
       puppetfile = get_puppetfile
       puppetfile.load!
 
-      puts "Processing Puppetfile for fixtures"
+      puts 'Processing Puppetfile for fixtures'
       puppetfile.modules.each do |mod|
         if mod.status == :insync
           puts "Skipping #{mod.name} (#{mod.version}) already in sync"
         else
-          if mod.status == :absent
-            msg = "installed #{mod.name}"
-          else
-            msg = "updated #{mod.name} from #{mod.version} to"
-          end
+          msg = if mod.status == :absent
+                  "installed #{mod.name}"
+                else
+                  "updated #{mod.name} from #{mod.version} to"
+                end
           mod.sync
-          if mod.status != :insync
-            puts "Failed to sync #{mod.name}".red
-          else
+          if mod.status == :insync
             puts "Successfully #{msg} #{mod.version}".green
+          else
+            puts "Failed to sync #{mod.name}".red
           end
         end
       end

data/lib/ra10ke/monkey_patches.rb

@@ -18,7 +18,7 @@ class String
     colorize(33)
   end
 
-  # removes specified markes from string. 
+  # removes specified markes from string.
   # @return [String] - the string with markers removed
   def strip_comment(markers = ['#', "\n"])
     re = Regexp.union(markers)

data/lib/ra10ke/puppetfile_parser.rb

@@ -1,90 +1,90 @@
-# it might be desirable to parse the Puppetfile as a string instead of evaling it. 
+# it might be desirable to parse the Puppetfile as a string instead of evaling it.
 # this module allows you to do just that.
 require 'ra10ke/monkey_patches'
 
 module Ra10ke
-    module PuppetfileParser
-
-      # @return [Array] - returns a array of hashes that contain modules with a git source
-      def git_modules(file = puppetfile)
-        modules(file).find_all do |mod|
-          mod[:args].key?(:git)
-        end
+  module PuppetfileParser
+    # @return [Array] - returns a array of hashes that contain modules with a git source
+    def git_modules(file = puppetfile)
+      modules(file).find_all do |mod|
+        mod[:args].key?(:git)
       end
+    end
 
-      # @return [Array] - returns a array of hashes that contain modules from the Forge
-      def forge_modules(file = puppetfile)
-        modules(file).reject do |mod|
-          mod[:args].key?(:git)
-        end
+    # @return [Array] - returns a array of hashes that contain modules from the Forge
+    def forge_modules(file = puppetfile)
+      modules(file).reject do |mod|
+        mod[:args].key?(:git)
       end
+    end
 
-      # @param puppetfile [String] - the absolute path to the puppetfile
-      # @return [Array] - returns an array of module hashes that represent the puppetfile
-      # @example
-      # [{:namespace=>"puppetlabs", :name=>"stdlib", :args=>[]},
-      # {:namespace=>"petems", :name=>"swap_file", :args=>["'4.0.0'"]}]
-      def modules(puppetfile)
-        @modules ||= begin
-          return [] unless File.exist?(puppetfile)
-          all_lines = File.read(puppetfile).lines.map(&:strip_comment)
-          # remove comments from all the lines
-          lines_without_comments = all_lines.reject { |line| line.match(/#.*\n/) || line.empty? }.join("\n")
-          lines_without_comments.split(/^mod/).map do |line|
-            
-            next nil if line =~ /^forge/
-            next nil if line.empty?
+    # @param puppetfile [String] - the absolute path to the puppetfile
+    # @return [Array] - returns an array of module hashes that represent the puppetfile
+    # @example
+    # [{:namespace=>"puppetlabs", :name=>"stdlib", :args=>[]},
+    # {:namespace=>"petems", :name=>"swap_file", :args=>["'4.0.0'"]}]
+    def modules(puppetfile)
+      @modules ||= begin
+        return [] unless File.exist?(puppetfile)
 
-            parse_module_args(line)
-          end.compact.uniq
-        end
-      end
+        all_lines = File.read(puppetfile).lines.map(&:strip_comment)
+        # remove comments from all the lines
+        lines_without_comments = all_lines.reject { |line| line.match(/#.*\n/) || line.empty? }.join("\n")
+        lines_without_comments.split(/^mod/).map do |line|
+          next nil if /^forge/.match?(line)
+          next nil if line.empty?
 
-      # @param data [String] - the string to parse the puppetfile args out of
-      # @return [Array] -  an array of arguments in hash form
-      # @example
-      # {:namespace=>"puppetlabs", :name=>"stdlib", :args=>[]}
-      # {:namespace=>"petems", :name=>"swap_file", :args=>["'4.0.0'"]}
-      def parse_module_args(data)
-        return {} if data.empty?
-        args = data.split(',').map(&:strip)
-        # we can't guarantee that there will be a namespace when git is used
-        # remove quotes and dash and slash
-        namespace, name = args.shift.gsub(/'|"/, '').split(%r{-|/})
-        name ||= namespace
-        namespace = nil if namespace == name
-        {
-          namespace: namespace,
-          name: name,
-          args: process_args(args)
-        }
+          parse_module_args(line)
+        end.compact.uniq
       end
+    end
+
+    # @param data [String] - the string to parse the puppetfile args out of
+    # @return [Array] -  an array of arguments in hash form
+    # @example
+    # {:namespace=>"puppetlabs", :name=>"stdlib", :args=>[]}
+    # {:namespace=>"petems", :name=>"swap_file", :args=>["'4.0.0'"]}
+    def parse_module_args(data)
+      return {} if data.empty?
+
+      args = data.split(',').map(&:strip)
+      # we can't guarantee that there will be a namespace when git is used
+      # remove quotes and dash and slash
+      namespace, name = args.shift.gsub(/'|"/, '').split(%r{-|/})
+      name ||= namespace
+      namespace = nil if namespace == name
+      {
+        namespace: namespace,
+        name: name,
+        args: process_args(args),
+      }
+    end
 
-      # @return [Array] - returns an array of hashes with the args in key value pairs
-      # @param [Array] - the arguments processed from each entry in the puppetfile
-      # @example
-      # [{:args=>[], :name=>"razor", :namespace=>"puppetlabs"},
-      #  {:args=>[{:version=>"0.0.3"}], :name=>"ntp", :namespace=>"puppetlabs"},
-      #  {:args=>[], :name=>"inifile", :namespace=>"puppetlabs"},
-      #  {:args=>
-      #    [{:git=>"https://github.com/nwops/reportslack.git"}, {:ref=>"1.0.20"}],
-      #   :name=>"reportslack",
-      #   :namespace=>"nwops"},
-      #  {:args=>{:git=>"git://github.com/puppetlabs/puppetlabs-apt.git"},
-      #   :name=>"apt",
-      #   :namespace=>nil}
-      # ]
-      def process_args(args)
-        results = {}
-        args.each do |arg|
-          a = arg.gsub(/'|"/, '').split(/\A\:|\:\s|\=\>/).map(&:strip).reject(&:empty?)
-          if a.count < 2
-            results[:version] = a.first
-          else
-            results[a.first.to_sym] = a.last
-          end
+    # @return [Array] - returns an array of hashes with the args in key value pairs
+    # @param [Array] - the arguments processed from each entry in the puppetfile
+    # @example
+    # [{:args=>[], :name=>"razor", :namespace=>"puppetlabs"},
+    #  {:args=>[{:version=>"0.0.3"}], :name=>"ntp", :namespace=>"puppetlabs"},
+    #  {:args=>[], :name=>"inifile", :namespace=>"puppetlabs"},
+    #  {:args=>
+    #    [{:git=>"https://github.com/nwops/reportslack.git"}, {:ref=>"1.0.20"}],
+    #   :name=>"reportslack",
+    #   :namespace=>"nwops"},
+    #  {:args=>{:git=>"git://github.com/puppetlabs/puppetlabs-apt.git"},
+    #   :name=>"apt",
+    #   :namespace=>nil}
+    # ]
+    def process_args(args)
+      results = {}
+      args.each do |arg|
+        a = arg.gsub(/'|"/, '').split(/\A:|:\s|=>/).map(&:strip).reject(&:empty?)
+        if a.count < 2
+          results[:version] = a.first
+        else
+          results[a.first.to_sym] = a.last
         end
-        results
       end
+      results
     end
+  end
 end

data/lib/ra10ke/solve.rb

@@ -27,18 +27,16 @@ module Ra10ke::Solve
       PuppetForge.user_agent = "ra10ke/#{Ra10ke::VERSION}"
       puppetfile = get_puppetfile
       puppetfile.load!
-      PuppetForge.host = puppetfile.forge if puppetfile.forge =~ /^http/
+      PuppetForge.host = puppetfile.forge if /^http/.match?(puppetfile.forge)
 
       # ignore file allows for "don't tell me about this"
       ignore_modules = []
-      if File.exist?('.r10kignore')
-        ignore_modules = File.readlines('.r10kignore').each(&:chomp!)
-      end
+      ignore_modules = File.readlines('.r10kignore').each(&:chomp!) if File.exist?('.r10kignore')
       # Actual new logic begins here:
       cache = (ENV['XDG_CACHE_DIR'] || File.expand_path('~/.cache'))
 
       FileUtils.mkdir_p(cache)
-      
+
       # Metadata cache, since the Forge is slow:
       @metadata_cache = YAML::Store.new File.join(cache, 'ra10ke.metadata_cache')
       # The graph of available module versions
@@ -54,7 +52,8 @@ module Ra10ke::Solve
 
       puppetfile.modules.each do |puppet_module|
         next if ignore_modules.include? puppet_module.title
-        if puppet_module.class == R10K::Module::Forge
+
+        if puppet_module.instance_of?(R10K::Module::Forge)
           module_name = puppet_module.title.tr('/', '-')
           installed_version = puppet_module.expected_version
           puts "Processing Forge module #{module_name}-#{installed_version}"
@@ -81,7 +80,8 @@ module Ra10ke::Solve
           add_reqs_to_graph(mod, meta)
         end
 
-        next unless puppet_module.class == R10K::Module::Git
+        next unless puppet_module.instance_of?(R10K::Module::Git)
+
         # This downloads the git module to modules/modulename
         meta = fetch_git_metadata(puppet_module)
         version = get_key_or_sym(meta, :version)
@@ -97,9 +97,7 @@ module Ra10ke::Solve
       end
       puts
       puts 'Resolving dependencies...'
-      if allow_major_bump
-        puts 'WARNING:  Potentially breaking updates are allowed for this resolution'
-      end
+      puts 'WARNING:  Potentially breaking updates are allowed for this resolution' if allow_major_bump
       result = Solve.it!(@graph, @demands, sorted: true)
       puts
       print_module_diff(@current_modules, result)
@@ -130,7 +128,7 @@ module Ra10ke::Solve
       return {
         version: '0.0.0',
         name: puppet_module.title,
-        dependencies: []
+        dependencies: [],
       }
     end
     metadata = R10K::Module::MetadataFile.new(metadata_path)
@@ -138,7 +136,7 @@ module Ra10ke::Solve
     {
       version: metadata.version,
       name: metadata.name,
-      dependencies: metadata.dependencies
+      dependencies: metadata.dependencies,
     }
   end
 
@@ -150,7 +148,7 @@ module Ra10ke::Solve
   # At least puppet-extlib has malformed metadata
   def get_version_req(dep)
     req = get_key_or_sym(dep, :version_requirement)
-    req = get_key_or_sym(dep, :version_range) unless req
+    req ||= get_key_or_sym(dep, :version_range)
     req
   end
 
@@ -186,17 +184,14 @@ module Ra10ke::Solve
       # actually ask the solver for the versioned thing
       @demands.add(name) unless no_demands
       ver = get_version_req(dep)
-      unless ver
-        # no version specified, so anything will do
-        ver = '>=0.0.0'
-      end
-      ver.split(/(?=[<])/).each do |bound|
+      ver ||= '>=0.0.0'
+      ver.split(/(?=<)/).each do |bound|
         bound.strip!
         v = begin
-              Semverse::Constraint.new(bound)
-            rescue
-              nil
-            end
+          Semverse::Constraint.new(bound)
+        rescue StandardError
+          nil
+        end
         if v
           artifact.depends(name, v.to_s)
         else
@@ -206,14 +201,16 @@ module Ra10ke::Solve
       # Find the dependency in the forge, unless it's already been processed
       # and add its releases to the global graph
       next unless @processed_modules.add?(name)
+
       puts "Fetching module info for #{name}"
       mod = begin
-              PuppetForge::Module.find(name)
-            rescue
-              # It's probably a git module
-              nil
-            end
+        PuppetForge::Module.find(name)
+      rescue StandardError
+        # It's probably a git module
+        nil
+      end
       next unless mod # Git module, or non-forge dependency. Skip to next for now.
+
       # Fetching metadata for all releases takes ages (which is weird, since it's mostly static info)
       mod.releases.take(FETCH_LIMIT).each do |rel|
         meta = get_release_metadata(name, rel)

data/lib/ra10ke/syntax.rb

@@ -1,18 +1,16 @@
 module Ra10ke::Syntax
   def define_task_syntax(*_args)
-    desc "Syntax check Puppetfile"
+    desc 'Syntax check Puppetfile'
     task :syntax do
       require 'r10k/action/puppetfile/check'
 
       puppetfile = R10K::Action::Puppetfile::Check.new({
-        :root => @basedir,
-        :moduledir => @moduledir,
-        :puppetfile => @puppetfile_path
-      }, '')
+                                                         root: @basedir,
+                                                         moduledir: @moduledir,
+                                                         puppetfile: @puppetfile_path,
+                                                       }, '')
 
-      unless puppetfile.call
-        abort("Puppetfile syntax check failed")
-      end
+      abort('Puppetfile syntax check failed') unless puppetfile.call
     end
   end
 end

data/lib/ra10ke/validate.rb

@@ -8,7 +8,6 @@ require 'ra10ke/git_repo'
 
 module Ra10ke
   module Validate
-
     GOOD_EMOJI = ENV['GOOD_EMOJI'] || '👍'
     BAD_EMOJI = ENV['BAD_EMOJI'] || '😨'
 
@@ -64,7 +63,7 @@ module Ra10ke
               ref: ref,
               valid_url?: repo.valid_url?,
               valid_ref?: valid_ref,
-              status: valid_ref ? Ra10ke::Validate::GOOD_EMOJI : Ra10ke::Validate::BAD_EMOJI
+              status: valid_ref ? Ra10ke::Validate::GOOD_EMOJI : Ra10ke::Validate::BAD_EMOJI,
             }
           end
         end

data/lib/ra10ke/version.rb

@@ -1,3 +1,3 @@
 module Ra10ke
-  VERSION = "2.0.0"
+  VERSION = '3.0.0'
 end

data/lib/ra10ke.rb

@@ -48,7 +48,8 @@ module Ra10ke
     def get_puppetfile
       R10K::Puppetfile.new(@basedir, @moduledir, @puppetfile_path, @puppetfile_name, @force)
     rescue ArgumentError # R10k < 2.6.0
-      R10K::Puppetfile.new(@basedir, @moduledir, @puppetfile_path || File.join(@basedir, @puppetfile_name || 'Puppetfile'))
+      R10K::Puppetfile.new(@basedir, @moduledir,
+                           @puppetfile_path || File.join(@basedir, @puppetfile_name || 'Puppetfile'))
     end
   end
 end

data/ra10ke.gemspec

@@ -1,30 +1,30 @@
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'ra10ke/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "ra10ke"
+  spec.name          = 'ra10ke'
   spec.version       = Ra10ke::VERSION
-  spec.authors       = ["Theo Chatzimichos", "Vox Pupuli"]
-  spec.email         = ["voxpupuli@groups.io"]
-  spec.description   = %q{R10K and Puppetfile rake tasks}
-  spec.summary       = %q{Syntax check for the Puppetfile, check for outdated installed puppet modules}
-  spec.homepage      = "https://github.com/voxpupuli/ra10ke"
-  spec.license       = "MIT"
+  spec.authors       = ['Theo Chatzimichos', 'Vox Pupuli']
+  spec.email         = ['voxpupuli@groups.io']
+  spec.description   = 'R10K and Puppetfile rake tasks'
+  spec.summary       = 'Syntax check for the Puppetfile, check for outdated installed puppet modules'
+  spec.homepage      = 'https://github.com/voxpupuli/ra10ke'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($/)
-  spec.require_paths = ["lib"]
-  spec.required_ruby_version = '>= 2.6.0'
+  spec.require_paths = ['lib']
+  spec.required_ruby_version = '>= 2.7.0'
 
-  spec.add_dependency "rake"
-  spec.add_dependency "puppet_forge"
-  spec.add_dependency "r10k", '>= 2.6.5'
-  spec.add_dependency "git"
-  spec.add_dependency "solve"
-  spec.add_dependency 'semverse', '>= 2.0'
+  spec.add_dependency 'git', '~> 1.18'
+  spec.add_dependency 'puppet_forge', '~> 5.0', '>= 5.0.1'
+  spec.add_dependency 'r10k', '>= 2.6.5', '< 5'
+  spec.add_dependency 'rake', '~> 13.0', '>= 13.0.6'
+  spec.add_dependency 'semverse', '>= 2.0', '< 4'
+  spec.add_dependency 'solve', '~> 4.0', '>= 4.0.4'
   spec.add_dependency 'table_print', '~> 1.5.6'
+  spec.add_development_dependency 'pry', '~> 0.14.2'
   spec.add_development_dependency 'rspec', '~> 3.6'
-  spec.add_development_dependency 'pry'
-  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'simplecov', '~> 0.22.0'
+  spec.add_development_dependency 'voxpupuli-rubocop', '~> 2.0.0'
 end
-

data/spec/fixtures/Puppetfile_deprecation_issue

@@ -5,8 +5,8 @@ mod 'puppet/ferm', :latest
 mod 'puppet/borg', :latest
 mod 'puppet/wireguard', :latest
 mod 'puppet/bird', :latest
-mod 'herculesteam/augeasproviders_pam', :latest
-mod 'herculesteam/augeasproviders_shellvar', :latest
+mod 'puppet/augeasproviders_pam', :latest
+mod 'puppet/augeasproviders_shellvar', :latest
 mod 'puppetlabs/vcsrepo', :latest
 mod 'saz/ssh', :latest
 mod 'puppet/r10k', :latest
@@ -22,8 +22,8 @@ mod 'theforeman/foreman', :latest
 mod 'theforeman/puppet', :latest
 mod 'theforeman/foreman_proxy', :latest
 mod 'puppet/nftables', :latest
-mod 'herculesteam/augeasproviders_sysctl', :latest
-mod 'camptocamp/catalog_diff', :latest
+mod 'puppet/augeasproviders_sysctl', :latest
+mod 'puppet/catalog_diff', :latest
 mod 'puppet/unattended_upgrades', :latest
 mod 'puppet/selinux', :latest
 mod 'choria/choria', :latest
@@ -34,7 +34,7 @@ mod 'jsok/vault',
   ref: 'test'
 
 # dependencies
-mod 'herculesteam/augeasproviders_core', :latest
+mod 'puppet/augeasproviders_core', :latest
 mod 'puppetlabs/stdlib', :latest
 mod 'choria/mcollective', :latest
 mod 'puppetlabs/concat', :latest

data/spec/ra10ke/dependencies_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'r10k/puppetfile'
 require 'spec_helper'
 require 'ra10ke/dependencies'
@@ -8,7 +9,7 @@ RSpec::Mocks.configuration.allow_message_expectations_on_nil = true
 
 RSpec.describe 'Ra10ke::Dependencies::Verification' do
   let(:instance) do
-    pfile = R10K::Puppetfile.new(File.basename(puppetfile), nil,puppetfile, nil, false)
+    pfile = R10K::Puppetfile.new(File.basename(puppetfile), nil, puppetfile, nil, false)
     Ra10ke::Dependencies::Verification.new(pfile)
   end
 
@@ -20,8 +21,9 @@ RSpec.describe 'Ra10ke::Dependencies::Verification' do
     it 'default contains semver' do
       expect(Ra10ke::Dependencies::Verification.version_formats).to have_key(:semver)
     end
+
     it 'add new version format' do
-      Ra10ke::Dependencies::Verification.register_version_format(:test) do |tags|
+      Ra10ke::Dependencies::Verification.register_version_format(:test) do |_tags|
         nil
       end
       expect(Ra10ke::Dependencies::Verification.version_formats).to have_key(:test)
@@ -30,10 +32,10 @@ RSpec.describe 'Ra10ke::Dependencies::Verification' do
 
   context 'show output in table format' do
     let(:instance) do
-      pfile = R10K::Puppetfile.new(File.basename(puppetfile), nil,puppetfile, nil, false)
+      pfile = R10K::Puppetfile.new(File.basename(puppetfile), nil, puppetfile, nil, false)
       Ra10ke::Dependencies::Verification.new(pfile)
     end
-  
+
     let(:puppetfile) do
       File.join(fixtures_dir, 'Puppetfile')
     end
@@ -49,26 +51,24 @@ RSpec.describe 'Ra10ke::Dependencies::Verification' do
     it 'show dependencies as table' do
       instance.print_table(processed_modules)
     end
-
   end
 
   context 'get_latest_ref' do
-
     context 'find latest semver tag' do
       let(:latest_tag) do
-          'v1.1.0'
+        'v1.1.0'
       end
       let(:test_tags) do
         {
-          'v1.0.0'   => nil,
+          'v1.0.0' => nil,
           latest_tag => nil,
         }
       end
 
       it do
         expect(instance.get_latest_ref({
-          'tags' => test_tags,
-        })).to eq(latest_tag)
+                                         'tags' => test_tags,
+                                       })).to eq(latest_tag)
       end
     end
 
@@ -78,7 +78,7 @@ RSpec.describe 'Ra10ke::Dependencies::Verification' do
       end
       let(:test_tags) do
         {
-          'dev'      => nil,
+          'dev' => nil,
           latest_tag => nil,
         }
       end
@@ -88,20 +88,19 @@ RSpec.describe 'Ra10ke::Dependencies::Verification' do
           tags.detect { |tag| tag == latest_tag }
         end
         expect(instance.get_latest_ref({
-          'tags' => test_tags,
-        })).to eq(latest_tag)
+                                         'tags' => test_tags,
+                                       })).to eq(latest_tag)
       end
     end
 
     context 'convert to ref' do
-       
       it 'run rake task' do
         output_conversion = File.read(File.join(fixtures_dir, 'Puppetfile_git_conversion'))
         require 'ra10ke'
         Ra10ke::RakeTask.new do |t|
           t.basedir = fixtures_dir
         end
-        expect{Rake::Task['r10k:print_git_conversion'].invoke}.to output(output_conversion).to_stdout
+        expect { Rake::Task['r10k:print_git_conversion'].invoke }.to output(output_conversion).to_stdout
       end
     end
   end

data/spec/ra10ke/deprecation_spec.rb

@@ -14,21 +14,24 @@ RSpec.describe 'Ra10ke::Deprecation::Validation' do
   end
 
   it 'only checks forge modules' do
-    expect(PuppetForge::Module).to_not receive(:find).with('puppet')
+    expect(PuppetForge::Module).not_to receive(:find).with('puppet')
     allow(PuppetForge::Module).to receive(:find).and_raise(Faraday::ResourceNotFound.new(nil))
     expect(instance.deprecated_modules.count).to eq(0)
   end
 
   it 'handles deprecated modules' do
-    expect(PuppetForge::Module).to receive(:find).with('puppetlabs-ruby').and_return(double(slug: 'puppetlabs-ruby', deprecated_at: '2021-04-22 10:29:42 -0700'))
+    expect(PuppetForge::Module).to receive(:find).with('puppetlabs-ruby').and_return(double(slug: 'puppetlabs-ruby',
+                                                                                            deprecated_at: '2021-04-22 10:29:42 -0700'))
     allow(PuppetForge::Module).to receive(:find).and_return(double(slug: 'module-module', deprecated_at: nil))
 
     expect(instance.bad_mods?).to eq(true)
-    expect(instance.deprecated_modules.first).to eq(name: 'puppetlabs-ruby', deprecated_at: Time.parse('2021-04-22 10:29:42 -0700'))
+    expect(instance.deprecated_modules.first).to eq(name: 'puppetlabs-ruby',
+                                                    deprecated_at: Time.parse('2021-04-22 10:29:42 -0700'))
   end
 
   it 'handles missing modules' do
-    expect(PuppetForge::Module).to receive(:find).with('choria-choria').and_return(double(slug: 'choria-choria', deprecated_at: nil))
+    expect(PuppetForge::Module).to receive(:find).with('choria-choria').and_return(double(slug: 'choria-choria',
+                                                                                          deprecated_at: nil))
     expect(PuppetForge::Module).to receive(:find).with('puppetlabs-ruby').and_raise(Faraday::ResourceNotFound.new(nil))
     allow(PuppetForge::Module).to receive(:find).and_return(double(slug: 'module-module', deprecated_at: nil))