qwtf_discord_bot 6.0.3 → 6.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 151d77adaf69b8f02ce8cba749eee97bdc6927956169d673d72917563bb07b91
-  data.tar.gz: 781ddacc6d1f792df33553581cdc9a00f583872de3ed6f4581f2024fab7a83bd
+  metadata.gz: ef8bda609c0735d9ba3ba074c3f53a963c2d2cc7f933af4965ba9fb797b7d151
+  data.tar.gz: de760869c4380aa7d14ec16b7828655b1534c41aa3808a6c26d8f36a5694e7dd
 SHA512:
-  metadata.gz: b034cd067bc60caaa168f175debfb55f607416a7b7a4efd37f9a0e00b49a693a9722d021989fd3518c8e56134ada4379c9273106fac0a0d8083d493f01d040ec
-  data.tar.gz: 74436d2a147f42297fa21f7e20429c8e902bda52535089a6dd8f97ac452686d19ff78702ee413efc69c4f2e1248691456de78c84ba779e79819a04bb077d1363
+  metadata.gz: ec8f53ff7b12188bab9059db811c478b7010a105e7d37e626816da5d03003502030515e7ab918b521ec0d6dd7998c1a776be332d8a1fdc1fa2a8935df4fb272b
+  data.tar.gz: 4812904a6c1dd2824f08bd376239760c8506329438c26dae718ac809a123e6201547ad40f77de1bd3cab91781234022f6f914ba4f1abc21eba9c19c6f0e7999b

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    qwtf_discord_bot (6.0.2)
+    qwtf_discord_bot (6.1.3)
       discordrb (= 3.4.0)
       redis (~> 4.2)
       thor (~> 1.1)

data/README.md

@@ -140,6 +140,14 @@ Push:
     gem push qwtf_discord_bot-$(cat VERSION).gem
 
 
+## Develop
+
+```
+bundle install
+bundle exec bin/qwtf_discord_bot
+```
+
+
 ## Docker
 
 Run:

data/VERSION

@@ -1 +1 @@
-6.0.3
+6.1.3

data/lib/dashboard.rb

@@ -4,7 +4,6 @@ class Dashboard
     @endpoints = dashboard_config["endpoints"]
     @messages = {}
 
-
     channel_name = dashboard_config["name"]
 
     old_dashboard_channel = @server.channels.find do |chan|

data/lib/pug.rb

@@ -11,17 +11,28 @@ class Pug
   end
 
   def join(player_id)
-    redis.setnx(pug_key, Time.now.to_i)
-    redis.sadd(team_key(0), player_id)
+    timestamp = Time.now.to_i
+    redis.setnx(pug_key, timestamp)
+    redis.zadd(queue_key, timestamp, player_id, nx: true)
   end
 
   def join_team(team_no:, player_id:)
-    redis.setnx(pug_key, Time.now.to_i)
-    leave_teams(player_id)
+    join(player_id)
+    unteam(player_id)
     redis.sadd(team_key(team_no), player_id)
   end
 
-  def joined_players
+  def up_now_players
+    players[0, maxplayers]
+  end
+
+  def destroy_teams
+    teamed_players.each do |player_id|
+      unteam(player_id)
+    end
+  end
+
+  def teamed_players
     teams_keys.inject([]) do |players, team|
       players + redis.smembers(team).map(&:to_i)
     end
@@ -55,16 +66,24 @@ class Pug
     redis.set(teamsize_key, teamsize)
   end
 
+  def total_player_count
+    players.count
+  end
+
   def full?
-    joined_player_count >= maxplayers
+    total_player_count >= maxplayers
+  end
+
+  def has_exactly_maxplayers?
+    total_player_count == maxplayers
   end
 
   def empty?
-    joined_player_count.zero?
+    total_player_count.zero?
   end
 
-  def joined_player_count
-    joined_players.count
+  def teamed_player_count
+    teamed_players.count
   end
 
   def team_player_count(team_no)
@@ -72,11 +91,11 @@ class Pug
   end
 
   def player_slots
-    "#{joined_player_count}/#{maxplayers}"
+    "#{total_player_count}/#{maxplayers}"
   end
 
   def slots_left
-    maxplayers - joined_player_count
+    maxplayers - total_player_count
   end
 
   def game_map=(map)
@@ -104,7 +123,8 @@ class Pug
   end
 
   def leave(player_id)
-    leave_teams(player_id)
+    leave_queue(player_id)
+    unteam(player_id)
   end
 
   def end_pug
@@ -114,13 +134,17 @@ class Pug
   end
 
   def joined?(player_id)
-    joined_players.include?(player_id)
+    redis.zrank(queue_key, player_id)
   end
 
   def maxplayers
     teamsize * no_of_teams
   end
 
+  def queued_players
+    players - teamed_players
+  end
+
   def teams
     all_teams = teams_keys.inject({}) do |teams, team|
       teams.merge({ team.split(':').last.to_i => redis.smembers(team).map(&:to_i) })
@@ -129,16 +153,6 @@ class Pug
     all_teams.sort.to_h
   end
 
-  def actual_teams
-    teams.tap { |team| team.delete(0) }
-  end
-
-  def unteam_all_players
-    joined_players.each do |player_id|
-      join_team(team_no: 0, player_id: player_id)
-    end
-  end
-
   def update_last_result_time
     redis.set(last_result_time_key, Time.now.to_i)
   end
@@ -148,25 +162,37 @@ class Pug
   end
 
   def equal_number_of_players_on_each_team?
-    team_player_counts = actual_teams.map do |_name, players|
+    team_player_counts = teams.map do |_name, players|
       players.size
     end
 
     team_player_counts.uniq.size == 1
   end
 
-  private
-
-  def leave_teams(player_id)
+  def unteam(player_id)
     teams_keys.each do |team|
       redis.srem(team, player_id)
     end
   end
 
+  def players
+    redis.zrange(queue_key, 0, -1).map(&:to_i)
+  end
+
+  private
+
+  def leave_queue(player_id)
+    redis.zrem(queue_key, player_id)
+  end
+
   def teams_keys
     redis.keys([pug_key, 'teams:*'].join(':'))
   end
 
+  def queue_key
+    [pug_key, 'queue'].join(':')
+  end
+
   def team_key(team_no)
     [pug_key, 'teams', team_no].join(':')
   end
@@ -208,6 +234,6 @@ class Pug
   end
 
   def no_of_teams
-    [actual_teams.count, MIN_NO_OF_TEAMS].max
+    [teams.count, MIN_NO_OF_TEAMS].max
   end
 end

data/lib/qstat_request.rb

@@ -11,28 +11,26 @@ class QstatRequest
     @result ||= execute
   end
 
-  def to_embed
-    return nil if is_empty?
-
-    embed = Discordrb::Webhooks::Embed.new
-
-    teams.each do |team|
-      embed << team.to_embed_field
-    end
-
-    embed
-  end
-
   def to_full_embed
     Discordrb::Webhooks::Embed.new.tap do |embed|
       embed.add_field(
         name: name,
-        value: embed_summary,
+        value: join_link,
       )
 
       teams.each do |team|
         embed << team.to_embed_field
       end
+
+      footer = [game_map, "#{numplayers}/#{maxplayers} players"]
+
+      if has_spectators?
+        footer << "#{numspectators}/#{maxspectators} spectators"
+      end
+
+      embed.footer = Discordrb::Webhooks::EmbedFooter.new(
+        text: footer.join(MSG_SNIPPET_DELIMITER)
+      )
     end
   end
 
@@ -43,9 +41,7 @@ class QstatRequest
   end
 
   def server_summary
-    return "#{@endpoint} isn't responding" unless game_map
-
-    info = [name, @endpoint, game_map]
+    info = [name, game_map]
 
     info += if !has_spectators?
               ["#{numplayers}/#{maxplayers}"]
@@ -56,28 +52,13 @@ class QstatRequest
               ]
             end
 
+    info << join_link
+
     info.join(MSG_SNIPPET_DELIMITER)
   end
 
   def join_link
-    "[Join](http://phobos.baseq.fr:9999/join?url=#{@endpoint})"
-  end
-
-  def embed_summary
-    info = [@endpoint, game_map]
-
-    info += if !has_spectators?
-              ["#{numplayers}/#{maxplayers}"]
-            else
-              [
-                "#{numplayers}/#{maxplayers} players",
-                "#{numspectators}/#{maxspectators} spectators"
-              ]
-            end
-
-    info << join_link
-
-    info.join(MSG_SNIPPET_DELIMITER)
+    "<qw://#{@endpoint}>"
   end
 
   def is_empty?
@@ -92,6 +73,10 @@ class QstatRequest
     numplayers && numplayers > 0
   end
 
+  def live_server?
+    !game_map.nil?
+  end
+
   private
 
   def has_spectators?

data/lib/qwtf_discord_bot/qwtf_discord_bot_pug.rb

@@ -40,22 +40,15 @@ class QwtfDiscordBotPug # :nodoc:
         end
 
         join_pug(e, pug)
-        start_pug(pug, e) if pug.full?
+        start_pug(pug, e) if pug.has_exactly_maxplayers?
       end
     end
 
     bot.command :choose do |event, *args|
       setup_pug(event) do |e, pug|
-        if pug.joined_players.count > pug.maxplayers
-          return send_embedded_message(
-            description: "Too many players, increase `!teamsize` or `!kick` extras",
-            channel: event.channel
-          )
-        end
-
-        if pug.joined_players.count.odd?
+        if !pug.full?
           return send_embedded_message(
-            description: "Can't choose teams with odd number of players",
+            description: "Not enough players, reduce !teamsize",
             channel: event.channel
           )
         end
@@ -257,13 +250,6 @@ class QwtfDiscordBotPug # :nodoc:
           )
         else
           args[1..-1].each do |mention|
-            if pug.team(team_no).size >= pug.teamsize
-              return send_embedded_message(
-                description: "Team is full",
-                channel: e.channel
-              )
-            end
-
             unless mention.match(/<@!\d+>/)
               send_embedded_message(
                 description: "#{arg} isn't a valid mention",
@@ -286,7 +272,7 @@ class QwtfDiscordBotPug # :nodoc:
           end
         end
 
-        start_pug(pug, e) if !pug_already_full && pug.full?
+        start_pug(pug, e) if !pug_already_full && pug.has_exactly_maxplayers?
       end
     end
 
@@ -309,14 +295,14 @@ class QwtfDiscordBotPug # :nodoc:
             )
           end
 
-          if pug.team(0).include?(user_id)
+          if !pug.teamed_players.include?(user_id)
             return send_embedded_message(
               description: "You aren't in a team",
               channel: e.channel
             )
           end
 
-          pug.join_team(team_no: 0, player_id: user_id)
+          pug.unteam(user_id)
 
           send_embedded_message(
             description: "#{e.display_name} leaves team",
@@ -334,7 +320,15 @@ class QwtfDiscordBotPug # :nodoc:
 
             user_id = mention_to_user_id(mention)
             display_name = e.display_name_for(user_id) || arg
-            pug.join_team(team_no: 0, player_id: user_id)
+
+            unless pug.joined?(user_id)
+              return send_embedded_message(
+                description: "#{display_name} isn't in this PUG",
+                channel: e.channel
+              )
+            end
+
+            pug.unteam(user_id)
 
             send_embedded_message(
               description: "#{display_name} leaves team",
@@ -391,14 +385,14 @@ class QwtfDiscordBotPug # :nodoc:
 
         winning_team_no = args.first.to_i
 
-        if pug.actual_teams.count < 2
+        if pug.teams.count < 2
           return send_embedded_message(
             description: "There must be at least two teams with players to submit a result",
             channel: e.channel
           )
         end
 
-        team_results = pug.actual_teams.inject({}) do |teams, (name, player_ids)|
+        team_results = pug.teams.inject({}) do |teams, (name, player_ids)|
           players = player_ids.inject({}) do |memo, id|
             memo.merge({ id => e.display_name_for(id) })
           end
@@ -451,7 +445,7 @@ class QwtfDiscordBotPug # :nodoc:
           )
         end
 
-        if pug.actual_teams.count < 2
+        if pug.teams.count < 2
           return send_embedded_message(
             description: "There must be at least two teams with players to submit a result",
             channel: e.channel
@@ -467,7 +461,7 @@ class QwtfDiscordBotPug # :nodoc:
           )
         end
 
-        team_results = pug.actual_teams.inject({}) do |teams, (name, player_ids)|
+        team_results = pug.teams.inject({}) do |teams, (name, player_ids)|
           players = player_ids.inject({}) do |memo, id|
             memo.merge({ id => e.display_name_for(id) })
           end
@@ -651,7 +645,7 @@ class QwtfDiscordBotPug # :nodoc:
   def join_pug(e, pug)
     pug.join(e.user_id)
 
-    if pug.joined_player_count == 1
+    if pug.total_player_count == 1
       snippets = ["#{e.display_name} creates a PUG", "#{pug.player_slots} joined"]
       message = pug.notify_roles
     else
@@ -676,7 +670,7 @@ class QwtfDiscordBotPug # :nodoc:
   def choose_fair_teams(pug:, event:, iteration: 0)
     if !pug.full?
       return send_embedded_message(
-        description: "Can't choose teams until PUG is full",
+        description: "Not enough players, reduce !teamsize",
         channel: event.channel
       ) && nil
     end
@@ -687,7 +681,7 @@ class QwtfDiscordBotPug # :nodoc:
     )
 
     combinations = get_fair_teams(
-      channel_id: event.channel.id, players: pug.joined_players
+      channel_id: event.channel.id, players: pug.up_now_players
     )
 
     teams = combinations[iteration]
@@ -700,6 +694,8 @@ class QwtfDiscordBotPug # :nodoc:
       ) && nil
     end
 
+    pug.destroy_teams
+
     teams.each do |team_no, player_ids|
       player_ids.each do |player_id|
         pug.join_team(team_no: team_no, player_id: player_id)
@@ -724,6 +720,18 @@ class QwtfDiscordBotPug # :nodoc:
         text: footer
       )
 
+      if pug.queued_players.any?
+        queue_display_names = pug.queued_players.map do |player_id|
+          event.display_name_for(player_id)
+        end
+
+        embed.add_field(
+          inline: true,
+          name: "Queue",
+          value: queue_display_names.join("\n")
+        )
+      end
+
       pug.teams.each do |team_no, player_ids|
         team_display_names = player_ids.map do |player_id|
           event.display_name_for(player_id)
@@ -739,14 +747,14 @@ class QwtfDiscordBotPug # :nodoc:
   end
 
   def start_pug(pug, event)
-    choose_fair_teams(pug: pug, event: event) unless pug.actual_teams.any?
+    choose_fair_teams(pug: pug, event: event) unless pug.teams.any?
 
     footer = [
       pug.game_map,
       "#{pug.player_slots} joined",
     ].compact.join(MSG_SNIPPET_DELIMITER)
 
-    mentions = pug.joined_players.map do |player_id|
+    mentions = pug.players.map do |player_id|
       event.mention_for(player_id)
     end
 
@@ -760,6 +768,18 @@ class QwtfDiscordBotPug # :nodoc:
         text: footer
       )
 
+      if pug.queued_players.any?
+        queue_display_names = pug.queued_players.map do |player_id|
+          event.display_name_for(player_id)
+        end
+
+        embed.add_field(
+          inline: true,
+          name: "Queue",
+          value: queue_display_names.join("\n")
+        )
+      end
+
       pug.teams.each do |team_no, player_ids|
         team_mentions = player_ids.map do |player_id|
           event.display_name_for(player_id)

data/lib/qwtf_discord_bot/qwtf_discord_bot_server.rb

@@ -16,20 +16,17 @@ class QwtfDiscordBotServer
         message = 'Provide a server address e.g. `!server ' \
           'sydney.fortressone.org` or use `!active` or `!all`'
         event.channel.send_message(message)
-        puts message
+
+        return puts message
+      end
+
+      endpoint = args.first
+      request = QstatRequest.new(endpoint)
+
+      if !request.live_server?
+        event.channel.send_message("#{endpoint} isn't responding")
       else
-        endpoint = args.first
-        qstat_response = QstatRequest.new(endpoint)
-        message = qstat_response.server_summary
-        embed = qstat_response.to_embed
-
-        if embed
-          event.channel.send_embed(message, embed)
-          puts message
-        else
-          event.channel.send_message(message)
-          puts message
-        end
+        event.channel.send_embed(nil, request.to_full_embed)
       end
     end
 
@@ -43,20 +40,16 @@ class QwtfDiscordBotServer
       if endpoints_for_this_channel.empty?
         message = 'There are no servers associated with this channel'
         event.channel.send_message(message)
-        puts message
-      else
-        endpoints_for_this_channel.each do |endpoint|
-          qstat_request = QstatRequest.new(endpoint.address)
-          message = qstat_request.server_summary
-          embed = qstat_request.to_embed
-
-          if embed
-            event.channel.send_embed(message, embed)
-            puts message
-          else
-            event.channel.send_message(message)
-            puts message
-          end
+        return puts message
+      end
+
+      endpoints_for_this_channel.each do |endpoint|
+        request = QstatRequest.new(endpoint.address)
+
+        if !request.live_server?
+          event.channel.send_message("#{endpoint} isn't responding")
+        else
+          event.channel.send_embed(nil, request.to_full_embed)
         end
       end
 
@@ -73,35 +66,27 @@ class QwtfDiscordBotServer
       if endpoints_for_this_channel.empty?
         message = 'There are no servers associated with this channel'
         event.channel.send_message(message)
-        puts message
-      else
-        qstat_requests = endpoints_for_this_channel.map do |endpoint|
-          QstatRequest.new(endpoint.address)
-        end
+        return puts message
+      end
 
-        servers_with_players = qstat_requests.reject do |server|
-          server.is_empty?
-        end
+      qstat_requests = endpoints_for_this_channel.map do |endpoint|
+        QstatRequest.new(endpoint.address)
+      end
 
-        if servers_with_players.empty?
-          message = "All ##{event.channel.name} servers are empty"
-          event.channel.send_message(message)
-          puts message
-        else
-          servers_with_players.each do |server|
-            message = server.server_summary
-            embed = server.to_embed
-
-            if embed
-              event.channel.send_embed(message, embed)
-              puts message
-            else
-              event.channel.send_message(message)
-              puts message
-            end
-          end
-        end
+      servers_with_players = qstat_requests.reject do |server|
+        server.is_empty?
       end
+
+      if servers_with_players.empty?
+        message = "All ##{event.channel.name} servers are empty"
+        event.channel.send_message(message)
+        return puts message
+      end
+
+      servers_with_players.each do |server|
+        event.channel.send_embed(nil, server.to_full_embed)
+      end
+
       return nil
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: qwtf_discord_bot
 version: !ruby/object:Gem::Version
-  version: 6.0.3
+  version: 6.1.3
 platform: ruby
 authors:
 - Sheldon Johnson
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-05-16 00:00:00.000000000 Z
+date: 2021-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: discordrb