qwtf_discord_bot 5.1.1 → 5.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 15afdd84de10528d7020797cbf211448eefa0ae8b6b7e13e9cab2e9bccdbc957
-  data.tar.gz: 324e5b52860aec148206e4408b4dbc0dd56b4b7a3c1dbfc36e960ef469a6ea79
+  metadata.gz: be9d7e86ba5a7b1a38b2ad8f12d34295a3882e871d535f01c1d8fb1ada700129
+  data.tar.gz: 1fad670f56fe547f42b5f6b4a14e0769a8195080125536c64b480d29f6bf4f48
 SHA512:
-  metadata.gz: 1952f502bbcc26942fe362749e2f6f3640fa7c5b0b87d80a4d4d7abe179ad629c7b6fa366ad4f878c9b9e5ae4e1833bbce1a7675b09796f94ab51463649771fd
-  data.tar.gz: 11dd44583e6a5cada8ceb31b89d9305016fc7ee12f8d3cf2aaba3781fa07f427de19014694c23c794faff6c8e589d8984a171d4b328abcf0828a68162c73592e
+  metadata.gz: 8e6e67d9588c6806545133f3d37c473445b594c515d9621fdd2c6b95bad20e21af356756c949cff72445533611a2205b67989f8b58ae6b61da40a2dac20a7454
+  data.tar.gz: c7a8dcbeadf3074650526f3c8849db414dd6690699412182e9970fbdc893f2fb13be9f1997487af5329b785d548d7e4e93f9175d31f24ed7092e2b27ab531e0b

data/README.md

@@ -89,8 +89,9 @@ This responds to discord messages:
   - `!join`
   - `!leave`
   - `!status`
+  - `!kick <@player>`
   - `!maxplayers <no_of_players>`
-  - `!notify <roles>`
+  - `!notify <@role @role2>`
   - `!end`
 
 

data/VERSION

@@ -1 +1 @@
-5.1.1
+5.1.6

data/lib/event_decorator.rb

@@ -11,8 +11,8 @@ class EventDecorator
     @event.channel.id
   end
 
-  def username
-    user.username
+  def display_name
+    user.display_name
   end
 
   def user_id
@@ -27,8 +27,12 @@ class EventDecorator
     find_users(user_ids).map(&:mention)
   end
 
-  def usernames_for(user_ids)
-    find_users(user_ids).map(&:username)
+  def display_names_for(user_ids)
+    find_users(user_ids).map(&:display_name)
+  end
+
+  def display_name_for(user_id)
+    find_user(user_id).display_name
   end
 
   private

data/lib/qwtf_discord_bot/qwtf_discord_bot_pug.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'pug'
 require 'event_decorator'
 
-class QwtfDiscordBotPug
+class QwtfDiscordBotPug # :nodoc:
   include QwtfDiscordBot
 
   FOUR_HOURS = 4 * 60 * 60
@@ -14,121 +16,160 @@ class QwtfDiscordBotPug
       prefix: '!'
     )
 
-    bot.command :join do |event, *_args|
-      e = EventDecorator.new(event)
-      pug = Pug.for(e.channel_id)
-
-      pug.join(e.user_id)
-
-      message = if pug.full?
-                  time_to_play_message(
-                    pug.player_slots,
-                    e.mentions_for(pug.joined_players)
-                  )
-                elsif pug.joined_player_count == 1
-                  [
-                    "#{e.username} creates a PUG",
-                    pug.player_slots,
-                    pug.notify_roles
-                  ].join(' | ')
-                elsif pug.slots_left <= 3
-                  [
-                    "#{e.username} joins the PUG",
-                    pug.player_slots,
-                    "#{pug.slots_left} more",
-                    pug.notify_roles
-                  ].join(' | ')
-                else
-                  [
-                    "#{e.username} joins the PUG",
-                    pug.player_slots
-                  ].join(' | ')
-                end
-
-      send_and_log_message(message, e.channel)
+    bot.command :join do |event, *args|
+      set_pug(event) do |e, pug|
+        if pug.joined_players.include?(e.user_id)
+          message = "You've already joined"
+          send_and_log_message(message, e.channel)
+        else
+          pug.join(e.user_id)
+
+          message = if pug.joined_player_count == 1
+                      [
+                        "#{e.display_name} creates a PUG",
+                        pug.player_slots,
+                        pug.notify_roles
+                      ].join(' | ')
+                    elsif pug.slots_left.between?(1,3)
+                      [
+                        "#{e.display_name} joins the PUG",
+                        pug.player_slots,
+                        "#{pug.slots_left} more",
+                        pug.notify_roles
+                      ].join(' | ')
+                    else
+                      [
+                        "#{e.display_name} joins the PUG",
+                        pug.player_slots
+                      ].join(' | ')
+                    end
+
+          send_and_log_message(message, e.channel)
+
+          if pug.full?
+            message = start_pug(
+              pug.player_slots,
+              e.mentions_for(pug.joined_players)
+            )
+
+            send_and_log_message(message, e.channel)
+          end
+        end
+      end
     end
 
-    bot.command :status do |event, *_args|
-      e = EventDecorator.new(event)
-      pug = Pug.for(e.channel_id)
-
-      message = if pug.active?
-                  [
-                    "#{e.usernames_for(pug.joined_players).join(', ')} joined",
-                    pug.player_slots
-                  ].join(' | ')
-                else
-                  'No PUG has been started. `!join` to create'
-                end
+    bot.command :status do |event, *args|
+      set_pug(event) do |e, pug|
+        message = if pug.active?
+                    [
+                      "#{e.display_names_for(pug.joined_players).join(', ')} joined",
+                      pug.player_slots
+                    ].join(' | ')
+                  else
+                    'No PUG has been started. `!join` to create'
+                  end
 
-      send_and_log_message(message, e.channel)
+        send_and_log_message(message, e.channel)
+      end
     end
 
     bot.command :maxplayers do |event, *args|
-      e = EventDecorator.new(event)
-      pug = Pug.for(e.channel_id)
-      new_maxplayers = args[0]
+      set_pug(event) do |e, pug|
+        new_maxplayers = args[0]
 
-      message = if new_maxplayers
-                  pug.maxplayers = new_maxplayers
-                  "Max number of players set to #{pug.maxplayers} | #{pug.player_slots} joined"
-                else
-                  "Current max number of players is #{pug.maxplayers} | #{pug.player_slots} joined"
-                end
+        message = if new_maxplayers
+                    pug.maxplayers = new_maxplayers
+                    "Max number of players set to #{pug.maxplayers} | #{pug.player_slots} joined"
+                  else
+                    "Current max number of players is #{pug.maxplayers} | #{pug.player_slots} joined"
+                  end
 
-      send_and_log_message(message, e.channel)
+        send_and_log_message(message, e.channel)
 
-      if pug.full?
-        message = time_to_play_message(
-          pug.player_slots,
-          e.mentions_for(pug.joined_players)
-        )
+        if pug.full?
+          message = start_pug(
+            pug.player_slots,
+            e.mentions_for(pug.joined_players)
+          )
 
-        send_and_log_message(message, e.channel)
+          send_and_log_message(message, e.channel)
+        end
       end
     end
 
-    bot.command :leave do |event, *_args|
-      e = EventDecorator.new(event)
-      pug = Pug.for(e.channel_id)
-
-      pug.leave(e.user_id)
-
-      message = "#{e.username} leaves the PUG | #{pug.player_slots} remain"
+    bot.command :leave do |event, *args|
+      set_pug(event) do |e, pug|
+        if !pug.active?
+          message = "There's no active PUG to leave"
+          send_and_log_message(message, e.channel)
+        elsif !pug.joined_players.include?(e.user_id)
+          message = "You're not in the PUG"
+          send_and_log_message(message, e.channel)
+        else
+          pug.leave(e.user_id)
+          message = "#{e.display_name} leaves the PUG | #{pug.player_slots} remain"
+          send_and_log_message(message, e.channel)
+
+          if pug.empty?
+            message = end_pug(pug)
+            send_and_log_message(message, e.channel)
+          end
+        end
+      end
+    end
 
-      send_and_log_message(message, e.channel)
+    bot.command :kick do |event, *args|
+      set_pug(event) do |e, pug|
+        if !pug.active?
+          message = "There's no active PUG"
+          return send_and_log_message(message, e.channel)
+        end
+
+        mention = args[0]
+        user_id = mention[3..-2].to_i
+        display_name = e.display_name_for(user_id)
+
+        if !pug.joined_players.include?(user_id)
+          message = "#{display_name} isn't in the PUG"
+          send_and_log_message(message, e.channel)
+        else
+          pug.leave(user_id)
+          message = "#{display_name} is kicked from the PUG | #{pug.player_slots} remain"
+          send_and_log_message(message, e.channel)
+
+          if pug.empty?
+            message = end_pug(pug)
+            send_and_log_message(message, e.channel)
+          end
+        end
+      end
+    end
 
-      if pug.empty?
-        pug.end_pug
+    bot.command :end do |event, *args|
+      set_pug(event) do |e, pug|
+        message = if !pug.active?
+                    "There's no active PUG to end"
+                  else
+                    end_pug(pug)
+                  end
 
-        message = 'PUG ended'
         send_and_log_message(message, e.channel)
       end
     end
 
-    bot.command :end do |event, *_args|
-      e = EventDecorator.new(event)
-      pug = Pug.for(e.channel_id)
-
-      pug.end_pug
+    bot.command :notify do |event, *args|
+      set_pug(event) do |e, pug|
+        roles = args.join(' ')
+        pug.notify_roles = roles
 
-      message = 'PUG ended'
-      send_and_log_message(message, e.channel)
-    end
+        message = if roles.empty?
+                    'Notification removed'
+                  else
+                    "Notification role set to #{roles}"
+                  end
 
-    bot.command :notify do |event, *args|
-      e = EventDecorator.new(event)
-      pug = Pug.for(e.channel_id)
-      roles = args.join(' ')
-      pug.notify_roles = roles
-
-      message = if roles.empty?
-                  'Notification removed'
-                else
-                  "Notification role set to #{roles}"
-                end
-
-      send_and_log_message(message, e.channel)
+        send_and_log_message(message, e.channel)
+      end
     end
 
     bot.run
@@ -136,12 +177,26 @@ class QwtfDiscordBotPug
 
   private
 
-  def time_to_play_message(player_slots, mentions)
-    ['Time to play!', player_slots, mentions.join(' ')].join(' | ')
+  def set_pug(event)
+    e = EventDecorator.new(event)
+    pug = Pug.for(e.channel_id)
+    yield(e, pug)
+  end
+
+  def start_pug(player_slots, mentions)
+    [
+      'Time to play!',
+      player_slots,
+      mentions.join(' ')
+    ].join(' | ')
+  end
+
+  def end_pug(pug)
+    pug.end_pug
+    'PUG ended'
   end
 
   def send_and_log_message(message, channel)
-    channel.send_message(message)
-    puts message
+    channel.send_message(message) && puts(message)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: qwtf_discord_bot
 version: !ruby/object:Gem::Version
-  version: 5.1.1
+  version: 5.1.6
 platform: ruby
 authors:
 - Sheldon Johnson
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-08-24 00:00:00.000000000 Z
+date: 2020-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: discordrb