quovo 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b2b6eac7fb141cc4c7dc62499f707640d17e4320
-  data.tar.gz: c7107b3bb7f5f892c1f4c8e75965a4d4a5c27e83
+  metadata.gz: 398cce62ff51e5d66813740023fe251d1c5facdc
+  data.tar.gz: e129102cd9c3df882b2a586716a0ad8ecb559514
 SHA512:
-  metadata.gz: f8b1ce1b75ad54337024a86c272853296b6d465f2a84667b6b370529a21090a20a7f4e5e95a6298e9ed0988e072be88207e4b727f780a112f3a7186dfa8fc7c7
-  data.tar.gz: 3c222fa0a62b9b51399ee562b43cbb323ed0a1887d697e8cb1c4500753571c9a5141e73705e1dbb932edeaf894ef3d1a74d51f0f9c450e76aaca8aa626ffa8e1
+  metadata.gz: 839329cd6df5ed129db2c97afb94b8771155a45bf11a993117d4181cab20c09f5697bb8135770db629f0a926e5a6c7a2b683fc3273848068bb4227a2f0c8dbba
+  data.tar.gz: 000b8cab076fd0ae5b988471b2246868845eaf3520f8aff402eec8177464fbc6190be876613dc74641377802c90de763ad9654613e179b9a63274b1de2cc3388

data/CHANGELOG.md

@@ -0,0 +1,8 @@
+### v1.0.3
+[FIX] Pass params to url for api GET requests.
+
+### v1.0.2
+[FIX] Do not process body (convert to json) if HTTP status is bad.
+
+### v1.0.1
+[FEATURE] First release includes bindings for users, brokerages, accounts, challenges, portfolios, positions and history apis.

data/lib/quovo/request.rb

@@ -5,7 +5,8 @@ module Quovo
     def request(method, path, params = {}, format = :plain, config = Quovo.config)
       return fake_request(method, path, params, &Proc.new) if Quovo.fake?
 
-      request = build_http_request(config.endpoint, method, path, params)
+      uri = build_uri(config.endpoint, method, path, params)
+      request = build_http_request(uri, method, params)
 
       yield(request) if block_given?
 
@@ -24,21 +25,15 @@ module Quovo
 
     protected
 
-    def build_http_request(endpoint, method, path, params)
-      request = case method
-                when :get
-                  Net::HTTP::Get
-                when :post
-                  Net::HTTP::Post
-                when :put
-                  Net::HTTP::Put
-                when :delete
-                  Net::HTTP::Delete
-                else
-                  raise Quovo::HttpError, 'unsupported method'
-                end.new(URI(endpoint + path))
-
-      inject_http_params(request, method, params) if params.any?
+    def build_uri(endpoint, method, path, params)
+      get_params = '?' + URI.encode_www_form(params) if method == :get && params.any?
+      URI(endpoint + path + (get_params || ''))
+    end
+
+    def build_http_request(uri, method, params)
+      raise Quovo::HttpError, 'unsupported method' unless [:get, :post, :put, :delete].include?(method)
+      request = Kernel.const_get("Net::HTTP::#{method.to_s.capitalize}").new(uri)
+      inject_http_params(request, params) if method != :get && params.any?
       request
     end
 
@@ -55,21 +50,17 @@ module Quovo
       http.verify_mode  = OpenSSL::SSL::VERIFY_NONE
 
       http.start do |transport|
-        (status_code, payload), elapsed = with_timing { parse_response(transport.request(request), format) }
+        (status_code, payload), elapsed = with_timing { parse_http_response(transport.request(request), format) }
         yield(status_code, payload, elapsed)
       end
     end
 
-    def inject_http_params(request, method, params)
-      if method == :get
-        request.uri.query = URI.encode_www_form(params)
-      else
-        request.body = params.to_json
-        request['Content-Type'] = 'application/json'
-      end
+    def inject_http_params(request, params)
+      request.body = params.to_json
+      request['Content-Type'] = 'application/json'
     end
 
-    def parse_response(response, format)
+    def parse_http_response(response, format)
       status_code = response.code
       body        = response.body
       raise Quovo::NotFoundError,  body if status_code =~ /404/

data/lib/quovo/version.rb

@@ -1,3 +1,3 @@
 module Quovo
-  VERSION = '1.0.2'.freeze
+  VERSION = '1.0.3'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quovo
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Alex Gorkunov
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-04 00:00:00.000000000 Z
+date: 2016-07-07 00:00:00.000000000 Z
 dependencies: []
 description: Quovo RESTful API client, configurable, thread-safe and well-tested
 email:
@@ -19,6 +19,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md