quke 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1bb1e5484a903fbc8b00b9d67b3eabc25a2abf6e
-  data.tar.gz: 6d19bda0cc6cd6837a10518e62afb43378f7d6f5
+  metadata.gz: dd7aa28081edfc9cce4400842782f1c8e853a1b7
+  data.tar.gz: d99e4eacf100a69a276323a80617c15d8534fdb7
 SHA512:
-  metadata.gz: 3a00d9f8f551ff3457facfd76de6c95e0c99e114ecd54ea5ff5d405d1b52b7022709ca522a65de7a9a8653277058af329d231039465377ed80f8f26090465674
-  data.tar.gz: 428e1141fa40375500a329a665afc474fb43ad261060b53f02b6a039d23e3401b88a27e0e6f75988fb6ec65165b136aa3d206092a7b9f2e9751babaaf6be785f
+  metadata.gz: cea424d7ee59455d0496808b0b7c6e442984f37db9c834b8c06e75d24c11b6d1414a007fa83a1f988c7e3f1c5c395a880d102912c14b64140ca209f395819ece
+  data.tar.gz: 3d41f20f1c49d414f44f0bd573b8540bcfae9bdecfd4dc1e974cad8d6751f75569e075a52799df4045e13072deb1cf249a12d1c3ab19cb8de0b23b7b3c3a26d6

data/.config.example.yml

@@ -39,6 +39,15 @@ max_wait_time: 5
 # you have is not supported by the site.
 user_agent: "Mozilla/5.0 (MSIE 10.0; Windows NT 6.1; Trident/5.0)"
 
+# Currently only supported when using the phantomjs driver (ignored by the
+# others). In phantomjs if a site has a javascript error we can configure it
+# to throw an error which will cause the test to fail. Quke by default sets this
+# to true, however you can override it by setting this flag to false.
+# For example you may be dealing with a legacy site and JavaScript errors
+# are out of your scope. You still want to test other aspects of the site
+# but not let these errors prevent you from using phantomjs.
+javascript_errors: false
+
 # Anything you place under the 'custom' node in the `.config.yml` file will be
 # available within your steps and page objects by calling
 # `Quke::Quke.config.custom`. So using the example below we could access its

data/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Change Log
 
+## [Unreleased](https://github.com/DEFRA/quke/tree/HEAD)
+
+[Full Changelog](https://github.com/DEFRA/quke/compare/v0.3.1...HEAD)
+
+**Merged pull requests:**
+
+- Update version number \(forgot during last change!\) [\#62](https://github.com/DEFRA/quke/pull/62) ([Cruikshanks](https://github.com/Cruikshanks))
+
+## [v0.3.1](https://github.com/DEFRA/quke/tree/v0.3.1) (2017-06-12)
+[Full Changelog](https://github.com/DEFRA/quke/compare/v0.3.0...v0.3.1)
+
+**Merged pull requests:**
+
+- Refactor some proxy logic to make code simpler [\#61](https://github.com/DEFRA/quke/pull/61) ([Cruikshanks](https://github.com/Cruikshanks))
+- Add ability to set user-agent to use [\#60](https://github.com/DEFRA/quke/pull/60) ([Cruikshanks](https://github.com/Cruikshanks))
+- \[ci skip\] Updating CHANGELOG.md [\#56](https://github.com/DEFRA/quke/pull/56) ([Cruikshanks](https://github.com/Cruikshanks))
+
 ## [v0.3.0](https://github.com/DEFRA/quke/tree/v0.3.0) (2017-03-07)
 [Full Changelog](https://github.com/DEFRA/quke/compare/v0.2.8...v0.3.0)
 

data/lib/quke/configuration.rb

@@ -116,6 +116,19 @@ module Quke #:nodoc:
       @data['user_agent']
     end
 
+    # Return the value set for +javascript_errors+.
+    #
+    # Currently only supported when using the phantomjs driver (ignored by the
+    # others). In phantomjs if a site has a javascript error we can configure it
+    # to throw an error which will cause the test to fail. Quke by default sets
+    # this to true, however you can override it by setting this flag to false.
+    # For example you may be dealing with a legacy site and JavaScript errors
+    # are out of your scope. You still want to test other aspects of the site
+    # but not let these errors prevent you from using phantomjs.
+    def javascript_errors
+      @data['javascript_errors']
+    end
+
     # Return the hash of +browserstack+ options.
     #
     # If you select the browserstack driver, there are a number of options you
@@ -170,14 +183,21 @@ module Quke #:nodoc:
     # rubocop:disable Metrics/PerceivedComplexity
     def default_data!(data)
       data.merge(
-        'features_folder' => (data['features'] || 'features').downcase.strip,
-        'app_host' =>        (data['app_host'] || '').downcase.strip,
-        'driver' =>          (data['driver'] || 'phantomjs').downcase.strip,
-        'pause' =>           (data['pause'] || '0').to_s.downcase.strip.to_i,
-        'stop_on_error' =>   (data['stop_on_error'] || 'false').to_s.downcase.strip,
-        'max_wait_time' =>   (data['max_wait_time'] || Capybara.default_max_wait_time).to_s.downcase.strip.to_i,
-        'user_agent' =>      (data['user_agent'] || '').strip,
-        'custom' =>          (data['custom'] || nil)
+        'features_folder' =>   (data['features'] || 'features').downcase.strip,
+        'app_host' =>          (data['app_host'] || '').downcase.strip,
+        'driver' =>            (data['driver'] || 'phantomjs').downcase.strip,
+        'pause' =>             (data['pause'] || '0').to_s.downcase.strip.to_i,
+        'stop_on_error' =>     (data['stop_on_error'] || 'false').to_s.downcase.strip,
+        'max_wait_time' =>     (data['max_wait_time'] || Capybara.default_max_wait_time).to_s.downcase.strip.to_i,
+        'user_agent' =>        (data['user_agent'] || '').strip,
+        # Because we want to default to 'true', but allow users to override it
+        # with 'false' it causes us to mess with the logic. Essentially if the
+        # user does enter false (either as a string or as a boolean) the result
+        # will be 'true', so we flip it back to 'false' with !.
+        # Else the condition fails and we get 'false', which when flipped gives
+        # us 'true', which is what we want the default value to be
+        'javascript_errors' => !(data['javascript_errors'].to_s.downcase.strip == 'false'),
+        'custom' =>            (data['custom'] || nil)
       )
     end
     # rubocop:enable Metrics/AbcSize

data/lib/quke/driver_configuration.rb

@@ -52,7 +52,7 @@ module Quke #:nodoc:
       # https://github.com/teampoltergeist/poltergeist#customization
       {
         # Javascript errors will get re-raised in our tests causing them to fail
-        js_errors: true,
+        js_errors: config.javascript_errors,
         # How long in seconds we'll wait for response when communicating with
         # Phantomjs
         timeout: 30,

data/lib/quke/version.rb

@@ -1,3 +1,3 @@
 module Quke #:nodoc:
-  VERSION = '0.3.1'.freeze
+  VERSION = '0.3.2'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quke
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Alan Cruikshanks