quicktravel_client 3.8.0 → 3.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f0ed55eb639dbe01ac2b6781edfccbc34b720ea04c6b8239830bf60b86406f5f
-  data.tar.gz: 776482e19be6a3df01a7e0f2670fda08d5a1a73d3e4fbc0429867126b2385c7b
+  metadata.gz: b571276490332c20a8f3590a5fd8db3b1829c4ee997abd52637f16fd60faf08f
+  data.tar.gz: a113d127a0b9e43284651a6c655d09f6580be932dc95f155abddaaf589a609e6
 SHA512:
-  metadata.gz: '098cd8f377681060a0656ac2759730d816d55b3a7e37484d0577d5644ada764566a32911909ead40a61a5f455d0a52690e4a9a29e5b551af44e4a954141a5cec'
-  data.tar.gz: 6efb0debce10413a072952301ba5c8fc3a2826ecd3e67a0d94550b0ff1671105e392f351e8485e29488cb6d56ad1a1be222cdcd6dc302ef887e3d9b57e8304d9
+  metadata.gz: 56e1275a4222457a5de43a9894680c5c9e949cb83fd9b160c4c4db3f5d40c008741dc6ed5ee75f4a613cbea5dd03dc169c83bf69e272cd9162c9cf62f32fbd72
+  data.tar.gz: 2889b499da18348ca09d8474434cefbb8d4cfd3ad5f1ae110aa1417bd1dc9b7c929564545b18f6fdbac14dd48c19ff990d19c18188edb3289b0d51626352b0a4

data/CHANGELOG.md

@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 This changelog adheres to [Keep a CHANGELOG](http://keepachangelog.com/).
 
+## [3.8.1]
+### Changed
+- [DC-3033] Reverse changes in checkout class to fix polipay redirection in EcomEngine
+
 ## [3.8.0]
 ### Added
 - [DC-1794] Update httparty to allow caching the whole response, also add namespace to cache key

data/lib/quick_travel/checkout.rb

@@ -47,7 +47,6 @@ module QuickTravel
     def self.attributes_for
       attrs = yield
       attrs[:completed] = attrs['progress'] == 'completed'
-      attrs[:completed] = attrs['successful'] if attrs['successful'].present?
       attrs[:successful] = attrs[:completed]
       attrs
     rescue AdapterError => e

data/lib/quick_travel/version.rb

@@ -1,3 +1,3 @@
 module QuickTravel
-  VERSION = '3.8.0'
+  VERSION = '3.8.1'
 end

data/spec/checkout_spec.rb

@@ -12,186 +12,4 @@ describe QuickTravel::Checkout do
     expect(token.keys).to eq [:client_token]
     expect(token[:client_token]).to match /^[0-9A-Za-z\=]+$/
   end
-
-  context 'Modern Opal Pay' do
-    context 'failed payment' do
-      let!(:booking) {
-        VCR.use_cassette('opal_modern_pay_failed_booking') do
-          QuickTravel.config.version = 4
-          QuickTravel::Booking.create
-        end
-      }
-      let(:create_payment_request) {
-        {
-          booking_id: booking.id,
-          payment: {
-            payment_type_id: 10,
-            amount_in_cents: 10,
-            uid: 'modern-opal-failed-uid',
-            comment: 'Test Opal Payment'
-          }
-        }
-      }
-
-      let!(:create_payment_response) {
-        VCR.use_cassette('opal_modern_pay_failed_create') do
-          QuickTravel::Checkout.create(create_payment_request)
-        end
-      }
-
-      let(:update_payment_request) {
-        {
-          gateway_response: {
-            raw_response: '{
-              "CardNumber": 3085227007682330,
-              "CardBalance": 6546,
-              "CardSequenceNumber": 55,
-              "CILAmount": 0,
-              "AuthorizedAmount": 890,
-              "SalesReferenceNumber": 53183943,
-              "TransactionDTM": "2018-01-04T09:00:43.106",
-              "VoidTransactionReferenceNumber": 1271099697,
-              "CardBlockState": false,
-              "AutoloadAmount": 0
-              }',
-            meta_data: {
-              applicationInstanceId: 101166,
-              operatorId: 'an_operator'
-            },
-            success: false
-          }
-        }
-      }
-
-      let(:update_payment_response) {
-        VCR.use_cassette('opal_modern_pay_failed_update') do
-          QuickTravel::Checkout.update(create_payment_response.id, update_payment_request)
-        end
-      }
-
-      let(:expected_create_attributes) { { completable: false } }
-      let(:expected_update_attributes) { { successful: false } }
-      it 'should update correctly' do
-        expect(create_payment_response).to have_attributes(expected_create_attributes)
-        expect(update_payment_response).to have_attributes(expected_update_attributes)
-      end
-    end
-
-    context 'successful payment' do
-      let!(:booking) {
-        VCR.use_cassette('opal_modern_pay_successful_booking') do
-          QuickTravel.config.version = 4
-          QuickTravel::Booking.create
-        end
-      }
-      let(:payment_create_request) {
-        {
-          booking_id: booking.id,
-          payment: {
-            payment_type_id: 10,
-            amount_in_cents: 10,
-            uid: 'modern-opal-uid',
-            comment: 'Test Opal Payment'
-          }
-        }
-      }
-
-      let!(:create_payment_response) {
-        VCR.use_cassette('opal_modern_pay_successful_response') do
-          QuickTravel::Checkout.create(payment_create_request)
-        end
-      }
-
-      let(:update_payment_request) {
-        {
-          gateway_response: {
-            raw_response: '{
-              "CardNumber": 3085227007682330,
-              "CardBalance": 6546,
-              "CardSequenceNumber": 55,
-              "CILAmount": 0,
-              "AuthorizedAmount": 890,
-              "SalesReferenceNumber": 53183943,
-              "TransactionDTM": "2018-01-04T09:00:43.106",
-              "TransactionReferenceNumber": 1271099697,
-              "CardBlockState": false,
-              "AutoloadAmount": 0
-              }',
-            meta_data: {
-              applicationInstanceId: 101166,
-              operatorId: 'an_operator'
-            },
-            success: true
-          }
-        }
-      }
-
-      let(:update_payment_response) {
-        VCR.use_cassette('opal_modern_pay_successful_update_response') do
-          QuickTravel::Checkout.update(create_payment_response.id, update_payment_request)
-        end
-      }
-
-      let(:expected_create_attributes) { { completable: false } }
-      let(:expected_update_attributes) { { successful: true } }
-      it 'should update correctly' do
-        expect(create_payment_response).to have_attributes(expected_create_attributes)
-        expect(update_payment_response).to have_attributes(expected_update_attributes)
-      end
-    end
-  end
-
-  context 'Opal Pay' do
-    let(:booking) {
-      VCR.use_cassette('opal_pay_booking') do
-        QuickTravel.config.version = 4
-        QuickTravel::Booking.create
-      end
-    }
-
-    let(:payment_create_request) {
-      {
-        booking_id: booking.id,
-        payment: {
-          gateway_response: '{
-            "CardNumber": 3085227007682330,
-            "CardBalance": 6546,
-            "CardSequenceNumber": 55,
-            "CILAmount": 0,
-            "AuthorizedAmount": 890,
-            "SalesReferenceNumber": 53183943,
-            "TransactionDTM": "2018-01-04T09:00:43.106",
-            "TransactionReferenceNumber": 1271099697,
-            "CardBlockState": false,
-            "AutoloadAmount": 0
-            }',
-          meta_data: {
-            applicationInstanceId: 101166,
-            operatorId: 'an_operator'
-          },
-          payment_type_id: 10,
-          amount_in_cents: 10,
-          uid: 'opal-uid',
-          comment: 'Test Opal Payment'
-        }
-      }
-    }
-
-    subject(:response) {
-      VCR.use_cassette('opal_pay') do
-        QuickTravel::Checkout.create(payment_create_request)
-      end
-    }
-
-    let(:expected_attributes) {
-      {
-        completable: true,
-        completed: true,
-        progress: 'completed',
-        successful: true
-      }
-    }
-
-    it { is_expected.to have_attributes(expected_attributes) }
-  end
 end

data/spec/support/coverage_loader.rb

@@ -1,4 +1,4 @@
 require 'simplecov-rcov'
 require 'coveralls'
 require 'coverage/kit'
-Coverage::Kit.setup(minimum_coverage: 84.0)
+Coverage::Kit.setup(minimum_coverage: 83)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quicktravel_client
 version: !ruby/object:Gem::Version
-  version: 3.8.0
+  version: 3.8.1
 platform: ruby
 authors:
 - Michael Noack
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-11 00:00:00.000000000 Z
+date: 2020-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty