quicktravel_client 3.7.0 → 4.1.0

data/spec/adapter_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 require 'quick_travel/adapter'
 
 describe QuickTravel::Adapter do
-  let(:response) { double code: 200, parsed_response: parsed_response }
+  let(:response) { double code: 200, parsed_response: parsed_response, headers: {} }
   let(:parsed_response) { { test: true } }
 
   before do
@@ -26,8 +26,7 @@ describe QuickTravel::Adapter do
     let(:expected_body) {
       {
         test: true,
-        sub_hash: { id: 42 },
-        access_key: an_instance_of(String)
+        sub_hash: { id: 42 }
       }
     }
 
@@ -52,4 +51,36 @@ describe QuickTravel::Adapter do
       )
     end
   end
+
+  context 'when cache options present' do
+    subject(:all) do
+      QuickTravel::Adapter.call_and_validate(:get, 'some_path', {}, { cache_key: 'test_key', cache_options: { expires_in: 3.minutes } })
+    end
+    let(:api) { double }
+
+    before do
+      QuickTravel::Cache.cache_store.clear
+      stub_const('QuickTravel::Api', api)
+      allow(api).to receive(:call_and_validate) { [{id: 1}, {id: 2}] }
+      all
+    end
+
+    specify { expect(api).to have_received(:call_and_validate).once }
+
+    context 'when called again' do
+      before do
+        QuickTravel::Adapter.call_and_validate(:get, 'some_path', {}, { cache_key: 'test_key', cache_options: { expires_in: 3.minutes } })
+      end
+
+      specify { expect(api).to have_received(:call_and_validate).once } # not called again
+    end
+
+    context 'when called with different key' do
+      before do
+        QuickTravel::Adapter.call_and_validate(:get, 'some_path', {}, { cache_key: 'test_key1', cache_options: { expires_in: 3.minutes } })
+      end
+
+      specify { expect(api).to have_received(:call_and_validate).twice }
+    end
+  end
 end

data/spec/booking_spec.rb

@@ -207,3 +207,13 @@ describe QuickTravel::Booking, "when booking doesn't exist" do
     end
   end
 end
+
+describe QuickTravel::Booking, "#customer_comments" do
+  let(:booking) { QuickTravel::Booking.find(333536) }
+
+  it 'should return customer comments' do
+    VCR.use_cassette('booking_with_comments') do
+      expect(booking.customer_comments).to eq 'I hate this'
+    end
+  end
+end

data/spec/checkout_spec.rb

@@ -12,186 +12,4 @@ describe QuickTravel::Checkout do
     expect(token.keys).to eq [:client_token]
     expect(token[:client_token]).to match /^[0-9A-Za-z\=]+$/
   end
-
-  context 'Modern Opal Pay' do
-    context 'failed payment' do
-      let!(:booking) {
-        VCR.use_cassette('opal_modern_pay_failed_booking') do
-          QuickTravel.config.version = 4
-          QuickTravel::Booking.create
-        end
-      }
-      let(:create_payment_request) {
-        {
-          booking_id: booking.id,
-          payment: {
-            payment_type_id: 10,
-            amount_in_cents: 10,
-            uid: 'modern-opal-failed-uid',
-            comment: 'Test Opal Payment'
-          }
-        }
-      }
-
-      let!(:create_payment_response) {
-        VCR.use_cassette('opal_modern_pay_failed_create') do
-          QuickTravel::Checkout.create(create_payment_request)
-        end
-      }
-
-      let(:update_payment_request) {
-        {
-          gateway_response: {
-            raw_response: '{
-              "CardNumber": 3085227007682330,
-              "CardBalance": 6546,
-              "CardSequenceNumber": 55,
-              "CILAmount": 0,
-              "AuthorizedAmount": 890,
-              "SalesReferenceNumber": 53183943,
-              "TransactionDTM": "2018-01-04T09:00:43.106",
-              "VoidTransactionReferenceNumber": 1271099697,
-              "CardBlockState": false,
-              "AutoloadAmount": 0
-              }',
-            meta_data: {
-              applicationInstanceId: 101166,
-              operatorId: 'an_operator'
-            },
-            success: false
-          }
-        }
-      }
-
-      let(:update_payment_response) {
-        VCR.use_cassette('opal_modern_pay_failed_update') do
-          QuickTravel::Checkout.update(create_payment_response.id, update_payment_request)
-        end
-      }
-
-      let(:expected_create_attributes) { { completable: false } }
-      let(:expected_update_attributes) { { successful: false } }
-      it 'should update correctly' do
-        expect(create_payment_response).to have_attributes(expected_create_attributes)
-        expect(update_payment_response).to have_attributes(expected_update_attributes)
-      end
-    end
-
-    context 'successful payment' do
-      let!(:booking) {
-        VCR.use_cassette('opal_modern_pay_successful_booking') do
-          QuickTravel.config.version = 4
-          QuickTravel::Booking.create
-        end
-      }
-      let(:payment_create_request) {
-        {
-          booking_id: booking.id,
-          payment: {
-            payment_type_id: 10,
-            amount_in_cents: 10,
-            uid: 'modern-opal-uid',
-            comment: 'Test Opal Payment'
-          }
-        }
-      }
-
-      let!(:create_payment_response) {
-        VCR.use_cassette('opal_modern_pay_successful_response') do
-          QuickTravel::Checkout.create(payment_create_request)
-        end
-      }
-
-      let(:update_payment_request) {
-        {
-          gateway_response: {
-            raw_response: '{
-              "CardNumber": 3085227007682330,
-              "CardBalance": 6546,
-              "CardSequenceNumber": 55,
-              "CILAmount": 0,
-              "AuthorizedAmount": 890,
-              "SalesReferenceNumber": 53183943,
-              "TransactionDTM": "2018-01-04T09:00:43.106",
-              "TransactionReferenceNumber": 1271099697,
-              "CardBlockState": false,
-              "AutoloadAmount": 0
-              }',
-            meta_data: {
-              applicationInstanceId: 101166,
-              operatorId: 'an_operator'
-            },
-            success: true
-          }
-        }
-      }
-
-      let(:update_payment_response) {
-        VCR.use_cassette('opal_modern_pay_successful_update_response') do
-          QuickTravel::Checkout.update(create_payment_response.id, update_payment_request)
-        end
-      }
-
-      let(:expected_create_attributes) { { completable: false } }
-      let(:expected_update_attributes) { { successful: true } }
-      it 'should update correctly' do
-        expect(create_payment_response).to have_attributes(expected_create_attributes)
-        expect(update_payment_response).to have_attributes(expected_update_attributes)
-      end
-    end
-  end
-
-  context 'Opal Pay' do
-    let(:booking) {
-      VCR.use_cassette('opal_pay_booking') do
-        QuickTravel.config.version = 4
-        QuickTravel::Booking.create
-      end
-    }
-
-    let(:payment_create_request) {
-      {
-        booking_id: booking.id,
-        payment: {
-          gateway_response: '{
-            "CardNumber": 3085227007682330,
-            "CardBalance": 6546,
-            "CardSequenceNumber": 55,
-            "CILAmount": 0,
-            "AuthorizedAmount": 890,
-            "SalesReferenceNumber": 53183943,
-            "TransactionDTM": "2018-01-04T09:00:43.106",
-            "TransactionReferenceNumber": 1271099697,
-            "CardBlockState": false,
-            "AutoloadAmount": 0
-            }',
-          meta_data: {
-            applicationInstanceId: 101166,
-            operatorId: 'an_operator'
-          },
-          payment_type_id: 10,
-          amount_in_cents: 10,
-          uid: 'opal-uid',
-          comment: 'Test Opal Payment'
-        }
-      }
-    }
-
-    subject(:response) {
-      VCR.use_cassette('opal_pay') do
-        QuickTravel::Checkout.create(payment_create_request)
-      end
-    }
-
-    let(:expected_attributes) {
-      {
-        completable: true,
-        completed: true,
-        progress: 'completed',
-        successful: true
-      }
-    }
-
-    it { is_expected.to have_attributes(expected_attributes) }
-  end
 end

data/spec/clients_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'quick_travel/client'
+
+describe QuickTravel::Client do
+  context '#find' do
+    let(:templates) do
+      VCR.use_cassette('client_templates') do
+        QuickTravel::Client.find(2).templates
+      end
+    end
+    it 'should find the templates correctly' do
+      expect(templates['vehicle_templates']).to eq([
+        {
+          'id' => 1,
+          'length' => 5.0,
+          'height' => 1.5,
+          'width' => 1.8,
+          'weight' => 1000.0,
+          'details' => 'Holden Commodore',
+          'registration' => 'ABC123',
+          'cargo' => 'None',
+          'vehicle_type_id' => 1,
+          'party_id' => 9
+        }
+      ])
+      expect(templates['passenger_templates']).to eq([
+        {
+          'id' => 1,
+          'age' => 30,
+          'title' => 'Mr',
+          'first_name' => 'Homer',
+          'last_name' => 'Simpson',
+          'gender' => 'Male',
+          'passenger_type_id' => 1,
+          'party_id' => 9
+        }
+      ])
+    end
+  end
+end

data/spec/discounts_spec.rb

@@ -26,9 +26,9 @@ describe 'Booking price_changes' do
 
     specify { expect(price_change.target.type).to eq 'Booking' }
     specify { expect(price_change.target.id).to eq booking.id }
-    specify { expect(price_change.original_price).to eq 640.00 }
-    specify { expect(price_change.changed_price).to eq 380.00 }
-    specify { expect(price_change.price_change).to eq(-260.00) }
+    specify { expect(price_change.original_price).to eq 640.00.to_money }
+    specify { expect(price_change.changed_price).to eq 380.00.to_money }
+    specify { expect(price_change.price_change).to eq(-260.00.to_money) }
     specify do
       expect(price_change.reservation_price_changes.count).to(
         eq booking.reservations.count)
@@ -43,9 +43,9 @@ describe 'Booking price_changes' do
 
       specify { expect(price_change.target.type).to eq 'Reservation' }
       specify { expect(price_change.target.id).to eq reservation.id }
-      specify { expect(price_change.original_price).to eq 400.00 }
-      specify { expect(price_change.changed_price).to eq 200.00 }
-      specify { expect(price_change.price_change).to eq(-200) }
+      specify { expect(price_change.original_price).to eq 400.00.to_money }
+      specify { expect(price_change.changed_price).to eq 200.00.to_money }
+      specify { expect(price_change.price_change).to eq(-200.to_money) }
     end
 
     context 'the total price_change applied on the top level reservation' do
@@ -57,9 +57,9 @@ describe 'Booking price_changes' do
 
       specify { expect(price_change.target.type).to eq 'Reservation' }
       specify { expect(price_change.target.id).to eq reservation.id }
-      specify { expect(price_change.original_price).to eq 640.00 }
-      specify { expect(price_change.changed_price).to eq 380.00 }
-      specify { expect(price_change.price_change).to eq(-260.00) }
+      specify { expect(price_change.original_price).to eq 640.00.to_money }
+      specify { expect(price_change.changed_price).to eq 380.00.to_money }
+      specify { expect(price_change.price_change).to eq(-260.00.to_money) }
     end
 
     context 'the price_change applied on the first extra pick' do
@@ -71,9 +71,9 @@ describe 'Booking price_changes' do
 
       specify { expect(price_change.target.type).to eq 'Reservation' }
       specify { expect(price_change.target.id).to eq extra_pick_without_price_change.id }
-      specify { expect(price_change.original_price).to eq 120 }
-      specify { expect(price_change.changed_price).to eq 120 }
-      specify { expect(price_change.price_change).to eq 0 }
+      specify { expect(price_change.original_price).to eq 120.to_money }
+      specify { expect(price_change.changed_price).to eq 120.to_money }
+      specify { expect(price_change.price_change).to eq 0.to_money }
     end
 
     context 'the total price_change applied on the first extra pick' do
@@ -85,9 +85,9 @@ describe 'Booking price_changes' do
 
       specify { expect(price_change.target.type).to eq 'Reservation' }
       specify { expect(price_change.target.id).to eq extra_pick_without_price_change.id }
-      specify { expect(price_change.original_price).to eq 120 }
-      specify { expect(price_change.changed_price).to eq 120 }
-      specify { expect(price_change.price_change).to eq 0 }
+      specify { expect(price_change.original_price).to eq 120.to_money }
+      specify { expect(price_change.changed_price).to eq 120.to_money }
+      specify { expect(price_change.price_change).to eq 0.to_money }
     end
 
     context 'the price_change applied on second extra pick' do
@@ -99,9 +99,9 @@ describe 'Booking price_changes' do
 
       specify { expect(price_change.target.type).to eq 'Reservation' }
       specify { expect(price_change.target.id).to eq extra_pick_with_price_change.id }
-      specify { expect(price_change.original_price).to eq 120.00 }
-      specify { expect(price_change.changed_price).to eq 60.00 }
-      specify { expect(price_change.price_change).to eq(-60.00) }
+      specify { expect(price_change.original_price).to eq 120.00.to_money }
+      specify { expect(price_change.changed_price).to eq 60.00.to_money }
+      specify { expect(price_change.price_change).to eq(-60.00.to_money) }
     end
 
     context 'the total price_change applied on second extra pick' do
@@ -113,9 +113,9 @@ describe 'Booking price_changes' do
 
       specify { expect(price_change.target.type).to eq 'Reservation' }
       specify { expect(price_change.target.id).to eq extra_pick_with_price_change.id }
-      specify { expect(price_change.original_price).to eq 120.00 }
-      specify { expect(price_change.changed_price).to eq 60.00 }
-      specify { expect(price_change.price_change).to eq(-60.00) }
+      specify { expect(price_change.original_price).to eq 120.00.to_money }
+      specify { expect(price_change.changed_price).to eq 60.00.to_money }
+      specify { expect(price_change.price_change).to eq(-60.00.to_money) }
     end
   end
 end

data/spec/package_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+require 'quick_travel/package'
+
+describe QuickTravel::Package do
+  subject(:package) {
+    VCR.use_cassette('package_show') do
+      QuickTravel::Package.find(464)
+    end
+  }
+
+  its(:name) { should eq 'Swan Valley Gourmet Wine Cruise (SVGWC-0945)' }
+  its(:type) { should eq 'Package' }
+
+
+  context '#product_type' do
+    subject(:property_type) {
+      VCR.use_cassette 'package_show_product_type' do
+        package.product_type
+      end
+    }
+
+    its(:name) { should eq 'Rottnest Packages' }
+  end
+end

data/spec/passenger_type_spec.rb

@@ -39,7 +39,7 @@ describe QuickTravel::PassengerType do
 
     before do
       stub_const('QuickTravel::Api', api)
-      allow(api).to receive(:call_and_validate) { [{id: 1}, {id: 2}] }
+      allow(api).to receive(:call_and_validate) { double(parsed_response: [{id: 1}, {id: 2}], headers: {}) }
     end
     
     context 'when called the first time' do

data/spec/product_configuration_spec.rb

@@ -127,6 +127,17 @@ describe QuickTravel::ProductConfiguration do
       let(:pricing_details) { nil }
       it { is_expected.not_to be_priced }
     end
+
+    context 'when pricing details are omitted' do
+      let(:product) do
+        double(
+          extras: extras,
+          available?: available
+        )
+      end
+
+      it { is_expected.not_to be_priced }
+    end
   end
 
   context '#price' do

data/spec/reservation_spec.rb

@@ -48,3 +48,23 @@ describe QuickTravel::Reservation do
     expect(@reservation.gross_including_packaged_item).to be_an_instance_of Money
   end
 end
+
+describe QuickTravel::Reservation do
+  before(:each) do
+    VCR.use_cassette('reservation_with_extra_picks') do
+      @booking = QuickTravel::Booking.find(1)
+      @reservation = @booking.reservations.first
+    end
+  end
+
+  it 'should convert hash to objects' do
+    expect(@reservation.passenger_splits.first).to be_an_instance_of QuickTravel::PassengerSplit
+  end
+
+  let(:test_type) { double(name: 'test') }
+
+  it 'should not raise error in passenger count' do
+    allow(QuickTravel::PassengerType).to receive(:find).and_return(test_type)
+    expect{ @reservation.passengers_count(@booking) }.not_to raise_error
+  end
+end