quicktravel_client 3.1.0 → 3.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 21adb65a239a49ec7121e7c60c347d3599056a75
-  data.tar.gz: 5b5e26b87529048e7c6365756d6c50a345ff53dc
+  metadata.gz: 17de53c54db5f143fc8e6f38e0ddfcf1342970e1
+  data.tar.gz: 638fff7cb6f4adf684782d4f37d1ec2da2dbc563
 SHA512:
-  metadata.gz: 9772cb57121b8dc267c0d8d4d7c13036079f38dff857459865600c963cb72ac7f99456b01de3777a7c256ca7ef4fd1c2d913116dccdc7a5f1900810b81712c8d
-  data.tar.gz: 3c764251d247cb746a79099bbc019982aa6b9ec894e08a6ede5a598674356ab2edc318b868e90d68d32b4d0bb97d20fb01f2cfc7b87ddb4e2e5c48d1bb3eebb0
+  metadata.gz: e04a9695af61b229d37e9b3f9ce7d630f0c5ee7595dacbbb0a437ace9547a5dd53c8f409b54ca9c255c3f943529b0f69253b791e4fa60cf21b4775137a842b4f
+  data.tar.gz: d02ee5b83567d3e2c42ac982aa50f1777fddf0280acd21de2dfbf65db578d0a622d9c84c31e10d71bb419b7875a3ec6d8d8d07acc80d959e6000658c9f5d5b23

data/CHANGELOG.md

@@ -3,6 +3,9 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 This changelog adheres to [Keep a CHANGELOG](http://keepachangelog.com/).
 
+## [3.2.0]
+### Changed
+- Return status with QuickTravel::AdapterError
 
 ## [3.1.0]
 ### Added

data/lib/quick_travel/adapter_error.rb

@@ -1,17 +1,20 @@
 module QuickTravel
   class AdapterError < StandardError
     attr_reader :response
+    attr_reader :status
 
     def initialize(response)
-      @response = case response
-                  when String
-                    { 'error' => response }
-                  when HTTParty::Response
-                    response.parsed_response
-                  else
-                    fail "Unexpected response type #{response.class}"\
-                         "Should be String or HTTParty::Response"
-                  end
+      case response
+        when String
+          @response = { 'error' => response }
+          @status = 422
+        when HTTParty::Response
+          @response = response.parsed_response
+          @status = response.code
+        else
+          fail "Unexpected response type #{response.class}"\
+               "Should be String or HTTParty::Response"
+      end
 
       error_message = if @response.is_a? Hash
         @response.fetch('error', "We're sorry, but something went wrong. Please call us.")

data/lib/quick_travel/version.rb

@@ -1,3 +1,3 @@
 module QuickTravel
-  VERSION = '3.1.0'
+  VERSION = '3.2.0'
 end

data/spec/booking_spec.rb

@@ -186,3 +186,16 @@ describe QuickTravel::Booking, 'when changing state' do
     end
   end
 end
+
+describe QuickTravel::Booking, "when booking doesn't exist" do
+  let(:booking) { QuickTravel::Booking.find_by_reference('111111') }
+
+  it 'should raise an error' do
+    VCR.use_cassette('booking_non_existant') do
+      expect{ booking }.to raise_error(QuickTravel::AdapterError) { |exception|
+        expect(exception.status).to eq 404
+        expect(exception.response).to eq({'error' => "Booking not found. It may have been removed due to inactivity"})
+      }
+    end
+  end
+end

data/spec/support/cassettes/booking_non_existant.yml

@@ -0,0 +1,59 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://test.qt.sealink.com.au:8080/api/bookings/reference/111111.json
+    body:
+      encoding: UTF-8
+      string: access_key=<QT_KEY>
+    headers:
+      Content-Length:
+      - '0'
+  response:
+    status:
+      code: 404
+      message: 'Not Found '
+    headers:
+      P3p:
+      - CP="IDC DSP CAO COR ADM DEVi TAIi PSA PSD IVAi IVDi CONi HIS OUR IND CNT"
+      Content-Type:
+      - application/json; charset=utf-8
+      X-Ua-Compatible:
+      - IE=Edge,chrome=1
+      Cache-Control:
+      - no-cache
+      X-Request-Id:
+      - 620e301e261f4038453464856be47a9a
+      X-Runtime:
+      - '0.576024'
+      Vary:
+      - Origin
+      Date:
+      - Fri, 01 Jan 2016 02:32:07 GMT
+      X-Rack-Cache:
+      - miss
+      X-Content-Type-Options:
+      - nosniff
+      X-Download-Options:
+      - noopen
+      X-Frame-Options:
+      - sameorigin
+      X-Permitted-Cross-Domain-Policies:
+      - none
+      X-Xss-Protection:
+      - 1; mode=block
+      Server:
+      - WEBrick/1.3.1 (Ruby/2.2.5/2016-04-26)
+      Content-Length:
+      - '73'
+      Connection:
+      - Keep-Alive
+      Set-Cookie:
+      - _session_id=BAh7B0kiD3Nlc3Npb25faWQGOgZFVEkiJTRlNDQwYjQxYmYwODAyM2IwOTVhZWRmZmViZmM3MDFlBjsAVEkiCXVzZXIGOwBGaQY%3D--77cc7c8dff3a0d680d605543218ef1419ead29da;
+        path=/; HttpOnly
+    body:
+      encoding: UTF-8
+      string: '{"error":"Booking not found. It may have been removed due to inactivity"}'
+    http_version: 
+  recorded_at: Tue, 04 Jul 2017 07:39:13 GMT
+recorded_with: VCR 3.0.3

data/spec/support/coverage_loader.rb

@@ -1,4 +1,4 @@
 require 'simplecov-rcov'
 require 'coveralls'
 require 'coverage/kit'
-Coverage::Kit.setup(minimum_coverage: 82.10)
+Coverage::Kit.setup(minimum_coverage: 82.53)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quicktravel_client
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.2.0
 platform: ruby
 authors:
 - Michael Noack
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-22 00:00:00.000000000 Z
+date: 2017-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -371,6 +371,7 @@ files:
 - spec/support/cassettes/booking_cancel.yml
 - spec/support/cassettes/booking_create.yml
 - spec/support/cassettes/booking_documents.yml
+- spec/support/cassettes/booking_non_existant.yml
 - spec/support/cassettes/booking_price_changes.yml
 - spec/support/cassettes/booking_show.yml
 - spec/support/cassettes/booking_update.yml
@@ -460,6 +461,7 @@ test_files:
 - spec/support/cassettes/booking_cancel.yml
 - spec/support/cassettes/booking_create.yml
 - spec/support/cassettes/booking_documents.yml
+- spec/support/cassettes/booking_non_existant.yml
 - spec/support/cassettes/booking_price_changes.yml
 - spec/support/cassettes/booking_show.yml
 - spec/support/cassettes/booking_update.yml