quickbooks_web_connector 0.5.0 → 0.6.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 571ae04bbdd6cefeb9f277118239b06bf98dc292
+  data.tar.gz: 2a121acd4c1450fa7626b00c8fb4555a8d2c0af2
+SHA512:
+  metadata.gz: 26b37af64bafefbcf016367e66cd13b0db7aaf9192dff2d0b6e0ab70f48e30fe15c843c4fa2503c1cfbd2dc4a94cde2ae2b72c9d29a4022a36f424655c8f58b5
+  data.tar.gz: 5a5045052b55c5fd906afd4a9cb4b5db28d2e54c9351d5638560bc4f6a6490b139d05add8f4ad02b61c6ef8891cb723abaebc7b868d65dffdeeb9029151ba717

data/Rakefile

@@ -21,7 +21,7 @@ end
 task :default => 'spec:all'
 
 namespace :spec do
-  gemfiles = %w(rails_32 rails_40)
+  gemfiles = FileList['gemfiles/*.gemfile'].map { |f| File.basename(f, '.gemfile') }
 
   gemfiles.each do |gemfile|
     desc "Run tests against #{gemfile}"

data/app/controllers/quickbooks_web_connector/qwc_controller.rb

@@ -2,10 +2,16 @@ module QuickbooksWebConnector
   class QwcController < QuickbooksWebConnectorController
 
     def download
-      send_data render_to_string(:qwc),
-                disposition: 'attachment',
-                filename: 'qbwc.qwc',
-                type: :xml
+      @user = QuickbooksWebConnector.config.users[params[:username]]
+
+      if !@user
+        render nothing: true, status: :not_found
+      else
+        send_data render_to_string(:qwc),
+                  disposition: 'attachment',
+                  filename: "#{@user.username}.qwc",
+                  type: :xml
+      end
     end
 
   end

data/app/views/quickbooks_web_connector/qwc/qwc.xml.builder

@@ -1,12 +1,12 @@
 xml.instruct!
 xml.QBWCXML do
-  xml.AppName QuickbooksWebConnector.config.app_name
+  xml.AppName "#{QuickbooksWebConnector.config.app_name} (#{@user.username})"
   xml.AppID
   xml.AppURL quickbooks_web_connector.soap_url
   xml.AppDescription QuickbooksWebConnector.config.app_description
   xml.AppSupport main_app.root_url
-  xml.UserName QuickbooksWebConnector.config.username
-  xml.OwnerID '{d69682e6-4436-44bc-bd19-d6bfbd11778d}'
-  xml.FileID '{916222f3-c574-4c70-8c9d-e3cec2634e49}'
+  xml.UserName @user.username
+  xml.OwnerID "{#{@user.owner_id}}"
+  xml.FileID "{#{@user.file_id}}"
   xml.QBType 'QBFS'
 end

data/config/routes.rb

@@ -1,6 +1,6 @@
 QuickbooksWebConnector::Engine.routes.draw do
 
-  get 'qwc' => 'qwc#download', defaults: { format: :xml }
+  get 'qwc/:username' => 'qwc#download', as: :qwc, defaults: { format: :xml }
   post 'soap' => 'soap#endpoint'
 
   # QWC will perform a GET request to verify the SSL certificate

data/lib/quickbooks_web_connector.rb

@@ -6,6 +6,7 @@ require 'quickbooks_web_connector/config'
 require 'quickbooks_web_connector/failure'
 require 'quickbooks_web_connector/job'
 require 'quickbooks_web_connector/json_coder'
+require 'quickbooks_web_connector/user'
 
 require 'quickbooks_web_connector/soap_wrapper/default'
 require 'quickbooks_web_connector/soap_wrapper/defaultMappingRegistry'

data/lib/quickbooks_web_connector/config.rb

@@ -14,32 +14,49 @@ module QuickbooksWebConnector
     @config
   end
 
+  def self.reset_configuration!
+    @config = QuickbooksWebConnector::Configuration.new
+    set_default_configuration
+  end
+
+  def self.set_default_configuration
+    configure do |config|
+      config.server_version = '1.0.0'
+      config.minimum_web_connector_client_version = nil
+
+      config.parent_controller = 'ApplicationController'
+
+      config.app_name = 'My QBWC App'
+      config.app_description = 'My QBWC App Description'
+    end
+  end
+
   class Configuration
     include ActiveSupport::Configurable
 
     config_accessor :server_version
     config_accessor :minimum_web_connector_client_version
-    config_accessor :username
-    config_accessor :password
-    config_accessor :company_file_path
 
     config_accessor :parent_controller
 
     config_accessor :app_name
     config_accessor :app_description
-  end
 
-  configure do |config|
-    config.server_version = '1.0.0'
-    config.minimum_web_connector_client_version = nil
-    config.username = 'web_connector'
-    config.password = 'secret'
-    config.company_file_path = ''
+    def initialize
+      config.users = {}
+    end
 
-    config.parent_controller = 'ApplicationController'
+    def users
+      config.users
+    end
 
-    config.app_name = 'My QBWC App'
-    config.app_description = 'My QBWC App Description'
+    def user(username, *args)
+      username = username.to_s
+
+      config.users[username] = User.new(username, *args)
+    end
   end
 
+  set_default_configuration
+
 end

data/lib/quickbooks_web_connector/soap_wrapper/defaultServant.rb

@@ -45,12 +45,15 @@ module QuickbooksWebConnector
       #
       def authenticate(parameters)
         token = SecureRandom.uuid
-        result = if parameters.strUserName == QuickbooksWebConnector.config.username && parameters.strPassword == QuickbooksWebConnector.config.password
+
+        user = QuickbooksWebConnector.config.users[parameters.strUserName]
+
+        result = if user && user.valid_password?(parameters.strPassword)
           if QuickbooksWebConnector.size > 0
             # Store how many jobs are queued so we can track progress later
             QuickbooksWebConnector.store_job_count_for_session
 
-            QuickbooksWebConnector.config.company_file_path
+            user.company_file_path
           else
             'none'
           end

data/lib/quickbooks_web_connector/user.rb

@@ -0,0 +1,24 @@
+module QuickbooksWebConnector
+  class User
+
+    attr_reader :username, :company_file_path, :owner_id, :file_id
+
+    def initialize(username, password, company_file_path, owner_id = nil, file_id = nil)
+      @username = username
+      @password = password
+      @company_file_path = company_file_path
+
+      @owner_id = owner_id || 'd69682e6-4436-44bc-bd19-d6bfbd11778d'
+      @file_id = file_id || '916222f3-c574-4c70-8c9d-e3cec2634e49'
+    end
+
+    def valid_password?(provided_password)
+      provided_password == password
+    end
+
+    private
+
+    attr_reader :password
+
+  end
+end

data/lib/quickbooks_web_connector/version.rb

@@ -1,3 +1,3 @@
 module QuickbooksWebConnector
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 end

data/spec/config/config_spec.rb

@@ -1,131 +1,78 @@
 require 'spec_helper'
 
 describe QuickbooksWebConnector::Configuration do
-  subject { QuickbooksWebConnector.config }
+  subject(:configuration) { QuickbooksWebConnector.config }
 
   describe 'server_version' do
-
-    context 'by default' do
-      its(:server_version) { should eq '1.0.0' }
+    it 'returns 1.0.0 by default' do
+      expect(configuration.server_version).to eq('1.0.0')
     end
 
-    context 'configured via config block' do
-      before { QuickbooksWebConnector.configure { |c| c.server_version = '1.2.3' } }
-
-      its(:server_version) { should eq '1.2.3' }
+    it 'allows the server_version to be configured' do
+      QuickbooksWebConnector.config.server_version = '1.2.3'
 
-      after { QuickbooksWebConnector.configure { |c| c.server_version = '1.0.0' } }
+      expect(configuration.server_version).to eq('1.2.3')
     end
-
   end
 
   describe 'minimum_web_connector_client_version' do
-
-    context 'by default' do
-      its(:minimum_web_connector_client_version) { should be_nil }
+    it 'sets no minimum by default' do
+      expect(configuration.minimum_web_connector_client_version).to be_nil
     end
 
-    context 'configured via config block' do
-      before { QuickbooksWebConnector.configure { |c| c.minimum_web_connector_client_version = '2.1.0.30' } }
-
-      its(:minimum_web_connector_client_version) { should eq '2.1.0.30' }
+    it 'allows the minimum_web_connector_client_version to be configured' do
+      QuickbooksWebConnector.config.minimum_web_connector_client_version = '2.1.0.30'
 
-      after { QuickbooksWebConnector.configure { |c| c.minimum_web_connector_client_version = nil } }
+      expect(configuration.minimum_web_connector_client_version).to eq('2.1.0.30')
     end
-
   end
 
-  context 'username' do
-
-    context 'by default' do
-      its(:username) { should eq 'web_connector' }
+  describe 'user' do
+    it 'defaults to no users' do
+      expect(configuration.users).to be_empty
     end
 
-    context 'configured via a config block' do
-      before { QuickbooksWebConnector.configure { |c| c.username = 'jsmith' } }
+    it 'adds a new user' do
+      configuration.user 'jane', 'secret', '/path/to/company.qbw'
 
-      its(:username) { should eq 'jsmith' }
-
-      after { QuickbooksWebConnector.configure { |c| c.username = 'web_connector' } }
-    end
-  end
-
-  context 'password' do
-
-    context 'by default' do
-      its(:password) { should eq 'secret' }
-    end
-
-    context 'configured via a config block' do
-      before { QuickbooksWebConnector.configure { |c| c.password = 'quickbooks' } }
-
-      its(:password) { should eq 'quickbooks' }
-
-      after { QuickbooksWebConnector.configure { |c| c.password = 'secret' } }
-    end
-  end
-
-  context 'company_file_path' do
-
-    context 'by default' do
-      its(:company_file_path) { should eq '' }
-    end
-
-    context 'configured via a config block' do
-      before { QuickbooksWebConnector.configure { |c| c.company_file_path = '/path/to/company.qbw' } }
-
-      its(:company_file_path) { should eq '/path/to/company.qbw' }
-
-      after { QuickbooksWebConnector.configure { |c| c.company_file_path = '' } }
+      expect(configuration.users.size).to eq(1)
     end
   end
 
   describe 'parent_controller' do
-
-    context 'by default' do
-      its(:parent_controller) { should eq 'ApplicationController' }
+    it 'uses ApplicationController by default' do
+      expect(configuration.parent_controller).to eq('ApplicationController')
     end
 
-    context 'configured via config block' do
-      before { QuickbooksWebConnector.configure { |c| c.parent_controller = 'MyController' } }
+    it 'allows the parent_controller to be configured' do
+      QuickbooksWebConnector.config.parent_controller = 'MyController'
 
-      its(:parent_controller) { should eq 'MyController' }
-
-      after { QuickbooksWebConnector.configure { |c| c.parent_controller = 'ApplicationController' } }
+      expect(configuration.parent_controller).to eq('MyController')
     end
-
   end
 
   describe 'app_name' do
-
-    context 'by default' do
-      its(:app_name) { should eq 'My QBWC App' }
+    it 'uses My QBWC App by default' do
+      expect(configuration.app_name).to eq('My QBWC App')
     end
 
-    context 'configured via a config block' do
-      before { QuickbooksWebConnector.configure { |c| c.app_name = 'Sample App' } }
-
-      its(:app_name) { should eq 'Sample App' }
+    it 'allows the app_name to be configured' do
+      QuickbooksWebConnector.config.app_name = 'Sample App'
 
-      after { QuickbooksWebConnector.configure { |c| c.app_name = 'My QBWC App' } }
+      expect(configuration.app_name).to eq('Sample App')
     end
-
   end
 
   describe 'app_description' do
-
-    context 'by default' do
-      its(:app_description) { should eq 'My QBWC App Description' }
+    it 'sets a default description' do
+      expect(configuration.app_description).to eq('My QBWC App Description')
     end
 
-    context 'configured via a config block' do
-      before { QuickbooksWebConnector.configure { |c| c.app_description = 'Sample Description' } }
+    it 'allows the app_description to be configured' do
+      QuickbooksWebConnector.config.app_description = 'Sample Description'
 
-      its(:app_description) { should eq 'Sample Description' }
-
-      after { QuickbooksWebConnector.configure { |c| c.app_description = 'My QBWC App Description' } }
+      expect(configuration.app_description).to eq('Sample Description')
     end
-
   end
 
 end

data/spec/controllers/quickbooks_web_connector/qwc_controller_spec.rb

@@ -1,28 +1,26 @@
 require 'spec_helper'
 
-describe QuickbooksWebConnector::QwcController do
+RSpec.describe QuickbooksWebConnector::QwcController, type: :controller do
 
   describe 'GET :download' do
-    before { get :download, format: :xml, use_route: 'quickbooks_web_connector' }
+    it 'renders the QWC file' do
+      QuickbooksWebConnector.config.user 'jane', 'password', '/path/to/company.qbw'
 
-    it 'responds with success' do
-      expect(response).to be_success
-    end
+      get :download, username: 'jane', format: :xml, use_route: 'quickbooks_web_connector'
 
-    it 'responds as XML' do
+      expect(response).to be_success
       expect(response.header['Content-Type']).to match(/application\/xml/)
-    end
-
-    it 'sends the file as an attachment' do
       expect(response.header['Content-Disposition']).to match(/attachment/)
+      expect(response.header['Content-Disposition']).to match(/jane\.qwc/)
+      expect(response).to render_template(:qwc)
+      expect(assigns(:user).username).to eq('jane')
     end
 
-    it 'names the file' do
-      expect(response.header['Content-Disposition']).to match(/qbwc\.qwc/)
-    end
+    it 'returns a 404 when no user matches the given username' do
+      get :download, username: 'jane', format: :xml, use_route: 'quickbooks_web_connector'
 
-    it 'renders the qwc template' do
-      assert_template :qwc
+      expect(response.code).to eq('404')
+      expect(response).to_not render_template(:qwc)
     end
   end
 

data/spec/controllers/quickbooks_web_connector/soap_controller_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe QuickbooksWebConnector::SoapController do
+RSpec.describe QuickbooksWebConnector::SoapController, type: :controller do
 
   # QWC will perform a GET to check the certificate, so we gotta respond
   describe 'GET :endpoint' do
@@ -47,7 +47,7 @@ describe QuickbooksWebConnector::SoapController do
       # </env:Envelope>
 
       before do
-        QuickbooksWebConnector.configure { |c| c.server_version = '1.2.3' }
+        QuickbooksWebConnector.config.server_version = '1.2.3'
 
         post :endpoint, { use_route: 'quickbooks_web_connector' }
       end
@@ -135,19 +135,7 @@ describe QuickbooksWebConnector::SoapController do
       # </env:Envelope>
 
       before do
-        QuickbooksWebConnector.configure do |c|
-          c.username = 'foo'
-          c.password = 'bar'
-          c.company_file_path = "C:\\path\\to\\company.qbw"
-        end
-      end
-
-      after do
-        QuickbooksWebConnector.configure do |c|
-          c.username = 'web_connector'
-          c.password = 'secret'
-          c.company_file_path = nil
-        end
+        QuickbooksWebConnector.config.user 'foo', 'bar', "C:\\path\\to\\company.qbw"
       end
 
       it 'responds that theres no jobs to work when authenticated without jobs' do
@@ -159,7 +147,7 @@ describe QuickbooksWebConnector::SoapController do
       end
 
       it 'returns the company_file_path when theres data to send' do
-        SomeBuilder.stub(:perform).with(1).and_return('<some><xml></xml></some>')
+        allow(SomeBuilder).to receive(:perform).with(1).and_return('<some><xml></xml></some>')
         QuickbooksWebConnector.enqueue SomeBuilder, SomeHandler, 1
 
         do_post
@@ -202,7 +190,7 @@ describe QuickbooksWebConnector::SoapController do
       # </env:Envelope>
 
       before do
-        SomeBuilder.stub(:perform).with(1).and_return('<some><xml></xml></some>')
+        allow(SomeBuilder).to receive(:perform).with(1).and_return('<some><xml></xml></some>')
         QuickbooksWebConnector.enqueue SomeBuilder, SomeHandler, 1
 
         do_post