quickbooks_web_connector 0.0.3 → 0.0.4

data/spec/lib/quickbooks_web_connector/failure_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+describe QuickbooksWebConnector::Failure do
+
+  describe '.create' do
+    it 'creates a new failure and saves it' do
+      failure = stub :failure
+      failure.should_receive(:save)
+      described_class.should_receive(:new).with(Exception, { foo: 'bar' }).and_return(failure)
+
+      described_class.create(exception: Exception, payload: { foo: 'bar' })
+    end
+  end
+
+  describe '.requeue' do
+    it 'adds the failure back in as a new job' do
+      described_class.create(exception: Exception.new('boom'), payload: { 'request_builder_class' => 'SomeBuilder', 'response_handler_class' => 'SomeHandler', 'args' => ['36'] })
+
+      described_class.requeue(0)
+
+      expect(described_class.find(0)['retried_at']).to_not be_nil
+
+      expect(QuickbooksWebConnector.size).to eq(1)
+      new_job = QuickbooksWebConnector.reserve
+      expect(new_job.request_builder_class).to be(SomeBuilder)
+      expect(new_job.response_handler_class).to be(SomeHandler)
+      expect(new_job.args).to eq(['36'])
+    end
+  end
+
+  describe '.remove' do
+    it 'removes the failed job from the list' do
+      described_class.create(exception: Exception.new, payload: {})
+
+      expect(described_class.all).to have(1).job
+
+      described_class.remove(0)
+
+      expect(described_class.all).to have(0).jobs
+    end
+  end
+
+  describe '#save' do
+    subject(:failure) { described_class.new(Exception.new('something went wrong'), { foo: 'bar' }) }
+
+    it 'stores the failure with some details in redis' do
+      failure.save
+
+      expect(described_class.count).to eq(1)
+
+      item = described_class.all.first
+      expect(item['failed_at']).to_not be_nil
+      expect(item['payload']).to eq('foo' => 'bar')
+      expect(item['exception']).to eq('Exception')
+      expect(item['error']).to eq('something went wrong')
+      expect(item['backtrace']).to be_an(Array)
+    end
+  end
+
+end

data/spec/lib/quickbooks_web_connector/job_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+describe QuickbooksWebConnector::Job do
+
+  describe '.queued' do
+    it 'returns all queued jobs' do
+      expect(described_class.queued.size).to be(0)
+
+      described_class.create(SomeBuilder, SomeHandler, 12)
+      described_class.create(SomeBuilder, SomeHandler, 31)
+
+      expect(described_class.queued.size).to eq(2)
+    end
+  end
+
+  it 'becomes a failure if building the request XML raises an exception' do
+    SomeBuilder.stub(:perform).and_raise(Exception)
+    job = described_class.new 'request_builder_class' => 'SomeBuilder'
+
+    expect { job.request_xml }.to_not raise_exception
+
+    expect(QuickbooksWebConnector::Failure.count).to be(1)
+  end
+
+  it 'becomes a failure if handling the response raises an exception' do
+    SomeHandler.stub(:perform).and_raise(Exception)
+    job = described_class.new 'response_handler_class' => 'SomeHandler'
+
+    expect { job.perform }.to_not raise_exception
+
+    expect(QuickbooksWebConnector::Failure.count).to be(1)
+  end
+
+end

data/spec/{quickbooks_web_connector → lib/quickbooks_web_connector}/soap_wrapper/defaultServant_spec.rb

@@ -114,7 +114,10 @@ describe QuickbooksWebConnector::SoapWrapper::QBWebConnectorSvcSoap do
   describe 'sendRequestXML' do
     subject(:response) { servant.sendRequestXML(stub :parameters) }
 
-    before { QuickbooksWebConnector.enqueue '<some><xml></xml></some>', SomeHandler, 1 }
+    before do
+      SomeBuilder.stub(:perform).with(1).and_return('<some><xml></xml></some>')
+      QuickbooksWebConnector.enqueue SomeBuilder, SomeHandler, 1
+    end
 
     it { should be_a QuickbooksWebConnector::SoapWrapper::SendRequestXMLResponse }
     its(:sendRequestXMLResult) { should eq '<some><xml></xml></some>' }

data/spec/{quickbooks_web_connector_spec.rb → lib/quickbooks_web_connector_spec.rb}

@@ -25,12 +25,13 @@ describe QuickbooksWebConnector do
 
   it 'can enqueue jobs' do
     expect(described_class.size).to eq(0)
-    described_class.enqueue '<some><xml></xml></some>', SomeHandler, 1, '/tmp'
+    described_class.enqueue SomeBuilder, SomeHandler, 1, '/tmp'
 
     job = described_class.reserve
 
     expect(job).to be_a_kind_of(described_class::Job)
-    expect(job.payload_class).to eq(SomeHandler)
+    expect(job.request_builder_class).to eq(SomeBuilder)
+    expect(job.response_handler_class).to eq(SomeHandler)
     expect(job.args[0]).to eq 1
     expect(job.args[1]).to eq '/tmp'
 

data/spec/spec_helper.rb

@@ -37,13 +37,18 @@ RSpec.configure do |config|
   config.after(:suite) do
     processes = `ps -A -o pid,command | grep [r]edis-test`.split($/)
     pids = processes.map { |process| process.split(" ")[0] }
-    puts "Killing test redis server..."
+    puts '', "Killing test redis server..."
     pids.each { |pid| Process.kill("TERM", pid.to_i) }
     system("rm -f #{$dir}/support/redis/dump.rdb")
   end
 end
 
 # fixture classes
+class SomeBuilder
+  def self.perform(*args)
+  end
+end
+
 class SomeHandler
   def self.perform(response_xml, *args)
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quickbooks_web_connector
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-07 00:00:00.000000000 Z
+date: 2013-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -108,6 +108,7 @@ files:
 - config/routes.rb
 - lib/quickbooks_web_connector/config.rb
 - lib/quickbooks_web_connector/engine.rb
+- lib/quickbooks_web_connector/failure.rb
 - lib/quickbooks_web_connector/job.rb
 - lib/quickbooks_web_connector/json_coder.rb
 - lib/quickbooks_web_connector/soap_wrapper/default.rb
@@ -155,11 +156,12 @@ files:
 - spec/dummy/Rakefile
 - spec/dummy/README.rdoc
 - spec/dummy/script/rails
-- spec/quickbooks_web_connector/soap_wrapper/defaultServant_spec.rb
-- spec/quickbooks_web_connector_spec.rb
+- spec/lib/quickbooks_web_connector/failure_spec.rb
+- spec/lib/quickbooks_web_connector/job_spec.rb
+- spec/lib/quickbooks_web_connector/soap_wrapper/defaultServant_spec.rb
+- spec/lib/quickbooks_web_connector_spec.rb
 - spec/routing/quickbooks_web_connector_spec.rb
 - spec/spec_helper.rb
-- spec/support/redis/dump.rdb
 - spec/support/redis/redis-test.conf
 - spec/views/quickbooks_web_connector/qwc/qwc.xml.builder_spec.rb
 homepage: https://github.com/cgunther/quickbooks_web_connector
@@ -176,7 +178,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1903100488972492978
+      hash: -4263784119313176074
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -185,7 +187,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1903100488972492978
+      hash: -4263784119313176074
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23
@@ -227,10 +229,11 @@ test_files:
 - spec/dummy/Rakefile
 - spec/dummy/README.rdoc
 - spec/dummy/script/rails
-- spec/quickbooks_web_connector/soap_wrapper/defaultServant_spec.rb
-- spec/quickbooks_web_connector_spec.rb
+- spec/lib/quickbooks_web_connector/failure_spec.rb
+- spec/lib/quickbooks_web_connector/job_spec.rb
+- spec/lib/quickbooks_web_connector/soap_wrapper/defaultServant_spec.rb
+- spec/lib/quickbooks_web_connector_spec.rb
 - spec/routing/quickbooks_web_connector_spec.rb
 - spec/spec_helper.rb
-- spec/support/redis/dump.rdb
 - spec/support/redis/redis-test.conf
 - spec/views/quickbooks_web_connector/qwc/qwc.xml.builder_spec.rb

data/spec/support/redis/dump.rdb

@@ -1 +0,0 @@
-REDIS0006�ܳC�Z��V