quickbooks-ruby 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: da1eed0bda8ea24f1208cadd17ae3a71d9bb5ad3
-  data.tar.gz: f722fa73671873c979a30272ebfc34099d454431
+  metadata.gz: 370814f06f30b4295a57aa192b80f1e5595f2add
+  data.tar.gz: 979ea9f309103e35965164416c43f9fbf012c936
 SHA512:
-  metadata.gz: 501c32416df4feab6f5bda98a7228cd43be3a6a49b5ce9571078e023e976cd05bd4e402e53f372fc85adcb909c9b7ba6429fd32f144b8deaad55cbad7c6b1b7a
-  data.tar.gz: ace357f52b45d67c50483742e9b6499a4f58a8de92fc089075c6fb3685c7b9306f8e9006365ed4fdf93981a700c3ab0fecb7bdeee9ec51cb50f4d10c191f3afc
+  metadata.gz: 1e10973a8df8caf229df653080bd515d69efe0e03b94e9e348ac5bb7f31006e5a8676506dabf6c7612cdc955ab88f4e0780ab3fd754a8c1d0cd5c68dd5a3a759
+  data.tar.gz: 28fd0719eab709d93f1d3269995d3b65d6762eabe04a004034e119582d1f454bc3453c8a30a232166a8729403b59da3f8884a1c36b0486ec69a3da98599f28a5

data/lib/quickbooks-ruby.rb

@@ -162,6 +162,7 @@ module Quickbooks
   class InvalidModelException < StandardError; end
 
   class AuthorizationFailure < StandardError; end
+  class Forbidden < StandardError; end
 
   class ServiceUnavailable < StandardError; end
   class MissingRealmError < StandardError; end

data/lib/quickbooks/service/base_service.rb

@@ -68,7 +68,7 @@ module Quickbooks
 
       # A single object response is the same as a collection response except
       # it just has a single main element
-      def fetch_object(model, url, params = {}, options = {})
+      def fetch_object(model, url, params = {})
         raise ArgumentError, "missing model to instantiate" if model.nil?
         response = do_http_get(url, params)
         collection = parse_collection(response, model)
@@ -186,6 +186,7 @@ module Quickbooks
       end
 
       def do_http_get(url, params = {}, headers = {}) # throws IntuitRequestException
+        url = add_query_string_to_url(url, params)
         do_http(:get, url, {}, headers)
       end
 
@@ -246,11 +247,13 @@ module Quickbooks
           end
         when 302
           raise "Unhandled HTTP Redirect"
-        when 401, 403
+        when 401
           raise Quickbooks::AuthorizationFailure
+        when 403
+          raise Quickbooks::Forbidden
         when 400, 500
           parse_and_raise_exception(options)
-        when 503
+        when 503, 504
           raise Quickbooks::ServiceUnavailable
         else
           raise "HTTP Error Code: #{status}, Msg: #{response.plain_body}"
@@ -269,6 +272,8 @@ module Quickbooks
 
       def response_is_error?
         @last_response_xml.xpath("//xmlns:IntuitResponse/xmlns:Fault")[0] != nil
+      rescue Nokogiri::XML::XPath::SyntaxError => exception
+        true
       end
 
       def parse_intuit_error
@@ -288,6 +293,10 @@ module Quickbooks
           end
         end
 
+        error
+      rescue Nokogiri::XML::XPath::SyntaxError => exception
+        error[:detail] = @last_response_xml.to_s
+
         error
       end
 

data/lib/quickbooks/service/service_crud.rb

@@ -16,9 +16,9 @@ module Quickbooks
         end until results.count < per_page
       end
 
-      def fetch_by_id(id, options = {})
+      def fetch_by_id(id, params = {})
         url = "#{url_for_resource(model.resource_for_singular)}/#{id}"
-        fetch_object(model, url, options)
+        fetch_object(model, url, params)
       end
 
       def create(entity, options = {})

data/lib/quickbooks/version.rb

@@ -1,5 +1,5 @@
 module Quickbooks
 
-  VERSION = "0.1.6"
+  VERSION = "0.1.7"
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quickbooks-ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Cody Caughlan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-23 00:00:00.000000000 Z
+date: 2014-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oauth