quick_check 0.1.0 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 896e5b8930fe9d6f9c090ef32c1bbc70a57a05d415c7ad6996e5a4e211868963
-  data.tar.gz: ae0e8f1831e674357081df078d68cfdbf3966c22d09f6c826becaa7d6a21bd90
+  metadata.gz: e665ad565d365abca56c8521560fb97dd507683c8eec6d7c81084b2b393cf2d0
+  data.tar.gz: e82c198675cbc2aa956395d6b327088db5f5d4ad85f96a39c5abafb6830f57e4
 SHA512:
-  metadata.gz: cddc454b92ad6e3c2c1f9afe08dab40305c9ee29bfe91d35a44fe578b7c52bb27cc09dbd1806c13d6cb9350bb4e945a0e2e1c24c757bbb005865739b2cd9281f
-  data.tar.gz: 7952bbeb5140d87b51b189b464ee7309367a49fc687e099bdcd124b9d5744b0914735d0336b36d500a6dbe781b2bae5101101519a9446af319f2bbb442256fc4
+  metadata.gz: 60f09a0569f3d80c90d95b41bc1d289cf136331bdf639e50d3c85931262488e9f6a5edc9678241b6ed1b9c570bfd8791031b8056acd1b51f7769cd85a3da3505
+  data.tar.gz: 2e38a08ee04981404e46b4099882a07927397aa66a9961704f480bb30b48cdb691af989e5c48cfb84d17475767e81309b8e3aed9801b616840b45ec2fbe9556b

data/README.md

@@ -27,6 +27,7 @@ qc
   - Staged (index) changes
   - Untracked files (new specs not yet added)
   - All committed changes on your branch vs base (`main`/`master`)
+  - Renames and copies are tracked so moved tests still run
 - You can disable branch commits with `--no-committed`
 - Auto-detects base branch (`main` or `master`) or configure via `.quick_check.yml`
 - Auto-detects framework and command:
@@ -99,10 +100,10 @@ If no config is present, `qc` will use the first existing branch among `main` or
 
 ## How it works
 
-- Unstaged: `git diff --name-only --diff-filter=ACMR`
-- Staged: `git diff --name-only --cached --diff-filter=ACMR`
+- Unstaged: `git diff --name-only -M -C --diff-filter=ACMR`
+- Staged: `git diff --name-only --cached -M -C --diff-filter=ACMR`
 - Untracked: `git ls-files --others --exclude-standard`
-- Committed vs base: `git diff --name-only --diff-filter=ACMR <base>...HEAD`
+- Committed vs base: `git diff --name-only -M -C --diff-filter=ACMR <base>...HEAD`
 
 Files are filtered to `spec/**/*_spec.rb` and/or `test/**/*_test.rb`, de-duplicated, sorted, and then:
 

data/lib/quick_check/cli.rb

@@ -126,39 +126,74 @@ module QuickCheck
       files = []
 
       if @options[:include_unstaged]
-        files.concat(git_diff_name_only(["--name-only", "--diff-filter=ACMR"]))
+        files.concat(git_diff_name_only(["--name-only", "-M", "-C", "--diff-filter=ACMR"]))
         files.concat(git_untracked_files)
       end
 
       if @options[:include_staged]
-        files.concat(git_diff_name_only(["--name-only", "--cached", "--diff-filter=ACMR"]))
+        files.concat(git_diff_name_only(["--name-only", "--cached", "-M", "-C", "--diff-filter=ACMR"]))
       end
 
       if @options[:include_committed_diff]
         current_branch = git_current_branch
         if current_branch && base_branch && current_branch != base_branch
-          # Include files changed on this branch vs base
-          range = diff_range_against_base(base_branch)
-          files.concat(git_diff_name_only(["--name-only", "--diff-filter=ACMR", range])) if range
+          upstream_branch = git_upstream_branch(current_branch)
+          # Prefer upstream tracking branch to correctly handle rebases (only shows local changes)
+          if upstream_branch && upstream_has_differences?(upstream_branch)
+            changed_files = diff_range_against_upstream(upstream_branch)
+            files.concat(changed_files) if changed_files
+          elsif !upstream_branch
+            # Fall back to base branch if no upstream exists
+            changed_files = diff_range_against_base(base_branch)
+            files.concat(changed_files) if changed_files
+          end
         end
       end
 
       files = files.compact.uniq
       rspec_specs = files.select { |f| f.match?(%r{\Aspec/.+_spec\.rb\z}) }
+      rspec_specs += infer_rspec_from_source(files)
       minitest_tests = files.select { |f| f.match?(%r{\Atest/.+_test\.rb\z}) }
 
-      # Infer tests from source changes (e.g., app/models/user.rb -> spec/models/user_spec.rb)
-      source_files = files.reject { |f| f.match?(%r{\A(spec/|test/)}) }
-      unless source_files.empty?
-        inferred_rspec = source_files.flat_map { |src| infer_rspec_paths_for_source(src) }
-        inferred_minitest = source_files.flat_map { |src| infer_minitest_paths_for_source(src) }
-        rspec_specs.concat(inferred_rspec)
-        minitest_tests.concat(inferred_minitest)
-      end
-
       { rspec: rspec_specs.uniq, minitest: minitest_tests.uniq }
     end
 
+    def infer_rspec_from_source(files)
+      candidates = []
+      files.each do |path|
+        next unless path.end_with?(".rb")
+
+        if path =~ %r{\Aapp/models/(.+)\.rb\z}
+          spec_path = File.join("spec", "models", "#{$1}_spec.rb")
+          candidates << spec_path if File.file?(spec_path)
+          next
+        end
+
+        if path =~ %r{\Aapp/controllers/(.+?)(?:_controller)?\.rb\z}
+          controller_path = Regexp.last_match(1)
+          req_base = File.join("spec", "requests", controller_path)
+          req_variants = [
+            "#{req_base}_spec.rb",
+            "#{req_base}_controller_spec.rb"
+          ].select { |p| File.file?(p) }
+          if req_variants.any?
+            candidates.concat(req_variants)
+          else
+            ctrl_spec = File.join("spec", "controllers", "#{controller_path}_controller_spec.rb")
+            candidates << ctrl_spec if File.file?(ctrl_spec)
+          end
+          next
+        end
+
+        if path =~ %r{\Alib/(.+)\.rb\z}
+          spec_path = File.join("spec", "lib", "#{$1}_spec.rb")
+          candidates << spec_path if File.file?(spec_path)
+          next
+        end
+      end
+      candidates
+    end
+
     def ensure_git_repo!
       run_cmd(["git", "rev-parse", "--is-inside-work-tree"]).tap do |ok, out, _err|
         unless ok && out.to_s.strip == "true"
@@ -205,12 +240,17 @@ module QuickCheck
     end
 
     def branch_exists?(name)
+      local_branch_exists?(name) || remote_branch_exists?(name)
+    end
+
+    def local_branch_exists?(name)
       ok, _out, _err = run_cmd(["git", "show-ref", "--verify", "--quiet", "refs/heads/#{name}"])
-      return true if ok
+      ok
+    end
 
-      # fall back to remote branch
-      ok, _out, _err = run_cmd(["git", "ls-remote", "--heads", "origin", name])
-      ok && !_out.to_s.strip.empty?
+    def remote_branch_exists?(name)
+      ok, out, _err = run_cmd(["git", "ls-remote", "--heads", "origin", name])
+      ok && !out.to_s.strip.empty?
     end
 
     def git_current_branch
@@ -223,11 +263,50 @@ module QuickCheck
       ok ? out.to_s.strip : nil
     end
 
+    def git_upstream_branch(branch)
+      # Get the upstream tracking branch for the current branch
+      ok, out, _err = run_cmd(["git", "rev-parse", "--abbrev-ref", "--symbolic-full-name", "#{branch}@{u}"])
+      if ok && !out.to_s.strip.empty?
+        upstream = out.to_s.strip
+        # Verify the upstream branch actually exists
+        ok_check, _out_check, _err_check = run_cmd(["git", "rev-parse", "--verify", "--quiet", upstream])
+        return upstream if ok_check
+      end
+      nil
+    rescue StandardError
+      nil
+    end
+
+    def upstream_has_differences?(upstream)
+      # Only use upstream if it has local commits (avoids testing already-pushed changes)
+      ok, out, _err = run_cmd(["git", "rev-list", "--count", "#{upstream}..HEAD"])
+      return false unless ok
+      out.to_s.strip.to_i > 0
+    end
+
+    def diff_range_against_upstream(upstream)
+      files = git_log_first_parent_files(upstream, "HEAD")
+      files.empty? ? nil : files
+    end
+
     def diff_range_against_base(base)
-      return nil unless branch_exists?(base)
-      # If upstream exists, prefer merge-base to HEAD to include all branch commits
-      # The symmetric range base...HEAD ensures we include commits unique to the branch
-      "#{base}...HEAD"
+      base_ref = if local_branch_exists?(base)
+                   base
+                 elsif remote_branch_exists?(base)
+                   "origin/#{base}"
+                 else
+                   return nil
+                 end
+      files = git_log_first_parent_files(base_ref, "HEAD")
+      files.empty? ? nil : files
+    end
+
+    def git_log_first_parent_files(base_ref, head_ref)
+      # Use --first-parent to exclude merge commits, only showing changes from direct branch commits
+      cmd = ["git", "log", "--first-parent", "--name-only", "--diff-filter=ACMR", "--format=", "#{base_ref}..#{head_ref}"]
+      ok, out, _err = run_cmd(cmd)
+      return [] unless ok
+      out.split("\n").map(&:strip).reject(&:empty?).uniq
     end
 
     def git_diff_name_only(args)
@@ -245,52 +324,6 @@ module QuickCheck
       out.split("\n").map(&:strip).reject(&:empty?)
     end
 
-    def infer_rspec_paths_for_source(source_path)
-      candidates = []
-      if source_path.start_with?("app/")
-        rel = source_path.sub(/^app\//, "")
-        # Prefer request specs for controllers
-        if rel.start_with?("controllers/")
-          sub_rel = rel.sub(/^controllers\//, "")
-          dir = File.dirname(sub_rel)
-          dir = "" if dir == "."
-          base_with_controller = File.basename(sub_rel, ".rb")
-          base_without_controller = base_with_controller.sub(/_controller\z/, "")
-          # Common conventions for request specs
-          candidates << File.join("spec", "requests", dir, "#{base_without_controller}_spec.rb")
-          candidates << File.join("spec", "requests", dir, "#{base_with_controller}_spec.rb")
-        end
-        candidates << File.join("spec", rel).sub(/\.rb\z/, "_spec.rb")
-      elsif source_path.start_with?("lib/")
-        rel = source_path.sub(/^lib\//, "")
-        candidates << File.join("spec", "lib", rel).sub(/\.rb\z/, "_spec.rb")
-      end
-
-      candidates.select { |p| File.file?(p) }
-    end
-
-    def infer_minitest_paths_for_source(source_path)
-      candidates = []
-      if source_path.start_with?("app/")
-        rel = source_path.sub(/^app\//, "")
-        # Prefer integration/request-style tests for controllers when present
-        if rel.start_with?("controllers/")
-          sub_rel = rel.sub(/^controllers\//, "")
-          dir = File.dirname(sub_rel)
-          dir = "" if dir == "."
-          base = File.basename(sub_rel, ".rb").sub(/_controller\z/, "")
-          integration_test = File.join("test", "integration", dir, "#{base}_test.rb")
-          candidates << integration_test
-        end
-        candidates << File.join("test", rel).sub(/\.rb\z/, "_test.rb")
-      elsif source_path.start_with?("lib/")
-        rel = source_path.sub(/^lib\//, "")
-        candidates << File.join("test", "lib", rel).sub(/\.rb\z/, "_test.rb")
-      end
-
-      candidates.select { |p| File.file?(p) }
-    end
-
     def build_command_for(framework, files)
       return (@options[:custom_command] + files) if @options[:custom_command]
 
@@ -310,13 +343,11 @@ module QuickCheck
     end
 
     def rails_available?
-      bin_rails = File.join(Dir.pwd, "bin", "rails")
-      File.executable?(bin_rails) || File.file?(bin_rails) || gemfile_includes?("rails")
+      File.executable?(File.join(Dir.pwd, "bin", "rails")) || gemfile_includes?("rails")
     end
 
     def rails_cmd
-      bin_rails = File.join(Dir.pwd, "bin", "rails")
-      if File.executable?(bin_rails) || File.file?(bin_rails)
+      if File.executable?(File.join(Dir.pwd, "bin", "rails"))
         [File.join("bin", "rails")]
       else
         ["bundle", "exec", "rails"]

data/lib/quick_check/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module QuickCheck
-  VERSION = "0.1.0"
+  VERSION = "0.1.3"
 end

data/spec/quick_check/cli_spec.rb

@@ -53,7 +53,7 @@ RSpec.describe QuickCheck::CLI do
 
   it "runs rspec for changed rspec files" do
     stubs = base_git_stubs.merge(
-      "git diff --name-only --diff-filter=ACMR" => { stdout: "spec/models/user_spec.rb\n" }
+      "git diff --name-only -M -C --diff-filter=ACMR" => { stdout: "spec/models/user_spec.rb\n" }
     )
 
     status, out, _err = run_cli(["--dry-run"], git_outputs: stubs)
@@ -63,7 +63,7 @@ RSpec.describe QuickCheck::CLI do
 
   it "infers rspec from app source change" do
     stubs = base_git_stubs.merge(
-      "git diff --name-only --diff-filter=ACMR" => { stdout: "app/models/user.rb\n" }
+      "git diff --name-only -M -C --diff-filter=ACMR" => { stdout: "app/models/user.rb\n" }
     )
     status, out, _err = run_cli(["--dry-run"], git_outputs: stubs, existing_files: [
       File.join("spec", "models", "user_spec.rb")
@@ -74,7 +74,7 @@ RSpec.describe QuickCheck::CLI do
 
   it "maps controller to request spec with both base names" do
     stubs = base_git_stubs.merge(
-      "git diff --name-only --diff-filter=ACMR" => { stdout: "app/controllers/account/users_controller.rb\n" }
+      "git diff --name-only -M -C --diff-filter=ACMR" => { stdout: "app/controllers/account/users_controller.rb\n" }
     )
     existing = [
       File.join("spec", "requests", "account", "users_spec.rb"),
@@ -87,7 +87,7 @@ RSpec.describe QuickCheck::CLI do
 
   it "falls back to controller spec when no request spec exists" do
     stubs = base_git_stubs.merge(
-      "git diff --name-only --diff-filter=ACMR" => { stdout: "app/controllers/home_controller.rb\n" }
+      "git diff --name-only -M -C --diff-filter=ACMR" => { stdout: "app/controllers/home_controller.rb\n" }
     )
     existing = [File.join("spec", "controllers", "home_controller_spec.rb")]
     status, out, _err = run_cli(["--dry-run"], git_outputs: stubs, existing_files: existing)
@@ -97,7 +97,7 @@ RSpec.describe QuickCheck::CLI do
 
   it "runs minitest through rails test when test files change and rails present" do
     stubs = base_git_stubs.merge(
-      "git diff --name-only --diff-filter=ACMR" => { stdout: "test/models/user_test.rb\n" }
+      "git diff --name-only -M -C --diff-filter=ACMR" => { stdout: "test/models/user_test.rb\n" }
     )
     allow_any_instance_of(QuickCheck::CLI).to receive(:rails_available?).and_return(true)
     status, out, _err = run_cli(["--dry-run"], git_outputs: stubs, existing_files: [File.join("bin", "rails")])
@@ -107,11 +107,59 @@ RSpec.describe QuickCheck::CLI do
 
   it "runs per-file minitest when no rails" do
     stubs = base_git_stubs.merge(
-      "git diff --name-only --diff-filter=ACMR" => { stdout: "test/models/user_test.rb\n" }
+      "git diff --name-only -M -C --diff-filter=ACMR" => { stdout: "test/models/user_test.rb\n" }
     )
 
     status, out, _err = run_cli(["--dry-run"], git_outputs: stubs)
     expect(out.lines.map(&:strip)).to include("ruby -I test test/models/user_test.rb")
     expect(status).to eq(0)
   end
+
+  it "uses first-parent to handle rebases correctly" do
+    stubs = base_git_stubs.merge(
+      "git show-ref --verify --quiet refs/heads/main" => { success: true },
+      "git log --first-parent --name-only --diff-filter=ACMR --format= main..HEAD" => { stdout: "spec/my_feature_spec.rb\n" }
+    )
+
+    status, out, _err = run_cli(["--base", "main", "--dry-run", "--no-unstaged", "--no-staged"], git_outputs: stubs)
+    expect(status).to eq(0)
+    expect(out).to include("bundle exec rspec spec/my_feature_spec.rb")
+  end
+
+  it "prefers upstream branch over base branch when upstream has differences" do
+    stubs = base_git_stubs.merge(
+      "git rev-parse --abbrev-ref --symbolic-full-name feature@{u}" => { stdout: "origin/feature\n" },
+      "git rev-parse --verify --quiet origin/feature" => { success: true },
+      "git rev-list --count origin/feature..HEAD" => { stdout: "5\n" },
+      "git log --first-parent --name-only --diff-filter=ACMR --format= origin/feature..HEAD" => { stdout: "spec/my_local_change_spec.rb\n" }
+    )
+
+    status, out, _err = run_cli(["--base", "main", "--dry-run", "--no-unstaged", "--no-staged"], git_outputs: stubs)
+    expect(status).to eq(0)
+    expect(out).to include("bundle exec rspec spec/my_local_change_spec.rb")
+  end
+
+  it "does not include committed changes when upstream is in sync" do
+    stubs = base_git_stubs.merge(
+      "git rev-parse --abbrev-ref --symbolic-full-name feature@{u}" => { stdout: "origin/feature\n" },
+      "git rev-parse --verify --quiet origin/feature" => { success: true },
+      "git rev-list --count origin/feature..HEAD" => { stdout: "0\n" }
+    )
+
+    status, out, _err = run_cli(["--base", "main", "--dry-run", "--no-unstaged", "--no-staged"], git_outputs: stubs)
+    expect(status).to eq(0)
+    expect(out).to include("No changed/added test files detected.")
+  end
+
+  it "falls back to base branch when no upstream exists" do
+    stubs = base_git_stubs.merge(
+      "git rev-parse --abbrev-ref --symbolic-full-name feature@{u}" => { success: false, exitstatus: 128 },
+      "git show-ref --verify --quiet refs/heads/main" => { success: true },
+      "git log --first-parent --name-only --diff-filter=ACMR --format= main..HEAD" => { stdout: "spec/my_feature_spec.rb\n" }
+    )
+
+    status, out, _err = run_cli(["--base", "main", "--dry-run", "--no-unstaged", "--no-staged"], git_outputs: stubs)
+    expect(status).to eq(0)
+    expect(out).to include("bundle exec rspec spec/my_feature_spec.rb")
+  end
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: quick_check
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.3
 platform: ruby
 authors:
 - Kasvit
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-08-22 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies: []
 description: Adds the `qc` command to run only changed or newly added RSpec files
   from uncommitted changes and vs base branch (main/master).
@@ -32,7 +31,6 @@ homepage: https://github.com/kasvit/quick_check
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -47,8 +45,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Run changed/added RSpec specs quickly
 test_files: []