queue_classic_plus 4.0.0.alpha16 → 4.0.0.alpha18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1ca2467a415dbb231b97492a6b223945a08c79a704209c9f5cbdcc6317a51643
-  data.tar.gz: 497545d4065d6cd1c03a39591b04174fbff95899871a1b0dcb1d33a4d5cc4bdf
+  metadata.gz: f4194444b2e3b6bc8d08ebfe7393e9efa53bc31fdb8c7e79c5b1a6aff31e8776
+  data.tar.gz: a12f2b01acea5e2fb4fc6e6b257c6aafc228ff38f73280a3deb974452f2e7220
 SHA512:
-  metadata.gz: 2c46e104255d291c0bee0e2c5517bb72c1ced81f860fb8f7ee1474973ed806f92c5352bfb060e9f538dcacd9e43dfd8ad2100539931bf21f9d567a4456e6e64c
-  data.tar.gz: 6102b297532d4cc30c30825deb42a82121460d773f0881a250ea5280803aa0d959279cf4e1baee8e4719d41840afbb1e332a9b598b9ef9711ceed1b31da31cbe
+  metadata.gz: 42399e627f40795df59f4235e6d616527506758af7a988c2e7e923ce3fbad2bac49b188563ad508d66e95f9935149eaafd1928d6eac6c97bfeb9f1a437fffabe
+  data.tar.gz: b08d05305a8772d2aacf0e5984b5d2254f3b1f83cb8e6d4d02b7f1bb3d929d70e3ddd02b1130f9845ebec3d9ef409d7a86d63f44ff04ea3fb998dd0cab2080a0

data/lib/queue_classic_plus/base.rb

@@ -2,18 +2,10 @@ module QueueClassicPlus
   class Base
     extend QueueClassicPlus::InheritableAttribute
 
-    # Max value for bigint calculated from
-    # https://stackoverflow.com/questions/28960478/postgres-maximum-value-for-bigint
-    PG_BIGINT_MAX = 9223372036854775807.freeze
-
     def self.queue
       QC::Queue.new(@queue)
     end
 
-    def self.queue_name_digest
-      @queue_name_digest ||= @queue.to_s.to_i(36) % PG_BIGINT_MAX
-    end
-
     inheritable_attr :locked
     inheritable_attr :skip_transaction
     inheritable_attr :retries_on
@@ -83,19 +75,9 @@ module QueueClassicPlus
     end
 
     def self.enqueue(method, *args)
-       conn = QC.default_conn_adapter.connection
-       check_and_enqueue = proc do
-         conn.exec("SELECT pg_advisory_xact_lock(#{queue_name_digest})")
-         if can_enqueue?(method, *args)
-           queue.enqueue(method, *serialized(args))
-         end
-       end
-
-       if [PG::PQTRANS_ACTIVE, PG::PQTRANS_INTRANS].include?(conn.transaction_status)
-         check_and_enqueue.call
-       else
-         conn.transaction &check_and_enqueue
-       end
+      if can_enqueue?(method, *args)
+        queue.enqueue(method, *serialized(args))
+      end
     end
 
     def self.enqueue_perform(*args)

data/lib/queue_classic_plus/version.rb

@@ -1,3 +1,3 @@
 module QueueClassicPlus
-  VERSION = '4.0.0.alpha16'.freeze
+  VERSION = '4.0.0.alpha18'.freeze
 end

data/spec/base_spec.rb

@@ -12,15 +12,9 @@ describe QueueClassicPlus::Base do
       end
 
       it "does not allow multiple enqueues" do
-        threads = []
-        50.times do
-          threads << Thread.new do
-            subject.do
-            expect(subject).to have_queue_size_of(1)
-          end
-        end
-
-        threads.each(&:join)
+        subject.do
+        subject.do
+        expect(subject).to have_queue_size_of(1)
       end
 
       it "checks for an existing job using the same serializing as job enqueuing" do
@@ -44,23 +38,6 @@ describe QueueClassicPlus::Base do
       end
     end
 
-    context "when in a transaction" do
-      subject do
-        Class.new(QueueClassicPlus::Base) do
-          @queue = :test
-          lock!
-        end
-      end
-
-      it "does not create another transaction when enqueueing" do
-        conn = QC.default_conn_adapter.connection
-        expect(conn).to receive(:transaction).exactly(1).times.and_call_original
-        conn.transaction do
-          subject.do
-        end
-      end
-    end
-
     context "with default settings" do
       subject do
         Class.new(QueueClassicPlus::Base) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: queue_classic_plus
 version: !ruby/object:Gem::Version
-  version: 4.0.0.alpha16
+  version: 4.0.0.alpha18
 platform: ruby
 authors:
 - Simon Mathieu
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-11 00:00:00.000000000 Z
+date: 2023-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: queue_classic