queue_classic_plus 4.0.0.alpha14 → 4.0.0.alpha16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 02d3b91c1e5eb2b3cd87c4431123bcdcd83546352a101a70d88663914cae8b75
-  data.tar.gz: 2bae8d97dc7e05144fb5d398fafefb870aa0f476ea0d82cd595a26378ca16f75
+  metadata.gz: 1ca2467a415dbb231b97492a6b223945a08c79a704209c9f5cbdcc6317a51643
+  data.tar.gz: 497545d4065d6cd1c03a39591b04174fbff95899871a1b0dcb1d33a4d5cc4bdf
 SHA512:
-  metadata.gz: b536eafcf6c8a7fd0698a09a9f56b3bd944612df546c857f69784269472cba64a555c639cf856c6811bffdb0037b851d8fb73a3e661785ab295b8b2143408dd7
-  data.tar.gz: f9cc374b667dfdb79f9adba615aab35bd49e2f90fda74eec04681d4f6288547235baba2b676abd118f51d227a436a6a571a8fd758f3828db15cf7436fff93073
+  metadata.gz: 2c46e104255d291c0bee0e2c5517bb72c1ced81f860fb8f7ee1474973ed806f92c5352bfb060e9f538dcacd9e43dfd8ad2100539931bf21f9d567a4456e6e64c
+  data.tar.gz: 6102b297532d4cc30c30825deb42a82121460d773f0881a250ea5280803aa0d959279cf4e1baee8e4719d41840afbb1e332a9b598b9ef9711ceed1b31da31cbe

data/lib/queue_classic_plus/base.rb

@@ -2,12 +2,16 @@ module QueueClassicPlus
   class Base
     extend QueueClassicPlus::InheritableAttribute
 
+    # Max value for bigint calculated from
+    # https://stackoverflow.com/questions/28960478/postgres-maximum-value-for-bigint
+    PG_BIGINT_MAX = 9223372036854775807.freeze
+
     def self.queue
       QC::Queue.new(@queue)
     end
 
     def self.queue_name_digest
-      @queue_name_digest ||= @queue.to_s.to_i(36)
+      @queue_name_digest ||= @queue.to_s.to_i(36) % PG_BIGINT_MAX
     end
 
     inheritable_attr :locked
@@ -79,13 +83,19 @@ module QueueClassicPlus
     end
 
     def self.enqueue(method, *args)
-      conn = QC.default_conn_adapter.connection
-      conn.transaction do
-        conn.exec("SELECT pg_advisory_xact_lock(#{queue_name_digest})")
-        if can_enqueue?(method, *args)
-          queue.enqueue(method, *serialized(args))
-        end
-      end
+       conn = QC.default_conn_adapter.connection
+       check_and_enqueue = proc do
+         conn.exec("SELECT pg_advisory_xact_lock(#{queue_name_digest})")
+         if can_enqueue?(method, *args)
+           queue.enqueue(method, *serialized(args))
+         end
+       end
+
+       if [PG::PQTRANS_ACTIVE, PG::PQTRANS_INTRANS].include?(conn.transaction_status)
+         check_and_enqueue.call
+       else
+         conn.transaction &check_and_enqueue
+       end
     end
 
     def self.enqueue_perform(*args)

data/lib/queue_classic_plus/version.rb

@@ -1,3 +1,3 @@
 module QueueClassicPlus
-  VERSION = '4.0.0.alpha14'.freeze
+  VERSION = '4.0.0.alpha16'.freeze
 end

data/spec/base_spec.rb

@@ -44,6 +44,23 @@ describe QueueClassicPlus::Base do
       end
     end
 
+    context "when in a transaction" do
+      subject do
+        Class.new(QueueClassicPlus::Base) do
+          @queue = :test
+          lock!
+        end
+      end
+
+      it "does not create another transaction when enqueueing" do
+        conn = QC.default_conn_adapter.connection
+        expect(conn).to receive(:transaction).exactly(1).times.and_call_original
+        conn.transaction do
+          subject.do
+        end
+      end
+    end
+
     context "with default settings" do
       subject do
         Class.new(QueueClassicPlus::Base) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: queue_classic_plus
 version: !ruby/object:Gem::Version
-  version: 4.0.0.alpha14
+  version: 4.0.0.alpha16
 platform: ruby
 authors:
 - Simon Mathieu
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-08 00:00:00.000000000 Z
+date: 2023-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: queue_classic