query_string_parser 0.1.0 → 0.1.1

data/LICENSE

@@ -0,0 +1,24 @@
+Copyright (c) 2010, dan sinclair
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+    * Redistributions of source code must retain the above copyright
+      notice, this list of conditions and the following disclaimer.
+    * Redistributions in binary form must reproduce the above copyright
+      notice, this list of conditions and the following disclaimer in the
+      documentation and/or other materials provided with the distribution.
+    * The name of the author nor the names of any contributors may be used
+      to endorse or promote products derived from this software without
+      specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
+IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

data/README

@@ -0,0 +1,22 @@
+Query String Parser
+===================
+
+We parse a lot of queries at PostRank Inc. The time taken to parse those queries starts to add up.
+Eventually we got to the point where we decided to create a simple C based parser. Hence, QueryStringParser.
+
+A more detailed explanation of the origins can be found at: http://everburning.com/news/introducing-querystringparser
+
+Usage is pretty simple, you can either call the function against the QueryStringParser module, or include
+the module into your code. There is only one method, qs_parse.
+
+  require 'query_string_parser'
+  QueryStringParser.qs_parse("my=query&string=parser")
+  => {"my"=>"query", "string"=>"parser"}
+
+  include QueryStringParser
+  qs_parse("does[]=array&does[]=data&does[3]=values&does=more")
+  => {"does"=>["array", "data", "values", "more"]}
+
+
+Questions, comments, drop me a line. dj2 at everburning dot com
+

data/ext/pr_query_parser.c

@@ -93,19 +93,23 @@ pr_query_parser(VALUE self, VALUE query_string, VALUE delim)
 
     params = rb_hash_new();
     qs = strdup(RSTRING_PTR(query_string));
-    for (s = qs, p = qs, key = qs; *p != 0; p++)
+    for (s = qs, p = qs; *p != 0; p++)
     {
         if (*p == delimiter)
         {
+            *p = 0;
             if (key != NULL)
             {
-                *p = 0;
                 pr_set_param(params, key, s);
+                key = NULL;
+            }
+            else
+            {
+                pr_set_param(params, s, s);
             }
             s = (p + 1);
-            key = s;
         }
-        else if (*p == '=')
+        else if ((*p == '=') && (key == NULL))
         {
             *p = 0;
             key = s;
@@ -113,7 +117,11 @@ pr_query_parser(VALUE self, VALUE query_string, VALUE delim)
         }
     }
 
-    if (key != NULL) pr_set_param(params, key, s);
+    if (s != NULL)
+    {
+        if (key != NULL) pr_set_param(params, key, s);
+        else pr_set_param(params, s, s);
+    }
     free(qs);
 
     return params;

data/spec/query_string_parser_spec.rb

@@ -163,4 +163,14 @@ describe 'QueryStringParser' do
     h['feed_id'][0].should == '2e2b55b3058696ccbe633e7241d53b16'
     h['feed_id'][1].should == '0381dd0545852d28d82ad7d0befbfd92'
   end
+
+  context 'improper escaping' do
+    it 'handles ? and = in query params' do
+      h = qs_parse('appkey=Test&id=http://xkcd.com/530?utm=a&bar=baz')
+      h.keys.length.should == 3
+      h['appkey'].should == 'Test'
+      h['id'].should == 'http://xkcd.com/530?utm=a'
+      h['bar'].should == 'baz'
+    end
+  end
 end

metadata

@@ -1,12 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: query_string_parser
 version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 0
-  - 1
-  - 0
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors: 
 - dan sinclair
@@ -14,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-06-15 00:00:00 -04:00
+date: 2010-09-02 00:00:00 -04:00
 default_executable: 
 dependencies: []
 
@@ -25,14 +20,17 @@ executables: []
 extensions: 
 - ext/extconf.rb
 - ext/extconf.rb
-extra_rdoc_files: []
-
+extra_rdoc_files: 
+- LICENSE
+- README
 files: 
 - Rakefile
 - ext/extconf.rb
 - ext/pr_query_parser.c
 - lib/query_string_parser.rb
 - spec/query_string_parser_spec.rb
+- LICENSE
+- README
 has_rdoc: true
 homepage: http://github.com/dj2/query_string_parser
 licenses: []
@@ -46,20 +44,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
+  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
+  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: Simple query string parser