que 0.14.1 → 0.14.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: dad50627f82edb14529d66b00f009f61f8cce6ad
-  data.tar.gz: 5644e3ae8518c25e14ddc3381973dc81374e32f4
+SHA256:
+  metadata.gz: 91851179dace9028e7617410ea3214b2f465aa20399db4714c91aa533682a326
+  data.tar.gz: 42935a8c9b1d8c709b7e39c590d2d1b062474dc509c66c0e5e87650bf40b39ac
 SHA512:
-  metadata.gz: b4f23840e1d4c2143d9fe66a672659421af2a01f321a5a29abf9019f1b79c57a91832f6211c2d0dfd6a793c9e9ba7cc6d8ae44f5d4d925844106f6af7b1193d1
-  data.tar.gz: 203489a4d1e2fbcd3b6c6e3f4e54f5e9c5cb0df11b32f392fc65a5a5feae969694001e4fdfbf778afb4a50dddc666054e23bc7704b22f273c2a006aca6c3f5e0
+  metadata.gz: 2635539c039b7e30736d8032bf8c27210624b98695f98c30053dff29345cc6368eb864315b32a41ea79a8af7a91f0c76c89924e73b652fe4edc08f15b1b65e41
+  data.tar.gz: 28d797216ae91e9cc15aee815c51308432f45d87dbc9cfc966d500496eec4efecb018c99dcf19fc0edb46bdd925ca35967eb10da325dfde642dafceb5f38297b

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+### 0.14.2 (2018-01-05)
+
+*   Deprecate the Que.disable_prepared_statements= accessors.
+
+*   Add Que.use_prepared_statements= configuration accessors.
+
+*   Update the generated Rails migration to declare a version. (NARKOZ)
+
 ### 0.14.1 (2017-12-14)
 
 *   Fix a bug with typecasting boolean values on Rails 5+.

data/README.md

@@ -111,6 +111,7 @@ To determine what happens when a job is queued, you can set Que's mode. There ar
 
   * [que-web](https://github.com/statianzo/que-web) is a Sinatra-based UI for inspecting your job queue.
   * [que-testing](https://github.com/statianzo/que-testing) allows making assertions on enqueued jobs.
+  * [que-scheduler](https://github.com/hlascelles/que-scheduler) is a cron scheduler for Que jobs that runs on Que itself.
   * [que-go](https://github.com/bgentry/que-go) is a port of Que for the Go programming language. It uses the same table structure, so that you can use the same job queue from Ruby and Go applications.
   * [wisper-que](https://github.com/joevandyk/wisper-que) adds support for Que to [wisper](https://github.com/krisleech/wisper).
 

data/lib/generators/que/templates/add_que.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class AddQue < ActiveRecord::Migration
+class AddQue < ActiveRecord::Migration[4.2]
   def self.up
     # The current version as of this migration's creation.
     Que.migrate! :version => 3

data/lib/que.rb

@@ -42,7 +42,7 @@ module Que
 
   class << self
     attr_accessor :error_notifier
-    attr_writer :logger, :adapter, :log_formatter, :disable_prepared_statements, :json_converter
+    attr_writer :logger, :adapter, :log_formatter, :use_prepared_statements, :json_converter
 
     def connection=(connection)
       self.adapter =
@@ -126,8 +126,19 @@ module Que
       @log_formatter ||= JSON.method(:dump)
     end
 
+    def use_prepared_statements
+      setting = @use_prepared_statements
+      setting.nil? ? true : setting
+    end
+
     def disable_prepared_statements
-      @disable_prepared_statements || false
+      warn "Que.disable_prepared_statements has been deprecated, please update your code to invert the result of Que.disable_prepared_statements instead. This shim will be removed in Que version 1.0.0."
+      !use_prepared_statements
+    end
+
+    def disable_prepared_statements=(setting)
+      warn "Que.disable_prepared_statements= has been deprecated, please update your code to pass the inverted value to Que.use_prepared_statements= instead. This shim will be removed in Que version 1.0.0."
+      self.use_prepared_statements = !setting
     end
 
     def error_handler

data/lib/que/adapters/base.rb

@@ -67,7 +67,7 @@ module Que
         checkout do |conn|
           # Prepared statement errors have the potential to foul up the entire
           # transaction, so if we're in one, err on the side of safety.
-          return execute_sql(SQL[name], params) if Que.disable_prepared_statements || in_transaction?
+          return execute_sql(SQL[name], params) if !Que.use_prepared_statements || in_transaction?
 
           statements = @prepared_statements[conn] ||= {}
 

data/lib/que/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Que
-  Version = '0.14.1'
+  Version = '0.14.2'
 end

data/spec/unit/configuration_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Que do
+  it ".use_prepared_statements should be the opposite of disable_prepared_statements" do
+    original_verbose = $VERBOSE
+    $VERBOSE = nil
+
+    Que.use_prepared_statements.should == true
+    Que.disable_prepared_statements.should == false
+
+    Que.disable_prepared_statements = true
+    Que.use_prepared_statements.should == false
+    Que.disable_prepared_statements.should == true
+
+    Que.disable_prepared_statements = nil
+    Que.use_prepared_statements.should == true
+    Que.disable_prepared_statements.should == false
+
+    Que.use_prepared_statements = false
+    Que.use_prepared_statements.should == false
+    Que.disable_prepared_statements.should == true
+
+    Que.use_prepared_statements = true
+    Que.use_prepared_statements.should == true
+    Que.disable_prepared_statements.should == false
+
+    $VERBOSE = original_verbose
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: que
 version: !ruby/object:Gem::Version
-  version: 0.14.1
+  version: 0.14.2
 platform: ruby
 authors:
 - Chris Hanks
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-15 00:00:00.000000000 Z
+date: 2018-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -91,6 +91,7 @@ files:
 - spec/support/jobs.rb
 - spec/support/shared_examples/adapter.rb
 - spec/support/shared_examples/multi_threaded_adapter.rb
+- spec/unit/configuration_spec.rb
 - spec/unit/connection_spec.rb
 - spec/unit/customization_spec.rb
 - spec/unit/enqueue_spec.rb
@@ -127,7 +128,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: A PostgreSQL-based Job Queue
@@ -146,6 +147,7 @@ test_files:
 - spec/support/jobs.rb
 - spec/support/shared_examples/adapter.rb
 - spec/support/shared_examples/multi_threaded_adapter.rb
+- spec/unit/configuration_spec.rb
 - spec/unit/connection_spec.rb
 - spec/unit/customization_spec.rb
 - spec/unit/enqueue_spec.rb