que 0.10.0 → 0.11.0

data/spec/unit/customization_spec.rb

@@ -185,4 +185,65 @@ describe "Customizing Que" do
       end
     end
   end
+
+  describe "not retrying specific failed jobs" do
+    before do
+      Que.execute "CREATE TABLE failed_jobs AS SELECT * FROM que_jobs LIMIT 0"
+    end
+
+    after do
+      DB.drop_table? :failed_jobs
+    end
+
+    it "should be easily achievable with a module" do
+      begin
+        module SkipRetries
+          def run(*args)
+            super
+          rescue
+            sql = <<-SQL
+              WITH failed AS (
+                DELETE
+                FROM   que_jobs
+                WHERE  queue    = $1::text
+                AND    priority = $2::smallint
+                AND    run_at   = $3::timestamptz
+                AND    job_id   = $4::bigint
+                RETURNING *
+              )
+              INSERT INTO failed_jobs
+                SELECT * FROM failed;
+            SQL
+
+            Que.execute sql, @attrs.values_at(:queue, :priority, :run_at, :job_id)
+
+            raise
+          end
+        end
+
+        class SkipRetryJob < Que::Job
+          prepend SkipRetries
+
+          def run(*args)
+            $retry_job_args = args
+            raise "Fail!"
+          end
+        end
+
+        SkipRetryJob.enqueue 1, 'arg1', :other_arg => 'blah'
+        Que::Job.work
+
+        $retry_job_args.should == [1, 'arg1', {'other_arg' => 'blah'}]
+
+        DB[:que_jobs].count.should == 0
+        DB[:failed_jobs].count.should == 1
+
+        job = DB[:failed_jobs].first
+        JSON.parse(job[:args]).should == [1, 'arg1', {'other_arg' => 'blah'}]
+        job[:job_class].should == 'SkipRetryJob'
+      ensure
+        $retry_job_args = nil
+      end
+    end
+  end
 end

data/spec/unit/pool_spec.rb

@@ -103,12 +103,12 @@ describe "Managing the Worker pool" do
         sleep_until { DB[:que_jobs].count == 0 }
       end
 
-      it "should work jobs in the queue defined by QUE_QUEUE" do
+      it "should work jobs in the queue defined by the Que.queue_name config option" do
         begin
           Que::Job.enqueue 1
           Que::Job.enqueue 2, :queue => 'my_queue'
 
-          ENV['QUE_QUEUE'] = 'my_queue'
+          Que.queue_name = 'my_queue'
 
           Que.mode = :async
           Que.worker_count = 2
@@ -120,7 +120,7 @@ describe "Managing the Worker pool" do
           job[:queue].should == ''
           job[:args].should == '[1]'
         ensure
-          ENV.delete('QUE_QUEUE')
+          Que.queue_name = nil
         end
       end
     end

data/spec/unit/work_spec.rb

@@ -14,6 +14,24 @@ describe Que::Job, '.work' do
     $passed_args.should == [1, 'two', {'three' => 3}]
   end
 
+  it "should respect a custom json converter when processing the job's arguments" do
+    ArgsJob.enqueue 1, 'two', {'three' => 3}
+    DB[:que_jobs].count.should be 1
+
+    begin
+      Que.json_converter = Que::SYMBOLIZER
+
+      result = Que::Job.work
+      result[:event].should == :job_worked
+      result[:job][:job_class].should == 'ArgsJob'
+
+      DB[:que_jobs].count.should be 0
+      $passed_args.should == [1, 'two', {:three => 3}]
+    ensure
+      Que.json_converter = Que::INDIFFERENTIATOR
+    end
+  end
+
   it "should default to only working jobs without a named queue" do
     Que::Job.enqueue 1, :queue => 'other_queue'
     Que::Job.enqueue 2

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: que
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Chris Hanks
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-18 00:00:00.000000000 Z
+date: 2015-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -27,7 +27,8 @@ dependencies:
 description: A job queue that uses PostgreSQL's advisory locks for speed and reliability.
 email:
 - christopher.m.hanks@gmail.com
-executables: []
+executables:
+- que
 extensions: []
 extra_rdoc_files: []
 files:
@@ -39,6 +40,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- bin/que
 - docs/advanced_setup.md
 - docs/customizing_que.md
 - docs/error_handling.md
@@ -123,7 +125,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: A PostgreSQL-based Job Queue