quby-compiler 0.4.8 → 0.4.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 886ce60c1b1c37de0dfdbb8d0b14b4c2ed2574f873a2230ff50e80413e50c031
-  data.tar.gz: ee12f0733d624ffea8061b4f9f7bcbcdea9c904eb05d9b1e426b9f646bae91da
+  metadata.gz: 8b2f73a073de0f20b5dfd57b8e8c3b65c1878abce2cb109e67fe1cc302900b02
+  data.tar.gz: fec490f89c77a497fbac304a381e150aec1fc8e8e4e06950aff20424561fb69c
 SHA512:
-  metadata.gz: d24325dcee35fafd2d99d65bc6761eb7fa764efe2c5b549208e5130b3b0218bdc2dbf9e932886f1f05a8ac9461236dd398e9d8d733a4a715c2a62fddeb768da0
-  data.tar.gz: 0d45e85ea11b5c03710011aff584bf6df363f140184519e6a5c374651e516599a7667921560b41d3870b4c3ef98a55cfc097550aba39199f4be233001453e0fc
+  metadata.gz: 70bbcf09fa8b4d789ec22eaebb06b46a10bbdfcf5a5125f205f26307cceb471aef5c1e5e30a5b7ea510f64a304a59e21a40c64b3c40dde6935f291f04237e6de
+  data.tar.gz: 887f84082878e3a49dda34d8c92f62db3849e5ee716e0a69f9d1b92c1543cc1a3fe21fd65c5603c7703ce4168404dab75fc191f4999bd0aeeb032137d41e50e4

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+# 0.4.11
+
+* roqua.json: Baseline for a chart now always exports as a hash of gender/age => value
+
+# 0.4.10
+
+* quby2.json: Fix validations json (regex-serialization and key-capitalization)
+* roqua.json: Change questions, options, date_parts, scores, subscores and outcome_tables from hash to array, since ordering is important and not all systems preserve the order of  hashes (like pg's jsonb)
+
+#  0.4.9
+
+* roqua.json: Fix html stripping for string with no whitespace
+
 # 0.4.8
 
 * roqua.json: 

data/lib/quby/compiler/entities/questionnaire.rb

@@ -209,7 +209,6 @@ module Quby
             fields: fields.as_json,
             flags: flags,
             textvars: textvars,
-            validations: validations,
             visibilityRules: visibility_rules
           }
         end

data/lib/quby/compiler/outputs/quby_frontend_v2_serializer.rb

@@ -6,10 +6,23 @@ module Quby
           @questionnaire = questionnaire
         end
 
+        # TODO: Move all attributes here from Questionnaire#as_json
         def as_json(options = {})
-          @questionnaire.as_json
+          @questionnaire.as_json.merge \
+            validations: validations
+        end
+
+        def validations
+          @questionnaire.validations.map do |validation|
+            validation.config.compact
+              .transform_keys{ _1.to_s.camelize(:lower) }
+              .tap do |validation_hsh|
+                # otherwise ruby will put a (?-mix around the regex, which js errors on.
+                validation_hsh['matcher'] = validation_hsh['matcher'].source.to_s  if validation_hsh['matcher']
+              end.as_json
+          end
         end
       end
     end
   end
-end
+end

data/lib/quby/compiler/outputs/roqua_serializer.rb

@@ -60,9 +60,8 @@ module Quby
               case chart
               when Quby::Compiler::Entities::Charting::LineChart
                 {
-                  y_label: chart.y_label,
                   tonality: chart.tonality,
-                  baseline: YAML.dump(chart.baseline),
+                  baseline: chart_baseline(chart.baseline),
                   clinically_relevant_change: chart.clinically_relevant_change,
                 }
               when Quby::Compiler::Entities::Charting::OverviewChart
@@ -89,6 +88,17 @@ module Quby
           }
         end
 
+        def chart_baseline(baseline)
+          case baseline
+          when nil
+            nil
+          when Float, Integer
+            {default: {default: baseline}}
+          when Hash
+            baseline
+          end
+        end
+
         # configuration for outcome tables.
         # tables:
         #   <outcome_table_name:Symbol>: # each entry is a table.
@@ -107,15 +117,18 @@ module Quby
 
         def outcome_tables_from_definition
           # hash of tables, with the score keys (rows) and subscore keys (columns) used for each
-          tables = {}
+          tables = []
           # hash of `subscore_key: subscore_label` pairs used in tables
           headers = {}
 
           questionnaire.outcome_tables.each do |table|
-            tables[table.key] = {name: table.name,
-                                 default_collapsed: table.default_collapsed,
-                                 score_keys: table.score_keys,
-                                 subscore_keys: table.subscore_keys}.compact
+            tables << {
+              key: table.key,
+              name: table.name,
+              default_collapsed: table.default_collapsed,
+              score_keys: table.score_keys,
+              subscore_keys: table.subscore_keys
+            }.compact
 
             table.subscore_keys.each do |subscore_key|
               table.score_keys.find do |score_key|
@@ -142,6 +155,7 @@ module Quby
           questionnaire.score_schemas.values.each do |schema|
             schema.subscore_schemas.each do |subschema|
               next if subschema.outcome_table.blank?
+              tables[subschema.outcome_table][:key] = subschema.outcome_table
               tables[subschema.outcome_table][:subscore_keys] << subschema.key
               tables[subschema.outcome_table][:score_keys] << schema.key
               headers[subschema.key] = subschema.label
@@ -150,7 +164,7 @@ module Quby
 
           {
             headers: headers,
-            tables: tables,
+            tables: tables.values,
           }
         end
 
@@ -170,25 +184,22 @@ module Quby
         # date_parts [nil/{..}]
         # options: [nil/{..}]
         def questions
-          questionnaire.sorted_questions.reject{_1.type == :hidden}.to_h { |question|
-            [
-              question.key,
-              {
-                key: question.key,
-                sbg_key: question.sbg_key,
-                type: QUBY_TYPE_TO_ROQUA_TYPE.fetch(question.type),
-                title: parse_markdown_and_strip_tags(question.title),
-                context_free_title: question.context_free_title,
-                unit: question.unit,
-                deprecated: question.hidden.presence,
-                default_invisible: question.default_invisible.presence,
-                parent_question_key: question.parent&.key,
-                parent_option_key: question.parent_option_key,
-                title_question_key: question.title_question&.key,
-                date_parts: date_parts_for(question),
-                options: options_for(question)
-              }.compact
-            ]
+          questionnaire.sorted_questions.reject{_1.type == :hidden}.map { |question|
+            {
+              key: question.key,
+              sbg_key: question.sbg_key,
+              type: QUBY_TYPE_TO_ROQUA_TYPE.fetch(question.type),
+              title: parse_markdown_and_strip_tags(question.title),
+              context_free_title: question.context_free_title,
+              unit: question.unit,
+              deprecated: question.hidden.presence,
+              default_invisible: question.default_invisible.presence,
+              parent_question_key: question.parent&.key,
+              parent_option_key: question.parent_option_key,
+              title_question_key: question.title_question&.key,
+              date_parts: date_parts_for(question),
+              options: options_for(question)
+            }.compact
           }
         end
 
@@ -197,13 +208,11 @@ module Quby
         def date_parts_for(question)
           return nil unless question.type == :date
 
-          question.components.to_h { |component|
-            [
-              component,
-              {
-                key: question.send("#{component}_key")
-              }
-            ]
+          question.components.map { |component|
+            {
+              part: component,
+              key: question.send("#{component}_key")
+            }
           }
         end
 
@@ -216,22 +225,19 @@ module Quby
           return nil if question.options.empty?
 
           question.options.reject { |option| option.inner_title || option.placeholder }
-                          .to_h { |option|
-            [
-              option.key,
-              {
-                key: option.key,
-                value: (option.value.to_s unless question.type == :check_box),
-                description: option.context_free_description || parse_markdown_and_strip_tags(option.description),
-                child_question_keys: option.questions.map(&:key).presence
-              }.compact
-            ]
+                          .map { |option|
+            {
+              key: option.key,
+              value: (option.value.to_s unless question.type == :check_box),
+              description: option.context_free_description || parse_markdown_and_strip_tags(option.description),
+              child_question_keys: option.questions.map(&:key).presence
+            }.compact
           }
         end
 
         # [{ key: { ..,  subscores: { subkey: {..} } } }]
         def scores
-          questionnaire.score_schemas.transform_values { |score|
+          questionnaire.score_schemas.values.map { |score|
             {
               key: score.key,
               label: score.label,
@@ -242,16 +248,13 @@ module Quby
 
         # { subkey: {..} }
         def subscores_for(score)
-          score.subscore_schemas.to_h { |subscore|
-            [
-              subscore.key,
-              {
-                key: subscore.key,
-                label: subscore.label,
-                export_key: subscore.export_key,
-                only_for_export: subscore.only_for_export.presence
-              }.compact
-            ]
+          score.subscore_schemas.map { |subscore|
+            {
+              key: subscore.key,
+              label: subscore.label,
+              export_key: subscore.export_key,
+              only_for_export: subscore.only_for_export.presence
+            }.compact
           }
         end
 
@@ -264,7 +267,7 @@ module Quby
             doc.css('br, hr, img').each { |node| node.replace(' ') }
           end \
             .text
-            .gsub!(/\s+/, ' ')
+            .gsub(/\s+/, ' ')
             .presence
         end
       end

data/lib/quby/compiler/services/definition_validator.rb

@@ -137,14 +137,14 @@ module Quby
           unknown_questions = flag.shows_questions.select { |key| !questionnaire.key_in_use?(key) }
           return if unknown_questions.blank?
 
-          fail ArgumentError, "Flag '#{key}' has unknown shows_questions keys #{unknown_questions}"
+          fail ArgumentError, "Flag '#{flag.key}' has unknown shows_questions keys #{unknown_questions}"
         end
 
         def validate_flag_hides(questionnaire, flag)
           unknown_questions = flag.hides_questions.select { |key| !questionnaire.key_in_use?(key) }
           return if unknown_questions.blank?
 
-          fail ArgumentError, "Flag '#{key}' has unknown hides_questions keys #{unknown_questions}"
+          fail ArgumentError, "Flag '#{flag.key}' has unknown hides_questions keys #{unknown_questions}"
         end
 
         def validate_flag_depends_on(questionnaire, flag)

data/lib/quby/compiler/version.rb

@@ -1,5 +1,5 @@
 module Quby
   module Compiler
-    VERSION = "0.4.8"
+    VERSION = "0.4.11"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quby-compiler
 version: !ruby/object:Gem::Version
-  version: 0.4.8
+  version: 0.4.11
 platform: ruby
 authors:
 - Marten Veldthuis
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-02-16 00:00:00.000000000 Z
+date: 2022-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel