qubole-statsd-instrument 2.1.4

data/test/assertions_test.rb

@@ -0,0 +1,329 @@
+require 'test_helper'
+
+class AssertionsTest < Minitest::Test
+  def setup
+    test_class = Class.new(Minitest::Test)
+    test_class.send(:include, StatsD::Instrument::Assertions)
+    @test_case = test_class.new('fake')
+  end
+
+  def test_assert_no_statsd_calls
+    assert_no_assertion_triggered do
+      @test_case.assert_no_statsd_calls('counter') do
+        # noop
+      end
+    end
+
+    assert_no_assertion_triggered do
+      @test_case.assert_no_statsd_calls('counter') do
+        StatsD.increment('other')
+      end
+    end
+
+    assert_assertion_triggered("No StatsD calls for metric counter expected.") do
+      @test_case.assert_no_statsd_calls('counter') do
+        StatsD.increment('counter')
+      end
+    end
+
+    assert_assertion_triggered("No StatsD calls for metric other expected.") do
+      @test_case.assert_no_statsd_calls do
+        StatsD.increment('other')
+      end
+    end
+
+    assert_assertion_triggered("No StatsD calls for metric other, another expected.") do
+      @test_case.assert_no_statsd_calls do
+        StatsD.increment('other')
+        StatsD.increment('another')
+      end
+    end
+  end
+
+  def test_assert_statsd_call
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter') do
+        StatsD.increment('counter')
+      end
+    end
+
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter') do
+        StatsD.increment('counter')
+        StatsD.increment('other')
+      end
+    end
+
+    assert_assertion_triggered do
+      @test_case.assert_statsd_increment('counter') do
+        StatsD.increment('other')
+      end
+    end
+
+    assert_assertion_triggered do
+      @test_case.assert_statsd_increment('counter') do
+        StatsD.gauge('counter', 42)
+      end
+    end
+
+    assert_assertion_triggered do
+      @test_case.assert_statsd_increment('counter') do
+        StatsD.increment('counter')
+        StatsD.increment('counter')
+      end
+    end
+
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', times: 2) do
+        StatsD.increment('counter')
+        StatsD.increment('counter')
+      end
+    end
+
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', times: 2, tags: ['foo:1']) do
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 1 })
+      end
+    end
+
+    assert_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', times: 2, tags: ['foo:1']) do
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 2 })
+      end
+    end
+
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', sample_rate: 0.5, tags: ['a', 'b']) do
+        StatsD.increment('counter', sample_rate: 0.5, tags: ['a', 'b'])
+      end
+    end
+
+    assert_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', sample_rate: 0.5, tags: ['a', 'b'], ignore_tags: ['b']) do
+        StatsD.increment('counter', sample_rate: 0.5, tags: ['a'])
+      end
+    end
+
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', sample_rate: 0.5, tags: ['a'], ignore_tags: ['b']) do
+        StatsD.increment('counter', sample_rate: 0.5, tags: ['a', 'b'])
+      end
+    end
+
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', sample_rate: 0.5, tags: ['a'], ignore_tags: ['b']) do
+        StatsD.increment('counter', sample_rate: 0.5, tags: ['a'])
+      end
+    end
+
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', sample_rate: 0.5, tags: { a: 1 }, ignore_tags: { b: 2 }) do
+        StatsD.increment('counter', sample_rate: 0.5, tags: { a: 1, b: 2 })
+      end
+    end
+
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', sample_rate: 0.5, tags: { a: 1 }, ignore_tags: { b: 2 }) do
+        StatsD.increment('counter', sample_rate: 0.5, tags: { a: 1, b: 3 })
+      end
+    end
+
+    assert_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', sample_rate: 0.5, tags: { a: 1, b: 3 }, ignore_tags: ['b']) do
+        StatsD.increment('counter', sample_rate: 0.5, tags: { a: 1, b: 2 })
+      end
+    end
+
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', sample_rate: 0.5, tags: { a: 1 }, ignore_tags: ['b']) do
+        StatsD.increment('counter', sample_rate: 0.5, tags: { a: 1, b: 2 })
+      end
+    end
+
+    assert_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', sample_rate: 0.5, tags: ['a', 'b']) do
+        StatsD.increment('counter', sample_rate: 0.2, tags: ['c'])
+      end
+    end
+  end
+
+  def test_tags_will_match_subsets
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', sample_rate: 0.5, tags: { a: 1 }) do
+        StatsD.increment('counter', sample_rate: 0.5, tags: { a: 1, b: 2 })
+      end
+    end
+
+    assert_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', sample_rate: 0.5, tags: { a: 1, b: 3 }) do
+        StatsD.increment('counter', sample_rate: 0.5, tags: { a: 1, b: 2, c: 4 })
+      end
+    end
+  end
+
+  def test_multiple_metrics_are_not_order_dependent
+    assert_no_assertion_triggered do
+      foo_1_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 1, tags: ['foo:1'])
+      foo_2_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 1, tags: ['foo:2'])
+      @test_case.assert_statsd_calls([foo_1_metric, foo_2_metric]) do
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 2 })
+      end
+    end
+
+    assert_no_assertion_triggered do
+      foo_1_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 1, tags: ['foo:1'])
+      foo_2_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 1, tags: ['foo:2'])
+      @test_case.assert_statsd_calls([foo_2_metric, foo_1_metric]) do
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 2 })
+      end
+    end
+
+    assert_no_assertion_triggered do
+      foo_1_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 2, tags: ['foo:1'])
+      foo_2_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 1, tags: ['foo:2'])
+      @test_case.assert_statsd_calls([foo_1_metric, foo_2_metric]) do
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 2 })
+      end
+    end
+
+    assert_no_assertion_triggered do
+      foo_1_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 2, tags: ['foo:1'])
+      foo_2_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 1, tags: ['foo:2'])
+      @test_case.assert_statsd_calls([foo_2_metric, foo_1_metric]) do
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 2 })
+      end
+    end
+
+    assert_no_assertion_triggered do
+      foo_1_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 2, tags: ['foo:1'])
+      foo_2_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 1, tags: ['foo:2'])
+      @test_case.assert_statsd_calls([foo_2_metric, foo_1_metric]) do
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 2 })
+        StatsD.increment('counter', tags: { foo: 1 })
+      end
+    end
+  end
+
+  def test_assert_multiple_statsd_calls
+    assert_assertion_triggered do
+      foo_1_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 2, tags: ['foo:1'])
+      foo_2_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 1, tags: ['foo:2'])
+      @test_case.assert_statsd_calls([foo_1_metric, foo_2_metric]) do
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 2 })
+      end
+    end
+
+    assert_assertion_triggered do
+      foo_1_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 2, tags: ['foo:1'])
+      foo_2_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 1, tags: ['foo:2'])
+      @test_case.assert_statsd_calls([foo_1_metric, foo_2_metric]) do
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 2 })
+        StatsD.increment('counter', tags: { foo: 2 })
+      end
+    end
+
+    assert_no_assertion_triggered do
+      foo_1_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 2, tags: ['foo:1'])
+      foo_2_metric = StatsD::Instrument::MetricExpectation.new(type: :c, name: 'counter', times: 1, tags: ['foo:2'])
+      @test_case.assert_statsd_calls([foo_1_metric, foo_2_metric]) do
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 1 })
+        StatsD.increment('counter', tags: { foo: 2 })
+      end
+    end
+  end
+
+  def test_assert_statsd_call_with_tags
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', tags: ['a:b', 'c:d']) do
+        StatsD.increment('counter', tags: { a: 'b', c: 'd' })
+      end
+    end
+
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter', tags: { a: 'b', c: 'd' }) do
+        StatsD.increment('counter', tags: ['a:b', 'c:d'])
+      end
+    end
+  end
+
+  def test_assert_statsd_call_with_wrong_sample_rate_type
+    assert_assertion_triggered "Unexpected sample rate type for metric counter, must be numeric" do
+      @test_case.assert_statsd_increment('counter', tags: ['a', 'b']) do
+        StatsD.increment('counter', sample_rate: 'abc', tags:  ['a', 'b'])
+      end
+    end
+  end
+
+  def test_nested_assertions
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter1') do
+        @test_case.assert_statsd_increment('counter2') do
+          StatsD.increment('counter1')
+          StatsD.increment('counter2')
+        end
+      end
+    end
+
+    assert_no_assertion_triggered do
+      @test_case.assert_statsd_increment('counter1') do
+        StatsD.increment('counter1')
+        @test_case.assert_statsd_increment('counter2') do
+          StatsD.increment('counter2')
+        end
+      end
+    end
+
+    assert_assertion_triggered do
+      @test_case.assert_statsd_increment('counter1') do
+        @test_case.assert_statsd_increment('counter2') do
+          StatsD.increment('counter2')
+        end
+      end
+    end
+
+    assert_assertion_triggered do
+      @test_case.assert_statsd_increment('counter1') do
+        @test_case.assert_statsd_increment('counter2') do
+          StatsD.increment('counter1')
+        end
+        StatsD.increment('counter2')
+      end
+    end
+  end
+
+  private
+
+  def assert_no_assertion_triggered(&block)
+    block.call
+  rescue MiniTest::Assertion => assertion
+    flunk "No assertion trigger expected, but one was triggered with message #{assertion.message}."
+  else
+    pass
+  end
+
+  def assert_assertion_triggered(message = nil, &block)
+    block.call
+  rescue MiniTest::Assertion => assertion
+    if message
+      assert_equal message, assertion.message, "Assertion triggered, but message was not what was expected."
+    else
+      pass
+    end
+    assertion
+  else
+    flunk "No assertion was triggered, but one was expected."
+  end
+end

data/test/benchmark/tags.rb

@@ -0,0 +1,34 @@
+require 'statsd-instrument'
+require 'benchmark/ips'
+
+Benchmark.ips do |bench|
+  bench.report("normalized tags with simple hash") do
+    StatsD::Instrument::Metric.normalize_tags(:tag => 'value')
+  end
+
+  bench.report("normalized tags with simple array") do
+    StatsD::Instrument::Metric.normalize_tags(['test:test'])
+  end
+
+  bench.report("normalized tags with large hash") do
+    StatsD::Instrument::Metric.normalize_tags({
+      mobile: true,
+      pod: "1",
+      protocol: "https",
+      country: "Langbortistan",
+      complete: true,
+      shop: "omg shop that has a longer name",
+    })
+  end
+
+  bench.report("normalized tags with large array") do
+    StatsD::Instrument::Metric.normalize_tags([
+      "mobile:true",
+      "pod:1",
+      "protocol:https",
+      "country:Langbortistan",
+      "complete:true",
+      "shop:omg_shop_that_has_a_longer_name",
+    ])
+  end
+end

data/test/capture_backend_test.rb

@@ -0,0 +1,24 @@
+require 'test_helper'
+
+class CaptureBackendTest < Minitest::Test
+  def setup
+    @backend = StatsD::Instrument::Backends::CaptureBackend.new
+    @metric1 = StatsD::Instrument::Metric::new(type: :c, name: 'mock.counter')
+    @metric2 = StatsD::Instrument::Metric::new(type: :ms, name: 'mock.measure', value: 123)
+  end
+
+  def test_collecting_metric
+    assert @backend.collected_metrics.empty?
+    @backend.collect_metric(@metric1)
+    @backend.collect_metric(@metric2)
+    assert_equal [@metric1, @metric2], @backend.collected_metrics
+  end
+
+  def test_reset
+    @backend.collect_metric(@metric1)
+    @backend.reset
+    assert @backend.collected_metrics.empty?
+    @backend.collect_metric(@metric2)
+    assert_equal [@metric2], @backend.collected_metrics
+  end
+end

data/test/environment_test.rb

@@ -0,0 +1,46 @@
+require 'test_helper'
+
+module Rails; end
+
+class EnvironmentTest < Minitest::Test
+
+  def setup
+    ENV['STATSD_ADDR'] = nil
+    ENV['IMPLEMENTATION'] = nil
+  end
+
+  def test_uses_logger_in_development_environment
+    StatsD::Instrument::Environment.stubs(:environment).returns('development')
+    assert_instance_of StatsD::Instrument::Backends::LoggerBackend, StatsD::Instrument::Environment.default_backend
+  end
+
+  def test_uses_null_backend_in_test_environment
+    StatsD::Instrument::Environment.stubs(:environment).returns('test')
+    assert_instance_of StatsD::Instrument::Backends::NullBackend, StatsD::Instrument::Environment.default_backend
+  end
+
+  def test_uses_udp_backend_in_production_environment
+    StatsD::Instrument::Environment.stubs(:environment).returns('production')
+    assert_instance_of StatsD::Instrument::Backends::UDPBackend, StatsD::Instrument::Environment.default_backend
+  end
+
+  def test_uses_environment_variables_in_production_environment
+    StatsD::Instrument::Environment.stubs(:environment).returns('production')
+    ENV['STATSD_ADDR'] = '127.0.0.1:1234'
+    ENV['STATSD_IMPLEMENTATION'] = 'datadog'
+
+    backend = StatsD::Instrument::Environment.default_backend
+    assert_equal '127.0.0.1', backend.host
+    assert_equal 1234, backend.port
+    assert_equal :datadog, backend.implementation
+  end
+
+  def test_uses_env_when_rails_does_not_respond_to_env
+    assert_equal ENV['ENV'], StatsD::Instrument::Environment.environment
+  end
+
+  def test_uses_rails_env_when_rails_is_available
+    Rails.stubs(:env).returns('production')
+    assert_equal 'production', StatsD::Instrument::Environment.environment
+  end
+end

data/test/helpers_test.rb

@@ -0,0 +1,24 @@
+require 'test_helper'
+
+class HelpersTest < Minitest::Test
+  def setup
+    test_class = Class.new(Minitest::Test)
+    test_class.send(:include, StatsD::Instrument::Helpers)
+    @test_case = test_class.new('fake')
+  end
+
+  def test_capture_metrics_inside_block_only
+    StatsD.increment('counter')
+    metrics = @test_case.capture_statsd_calls do
+      StatsD.increment('counter')
+      StatsD.gauge('gauge', 12)
+    end
+    StatsD.gauge('gauge', 15)
+
+    assert_equal 2, metrics.length
+    assert_equal 'counter', metrics[0].name
+    assert_equal 'gauge', metrics[1].name
+    assert_equal 12, metrics[1].value
+  end
+end
+

data/test/integration_test.rb

@@ -0,0 +1,20 @@
+require 'test_helper'
+
+class IntegrationTest < Minitest::Test
+
+  def setup
+    @old_backend, StatsD.backend = StatsD.backend, StatsD::Instrument::Backends::UDPBackend.new("localhost:31798")
+  end
+  
+  def teardown
+    StatsD.backend = @old_backend
+  end
+
+  def test_live_local_udp_socket
+    server = UDPSocket.new
+    server.bind('localhost', 31798)
+
+    StatsD.increment('counter')
+    assert_equal "counter:1|c", server.recvfrom(100).first
+  end
+end

data/test/logger_backend_test.rb

@@ -0,0 +1,20 @@
+require 'test_helper'
+
+class LoggerBackendTest < Minitest::Test
+  def setup
+    logger = Logger.new(@io = StringIO.new)
+    logger.formatter = lambda { |_,_,_, msg| "#{msg}\n" }
+    @backend = StatsD::Instrument::Backends::LoggerBackend.new(logger)
+    @metric1 = StatsD::Instrument::Metric::new(type: :c, name: 'mock.counter', tags: { a: 'b', c: 'd'})
+    @metric2 = StatsD::Instrument::Metric::new(type: :ms, name: 'mock.measure', value: 123, sample_rate: 0.3)
+  end
+
+  def test_logs_metrics
+    @backend.collect_metric(@metric1)
+    assert_equal @io.string, "[StatsD] increment mock.counter:1 #a:b #c:d\n"
+    @io.string = ""
+
+    @backend.collect_metric(@metric2)
+    assert_equal @io.string, "[StatsD] measure mock.measure:123 @0.3\n"
+  end
+end

data/test/matchers_test.rb

@@ -0,0 +1,102 @@
+require 'test_helper'
+require 'statsd/instrument/matchers'
+
+class MatchersTest < Minitest::Test
+  def test_statsd_increment_matched
+    assert StatsD::Instrument::Matchers::Increment.new(:c, 'counter', {}).matches? lambda { StatsD.increment('counter') }
+  end
+
+  def test_statsd_increment_not_matched
+    refute StatsD::Instrument::Matchers::Increment.new(:c, 'counter', {}).matches? lambda { StatsD.increment('not_counter') }
+  end
+
+  def test_statsd_increment_compound_matched
+    matcher_1 = StatsD::Instrument::Matchers::Increment.new(:c, 'counter', tags: ['a'])
+    matcher_2 = StatsD::Instrument::Matchers::Increment.new(:c, 'counter', tags: ['b'])
+
+    assert RSpec::Matchers::BuiltIn::Compound::And.new(matcher_1, matcher_2).matches? lambda {
+      StatsD.increment('counter', tags: ['a'])
+      StatsD.increment('counter', tags: ['b'])
+    }
+  end
+
+  def test_statsd_increment_compound_not_matched
+    matcher_1 = StatsD::Instrument::Matchers::Increment.new(:c, 'counter', tags: ['a'])
+    matcher_2 = StatsD::Instrument::Matchers::Increment.new(:c, 'counter', tags: ['b'])
+
+    refute RSpec::Matchers::BuiltIn::Compound::And.new(matcher_1, matcher_2).matches? lambda {
+      StatsD.increment('counter', tags: ['a'])
+      StatsD.increment('counter', tags: ['a'])
+    }
+  end
+
+  def test_statsd_increment_with_times_matched
+    assert StatsD::Instrument::Matchers::Increment.new(:c, 'counter', times: 1).matches? lambda { StatsD.increment('counter') }
+  end
+
+  def test_statsd_increment_with_times_not_matched
+    refute StatsD::Instrument::Matchers::Increment.new(:c, 'counter', times: 2).matches? lambda { StatsD.increment('counter', times: 3) }
+  end
+
+  def test_statsd_increment_with_sample_rate_matched
+    assert StatsD::Instrument::Matchers::Increment.new(:c, 'counter', sample_rate: 0.5).matches? lambda { StatsD.increment('counter', sample_rate: 0.5) }
+  end
+
+  def test_statsd_increment_with_sample_rate_not_matched
+    refute StatsD::Instrument::Matchers::Increment.new(:c, 'counter', sample_rate: 0.5).matches? lambda { StatsD.increment('counter', sample_rate: 0.7) }
+  end
+
+  def test_statsd_increment_with_value_matched
+    assert StatsD::Instrument::Matchers::Increment.new(:c, 'counter', value: 1).matches? lambda { StatsD.increment('counter') }
+  end
+
+  def test_statsd_increment_with_value_matched_when_multiple_metrics
+    assert StatsD::Instrument::Matchers::Increment.new(:c, 'counter', value: 1).matches? lambda {
+      StatsD.increment('counter', value: 2)
+      StatsD.increment('counter', value: 1)
+    }
+  end
+
+  def test_statsd_increment_with_value_not_matched_when_multiple_metrics
+    refute StatsD::Instrument::Matchers::Increment.new(:c, 'counter', value: 1).matches? lambda {
+      StatsD.increment('counter', value: 2)
+      StatsD.increment('counter', value: 3)
+    }
+  end
+
+  def test_statsd_increment_with_value_not_matched
+    refute StatsD::Instrument::Matchers::Increment.new(:c, 'counter', value: 3).matches? lambda { StatsD.increment('counter') }
+  end
+
+  def test_statsd_increment_with_tags_matched
+    assert StatsD::Instrument::Matchers::Increment.new(:c, 'counter', tags: ['a', 'b']).matches? lambda { StatsD.increment('counter', tags: ['a', 'b']) }
+  end
+
+  def test_statsd_increment_with_tags_not_matched
+    refute StatsD::Instrument::Matchers::Increment.new(:c, 'counter', tags: ['a', 'b']).matches? lambda { StatsD.increment('counter', tags: ['c']) }
+  end
+
+  def test_statsd_increment_with_times_and_value_matched
+    assert StatsD::Instrument::Matchers::Increment.new(:c, 'counter', times: 2, value: 1).matches? lambda {
+      StatsD.increment('counter', value: 1)
+      StatsD.increment('counter', value: 1)
+    }
+  end
+
+  def test_statsd_increment_with_times_and_value_not_matched
+    refute StatsD::Instrument::Matchers::Increment.new(:c, 'counter', times: 2, value: 1).matches? lambda {
+      StatsD.increment('counter', value: 1)
+      StatsD.increment('counter', value: 2)
+    }
+  end
+
+  def test_statsd_increment_with_sample_rate_and_argument_matcher_matched
+    between_matcher = RSpec::Matchers::BuiltIn::BeBetween.new(0.4, 0.6).inclusive
+    assert StatsD::Instrument::Matchers::Increment.new(:c, 'counter', sample_rate: between_matcher).matches? lambda { StatsD.increment('counter', sample_rate: 0.5) }
+  end
+
+  def test_statsd_increment_with_sample_rate_and_argument_matcher_not_matched
+    between_matcher = RSpec::Matchers::BuiltIn::BeBetween.new(0.4, 0.6).inclusive
+    refute StatsD::Instrument::Matchers::Increment.new(:c, 'counter', sample_rate: between_matcher).matches? lambda { StatsD.increment('counter', sample_rate: 0.7) }
+  end
+end

data/test/metric_test.rb

@@ -0,0 +1,45 @@
+require 'test_helper'
+
+class MetricTest < Minitest::Test
+
+  def test_required_arguments
+    assert_raises(ArgumentError) { StatsD::Instrument::Metric.new(type: :c) }
+    assert_raises(ArgumentError) { StatsD::Instrument::Metric.new(name: 'test') }
+    assert_raises(ArgumentError) { StatsD::Instrument::Metric.new(type: :ms, name: 'test') }
+  end
+
+  def test_default_values
+    m = StatsD::Instrument::Metric.new(type: :c, name: 'counter')
+    assert_equal 1, m.value
+    assert_equal StatsD.default_sample_rate, m.sample_rate
+    assert m.tags.nil?
+  end
+
+  def test_name_prefix
+    StatsD.stubs(:prefix).returns('prefix')
+    m = StatsD::Instrument::Metric.new(type: :c, name: 'counter')
+    assert_equal 'prefix.counter', m.name
+
+    m = StatsD::Instrument::Metric.new(type: :c, name: 'counter', no_prefix: true)
+    assert_equal 'counter', m.name
+  end
+
+  def test_bad_metric_name
+    m = StatsD::Instrument::Metric.new(type: :c, name: 'my:metric', no_prefix: true)
+    assert_equal 'my_metric', m.name
+    m = StatsD::Instrument::Metric.new(type: :c, name: 'my|metric', no_prefix: true)
+    assert_equal 'my_metric', m.name
+    m = StatsD::Instrument::Metric.new(type: :c, name: 'my@metric', no_prefix: true)
+    assert_equal 'my_metric', m.name
+  end
+
+  def test_handle_bad_tags
+    assert_equal ['ignored'], StatsD::Instrument::Metric.normalize_tags(['igno|red'])
+    assert_equal ['lol::class:omg::lol'], StatsD::Instrument::Metric.normalize_tags({ :"lol::class" => "omg::lol" })
+  end
+
+  def test_rewrite_tags_provided_as_hash
+    assert_equal ['tag:value'], StatsD::Instrument::Metric.normalize_tags(:tag => 'value')
+    assert_equal ['tag:value', 'tag2:value2'], StatsD::Instrument::Metric.normalize_tags(:tag => 'value', :tag2 => 'value2')
+  end
+end