quartz 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2e2fe4395a4d05407cfc6b760117f1a157357cda18e21434bc5d099367738af
-  data.tar.gz: 8f8aefe61999b809eae8a46a5e3f39a99249ccee623f322237fb38100e4f52b0
+  metadata.gz: 1a22ff297e6904e0f037039526312cfcb4d2e22018d08c50216ea834b75067de
+  data.tar.gz: 48bfc68a088720318828cc2389c1373753da2d27b9f144101d00c377a8824178
 SHA512:
-  metadata.gz: 5c105ff943245abb21c857543340778215c43c70d4a14c5f4d23a27674da8a7e6cffa3fa225e4b1b2314b49433482c6aae9bbe4d9e93413079bf16c86ca1a2d2
-  data.tar.gz: 02a7eb9ec1e09ccc37d76fc5593069a756606ef9a44f947d945ceb96662755b69abd1dd775ecd0ec36a66ed30db7ced67a371927558102cac8696e90fb014b3b
+  metadata.gz: f9f0845a06d885e1706a07040937577765e3c4dfc0eb66ebfce73e5a79df5b4234de1c42c5077f95d0b1642323bd506ebcb4b2cf4494ebc356ce8384f678a37b
+  data.tar.gz: e1f1371656edb1f49e478dc4c99155f42fba25e0bd4a8f523b5bafc29997d4c0a87ec6df670a14c3c87070a1921195bb0eb140fd51ba1b428d88f51a21aba7e5

data/README.md

@@ -125,6 +125,19 @@ you can pass the `socket_dir` option.
 client = Quartz::Client.new(bin_path: 'my_adder_binary', socket_dir: '/apps/my_app/tmp')
 ```
 
+If you want to manage the Go process manually, you can use the
+following system to set the socket path manually. Now, you can use
+Systemd/Kubernetes/etc. to manage the Go process.
+
+```shell
+$ QUARTZ_SOCKET=/tmp/custom.sock ./go_process
+```
+
+```ruby
+client = Quartz::Client.new(socket_path: '/tmp/custom.sock')
+
+```
+
 ## Copyright
 
 Copyright (c) 2018 David Huie. See LICENSE.txt for further details.

data/VERSION

@@ -1 +1 @@
-1.1.0
+1.2.0

data/lib/quartz/go_process.rb

@@ -24,7 +24,7 @@ class Quartz::GoProcess
   def initialize(opts)
     @seed = SecureRandom.hex
     socket_dir = opts.fetch(:socket_dir) { '/tmp' }
-    @socket_path = File.join(socket_dir, "quartz_#{seed}.sock")
+    @socket_path = opts[:socket_path] || File.join(socket_dir, "quartz_#{seed}.sock")
     ENV['QUARTZ_SOCKET'] = @socket_path
 
     if opts[:file_path]
@@ -32,6 +32,8 @@ class Quartz::GoProcess
       compile_and_run(opts[:file_path])
     elsif opts[:bin_path]
       @go_process = IO.popen(opts[:bin_path])
+    elsif opts[:socket_path]
+      @external_socket = true
     else
       raise Quartz::ConfigError, 'Missing go binary'
     end
@@ -127,6 +129,9 @@ class Quartz::GoProcess
     # process will.
     return if @forked
 
+    # If the Go process is managed externally, there's nothing to do.
+    return if @external_socket
+
     unless @killed_go_process
       Process.kill('SIGTERM', pid)
       Process.wait(pid)

data/quartz.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: quartz 1.1.0 ruby lib
+# stub: quartz 1.2.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "quartz".freeze
-  s.version = "1.1.0"
+  s.version = "1.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]

data/spec/go_process_spec.rb

@@ -7,11 +7,14 @@ describe Quartz::GoProcess do
   describe '#get_metadata' do
 
     context 'with a go file' do
-
       it 'pulls metadata' do
         expect(process.get_metadata).to eq("adder" => {"NameToMethodMetadata"=>{"Add"=>{"ArgumentToType"=>{"A"=>"int", "B"=>"int"}}, "AddError"=>{"ArgumentToType"=>{"A"=>"int", "B"=>"int"}}}})
       end
 
+      it 'pulls metadata from the recycled socket' do
+        new_process = Quartz::GoProcess.new(socket_path: process.socket_path)
+        expect(new_process.socket_path).to eq(process.socket_path)
+      end
     end
 
   end
@@ -53,6 +56,23 @@ describe Quartz::GoProcess do
 
   end
 
+  context 'with a custom socket path' do
+
+    let(:new_process) { Quartz::GoProcess.new(socket_path: process.socket_path) }
+
+    it 'the new process does not clean up the existing socket' do
+      expect(File.exists?(new_process.socket_path)).to be_truthy
+      new_process.cleanup
+      expect(File.exists?(new_process.socket_path)).to be_truthy
+    end
+
+    it 'creates the socket in the socket dir' do
+      result = new_process.call('adder', 'Add', { 'A' => 5, 'B' => 6 })
+      expect(result).to eq({"id"=>1, "result"=>{"X"=>11}, "error"=>nil})
+    end
+
+  end
+
   describe '.cleanup' do
 
     context 'files' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quartz
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - David Huie