quartermaster 1.0.2 → 1.0.3

data/History.txt

@@ -1,11 +1,16 @@
+=== 1.0.3 / 2008-05-09
+
+* 1 major bug fix
+  * ARGH. Stylesheet and javascript helpers weren't including "browsers/" directory in the call to *_tag so it was broked. Incorrect tests let it slip by (helps to sanity check things sometimes, doesn't it?)
+
 === 1.0.2 / 2008-05-08
 
-* 1 major enhancement
+* 1 major bug fix
   * Muffed handling of request's that have *no* user agent (request.user_agent is nil). Fixed!
 
 === 1.0.1 / 2008-05-08
 
-* 1 major enhancement
+* 1 major bug fix
   * Muffed handling of unknown browsers. Fixed!
 
 === 1.0.0 / 2008-05-06

data/lib/quartermaster.rb

@@ -1,5 +1,5 @@
 module Quartermaster
-  VERSION = '1.0.2'
+  VERSION = '1.0.3'
   
   module Helper
     # Uses the output of +browser_from_user_agent+ to figure out what stylesheets to look for and then uses +stylesheet_link_tag+ 
@@ -8,13 +8,13 @@ module Quartermaster
     # +stylesheet_link_tag+
     def stylesheet_link_tag_for_browser( options = {} )
       agent_attributes = [os_from_user_agent] + browser_from_user_agent
-      agent_attributes.select{ |attribute| File.exists?( File.join(self.class::STYLESHEETS_DIR, 'browsers', "#{attribute}.css" )) }.collect{ |attribute| stylesheet_link_tag( attribute, options )}.to_s
+      agent_attributes.select{ |attribute| File.exists?( File.join(self.class::STYLESHEETS_DIR, 'browsers', "#{attribute}.css" )) }.collect{ |attribute| stylesheet_link_tag( "browsers/#{attribute}", options )}.to_s
     end
     
     # Very similar to +stylesheet_link_tag_for_browser+ except for javascripts
     def javascript_include_tag_for_browser( options = {} )
       agent_attributes = [os_from_user_agent] + browser_from_user_agent
-      agent_attributes.select{ |attribute| File.exists?( File.join(self.class::JAVASCRIPTS_DIR, 'browsers', "#{attribute}.js" )) }.collect{ |attribute| javascript_include_tag( attribute, options )}.to_s
+      agent_attributes.select{ |attribute| File.exists?( File.join(self.class::JAVASCRIPTS_DIR, 'browsers', "#{attribute}.js" )) }.collect{ |attribute| javascript_include_tag( "browsers/#{attribute}", options )}.to_s
     end
     
     # Returns a space-separated string of the OS and the short user agents for the requesting browser

data/test/test_quartermaster.rb

@@ -10,12 +10,12 @@ class QMTest
   # Mock a couple ActionView helpers
   def stylesheet_link_tag(*sources)
     sources.pop if sources.last.is_a?(Hash)
-    "<link for #{sources.join(',')}>"
+    "<link for '#{sources.join(',')}'>"
   end
   
   def javascript_include_tag(*sources)
     sources.pop if sources.last.is_a?(Hash)
-    "<script for #{sources.join(',')}>"
+    "<script for '#{sources.join(',')}'>"
   end
 end
 
@@ -91,7 +91,7 @@ describe 'Quartermaster' do
       end
       
       def expected_output_for( *sources )
-        sources.collect{ |attribute| @qm.stylesheet_link_tag(attribute)}.to_s
+        sources.collect{ |attribute| @qm.stylesheet_link_tag("browsers/#{attribute}")}.to_s
       end
 
       it "should create links to the os file, the browser-base file, and the browser-specific file" do
@@ -129,7 +129,7 @@ describe 'Quartermaster' do
       end
       
       def expected_output_for( *sources )
-        sources.collect{ |attribute| @qm.javascript_include_tag(attribute)}.to_s
+        sources.collect{ |attribute| @qm.javascript_include_tag("browsers/#{attribute}")}.to_s
       end
 
       it "should create script tags for the os file, the browser-base file, and the browser-specific file" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: quartermaster
 version: !ruby/object:Gem::Version 
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors: 
 - Dave Myron
@@ -30,7 +30,7 @@ cert_chain:
   arkBVHd8TABNoJ+MQvwL/7sCwSTiTg==
   -----END CERTIFICATE-----
 
-date: 2008-05-08 00:00:00 -07:00
+date: 2008-05-09 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency