quandl_babelfish 0.0.8 → 0.0.9

data/UPGRADE.md

@@ -1,3 +1,8 @@
+## 0.0.9
+
+* QUGC-54 write failing spec for input with nil row value
+
+
 ## 0.0.8
 
 * QUGC-42 you should not have to include data; you might just want to update headers

data/lib/quandl/babelfish/cleaner.rb

@@ -21,11 +21,13 @@ class Cleaner
       NumberMaid::init(number_settings)
       dirty_array.each.with_index do |row, i|
         new_row=[]
-        (new_row << clean_dates[i]).concat Array(NumberMaid::clean(row[1..-1]))     #add clean date and all clean numbers
+        clean_row=NumberMaid::clean(row[1..-1])
+        clean_row=[nil] if clean_row.nil?
+        (new_row << clean_dates[i]).concat Array(clean_row)    #add clean date and all clean numbers
         clean_array << new_row
       end
 
-      return Helper::make_square(clean_array), header
+      return clean_array, header
     end
   end
 end

data/lib/quandl/babelfish/version.rb

@@ -1,5 +1,5 @@
 module Quandl
 module Babelfish
-  VERSION = '0.0.8'
+  VERSION = '0.0.9'
 end
 end

data/spec/lib/quandl/babelfish/cleaner_spec.rb

@@ -9,6 +9,16 @@ describe Cleaner do
   let(:headers){ output[1] }
   subject{ data }
   
+  context "given nil" do
+    let(:input){ [[2012, nil], [2011, 20], [2010, 30]] }
+    it{ should eq [[Date.new(2012,12,31), nil], [Date.new(2011,12,31), 20.0], [Date.new(2010,12,31), 30.0]] }
+  end
+  
+  context "mismatch row count" do
+    let(:input){ [[2012], [2011, 20], [2010, 30, 25]] }
+    it{ should eq [[Date.new(2012,12,31)], [Date.new(2011,12,31), 20], [Date.new(2010,12,31), 30, 25]] }
+  end
+  
   context "garbage" do
     let(:input){ [[2456624, 10], [2456625, 20], [2456626, 30]] }
     it{ should be_eq_at_index '[0][0]', Date.new(1970,01,29) }
@@ -49,7 +59,7 @@ describe Cleaner do
   context "data with nil" do
     let(:input){ [["Date", "Col1"], ["2002", nil], ["2003", "5"]] }
     it{ should be_eq_at_index '[0][0]', Date.new(2002,12,31) }
-    it{ data[0].length.should ==2}
+    it{ data[0].length.should == 2}
     it{ should be_eq_at_index '[0][1]', nil }
     it{ should be_eq_at_index '[1][0]', Date.new(2003,12,31)  }
     it{ should be_eq_at_index '[1][1]', 5 }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quandl_babelfish
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-31 00:00:00.000000000 Z
+date: 2014-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec