quandl_babelfish 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a53ee0db1ee101721529efaabecca18f5afb20c3
-  data.tar.gz: 955834a837b73a4154b8fff0510c7c6db6e9f98c
+  metadata.gz: 71a8ae07574d1b0763951541acf718b62c27110d
+  data.tar.gz: 1633fd8fc8d6f8a95bb3a08aa14d7e80a6fc9c6f
 SHA512:
-  metadata.gz: 3a0a066227348ad185b74c653bcd89d2be752b74efb9724757e0d17d2928a9010866d64b078f5ff02143bf9dfc17c3c786bf4d76ade3f7930bcfd3423062baf8
-  data.tar.gz: fbd1df51422791838162a0e43e562b9d0e9ca272d2af427eceb69d032dbd00d9f46b2f444c5ec5da1754eeef571485f2ddc0efdbc3484d2f5259cb8d1e866036
+  metadata.gz: a697bd2faf306f47e042b3d5a9cb765a9b4199a4cd7b38c11eb6fb2ec258323d53959f0886b6185a58a8ffaa53b8edc23cb9840ed16de108a846152012dfbedb
+  data.tar.gz: 6a96e6d3e9ba5151a853fe020c0d0fc9afceafd3b9e93c34299fc17adfe20026603bbcae1f8d9388d2a085237af404539ac30168a3400173986db064ad1a4724

data/UPGRADE.md

@@ -1,3 +1,9 @@
+## 0.0.5
+
+* improve error messages with line, row, context
+* add Quandl::Error::Standard, all errors inherit from Error::Standard
+
+
 ## 0.0.4
 
 * remove quandl_data as a dependency

data/lib/quandl/babelfish.rb

@@ -4,6 +4,7 @@ require "quandl/babelfish/cleaner"
 require "quandl/babelfish/date_maid"
 require "quandl/babelfish/number_maid"
 
+require 'quandl/error/standard'
 require 'quandl/error/guess_date_format'
 require 'quandl/error/invalid_date'
 require 'quandl/error/unknown_date_format'

data/lib/quandl/babelfish/date_maid.rb

@@ -25,7 +25,7 @@ module Babelfish
           #find good example and extract all info from it and apply it to each of the dates in the set
           good_sample = find_good_date(all_dates)
 
-          raise Error::GuessDateFormat.new("Unable to find date format for provide dates") if good_sample.nil?
+          raise( Error::GuessDateFormat.new, "Unable to find date format for provided dates" ) if good_sample.nil?
 
           date_format, frequency = analyze_date_format(good_sample)
 
@@ -35,8 +35,8 @@ module Babelfish
         end
 
         iso_dates=[]
-        all_dates.each do |fuzzy_date|
-          temp_date = convert(fuzzy_date, date_format) rescue raise(Error::InvalidDate,fuzzy_date)
+        all_dates.each_with_index do |fuzzy_date, i|
+          temp_date = convert(fuzzy_date, date_format) rescue raise( Error::InvalidDate.new( line: i+1, row: fuzzy_date, context: 'convert' ), "Invalid date '#{fuzzy_date}'" )
           iso_dates  << frequency_transform(temp_date, frequency)
         end
 

data/lib/quandl/babelfish/version.rb

@@ -1,5 +1,5 @@
 module Quandl
 module Babelfish
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end
 end

data/lib/quandl/error/guess_date_format.rb

@@ -1,6 +1,5 @@
 module Quandl
 module Error
-  class GuessDateFormat < StandardError
-  end
+  class GuessDateFormat < Quandl::Error::Standard; end
 end
 end

data/lib/quandl/error/invalid_date.rb

@@ -1,6 +1,5 @@
 module Quandl
 module Error
-  class InvalidDate < StandardError
-  end
+  class InvalidDate < Quandl::Error::Standard; end
 end
 end

data/lib/quandl/error/standard.rb

@@ -0,0 +1,27 @@
+module Quandl
+module Error
+  class Standard < StandardError
+    
+    attr_accessor :details
+    
+    def line
+      detail :line
+    end
+    def context
+      detail :context
+    end
+    def problem
+      detail :problem
+    end
+    
+    def detail(key)
+      details.send(key) if details.respond_to?(key)
+    end
+    
+    def initialize(opts=nil)
+      @details = OpenStruct.new( opts ) if opts && opts.is_a?(Hash)
+    end
+    
+  end
+end
+end

data/lib/quandl/error/unknown_date_format.rb

@@ -1,6 +1,5 @@
 module Quandl
 module Error
-  class UnknownDateFormat < StandardError
-  end
+  class UnknownDateFormat < Quandl::Error::Standard; end
 end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quandl_babelfish
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Sergei Ryshkevich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-09 00:00:00.000000000 Z
+date: 2013-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -58,6 +58,7 @@ files:
 - lib/quandl/babelfish/version.rb
 - lib/quandl/error/guess_date_format.rb
 - lib/quandl/error/invalid_date.rb
+- lib/quandl/error/standard.rb
 - lib/quandl/error/unknown_date_format.rb
 - quandl_babelfish.gemspec
 - spec/lib/quandl/babelfish/cleaner_spec.rb