quality_gate 0.2.1 → 0.3.0

data/lib/quality_gate/doctor_report.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module QualityGate
+  # Holds bounded preflight observations independently of gate findings.
+  class DoctorReport
+    STATUSES = %w[ready warning blocked unchecked not_applicable].map!(&:freeze).freeze
+
+    attr_reader :checks, :summary
+
+    def self.check(id:, status:, message:)
+      normalized_status = status.to_s
+      raise ArgumentError, "unknown Doctor status" unless STATUSES.include?(normalized_status)
+
+      { "id" => id.to_s.dup.freeze, "status" => normalized_status.dup.freeze,
+        "message" => message.to_s.dup.freeze }.freeze
+    end
+
+    def initialize(checks:)
+      @checks = checks.map { normalize_check(_1) }.freeze
+      @summary = STATUSES.to_h do |status|
+        [status, @checks.count { |check| check.fetch("status") == status }]
+      end.freeze
+    end
+
+    def exit_code
+      return 2 if summary.fetch("blocked").positive?
+      return 1 if summary.fetch("warning").positive? || summary.fetch("unchecked").positive?
+
+      0
+    end
+
+    private
+
+    def normalize_check(check)
+      self.class.check(id: check.fetch("id"), status: check.fetch("status"), message: check.fetch("message"))
+    end
+  end
+end

data/lib/quality_gate/init_command.rb

@@ -16,7 +16,7 @@ module QualityGate
 
       def parse(arguments)
         reject_format!(arguments)
-        options = { profile: "ruby", skip_coverage: false, agents: false, pretend: false }
+        options = { profile: "ruby", skip_coverage: false, agents: false, codex: false, ci: false, pretend: false }
         option_parser(options).parse!(arguments)
         raise OptionParser::InvalidOption, arguments.join(" ") if arguments.any?
 
@@ -62,6 +62,8 @@ module QualityGate
       def boolean_options(parser, options)
         parser.on("--skip-coverage") { options[:skip_coverage] = true }
         parser.on("--agents") { options[:agents] = true }
+        parser.on("--codex") { options[:codex] = true }
+        parser.on("--ci") { options[:ci] = true }
         parser.on("--pretend") { options[:pretend] = true }
       end
 

data/lib/quality_gate/installation.rb

@@ -2,8 +2,9 @@
 
 require "erb"
 require "fileutils"
+require "json"
 require "pathname"
-require "rbconfig"
+require "shellwords"
 require "tempfile"
 
 module QualityGate
@@ -19,6 +20,9 @@ module QualityGate
       .claude/settings.json
       CLAUDE.md
       AGENTS.md
+      .codex/hooks.json
+      .codex/hooks/quality_gate_fast.rb
+      .codex/hooks/quality_gate_verify_stop.rb
     ].freeze
     MARKER_START = "# quality_gate coverage — start"
     MARKER_END = "# quality_gate coverage — end"
@@ -28,7 +32,10 @@ module QualityGate
     AGENT_TEMPLATE_PATHS = {
       ".claude/hooks/quality_gate_fast.rb" => "quality_gate_fast.rb.tt",
       ".claude/hooks/quality_gate_verify_stop.rb" => "quality_gate_verify_stop.rb.tt",
-      ".claude/settings.json" => "claude_settings.json.tt"
+      ".claude/settings.json" => "claude_settings.json.tt",
+      ".codex/hooks.json" => "codex_hooks.json.tt",
+      ".codex/hooks/quality_gate_fast.rb" => "codex_fast.rb.tt",
+      ".codex/hooks/quality_gate_verify_stop.rb" => "codex_verify_stop.rb.tt"
     }.freeze
     AGENT_CONTRACT_PATHS = %w[CLAUDE.md AGENTS.md].freeze
     PRIOR_CLAUDE_SETTINGS = [
@@ -52,6 +59,25 @@ module QualityGate
         }
       JSON
     ].freeze
+    PRIOR_CODEX_HOOKS = lambda do |root|
+      JSON.pretty_generate(
+        "hooks" => {
+          "Stop" => [
+            {
+              "hooks" => [
+                {
+                  "type" => "command",
+                  "command" => Shellwords.join(
+                    ["ruby", File.expand_path(".codex/hooks/quality_gate_verify_stop.rb", root)]
+                  ),
+                  "timeout" => 600
+                }
+              ]
+            }
+          ]
+        }
+      ).b << "\n".b
+    end
     STRONG_MIGRATIONS_PROVENANCE = "# Generated by Quality Gate."
     HOOK_MODE = 0o755
     DEFAULT_AGENT_ARTIFACT_MODE = 0o644
@@ -63,7 +89,6 @@ module QualityGate
       class Unsupported < StandardError; end
 
       IMPORTER_MUTEX = Mutex.new
-      BUNDLED_REQUIRE_MUTEX = Mutex.new
       LINK_FLAGS = 0
       UNLINK_FLAGS = 0
       O_DIRECTORY = File.const_defined?(:DIRECTORY) ? File::DIRECTORY : 0
@@ -169,87 +194,10 @@ module QualityGate
       end
 
       def load_fiddle_importer!
-        return if defined?(Fiddle::Importer)
-        return load_bundled_fiddle_importer! if ruby4_bundle_fiddle?
-
         require "fiddle/import"
       rescue LoadError => e
         raise Unsupported, e.message
       end
-
-      def ruby4_bundle_fiddle?
-        RUBY_VERSION.start_with?("4.") && defined?(Bundler)
-      end
-
-      def load_bundled_fiddle_importer!
-        with_bundled_fiddle_require { load(fiddle_feature_paths.fetch("fiddle/import")) }
-      end
-
-      def with_bundled_fiddle_require
-        BUNDLED_REQUIRE_MUTEX.synchronize do
-          original_require = Kernel.instance_method(:require)
-          original_verbose = $VERBOSE
-          feature_paths = fiddle_feature_paths
-          $VERBOSE = nil
-          Kernel.module_eval do
-            define_method(:require) do |feature|
-              path = feature_paths[feature]
-              if path
-                return false if $LOADED_FEATURES.include?(path)
-
-                loaded = path.end_with?(".rb") ? load(path) : original_require.bind_call(self, path)
-                $LOADED_FEATURES << path unless $LOADED_FEATURES.include?(path)
-                loaded || true
-              else
-                original_require.bind_call(self, feature)
-              end
-            end
-          end
-          yield
-        ensure
-          Kernel.module_eval { define_method(:require, original_require) } if original_require
-          $VERBOSE = original_verbose
-        end
-      end
-
-      def fiddle_feature_paths
-        root = bundled_fiddle_root
-        {
-          "fiddle" => File.join(root, "fiddle.rb"),
-          "fiddle.so" => File.join(bundled_fiddle_extension_root, "fiddle.#{RbConfig::CONFIG.fetch("DLEXT")}"),
-          "fiddle/closure" => File.join(root, "fiddle", "closure.rb"),
-          "fiddle/function" => File.join(root, "fiddle", "function.rb"),
-          "fiddle/version" => File.join(root, "fiddle", "version.rb"),
-          "fiddle/import" => File.join(root, "fiddle", "import.rb"),
-          "fiddle/struct" => File.join(root, "fiddle", "struct.rb"),
-          "fiddle/cparser" => File.join(root, "fiddle", "cparser.rb"),
-          "fiddle/types" => File.join(root, "fiddle", "types.rb"),
-          "fiddle/value" => File.join(root, "fiddle", "value.rb"),
-          "fiddle/pack" => File.join(root, "fiddle", "pack.rb")
-        }
-      end
-
-      def bundled_fiddle_root
-        Dir[File.join(RbConfig::CONFIG["prefix"], "lib/ruby/gems/**/gems/fiddle-*/lib")].max or
-          raise Unsupported, "fiddle support is unavailable"
-      end
-
-      def bundled_fiddle_extension_root
-        root = bundled_fiddle_root
-        extension = File.join(root, "fiddle.#{RbConfig::CONFIG.fetch("DLEXT")}")
-        return root if File.file?(extension)
-
-        gem_name = File.basename(File.dirname(root))
-        gem_home = File.expand_path("../../..", root)
-        extension_api = if defined?(Gem) && Gem.respond_to?(:extension_api_version)
-                          Gem.extension_api_version
-                        else
-                          RbConfig::CONFIG.fetch("ruby_version")
-                        end
-        pattern = File.join(gem_home, "extensions", RbConfig::CONFIG.fetch("arch"), extension_api, gem_name)
-        native_root = pattern if File.file?(File.join(pattern, "fiddle.#{RbConfig::CONFIG.fetch("DLEXT")}"))
-        native_root or raise Unsupported, "fiddle native extension is unavailable"
-      end
     end
     PreparedTempfile = Data.define(
       :file,
@@ -272,7 +220,7 @@ module QualityGate
     private_constant :PreparedTempfile
     private_constant :DirectoryOperations
     private_constant :AGENT_TEMPLATE_PATHS, :AGENT_CONTRACT_PATHS
-    private_constant :PRIOR_CLAUDE_SETTINGS
+    private_constant :PRIOR_CLAUDE_SETTINGS, :PRIOR_CODEX_HOOKS
     private_constant :AGENT_CONTRACT_START, :AGENT_CONTRACT_END
     private_constant :HOOK_MODE, :DEFAULT_AGENT_ARTIFACT_MODE, :TEMPFILE_MODE
 
@@ -303,7 +251,7 @@ module QualityGate
       relative_path = test_helper_path
       path = safe_destination_path(relative_path)
       return unless path
-      return skip_missing_test_helper unless File.file?(path)
+      return skip_missing_test_helper(relative_path) unless File.file?(path)
 
       install_coverage(path, relative_path)
     end
@@ -311,22 +259,25 @@ module QualityGate
     def create_agent_integration
       return unless invoke_behavior?
 
-      unless options[:agents]
-        record(:skipped, "agent integration (pass --agents to install Claude hooks and contracts)")
+      unless options[:agents] || options[:codex]
+        record(
+          :skipped,
+          "agent integration (pass --agents for Claude hooks or --codex for Codex patch feedback and Stop verification)"
+        )
         return
       end
 
-      install_template("quality_gate_fast.rb.tt", ".claude/hooks/quality_gate_fast.rb", mode: HOOK_MODE)
-      install_template(
-        "quality_gate_verify_stop.rb.tt",
-        ".claude/hooks/quality_gate_verify_stop.rb",
-        mode: HOOK_MODE
-      )
-      install_template("claude_settings.json.tt", ".claude/settings.json")
-      install_agent_contract("CLAUDE.md")
+      install_claude_integration if options[:agents]
+      install_codex_integration if options[:codex]
       install_agent_contract("AGENTS.md")
     end
 
+    def create_ci_workflow
+      return unless invoke_behavior? && options[:ci]
+
+      install_template("quality_gate_workflow.yml.tt", ".github/workflows/quality_gate.yml")
+    end
+
     def print_summary
       return print_unsupported_behavior unless invoke_behavior?
 
@@ -340,10 +291,31 @@ module QualityGate
 
     private
 
+    def install_claude_integration
+      install_template("quality_gate_fast.rb.tt", ".claude/hooks/quality_gate_fast.rb", mode: HOOK_MODE)
+      install_template(
+        "quality_gate_verify_stop.rb.tt",
+        ".claude/hooks/quality_gate_verify_stop.rb",
+        mode: HOOK_MODE
+      )
+      install_template("claude_settings.json.tt", ".claude/settings.json")
+      install_agent_contract("CLAUDE.md")
+    end
+
+    def install_codex_integration
+      install_template("codex_fast.rb.tt", ".codex/hooks/quality_gate_fast.rb", mode: HOOK_MODE)
+      install_template("codex_hooks.json.tt", ".codex/hooks.json")
+      install_template("codex_verify_stop.rb.tt", ".codex/hooks/quality_gate_verify_stop.rb", mode: HOOK_MODE)
+    end
+
     def invoke_behavior?
       behavior == :invoke
     end
 
+    def agent_option?(name)
+      options.fetch(name, options.fetch(name.to_s, false))
+    end
+
     def print_unsupported_behavior
       say "Automatic removal is not supported. See the README installation undo instructions for manual removal."
     end
@@ -363,7 +335,7 @@ module QualityGate
       existing = existing_file.fetch(:content)
       if existing == content.b
         record_existing_template(path, relative_path, existing:, mode:, status: existing_file.fetch(:status))
-      elsif prior_claude_settings?(relative_path, existing)
+      elsif prior_claude_settings?(relative_path, existing) || prior_codex_hooks?(relative_path, existing)
         return record_pretend_skip(relative_path) if options[:pretend]
 
         replace_content(path, content, relative_path, expected: existing_file)
@@ -381,6 +353,10 @@ module QualityGate
       relative_path == ".claude/settings.json" && PRIOR_CLAUDE_SETTINGS.include?(content)
     end
 
+    def prior_codex_hooks?(relative_path, content)
+      relative_path == ".codex/hooks.json" && content == PRIOR_CODEX_HOOKS.call(destination_root).b
+    end
+
     def install_agent_contract(relative_path)
       path = safe_destination_path(relative_path)
       return unless path
@@ -656,9 +632,9 @@ module QualityGate
       markers
     end
 
-    def skip_missing_test_helper
-      say "Warning: Minitest coverage wiring skipped; test/test_helper.rb is missing."
-      record(:skipped, "test/test_helper.rb (missing; Minitest coverage wiring skipped)")
+    def skip_missing_test_helper(relative_path)
+      say "Warning: Minitest coverage wiring skipped; #{relative_path} is missing."
+      record(:skipped, "#{relative_path} (missing; Minitest coverage wiring skipped)")
     end
 
     def skip_existing_simplecov(relative_path)

data/lib/quality_gate/installer.rb

@@ -15,6 +15,8 @@ module QualityGate
       test_helper
       test_command
       agents
+      codex
+      ci
       pretend
       skip_coverage
     ].freeze
@@ -25,6 +27,7 @@ module QualityGate
       create_initializers
       inject_coverage
       create_agent_integration
+      create_ci_workflow
     ].freeze
 
     attr_reader :destination_root, :stdout, :profile

data/lib/quality_gate/reporters/doctor.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require "json"
+require_relative "../doctor_report"
+
+module QualityGate
+  module Reporters
+    # Renders Doctor's preflight checks as text or a stable JSON envelope.
+    class Doctor
+      def initialize(io:)
+        @io = io
+      end
+
+      def call(report, format:)
+        case format
+        when "json" then io.puts(JSON.generate(json_payload(report)))
+        when "text" then print_text(report)
+        else raise ArgumentError, "Doctor format must be text or json"
+        end
+      end
+
+      private
+
+      attr_reader :io
+
+      def json_payload(report)
+        {
+          "scope" => "preflight",
+          "checks" => sanitized_checks(report),
+          "summary" => report.summary
+        }
+      end
+
+      def sanitized_checks(report)
+        report.checks.map do |check|
+          check.transform_values { |value| FieldSanitizer.for_json(value) }
+        end
+      end
+
+      def print_text(report)
+        report.checks.each do |check|
+          io.puts [check.fetch("id"), check.fetch("status"), check.fetch("message")]
+            .map { FieldSanitizer.for_text(_1) }.join(" ")
+        end
+
+        io.puts "Preflight: #{summary_text(report.summary)}"
+      end
+
+      def summary_text(summary)
+        DoctorReport::STATUSES.map do |status|
+          label = status == "not_applicable" ? "not applicable" : status
+          "#{summary.fetch(status)} #{label}"
+        end.join(", ")
+      end
+    end
+  end
+end

data/lib/quality_gate/reporters/json.rb

@@ -19,7 +19,7 @@ module QualityGate
       attr_reader :io
 
       def payload_for(result)
-        {
+        payload = {
           "checks" => result.checks.map { serialize_check(_1) },
           "findings" => result.findings.map { serialize_finding(_1) },
           "summary" => {
@@ -28,6 +28,23 @@ module QualityGate
             "failed_tools" => result.failed_tools.map { FieldSanitizer.for_json(_1) }
           }
         }
+        add_baseline(payload, result.baseline)
+      end
+
+      def add_baseline(payload, baseline)
+        payload["baseline"] = serialize_baseline(baseline) if baseline
+        payload
+      end
+
+      def serialize_baseline(baseline)
+        {
+          "mode" => baseline.fetch(:mode),
+          "status" => baseline.fetch(:status),
+          "accepted_count" => baseline.fetch(:accepted_count),
+          "removed_count" => baseline.fetch(:removed_count),
+          "written" => baseline.fetch(:written),
+          "accepted_findings" => baseline.fetch(:accepted_findings).map { serialize_finding(_1) }
+        }
       end
 
       def serialize_finding(finding)

data/lib/quality_gate/reporters/markdown.rb

@@ -19,7 +19,17 @@ module QualityGate
       attr_reader :io
 
       def sections_for(result)
-        [summary_heading(result), checks_table(result.checks), findings_section(result.findings)].compact
+        [
+          summary_heading(result), baseline_section(result.baseline),
+          checks_table(result.checks), findings_section(result.findings)
+        ].compact
+      end
+
+      def baseline_section(baseline)
+        return unless baseline
+
+        "Baseline **#{baseline.fetch(:mode)}**: #{baseline.fetch(:status)}, " \
+          "#{baseline.fetch(:accepted_count)} accepted, #{baseline.fetch(:removed_count)} removed."
       end
 
       def summary_heading(result)

data/lib/quality_gate/reporters/text.rb

@@ -10,18 +10,26 @@ module QualityGate
 
       def call(result)
         print_checks(result.checks)
-
-        result.findings.each do |finding|
-          io.puts(render_finding(finding))
-        end
-
-        io.puts("#{result.findings.length} findings, #{result.failed_tools.length} tool failures")
+        print_baseline(result.baseline) if result.baseline
+        print_findings_and_summary(result)
       end
 
       private
 
       attr_reader :io
 
+      def print_findings_and_summary(result)
+        result.findings.each { |finding| io.puts(render_finding(finding)) }
+        io.puts("#{result.findings.length} findings, #{result.failed_tools.length} tool failures")
+      end
+
+      def print_baseline(baseline)
+        io.puts(
+          "Baseline #{baseline.fetch(:mode)}: #{baseline.fetch(:status)}, " \
+          "#{baseline.fetch(:accepted_count)} accepted, #{baseline.fetch(:removed_count)} removed"
+        )
+      end
+
       def print_checks(checks)
         return if checks.empty?
 

data/lib/quality_gate/ruby_profile.rb

@@ -42,8 +42,8 @@ module QualityGate
       raise ArgumentError, "#{name} must stay inside the project"
     end
 
-    def command(value, framework)
-      command = value.nil? ? DEFAULT_COMMANDS.fetch(framework) : parse_command(value)
+    def command(value, framework, defaults: DEFAULT_COMMANDS)
+      command = value.nil? ? defaults.fetch(framework) : parse_command(value)
       validate_command!(command)
       command.map(&:dup).freeze
     end
@@ -167,4 +167,123 @@ module QualityGate
             "test helper #{relative.inspect} does not exist; pass --skip-coverage or provide an existing helper"
     end
   end
+
+  # Resolves the Rails test helper and command while sharing the Ruby profile's
+  # validation for project-relative paths and shell-free argv.
+  class RailsProfile
+    DEFAULT_HELPERS = {
+      "minitest" => "test/test_helper.rb",
+      "rspec" => "spec/rails_helper.rb"
+    }.freeze
+    DEFAULT_COMMANDS = {
+      "minitest" => %w[bin/rails test].freeze,
+      "rspec" => %w[bundle exec rspec].freeze
+    }.freeze
+    TEMPLATE_MAP = { "quality_gate.yml.tt" => "rails_quality_gate.yml.tt" }.freeze
+    SUPPORTED_FRAMEWORKS = DEFAULT_HELPERS.keys.freeze
+
+    attr_reader :destination_root, :framework, :test_helper, :test_command
+
+    def initialize(destination_root:, options: {})
+      @destination_root = RubyProfileSupport.destination_root(destination_root)
+      @options = RubyProfileSupport.options(options)
+      resolve_settings
+    end
+
+    def coverage? = @coverage
+
+    def missing_default_helper? = !!@missing_default_helper
+
+    def template_for(name)
+      TEMPLATE_MAP.fetch(name, name)
+    end
+
+    private
+
+    attr_reader :options
+
+    def resolve_settings
+      @coverage = !option(:skip_coverage)
+      @framework = resolve_framework
+      @test_helper = resolve_test_helper
+      @test_command = RubyProfileSupport.command(option(:test_command), framework, defaults: DEFAULT_COMMANDS)
+    end
+
+    def option(key)
+      options.fetch(key, nil)
+    end
+
+    def resolve_framework
+      explicit = option(:test_framework)
+      return validate_framework(explicit) if explicit
+
+      helper = option(:test_helper)
+      return framework_for_helper(helper) if helper
+
+      detected_framework
+    end
+
+    def detected_framework
+      available = DEFAULT_HELPERS.select { |_name, path| helper_present?(path) }.keys
+      return available.first if available.one?
+
+      return missing_default_framework if available.empty?
+
+      raise ArgumentError, "both test helpers exist; pass --test-framework minitest or rspec"
+    end
+
+    def missing_default_framework
+      @missing_default_helper = true
+      "minitest"
+    end
+
+    def validate_framework(value)
+      selected = value.to_s
+      return selected if SUPPORTED_FRAMEWORKS.include?(selected)
+
+      raise ArgumentError, "test_framework must be minitest or rspec"
+    end
+
+    def framework_for_helper(value)
+      relative = RubyProfileSupport.relative_path(destination_root, value, "test_helper")
+      relative.start_with?("spec/") || relative == "spec" ? "rspec" : "minitest"
+    end
+
+    def resolve_test_helper
+      helper = option(:test_helper) || DEFAULT_HELPERS.fetch(framework)
+      relative = RubyProfileSupport.relative_path(destination_root, helper, "test_helper")
+      return relative unless coverage?
+
+      validate_test_helper!(relative)
+      relative
+    end
+
+    def validate_test_helper!(relative)
+      path = helper_path_without_symlinks(relative)
+      raise ArgumentError, "test_helper must not pass through symlinks" unless path
+      return if File.file?(path) || missing_default_helper?
+
+      raise ArgumentError,
+            "test helper #{relative.inspect} does not exist; pass --skip-coverage or provide an existing helper"
+    end
+
+    def helper_present?(helper)
+      path = helper_path_without_symlinks(helper)
+      path && File.file?(path)
+    end
+
+    def helper_path_without_symlinks(helper)
+      return if symlink_in_path?(helper)
+
+      File.join(destination_root, helper)
+    end
+
+    def symlink_in_path?(helper)
+      path = destination_root
+      helper.split(File::SEPARATOR).any? do |component|
+        path = File.join(path, component)
+        File.symlink?(path)
+      end
+    end
+  end
 end