quality_gate 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dc4fe18802dfc3fb409d11c8db6eb816df282e1914cd143807436998724eaf19
-  data.tar.gz: f1529c7f7cf1959a889fcc8a88691da70853ccb36e499718a5d56918e58add21
+  metadata.gz: 661dea9969d01c65c60ef01523cbdfc2ebae74be253bd3f78b5420b34aad934a
+  data.tar.gz: 6a34cb55d86a89885c635dd0c1b77d203c5432c4f85035b232510e23baa1aad2
 SHA512:
-  metadata.gz: f5d316d6426037588e9b895ed9f0d0a18d6f59e06b6666d8b37fd079af1bab0dddf991c1b756385ef90a6f5ae562da322f65a704f55d71b302adf5d9de90c63b
-  data.tar.gz: 2a21cb8513b65b1fb5fee6187bb303ae1ece9f575c9d1ae0c46c7cff5e2f27be7e12a88c6543cb9c29fb10fb636e02d0ebd4bab5b246c6d5ba6f99f51505ab39
+  metadata.gz: 0475a1a8e435e68effb9ea72bfbe3a82c69be9fb66e9c9e14c6cb983aec9354adb2754848a181dba35a128032e6131b1a3ed852defe5f838e1cb8d90589cc05a
+  data.tar.gz: 017605cf3e353c4e1861f03fd0e7fa2ac1ee1c6cedb6ba8fdfdbe99827bf1d186997b3ac794774f0259a23eb36b20a08f6a5957c8e67b7a43d65860755af4399

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.2.1] - 2026-09-22
+
+- Undercover reports stale coverage as an actionable `stale_coverage` finding with gate exit 1, telling operators to re-run the test suite before the coverage gate, instead of a parse failure with exit 2. Unknown validation reasons also fail closed and include their value; malformed output and CLI exit-status checks remain strict.
+
 ## [0.2.0] - 2026-09-21
 
 - Gate commands accept `--format markdown` and `format: markdown`, printing a heading with the tally, a checks table, and a findings list for agents and pull request comments.

data/README.md

@@ -581,14 +581,49 @@ Clone the repository and install its dependencies:
 bin/setup
 ```
 
-Run the tests, lint checks, or complete default task:
+Run the tests in two separate Ruby processes, lint checks, or complete serial default task:
 
 ```sh
-bundle exec rake test
+bundle exec rake test:parallel
 bundle exec rubocop
 bundle exec rake
 ```
 
+`TEST_WORKERS=4 bundle exec rake test:parallel` changes the worker count.
+`bundle exec rake test` preserves the serial runner and its Minitest filtering
+options; `test:parallel` accepts the same `N`, `X`, and `A` filters. Named latency
+checks (`QUALITY_GATE_ACCEPTANCE_TIMING=1`) always use one worker so concurrent
+tests do not distort their measurements.
+
+This repository's `quality_gate verify` uses the parallel task. Each worker writes
+isolated coverage results; the parent merges them and generates reports only after
+every worker succeeds and supplies coverage. `TEST_WORKERS=1 bundle exec quality_gate verify`
+runs the same coverage pipeline with one worker. CI runs RuboCop separately and
+lets verify run the full suite once per Ruby version.
+
+To investigate test performance with [TestProf](https://github.com/test-prof/test-prof),
+run the serial suite without coverage instrumentation:
+
+```sh
+QUALITY_GATE_PROFILE=1 COVERAGE=0 bundle exec rake test
+```
+
+This opt-in run prints a TagProf breakdown by test directory and an EventProf
+report for `subprocess.quality_gate`, including the ten slowest suites and tests.
+The event measures synchronous `Open3.capture2`, `capture2e`, and `capture3`
+calls, including time waiting for child processes. It does not measure work
+inside those processes or the adapter's separate `popen`/wait implementation.
+The profiling switch is consumed before tests run so nested test projects keep
+their normal output. Ordinary runs do not enable the profilers, and TestProf is
+only a development/test dependency.
+
+Use the serial task for a single report; parallel profiling produces a separate
+report per worker. Existing Minitest filters still apply, for example:
+
+```sh
+QUALITY_GATE_PROFILE=1 COVERAGE=0 bundle exec rake test N=/test_clean_fixture/
+```
+
 The gem is linted by the configuration it ships, so the Sandi Metz budgets apply to its own code. Violations that predate those budgets are frozen file by file in `.rubocop_todo.yml`, which keeps the gate green while forcing new code to meet the budgets. That file is a ratchet: it may only shrink. When you change a file listed there, bring it under the budget and delete its entry; never add one. Regenerate it only after such a burn-down:
 
 ```sh

data/lib/quality_gate/adapters/undercover.rb

@@ -39,8 +39,7 @@ module QualityGate
 
         stdout, stderr, status = capture_with_remaining_timeout(command)
         validate_cli_envelope!(stdout, stderr, status)
-        findings = parse(stdout)
-        validate_cli_result!(status.exitstatus, findings)
+        findings = parse(stdout, exitstatus: status.exitstatus)
         validate_findings!(findings, expected_tool: tool)
         findings
       rescue StandardError => e
@@ -49,11 +48,13 @@ module QualityGate
         clear_call_budget
       end
 
-      def parse(stdout)
+      def parse(stdout, exitstatus: nil)
         document = parsed_document(stdout)
         warnings, summary = report_parts(document)
         findings = warnings.map { finding_from(_1) }
         validate_summary!(summary, warnings)
+        validate_cli_result!(exitstatus, warnings)
+        findings << validation_finding(document["validation"]) unless document["validation"].nil?
         findings
       rescue JSON::ParserError, KeyError, TypeError, ArgumentError => e
         raise ParseError.new(tool: name, reason: e.message)
@@ -97,8 +98,10 @@ module QualityGate
         cli_contract_error!("Undercover output is missing its terminal timing footer")
       end
 
-      def validate_cli_result!(exitstatus, findings)
-        expected_exitstatus = findings.empty? ? 0 : 1
+      def validate_cli_result!(exitstatus, warnings)
+        return if exitstatus.nil?
+
+        expected_exitstatus = warnings.empty? ? 0 : 1
         return if exitstatus == expected_exitstatus
 
         cli_contract_error!("Undercover exit status #{exitstatus} disagrees with its warning count")
@@ -120,7 +123,6 @@ module QualityGate
         summary = document.fetch("summary")
         raise TypeError, "warnings must be an Array" unless warnings.is_a?(Array)
         raise TypeError, "summary must be a mapping" unless summary.is_a?(Hash)
-        raise TypeError, "validation must be nil" unless document["validation"].nil?
 
         [warnings, summary]
       end
@@ -145,6 +147,28 @@ module QualityGate
         )
       end
 
+      def validation_finding(validation)
+        raise TypeError, "validation must be a String or nil" unless validation.is_a?(String)
+
+        Finding.new(
+          tool: name,
+          file: "",
+          line: 0,
+          rule: validation == "stale_coverage" ? "stale_coverage" : "undercover_validation",
+          severity: :error,
+          message: validation_message(validation)
+        )
+      end
+
+      def validation_message(validation)
+        if validation == "stale_coverage"
+          "Undercover coverage data predates the changed files. Re-run the test suite before the coverage gate."
+        else
+          "Undercover validation failed: #{validation.inspect}. Coverage cannot be trusted; " \
+            "resolve the validation issue and re-run the test suite before the coverage gate."
+        end
+      end
+
       def skip_reason
         return "Undercover skipped: repository is shallow; set compare_point explicitly." if shallow_repository?
         return detached_reason if detached_head? && default_branch_present?

data/lib/quality_gate/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module QualityGate
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quality_gate
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Lucian Ghinda