quality 37.1.1 → 38.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e394e347040933d69847c4582fc43a3f15ab5325fb0c906da179a3ef04dd978
-  data.tar.gz: 14e4a38f238945557a8d1b8e164a03f67e09a96ac3453886fff14746f75312f0
+  metadata.gz: 313add6992c8a1f267328a1806dd28365c4d1a9f5c6bd1c8647cab8ea0dcc13f
+  data.tar.gz: 239a065dbee555879d31febe98f182351899bbc4d60546f842eed7228a076d6d
 SHA512:
-  metadata.gz: 32e74ae8aa22d4b8a0864f7ea7a6abfd213ccb64ec3c73c716706d95f053adf024638732344b786023a784b75e88a7ea7420cce549b4602ed8e5f0c209f01af4
-  data.tar.gz: 461e2d650b35393e64376e9f16f95704ef82fac9bd2f34caa5e6fab82719585327e184e753865edff79fb570ab044b807a33fa132cc7911c05fcd4242de28159
+  metadata.gz: de7208c080d5b76b4315d1cb12ad1c8cb231c8a3e41de3fb4a969ae3111a90d69190d23bcdcf7a6f29eace8fb50b2dbcfb412bd93ba97b85ae3600bcb4a78143
+  data.tar.gz: f1e306ac0000e7687f098b8e30dfbc82fa58edccb040904ae979573c261c20068a2454a8e7bb62344d534de9a8aeb2374879e6db2df51ba2238d2c92156c9703

data/README.md

@@ -149,7 +149,9 @@ updates.
 
 This includes RuboCop upgrades - the quality gem locks in a specific
 minor version of RuboCop to avoid your metrics being bumped and
-breaking your build.
+breaking your build.  This lock affects both the Docker-based quality
+gem (helping to ensure build stability for floating major versions) as
+well as the gem when included directly in your project's gems.
 
 Expect your build to break on major upgrades if you use RuboCop.
 

data/lib/quality/command_output_processor.rb

@@ -23,9 +23,7 @@ module Quality
 
     def process_file(file, &count_violations_on_line)
       out = ''
-      while (@current_line = file.gets)
-        out += process_line(&count_violations_on_line)
-      end
+      out += process_line(&count_violations_on_line) while (@current_line = file.gets)
       out
     end
 

data/lib/quality/quality_checker.rb

@@ -110,9 +110,7 @@ module Quality
     end
 
     def report_violations(existing)
-      if existing != MAX_VIOLATIONS
-        @logger.puts "Existing violations: #{existing}"
-      end
+      @logger.puts "Existing violations: #{existing}" if existing != MAX_VIOLATIONS
       @logger.puts "Found #{@violations} #{@cmd} violations"
     end
 

data/lib/quality/tools/bigfiles.rb

@@ -8,9 +8,7 @@ module Quality
     class Bigfiles < Tool
       def bigfiles_args
         args = ['--glob', "'#{source_and_doc_files_glob}'"]
-        unless source_files_exclude_glob == '{}'
-          args << ['--exclude-glob', "'#{source_files_exclude_glob}'"]
-        end
+        args << ['--exclude-glob', "'#{source_files_exclude_glob}'"] unless source_files_exclude_glob == '{}'
         args.join(' ')
       end
 

data/lib/quality/tools/cane.rb

@@ -20,9 +20,7 @@ module Quality
         args = [
           "-f '#{ruby_files_glob}'",
         ]
-        unless exclude_files.nil? || exclude_files.empty?
-          args += cane_exclude_args
-        end
+        args += cane_exclude_args unless exclude_files.nil? || exclude_files.empty?
         args.join(' ')
       end
 

data/lib/quality/tools/punchlist.rb

@@ -7,9 +7,7 @@ module Quality
       def punchlist_args
         glob = "--glob '#{source_and_doc_files_glob}'"
         regexp = " --regexp '#{punchlist_regexp}'" if punchlist_regexp
-        unless source_files_exclude_glob == '{}'
-          exclude = " --exclude-glob '#{source_files_exclude_glob}'"
-        end
+        exclude = " --exclude-glob '#{source_files_exclude_glob}'" unless source_files_exclude_glob == '{}'
 
         args = glob
         args += regexp if regexp

data/lib/quality/version.rb

@@ -4,5 +4,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '37.1.1'
+  VERSION = '38.0.0'
 end

data/quality.gemspec

@@ -42,7 +42,7 @@ Gem::Specification.new do |s|
   #
   # https://github.com/bbatsov/rubocop#installation
   s.add_runtime_dependency('mdl')
-  s.add_runtime_dependency('rubocop', '~> 0.78.0')
+  s.add_runtime_dependency('rubocop', '~> 0.92.0')
   # 0.2.0 had a fatal bug
   s.add_runtime_dependency('bigfiles', ['>= 0.1', '!= 0.2.0'])
   s.add_runtime_dependency('brakeman')
@@ -52,13 +52,8 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency('rubocop-minitest')
   s.add_runtime_dependency('rubocop-rake')
   # 1.19.0 was a RuboCop 0.51.0 compatibility release
+  s.add_runtime_dependency('faraday', ['~>1'])
   s.add_runtime_dependency('rubocop-rspec', ['>=1.19.0'])
-  # not directly required - this is to workaround this issue:
-  #  https://github.com/octokit/octokit.rb/issues/1177
-  #
-  # This causes:
-  #  "uninitialized constant Faraday::Error::ClientError (NameError)"
-  s.add_runtime_dependency('faraday', ['<1'])
 
   # need above 3.2.2 to support Ruby 2.0 syntax
   #

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 37.1.1
+  version: 38.0.0
 platform: ruby
 authors:
 - Vince Broz
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-01-05 00:00:00.000000000 Z
+date: 2020-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -148,14 +148,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.78.0
+        version: 0.92.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.78.0
+        version: 0.92.0
 - !ruby/object:Gem::Dependency
   name: bigfiles
   requirement: !ruby/object:Gem::Requirement
@@ -261,33 +261,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rspec
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.19.0
+        version: '1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.19.0
+        version: '1'
 - !ruby/object:Gem::Dependency
-  name: faraday
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: 1.19.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: 1.19.0
 - !ruby/object:Gem::Dependency
   name: ruby_parser
   requirement: !ruby/object:Gem::Requirement
@@ -507,7 +507,7 @@ homepage: http://github.com/apiology/quality
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -523,7 +523,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Code quality tools for Ruby
 test_files: []