quality 37.0.0 → 38.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c6e41075a75632729495d06a8d99f5a96a5d3256ab509f99fda27a20c90425e
-  data.tar.gz: bb0f8c7a16417cd6c240d40c846f89518977a4a729a5f7102f63476922eca0e6
+  metadata.gz: 48e5a658826a5173325eff4e5619770ea522511d7abfbcaab02aa34c56bd7ae6
+  data.tar.gz: 4e8e75ced5fa378412558485e865e5d0a0713ce4a549db77a235d0a6bf575fdc
 SHA512:
-  metadata.gz: 79be96733f293dffc553f942a66357becbd953061df2dfed6f3d4d7f8e78abdc6459e45da26a835bf068d1206912690a1124f9abc922aca84d309316fa6b15c9
-  data.tar.gz: 6a17209dd3f51ad443e3ebcfcce37a36c08d4e6b8ffeda64399dcfcc23484c49e63eca3782a6e0ca1a9adbb7f10683e85fdb520e9cc609f3e41ccaf798412aab
+  metadata.gz: bad91c1209954febba291e7d91a86624ed722f7c51475c2a2bd284ec7814c6963bd3ca157a5967535ac611a01d76112f64d029381404be97c7f563d1e5dfac22
+  data.tar.gz: 5b155a764d1387c64faceb9998fc7539e9753cb7bc2c7fd2c79ec90feeebf4db257e7060c629b3fbd8c1717d89fee2401a4bc2a93860b1efc4b62cf5ceb56f96

data/README.md

@@ -149,7 +149,9 @@ updates.
 
 This includes RuboCop upgrades - the quality gem locks in a specific
 minor version of RuboCop to avoid your metrics being bumped and
-breaking your build.
+breaking your build.  This lock affects both the Docker-based quality
+gem (helping to ensure build stability for floating major versions) as
+well as the gem when included directly in your project's gems.
 
 Expect your build to break on major upgrades if you use RuboCop.
 

data/lib/quality/command_output_processor.rb

@@ -23,9 +23,7 @@ module Quality
 
     def process_file(file, &count_violations_on_line)
       out = ''
-      while (@current_line = file.gets)
-        out += process_line(&count_violations_on_line)
-      end
+      out += process_line(&count_violations_on_line) while (@current_line = file.gets)
       out
     end
 

data/lib/quality/directory_of_classes.rb

@@ -1,5 +1,13 @@
 # frozen_string_literal: true
 
+# this 'time' require statement is needed as of active_support, which
+# tries to remap the xmlschema method.  Turns out there are two 'Time'
+# classes - methods get added when you "require 'time'".
+#
+# https://github.com/rails/rails/pull/40859
+#
+# https://app.circleci.com/pipelines/github/apiology/checkoff/46/workflows/27702e5f-ce86-4960-8b5e-f5277ddf159e/jobs/124
+require 'time'
 require 'active_support'
 require 'active_support/core_ext'
 

data/lib/quality/quality_checker.rb

@@ -3,7 +3,7 @@
 require_relative 'command_output_processor'
 require_relative 'process'
 require_relative 'ruby_spawn'
-require_relative 'threshold'
+require 'high_water_mark/threshold'
 
 module Quality
   # Runs a quality-checking, command, checks it agaist the existing
@@ -29,10 +29,10 @@ module Quality
       @command_options = command_options
       @verbose = verbose
       @count_dir.mkdir(output_dir) unless @count_file.exists?(output_dir)
-      @threshold = Quality::Threshold.new(cmd,
-                                          count_io: count_io,
-                                          count_file: count_file,
-                                          output_dir: output_dir)
+      @threshold = HighWaterMark::Threshold.new(cmd,
+                                                count_io: count_io,
+                                                count_file: count_file,
+                                                output_dir: output_dir)
       @process_class = process_class
     end
 
@@ -110,9 +110,7 @@ module Quality
     end
 
     def report_violations(existing)
-      if existing != MAX_VIOLATIONS
-        @logger.puts "Existing violations: #{existing}"
-      end
+      @logger.puts "Existing violations: #{existing}" if existing != MAX_VIOLATIONS
       @logger.puts "Found #{@violations} #{@cmd} violations"
     end
 

data/lib/quality/tools/bigfiles.rb

@@ -8,9 +8,7 @@ module Quality
     class Bigfiles < Tool
       def bigfiles_args
         args = ['--glob', "'#{source_and_doc_files_glob}'"]
-        unless source_files_exclude_glob == '{}'
-          args << ['--exclude-glob', "'#{source_files_exclude_glob}'"]
-        end
+        args << ['--exclude-glob', "'#{source_files_exclude_glob}'"] unless source_files_exclude_glob == '{}'
         args.join(' ')
       end
 

data/lib/quality/tools/cane.rb

@@ -20,9 +20,7 @@ module Quality
         args = [
           "-f '#{ruby_files_glob}'",
         ]
-        unless exclude_files.nil? || exclude_files.empty?
-          args += cane_exclude_args
-        end
+        args += cane_exclude_args unless exclude_files.nil? || exclude_files.empty?
         args.join(' ')
       end
 

data/lib/quality/tools/punchlist.rb

@@ -7,9 +7,7 @@ module Quality
       def punchlist_args
         glob = "--glob '#{source_and_doc_files_glob}'"
         regexp = " --regexp '#{punchlist_regexp}'" if punchlist_regexp
-        unless source_files_exclude_glob == '{}'
-          exclude = " --exclude-glob '#{source_files_exclude_glob}'"
-        end
+        exclude = " --exclude-glob '#{source_files_exclude_glob}'" unless source_files_exclude_glob == '{}'
 
         args = glob
         args += regexp if regexp

data/lib/quality/version.rb

@@ -4,5 +4,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '37.0.0'
+  VERSION = '38.0.1'
 end

data/quality.gemspec

@@ -42,21 +42,18 @@ Gem::Specification.new do |s|
   #
   # https://github.com/bbatsov/rubocop#installation
   s.add_runtime_dependency('mdl')
-  s.add_runtime_dependency('rubocop', '~> 0.78.0')
-  # 1.19.0 was a RuboCop 0.51.0 compatibility release
-  s.add_runtime_dependency('bigfiles', ['>= 0.1'])
+  s.add_runtime_dependency('rubocop', '~> 0.92.0')
+  # 0.2.0 had a fatal bug
+  s.add_runtime_dependency('bigfiles', ['>= 0.1', '!= 0.2.0'])
   s.add_runtime_dependency('brakeman')
+  s.add_runtime_dependency('high_water_mark')
   s.add_runtime_dependency('punchlist', ['>= 1.1'])
   s.add_runtime_dependency('rails_best_practices')
   s.add_runtime_dependency('rubocop-minitest')
   s.add_runtime_dependency('rubocop-rake')
+  # 1.19.0 was a RuboCop 0.51.0 compatibility release
+  s.add_runtime_dependency('faraday', ['~>1'])
   s.add_runtime_dependency('rubocop-rspec', ['>=1.19.0'])
-  # not directly required - this is to workaround this issue:
-  #  https://github.com/octokit/octokit.rb/issues/1177
-  #
-  # This causes:
-  #  "uninitialized constant Faraday::Error::ClientError (NameError)"
-  s.add_runtime_dependency('faraday', ['<1'])
 
   # need above 3.2.2 to support Ruby 2.0 syntax
   #
@@ -72,9 +69,11 @@ Gem::Specification.new do |s|
   s.add_development_dependency('minitest', ['~> 5'])
   s.add_development_dependency('mocha')
   s.add_development_dependency('pronto')
+  s.add_development_dependency('pronto-bigfiles')
   s.add_development_dependency('pronto-flake8')
   s.add_development_dependency('pronto-punchlist')
   s.add_development_dependency('pronto-rubocop')
-  s.add_development_dependency('rake', ['!= 10.4.2'])
+  # https://github.com/advisories/GHSA-jppv-gw3r-w3q8
+  s.add_development_dependency('rake', ['>= 12.3.3'])
   s.add_development_dependency('rspec')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 37.0.0
+  version: 38.0.1
 platform: ruby
 authors:
 - Vince Broz
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-01-02 00:00:00.000000000 Z
+date: 2020-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -148,14 +148,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.78.0
+        version: 0.92.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.78.0
+        version: 0.92.0
 - !ruby/object:Gem::Dependency
   name: bigfiles
   requirement: !ruby/object:Gem::Requirement
@@ -163,6 +163,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0.1'
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 0.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -170,6 +173,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0.1'
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: brakeman
   requirement: !ruby/object:Gem::Requirement
@@ -184,6 +190,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: high_water_mark
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: punchlist
   requirement: !ruby/object:Gem::Requirement
@@ -241,33 +261,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rspec
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.19.0
+        version: '1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.19.0
+        version: '1'
 - !ruby/object:Gem::Dependency
-  name: faraday
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: 1.19.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: 1.19.0
 - !ruby/object:Gem::Dependency
   name: ruby_parser
   requirement: !ruby/object:Gem::Requirement
@@ -358,6 +378,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pronto-bigfiles
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pronto-flake8
   requirement: !ruby/object:Gem::Requirement
@@ -404,16 +438,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "!="
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 10.4.2
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "!="
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 10.4.2
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -448,7 +482,6 @@ files:
 - lib/quality/rake/task.rb
 - lib/quality/ruby_spawn.rb
 - lib/quality/runner.rb
-- lib/quality/threshold.rb
 - lib/quality/tool.rb
 - lib/quality/tools/bigfiles.rb
 - lib/quality/tools/brakeman.rb
@@ -474,7 +507,7 @@ homepage: http://github.com/apiology/quality
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -490,7 +523,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Code quality tools for Ruby
 test_files: []

data/lib/quality/threshold.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-module Quality
-  # Calculate threshold for quality gem tool
-  class Threshold
-    attr_reader :tool_name
-
-    def initialize(tool_name,
-                   count_file: File,
-                   count_io: IO,
-                   output_dir: 'metrics')
-      @tool_name = tool_name
-      @count_file = count_file
-      @count_io = count_io
-      @filename = File.join(output_dir, "#{tool_name}_high_water_mark")
-    end
-
-    def threshold
-      return @count_io.read(@filename).to_i if @count_file.exist?(@filename)
-    end
-
-    def write_violations(new_violations)
-      @count_file.open(@filename, 'w') do |file|
-        file.write(new_violations.to_s + "\n")
-      end
-    end
-  end
-end