quality 36.1.0 → 38.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c66b37cdb110269046721f38cafb06eca1f8d96cec35d3c3ef2e5650d72e5ce
-  data.tar.gz: 82e46462a6ffa1ebb9e5eda340b9cb9817e5057026f9b9f2a3898d5a86ed380f
+  metadata.gz: 313add6992c8a1f267328a1806dd28365c4d1a9f5c6bd1c8647cab8ea0dcc13f
+  data.tar.gz: 239a065dbee555879d31febe98f182351899bbc4d60546f842eed7228a076d6d
 SHA512:
-  metadata.gz: 8901276ecd9d6e8ea29b568ee8f22e75acf7ebc08fb2641ed1604a203272983358f6d7df7f5756498e31f7b210802f105fce9f7a902148748970a6a6a539125a
-  data.tar.gz: d3d62de966cf078e7201972bb60ac07b4582af0872b6e21b8ee3892376a158a17e05ba6a2e5b94ce35e7c9f36c7b839e529e682e3d30ee5d377732c297c73910
+  metadata.gz: de7208c080d5b76b4315d1cb12ad1c8cb231c8a3e41de3fb4a969ae3111a90d69190d23bcdcf7a6f29eace8fb50b2dbcfb412bd93ba97b85ae3600bcb4a78143
+  data.tar.gz: f1e306ac0000e7687f098b8e30dfbc82fa58edccb040904ae979573c261c20068a2454a8e7bb62344d534de9a8aeb2374879e6db2df51ba2238d2c92156c9703

data/README.md

@@ -1,7 +1,6 @@
 # Quality -- code quality ratchet for Ruby
 
 [![Build Status](https://travis-ci.org/apiology/quality.png)](https://travis-ci.org/apiology/quality)
-[![Coverage Status](https://coveralls.io/repos/apiology/quality/badge.png?branch=master)](https://coveralls.io/r/apiology/quality?branch=master)
 
 ## Overview
 
@@ -150,7 +149,9 @@ updates.
 
 This includes RuboCop upgrades - the quality gem locks in a specific
 minor version of RuboCop to avoid your metrics being bumped and
-breaking your build.
+breaking your build.  This lock affects both the Docker-based quality
+gem (helping to ensure build stability for floating major versions) as
+well as the gem when included directly in your project's gems.
 
 Expect your build to break on major upgrades if you use RuboCop.
 

data/lib/quality/command_output_processor.rb

@@ -23,9 +23,7 @@ module Quality
 
     def process_file(file, &count_violations_on_line)
       out = ''
-      while (@current_line = file.gets)
-        out += process_line(&count_violations_on_line)
-      end
+      out += process_line(&count_violations_on_line) while (@current_line = file.gets)
       out
     end
 

data/lib/quality/quality_checker.rb

@@ -3,6 +3,7 @@
 require_relative 'command_output_processor'
 require_relative 'process'
 require_relative 'ruby_spawn'
+require 'high_water_mark/threshold'
 
 module Quality
   # Runs a quality-checking, command, checks it agaist the existing
@@ -28,7 +29,10 @@ module Quality
       @command_options = command_options
       @verbose = verbose
       @count_dir.mkdir(output_dir) unless @count_file.exists?(output_dir)
-      @filename = File.join(output_dir, "#{cmd}_high_water_mark")
+      @threshold = HighWaterMark::Threshold.new(cmd,
+                                                count_io: count_io,
+                                                count_file: count_file,
+                                                output_dir: output_dir)
       @process_class = process_class
     end
 
@@ -70,14 +74,7 @@ module Quality
     MAX_VIOLATIONS = 9_999_999_999
 
     def existing_violations
-      @existing_violations ||=
-        begin
-          if @count_file.exist?(@filename)
-            @count_io.read(@filename).to_i
-          else
-            MAX_VIOLATIONS
-          end
-        end
+      @existing_violations ||= (@threshold.threshold || MAX_VIOLATIONS)
     end
 
     def rendered_full_cmd
@@ -113,9 +110,7 @@ module Quality
     end
 
     def report_violations(existing)
-      if existing != MAX_VIOLATIONS
-        @logger.puts "Existing violations: #{existing}"
-      end
+      @logger.puts "Existing violations: #{existing}" if existing != MAX_VIOLATIONS
       @logger.puts "Found #{@violations} #{@cmd} violations"
     end
 
@@ -126,9 +121,7 @@ module Quality
     end
 
     def write_violations(new_violations)
-      @count_file.open(@filename, 'w') do |file|
-        file.write(new_violations.to_s + "\n")
-      end
+      @threshold.write_violations(new_violations)
     end
   end
 end

data/lib/quality/tools/bigfiles.rb

@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 
+require_relative '../tool'
+
 module Quality
   module Tools
     # Adds 'bigfiles' tool support to quality gem
     class Bigfiles < Tool
       def bigfiles_args
         args = ['--glob', "'#{source_and_doc_files_glob}'"]
-        unless source_files_exclude_glob == '{}'
-          args << ['--exclude-glob', "'#{source_files_exclude_glob}'"]
-        end
+        args << ['--exclude-glob', "'#{source_files_exclude_glob}'"] unless source_files_exclude_glob == '{}'
         args.join(' ')
       end
 

data/lib/quality/tools/cane.rb

@@ -20,9 +20,7 @@ module Quality
         args = [
           "-f '#{ruby_files_glob}'",
         ]
-        unless exclude_files.nil? || exclude_files.empty?
-          args += cane_exclude_args
-        end
+        args += cane_exclude_args unless exclude_files.nil? || exclude_files.empty?
         args.join(' ')
       end
 

data/lib/quality/tools/punchlist.rb

@@ -7,9 +7,7 @@ module Quality
       def punchlist_args
         glob = "--glob '#{source_and_doc_files_glob}'"
         regexp = " --regexp '#{punchlist_regexp}'" if punchlist_regexp
-        unless source_files_exclude_glob == '{}'
-          exclude = " --exclude-glob '#{source_files_exclude_glob}'"
-        end
+        exclude = " --exclude-glob '#{source_files_exclude_glob}'" unless source_files_exclude_glob == '{}'
 
         args = glob
         args += regexp if regexp

data/lib/quality/tools/rubocop.rb

@@ -7,6 +7,8 @@ module Quality
       def rubocop_args
         [
           '--force-exclusion',
+          '--require rubocop-minitest',
+          '--require rubocop-rake',
           '--require rubocop-rspec',
           '--format emacs',
           *ruby_files,

data/lib/quality/version.rb

@@ -4,5 +4,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '36.1.0'
+  VERSION = '38.0.0'
 end

data/quality.gemspec

@@ -1,4 +1,3 @@
-# -*- encoding: utf-8 -*-
 # frozen_string_literal: true
 
 # ; -*-Ruby-*-
@@ -43,12 +42,17 @@ Gem::Specification.new do |s|
   #
   # https://github.com/bbatsov/rubocop#installation
   s.add_runtime_dependency('mdl')
-  s.add_runtime_dependency('rubocop', '~> 0.78.0')
-  # 1.19.0 was a RuboCop 0.51.0 compatibility release
-  s.add_runtime_dependency('bigfiles', ['>= 0.1'])
+  s.add_runtime_dependency('rubocop', '~> 0.92.0')
+  # 0.2.0 had a fatal bug
+  s.add_runtime_dependency('bigfiles', ['>= 0.1', '!= 0.2.0'])
   s.add_runtime_dependency('brakeman')
+  s.add_runtime_dependency('high_water_mark')
   s.add_runtime_dependency('punchlist', ['>= 1.1'])
   s.add_runtime_dependency('rails_best_practices')
+  s.add_runtime_dependency('rubocop-minitest')
+  s.add_runtime_dependency('rubocop-rake')
+  # 1.19.0 was a RuboCop 0.51.0 compatibility release
+  s.add_runtime_dependency('faraday', ['~>1'])
   s.add_runtime_dependency('rubocop-rspec', ['>=1.19.0'])
 
   # need above 3.2.2 to support Ruby 2.0 syntax
@@ -63,13 +67,12 @@ Gem::Specification.new do |s|
   # Workaround for
   # https://github.com/bundler/bundler/issues/3401
   s.add_development_dependency('minitest', ['~> 5'])
-  # https://github.com/apiology/quality/issues/121
-  # https://github.com/freerange/mocha/issues/436
   s.add_development_dependency('mocha')
   s.add_development_dependency('pronto')
+  s.add_development_dependency('pronto-bigfiles')
   s.add_development_dependency('pronto-flake8')
   s.add_development_dependency('pronto-punchlist')
-  s.add_development_dependency('pronto-reek')
   s.add_development_dependency('pronto-rubocop')
   s.add_development_dependency('rake', ['!= 10.4.2'])
+  s.add_development_dependency('rspec')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 36.1.0
+  version: 38.0.0
 platform: ruby
 authors:
 - Vince Broz
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-12-27 00:00:00.000000000 Z
+date: 2020-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -148,14 +148,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.78.0
+        version: 0.92.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.78.0
+        version: 0.92.0
 - !ruby/object:Gem::Dependency
   name: bigfiles
   requirement: !ruby/object:Gem::Requirement
@@ -163,6 +163,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0.1'
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 0.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -170,6 +173,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0.1'
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: brakeman
   requirement: !ruby/object:Gem::Requirement
@@ -184,6 +190,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: high_water_mark
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: punchlist
   requirement: !ruby/object:Gem::Requirement
@@ -212,6 +232,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: faraday
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -317,7 +379,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pronto-flake8
+  name: pronto-bigfiles
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -331,7 +393,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pronto-punchlist
+  name: pronto-flake8
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -345,7 +407,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pronto-reek
+  name: pronto-punchlist
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -386,6 +448,20 @@ dependencies:
     - - "!="
       - !ruby/object:Gem::Version
         version: 10.4.2
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Quality is a tool that runs quality checks on your code using community
   tools, and makes sure your numbers don't get any worse over time. Just add 'rake
   quality' as part of your Continuous Integration
@@ -431,7 +507,7 @@ homepage: http://github.com/apiology/quality
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -447,7 +523,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Code quality tools for Ruby
 test_files: []