quality 36.1.0 → 37.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c66b37cdb110269046721f38cafb06eca1f8d96cec35d3c3ef2e5650d72e5ce
-  data.tar.gz: 82e46462a6ffa1ebb9e5eda340b9cb9817e5057026f9b9f2a3898d5a86ed380f
+  metadata.gz: 5c6e41075a75632729495d06a8d99f5a96a5d3256ab509f99fda27a20c90425e
+  data.tar.gz: bb0f8c7a16417cd6c240d40c846f89518977a4a729a5f7102f63476922eca0e6
 SHA512:
-  metadata.gz: 8901276ecd9d6e8ea29b568ee8f22e75acf7ebc08fb2641ed1604a203272983358f6d7df7f5756498e31f7b210802f105fce9f7a902148748970a6a6a539125a
-  data.tar.gz: d3d62de966cf078e7201972bb60ac07b4582af0872b6e21b8ee3892376a158a17e05ba6a2e5b94ce35e7c9f36c7b839e529e682e3d30ee5d377732c297c73910
+  metadata.gz: 79be96733f293dffc553f942a66357becbd953061df2dfed6f3d4d7f8e78abdc6459e45da26a835bf068d1206912690a1124f9abc922aca84d309316fa6b15c9
+  data.tar.gz: 6a17209dd3f51ad443e3ebcfcce37a36c08d4e6b8ffeda64399dcfcc23484c49e63eca3782a6e0ca1a9adbb7f10683e85fdb520e9cc609f3e41ccaf798412aab

data/README.md

@@ -1,7 +1,6 @@
 # Quality -- code quality ratchet for Ruby
 
 [![Build Status](https://travis-ci.org/apiology/quality.png)](https://travis-ci.org/apiology/quality)
-[![Coverage Status](https://coveralls.io/repos/apiology/quality/badge.png?branch=master)](https://coveralls.io/r/apiology/quality?branch=master)
 
 ## Overview
 

data/lib/quality/quality_checker.rb

@@ -3,6 +3,7 @@
 require_relative 'command_output_processor'
 require_relative 'process'
 require_relative 'ruby_spawn'
+require_relative 'threshold'
 
 module Quality
   # Runs a quality-checking, command, checks it agaist the existing
@@ -28,7 +29,10 @@ module Quality
       @command_options = command_options
       @verbose = verbose
       @count_dir.mkdir(output_dir) unless @count_file.exists?(output_dir)
-      @filename = File.join(output_dir, "#{cmd}_high_water_mark")
+      @threshold = Quality::Threshold.new(cmd,
+                                          count_io: count_io,
+                                          count_file: count_file,
+                                          output_dir: output_dir)
       @process_class = process_class
     end
 
@@ -70,14 +74,7 @@ module Quality
     MAX_VIOLATIONS = 9_999_999_999
 
     def existing_violations
-      @existing_violations ||=
-        begin
-          if @count_file.exist?(@filename)
-            @count_io.read(@filename).to_i
-          else
-            MAX_VIOLATIONS
-          end
-        end
+      @existing_violations ||= (@threshold.threshold || MAX_VIOLATIONS)
     end
 
     def rendered_full_cmd
@@ -126,9 +123,7 @@ module Quality
     end
 
     def write_violations(new_violations)
-      @count_file.open(@filename, 'w') do |file|
-        file.write(new_violations.to_s + "\n")
-      end
+      @threshold.write_violations(new_violations)
     end
   end
 end

data/lib/quality/threshold.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+module Quality
+  # Calculate threshold for quality gem tool
+  class Threshold
+    attr_reader :tool_name
+
+    def initialize(tool_name,
+                   count_file: File,
+                   count_io: IO,
+                   output_dir: 'metrics')
+      @tool_name = tool_name
+      @count_file = count_file
+      @count_io = count_io
+      @filename = File.join(output_dir, "#{tool_name}_high_water_mark")
+    end
+
+    def threshold
+      return @count_io.read(@filename).to_i if @count_file.exist?(@filename)
+    end
+
+    def write_violations(new_violations)
+      @count_file.open(@filename, 'w') do |file|
+        file.write(new_violations.to_s + "\n")
+      end
+    end
+  end
+end

data/lib/quality/tools/bigfiles.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../tool'
+
 module Quality
   module Tools
     # Adds 'bigfiles' tool support to quality gem

data/lib/quality/tools/rubocop.rb

@@ -7,6 +7,8 @@ module Quality
       def rubocop_args
         [
           '--force-exclusion',
+          '--require rubocop-minitest',
+          '--require rubocop-rake',
           '--require rubocop-rspec',
           '--format emacs',
           *ruby_files,

data/lib/quality/version.rb

@@ -4,5 +4,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '36.1.0'
+  VERSION = '37.0.0'
 end

data/quality.gemspec

@@ -1,4 +1,3 @@
-# -*- encoding: utf-8 -*-
 # frozen_string_literal: true
 
 # ; -*-Ruby-*-
@@ -49,7 +48,15 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency('brakeman')
   s.add_runtime_dependency('punchlist', ['>= 1.1'])
   s.add_runtime_dependency('rails_best_practices')
+  s.add_runtime_dependency('rubocop-minitest')
+  s.add_runtime_dependency('rubocop-rake')
   s.add_runtime_dependency('rubocop-rspec', ['>=1.19.0'])
+  # not directly required - this is to workaround this issue:
+  #  https://github.com/octokit/octokit.rb/issues/1177
+  #
+  # This causes:
+  #  "uninitialized constant Faraday::Error::ClientError (NameError)"
+  s.add_runtime_dependency('faraday', ['<1'])
 
   # need above 3.2.2 to support Ruby 2.0 syntax
   #
@@ -63,13 +70,11 @@ Gem::Specification.new do |s|
   # Workaround for
   # https://github.com/bundler/bundler/issues/3401
   s.add_development_dependency('minitest', ['~> 5'])
-  # https://github.com/apiology/quality/issues/121
-  # https://github.com/freerange/mocha/issues/436
   s.add_development_dependency('mocha')
   s.add_development_dependency('pronto')
   s.add_development_dependency('pronto-flake8')
   s.add_development_dependency('pronto-punchlist')
-  s.add_development_dependency('pronto-reek')
   s.add_development_dependency('pronto-rubocop')
   s.add_development_dependency('rake', ['!= 10.4.2'])
+  s.add_development_dependency('rspec')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 36.1.0
+  version: 37.0.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-27 00:00:00.000000000 Z
+date: 2020-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -212,6 +212,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -226,6 +254,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.19.0
+- !ruby/object:Gem::Dependency
+  name: faraday
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1'
 - !ruby/object:Gem::Dependency
   name: ruby_parser
   requirement: !ruby/object:Gem::Requirement
@@ -345,7 +387,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pronto-reek
+  name: pronto-rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -359,33 +401,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pronto-rubocop
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "!="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 10.4.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "!="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 10.4.2
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "!="
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 10.4.2
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "!="
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 10.4.2
+        version: '0'
 description: Quality is a tool that runs quality checks on your code using community
   tools, and makes sure your numbers don't get any worse over time. Just add 'rake
   quality' as part of your Continuous Integration
@@ -406,6 +448,7 @@ files:
 - lib/quality/rake/task.rb
 - lib/quality/ruby_spawn.rb
 - lib/quality/runner.rb
+- lib/quality/threshold.rb
 - lib/quality/tool.rb
 - lib/quality/tools/bigfiles.rb
 - lib/quality/tools/brakeman.rb