quality 30.0.1 → 31.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0d07c024080b1db800748592c08ce9b03989df7a
-  data.tar.gz: 62b0f35c9e751a480bb8a18307a112cf177c09c9
+  metadata.gz: d18279e26548cc804fc474d45f515f94487874d5
+  data.tar.gz: 7ee41bba669bb5da3b10ca1443af360e698715be
 SHA512:
-  metadata.gz: 0ec9a051a28b9d86586cde85c3b7519912fe161937766261b073ad823de1a0c1f9412ad85753979b57ebe8874bfd4c1c9821366b001b1b6c928f1156f6029563
-  data.tar.gz: 3bf65908ee5225e3a348c51e473295cbdf8475b55d34e3149a303a5998cb422f27e27656fe3c60fb9bc8d8f43e1850da2ef1a8aa4e7c16bbe38ce395cbed807e
+  metadata.gz: d532c0e7121c464cd59b343ec78386c3d3d8d75af6a5e093c271f063bf8bcb22b8177f6fc223e7384ce56a8982911a3194e72f8471bbfd4b7f669e5425c5dde9
+  data.tar.gz: c11b262e77e5d6f4d2528a9bb39452475759afb16a0f839b84d7172e9e7a7777d8676f2a9af1947ebd65e51f2de5dc39646c8b4c61a8a7bb7e5d0eb79dbcbe4f

data/README.md

@@ -28,7 +28,7 @@ Quality makes use of the following other tools, which do the actual checking:
 * [flay](https://github.com/seattlerb/flay)
 * [flog](https://github.com/seattlerb/flog)
 * [jscs](http://jscs.info/)
-* [pep8](https://pypi.python.org/pypi/pep8)
+* [pycodestyle](https://github.com/PyCQA/pycodestyle)
 * [punchlist](https://github.com/apiology/punchlist)
 * [rails_best_practices](https://github.com/railsbp/rails_best_practices)
 * [reek](https://github.com/troessner/reek)
@@ -54,7 +54,7 @@ jumbo-latest, jumbo-x.y.z, etc)
 ## How to use - as part of a Ruby-based Rakefile
 
 ```bash
-pip install pep8 flake8
+pip install pycodestyle flake8
 brew install cmake icu4c shellcheck scalastyle # OS X
 gem install quality
 ```

data/lib/quality/tools/{pep8.rb → pycodestyle.rb}

@@ -2,19 +2,19 @@
 
 module Quality
   module Tools
-    # Adds 'pep8' tool support to quality gem
-    module Pep8
+    # Adds 'pycodestyle' tool support to quality gem
+    module Pycodestyle
       private
 
-      def pep8_args
+      def pycodestyle_args
         python_files.join(' ')
       end
 
-      def pep8_count_errors(line)
+      def pycodestyle_count_errors(line)
         if line =~ /^Usage:/
           # no files specified
           0
-        elsif line =~ /^pep8: /
+        elsif line =~ /^pycodestyle: /
           # no files specified
           0
         elsif line =~ /^$/
@@ -25,12 +25,12 @@ module Quality
         end
       end
 
-      def quality_pep8
-        ratchet_quality_cmd('pep8',
-                            args: pep8_args,
+      def quality_pycodestyle
+        ratchet_quality_cmd('pycodestyle',
+                            args: pycodestyle_args,
                             gives_error_code_on_no_relevant_code:
                               true) do |line|
-          pep8_count_errors(line)
+          pycodestyle_count_errors(line)
         end
       end
     end

data/lib/quality/version.rb

@@ -4,5 +4,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '30.0.1'.freeze
+  VERSION = '31.0.0'.freeze
 end

data/quality.gemspec

@@ -39,6 +39,8 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency('reek', ['>= 1.3.4'])
   # flay 2.6.0 contained a command-line-parsing issue
   s.add_runtime_dependency('flay', ['>= 2.4', '!= 2.6.0'])
+  # avoid security issues - CVE-2015-1820, CVE-2015-3448
+  s.add_runtime_dependency('rest-client', ['>= 1.8.0'])
   #
   # per version advice here - locks quality gem version with rubocop
   # version to avoid unexplained metric-changing surprises:

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 30.0.1
+  version: 31.0.0
 platform: ruby
 authors:
 - Vince Broz
@@ -114,6 +114,20 @@ dependencies:
     - - "!="
       - !ruby/object:Gem::Version
         version: 2.6.0
+- !ruby/object:Gem::Dependency
+  name: rest-client
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.8.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.8.0
 - !ruby/object:Gem::Dependency
   name: mdl
   requirement: !ruby/object:Gem::Requirement
@@ -346,8 +360,8 @@ files:
 - lib/quality/tools/flog.rb
 - lib/quality/tools/jscs.rb
 - lib/quality/tools/mdl.rb
-- lib/quality/tools/pep8.rb
 - lib/quality/tools/punchlist.rb
+- lib/quality/tools/pycodestyle.rb
 - lib/quality/tools/rails_best_practices.rb
 - lib/quality/tools/reek.rb
 - lib/quality/tools/rubocop.rb
@@ -376,7 +390,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Code quality tools for Ruby