quality 23.0.7 → 24.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e9bc167ba873b117fd6a68918b2d725e6ed690c7
-  data.tar.gz: b6449ddb9ef200f22ede802b4b725ef0599b1800
+  metadata.gz: dd65945bd7c35435a89f463fdd85f22e8230ba3e
+  data.tar.gz: a3c9d4c3e91eaf36dc41be20894093f1b10e8bb3
 SHA512:
-  metadata.gz: fa41d35028970df19bd0a9ba63dd6f2bc2dd9cdeb3db366b14bee04783d8712a7ecb16854c0f2d55ff609405c3b303fbbc836e2bbd2fbe3df40e0c23766542ee
-  data.tar.gz: 814504792158be36626ff1ffd92d1fc0119a12f56505be93cf22d599d788a6e3a67e5a21c3735dbc89d4b4afd6b3b82c459f3e95516be44336ae02a9597ab3d0
+  metadata.gz: e037c248b2141330bb307387325cf761f8036e10e91f18785386d219de891eb3ada221670bafa47fffcbe74f3109f21f9b8b8e356f6a132d6310d3dc12949c89
+  data.tar.gz: c61ab972f3fbdd7a58c9304a1eeb210c75f4016f3911645f8d72888c0b205aa59b5ea45505e45817d7096b86b0905b6987d8ed655ddaf24c676e161abd7ddf4c

data/lib/quality/command_output_processor.rb

@@ -28,7 +28,7 @@ module Quality
       out
     end
 
-    def process_line
+    def process_line(&block)
       output =
         if emacs_format
           preprocess_line_for_emacs
@@ -36,7 +36,11 @@ module Quality
           @current_line
         end
       @found_output = true
-      @violations += yield @current_line
+      @violations += if block
+                       yield @current_line
+                     else
+                       1
+                     end
       output
     end
 

data/lib/quality/config.rb

@@ -15,9 +15,15 @@ module Quality
 
     extend Forwardable
 
-    def_delegators(:@source_file_globber, :ruby_files, :python_files,
-                   :js_files, :source_and_doc_files, :source_files,
-                   :exclude_files=, :exclude_files)
+    def_delegators(:@source_file_globber,
+                   :ruby_files,
+                   :python_files,
+                   :js_files,
+                   :shell_files,
+                   :source_and_doc_files,
+                   :source_files,
+                   :exclude_files=,
+                   :exclude_files)
 
     def to_glob(files)
       "{#{files.join(',')}}"

data/lib/quality/linguist_source_file_globber.rb

@@ -69,6 +69,10 @@ module Quality
       language_files('Python')
     end
 
+    def shell_files
+      language_files('Shell')
+    end
+
     def js_files
       language_files('JavaScript')
     end

data/lib/quality/runner.rb

@@ -79,17 +79,20 @@ module Quality
       existing_violations
     end
 
+    def command_name(ancestor, name)
+      if ancestor.respond_to? :command_name
+        ancestor.command_name
+      else
+        name
+      end
+    end
+
     def tools
       self.class.ancestors.map do |ancestor|
         ancestor_name = ancestor.to_s
         next unless ancestor_name.start_with?('Quality::Tools::')
         name = ancestor.to_s.split('::').last.underscore
-        command_name = if ancestor.respond_to? :command_name
-                         ancestor.command_name
-                       else
-                         name
-                       end
-        [name, command_name]
+        [name, command_name(ancestor, name)]
       end.compact
     end
 
@@ -106,6 +109,7 @@ module Quality
     def_delegators :@config,
                    :ruby_files,
                    :python_files,
+                   :shell_files,
                    :source_files,
                    :source_files_glob,
                    :source_and_doc_files,

data/lib/quality/tools/shellcheck.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module Quality
+  module Tools
+    # Adds 'ShellCheck' tool support to quality gem
+    module Shellcheck
+      private
+
+      def shellcheck_args
+        "-fgcc -sbash #{shell_files.join(' ')}"
+      end
+
+      def quality_shellcheck
+        ratchet_quality_cmd('shellcheck',
+                            args: shellcheck_args,
+                            gives_error_code_on_no_relevant_code: true,
+                            gives_error_code_on_violations: true)
+      end
+    end
+  end
+end

data/lib/quality/version.rb

@@ -4,5 +4,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '23.0.7'
+  VERSION = '24.0.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 23.0.7
+  version: 24.0.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-10 00:00:00.000000000 Z
+date: 2016-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -336,6 +336,7 @@ files:
 - lib/quality/tools/rails_best_practices.rb
 - lib/quality/tools/reek.rb
 - lib/quality/tools/rubocop.rb
+- lib/quality/tools/shellcheck.rb
 - lib/quality/version.rb
 - lib/quality/which.rb
 - quality.gemspec