quality 21.0.4 → 21.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 18fa65905d8ca7d7f8d968cd150c703a0426d680
-  data.tar.gz: 3e7618257f1e58499740908441209b386f662e85
+  metadata.gz: 0ba82925f9d35cd03980cf87ea36facd35294b85
+  data.tar.gz: 5748906f7e5a10a345e6b2f8ae2b8ab40da3a17b
 SHA512:
-  metadata.gz: 044dadea9230a9f069fda1f743430e9bfa6c128a9ce3f3bcbc1ba60181551f675ac502453f53460a4c8dcabab6926ca2140b0708e3d0712e15a2ea6c8a20a59e
-  data.tar.gz: 9b1e2e18c3ba98ab60b9c589dd320b3a4fc1327b8e050d43a7d6d23e4d3f90cfba739efef46e852b742e56435db0bec19e05c1edea4a403303a16589614b4bcf
+  metadata.gz: 709aeb06dce345bee67d09d96c5e8658394511b23894c7db4adfd00230fd90c1d9ed67f578e709f5e421cad496560e8e8da3f02caa5fdb6abb69e57138966d03
+  data.tar.gz: 817fb0244fef064802b2b8baa70572a4bc4d296d801e9cecb4981a5ab702302a94683fa136041327fcf8f976572bbdef6bd8a223166228bd4dd45a82f8e0c677

data/lib/quality/rake/task.rb

@@ -83,8 +83,10 @@ module Quality
              'the same' unless ::Rake.application.last_description
         @dsl.define_task(quality_name) { @runner.run_quality }
         @dsl.define_task(ratchet_name) { @runner.run_ratchet }
-        @runner.tools.each do |tool|
-          @dsl.define_task(tool) { @runner.run_quality_with_tool(tool) }
+        @runner.tools.each do |tool_name, tool_exe|
+          @dsl.define_task(tool_name) do
+            @runner.run_quality_with_tool(tool_exe)
+          end
         end
       end
     end

data/lib/quality/runner.rb

@@ -34,18 +34,20 @@ module Quality
     end
 
     def run_quality
-      tools.each { |tool| run_quality_with_tool(tool) }
+      tools.each do |tool_name, tool_exe|
+        run_quality_with_tool(tool_name, tool_exe)
+      end
     end
 
-    def run_quality_with_tool(tool)
-      suppressed = @config.skip_tools.include? tool
-      installed = @gem_spec.find_all_by_name(tool).any? ||
-                  !@which.which(tool).nil?
+    def run_quality_with_tool(tool_name, tool_exe)
+      suppressed = @config.skip_tools.include? tool_name
+      installed = @gem_spec.find_all_by_name(tool_name).any? ||
+                  !@which.which(tool_exe).nil?
 
       if installed && !suppressed
-        method("quality_#{tool}".to_sym).call
+        method("quality_#{tool_name}".to_sym).call
       elsif !installed
-        puts "#{tool} not installed"
+        puts "#{tool_name} not installed"
       end
     end
 
@@ -76,11 +78,13 @@ module Quality
       self.class.ancestors.map do |ancestor|
         ancestor_name = ancestor.to_s
         next unless ancestor_name.start_with?('Quality::Tools::')
-        # if ancestor.respond_to? :command_name
-        #  ancestor.command_name
-        # else
-          ancestor_name.split('::').last.underscore
-        # end
+        name = ancestor.to_s.split('::').last.underscore
+        command_name = if ancestor.respond_to? :command_name
+                         ancestor.command_name
+                       else
+                         name
+                       end
+        [name, command_name]
       end.compact
     end
 

data/lib/quality/tools/bundle_audit.rb

@@ -2,12 +2,12 @@ module Quality
   module Tools
     # Adds 'bundler_audit' tool support to quality gem
     module BundleAudit
-      private
-
       def self.command_name
         'bundle-audit'
       end
 
+      private
+
       def quality_bundle_audit
         ratchet_quality_cmd('bundle-audit', args: '') do |line|
           if line =~ /^Name: /

data/lib/quality/tools/cane.rb

@@ -16,7 +16,7 @@ module Quality
         args = [
           "-f '#{ruby_files_glob}'",
         ]
-        args += cane_exclude_args if !exclude_files.empty?
+        args += cane_exclude_args unless exclude_files.empty?
         args.join(' ')
       end
 

data/lib/quality/tools/punchlist.rb

@@ -7,7 +7,7 @@ module Quality
       def punchlist_args
         glob = "--glob '#{source_and_doc_files_glob}'"
         regexp = " --regexp '#{punchlist_regexp}'" if punchlist_regexp
-        if !exclude_files.empty?
+        unless exclude_files.empty?
           exclude = " --exclude-glob '#{source_files_exclude_glob}'"
         end
 

data/lib/quality/version.rb

@@ -2,5 +2,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '21.0.4'.freeze
+  VERSION = '21.0.5'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 21.0.4
+  version: 21.0.5
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-22 00:00:00.000000000 Z
+date: 2016-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport