quality 19.2.0 → 19.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e47bb64085ada30d3be31d1b91adb07ed0aa0e51
-  data.tar.gz: a79808375530728002c8a21dbf02e3a10dd490a0
+  metadata.gz: 2419ec7a0304aabcffc4d406dbdb2d39b84ad6a6
+  data.tar.gz: 5e83cfabae5da03934da1e76376cc577c8b7cb27
 SHA512:
-  metadata.gz: 96202c7579ed13d6c268e302ebdcd20bde306eebc2fdc8b8859a5cdbedbf39a1739d280f72d9e9f1d290b199f6084fc53558ddff5917406e8188db10aaa50ae8
-  data.tar.gz: 0dd376eae767ecd3978dfaa91b15512e05d697beb975d76e42f749b05d75a01ea9d3c023b4e7f762e3e175616577d0ddd2cafd4e816ed5a0478abf89b069b9b3
+  metadata.gz: f2509162901590ebd0f194d3818199bd852833435e26a8939f2c22a10bb32d4c6ea6be4563b97524bfcd8ae9ba284755a835bcb2960db26abf097d9b726b9ecc
+  data.tar.gz: 9336568f5350230577438cba1da1a3f03ef522866d89d37403b2952f45b3a23eb213db388ca6c2f14f51faacf6ce4fb554df64ef967caf97b5bc34f95969d13e

data/README.md

@@ -57,14 +57,14 @@ $ rake ratchet
 ## Configuration options
 
 ```ruby
-Quality::Rake::Task.new { |t|
+Quality::Rake::Task.new do |t|
   # Name of quality task.
   # Defaults to :quality.
-  t.quality_name = "quality"
+  t.quality_name = 'quality'
 
   # Name of ratchet task.
   # Defaults to :ratchet.
-  t.ratchet_name = "ratchet"
+  t.ratchet_name = 'ratchet'
 
   # Array of strings describing tools to be skipped--e.g., ["cane"]
   #
@@ -78,10 +78,12 @@ Quality::Rake::Task.new { |t|
 
   # Array of directory names which contain ruby files to analyze.
   #
-  # Defaults to %w(app lib test spec feature), which translates to *.rb in the base directory, as well as those directories.
+  # Defaults to %w(app lib test spec feature), which translates to
+  # *.rb in the base directory, as well as those directories.
   t.ruby_dirs = %w(app lib test spec feature)
 
-  # Array of directory names which contain any type of source files to analyze.
+  # Array of directory names which contain any type of source files to
+  # analyze.
   #
   # Defaults to t.ruby_dirs
   t.source_dirs.concat(%w(MyProject MyProjectTests))
@@ -95,12 +97,14 @@ Quality::Rake::Task.new { |t|
   t.extra_ruby_files = ['Rakefile']
 
   # Exclude the specified list of files--defaults to ['db/schema.rb']
-  t.exclude_files = ['lib/whatever/imported_file.rb', 'lib/vendor/someone_else_fault.rb']
+  t.exclude_files = ['lib/whatever/imported_file.rb',
+                     'lib/vendor/someone_else_fault.rb']
 
   # Alternately, express it as a glob:
 
   # Exclude the specified list of files
-  t.source_files_exclude_glob = "{lib/whatever/imported_file.rb,lib/vendor/**/*.rb}"
+  t.source_files_exclude_glob =
+    '{lib/whatever/imported_file.rb,lib/vendor/**/*.rb}'
 
   # Extensions for Ruby language files--defaults to 'rb,rake'
   t.ruby_file_extensions_glob = 'rb,rake'
@@ -121,7 +125,7 @@ Quality::Rake::Task.new { |t|
   #
   # Defaults to 'XXX|TODO'
   t.punchlist_regexp = 'XXX|TODO'
-}
+end
 ```
 
 ## Code coverage

data/lib/quality/tools/jscs.rb

@@ -9,10 +9,10 @@ module Quality
       end
 
       def jscs_check_configured
-        return if js_files_arr.empty?
+        return 0 if js_files_arr.empty?
 
         puts 'No JSCS config found!  To generate one, run ' \
-             'jscs --auto-configure ' + js_files_arr.join(' ')
+             'jscs --auto-configure representative_file.js'
         0
       end
 

data/lib/quality/tools/pep8.rb

@@ -11,7 +11,8 @@ module Quality
       def quality_pep8
         ratchet_quality_cmd('pep8',
                             args: pep8_args,
-                            gives_error_code_on_no_relevant_code: true) do |line|
+                            gives_error_code_on_no_relevant_code:
+                              true) do |line|
           line.split(':')[0].to_i
         end
       end

data/lib/quality/tools/rubocop.rb

@@ -25,6 +25,9 @@ module Quality
         def count_rubocop_violations(line)
           if line =~ /^.* file[s|] inspected, (.*) offence[s|] detected$/
             0
+          elsif line =~ /^warning: .*/
+            # don't count internal rubocop errors/warnings
+            0
           else
             1
           end

data/lib/quality/version.rb

@@ -2,5 +2,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '19.2.0'
+  VERSION = '19.2.1'
 end

data/lib/quality/which.rb

@@ -1,14 +1,25 @@
-class Which
-  # http://stackoverflow.com/questions/2108727/
-  #   which-in-ruby-checking-if-program-exists-in-path-from-ruby
-  def which(cmd)
-    exts = ENV['PATHEXT'] ? ENV['PATHEXT'].split(';') : ['']
-    ENV['PATH'].split(File::PATH_SEPARATOR).each do |path|
-      exts.each { |ext|
-        exe = File.join(path, "#{cmd}#{ext}")
-        return exe if File.executable?(exe) && !File.directory?(exe)
-      }
+# http://stackoverflow.com/questions/2108727/
+#   which-in-ruby-checking-if-program-exists-in-path-from-ruby
+module Quality
+  # Determine where a given executable lives, like the UNIX 'which' command
+  class Which
+    def initialize(env: ENV,
+                   file: File,
+                   separator: File::PATH_SEPARATOR)
+      @env = env
+      @file = file
+      @separator = separator
+    end
+
+    def which(cmd)
+      exts = @env['PATHEXT'] ? @env['PATHEXT'].split(';') : ['']
+      @env['PATH'].split(@separator).each do |path|
+        exts.each do |ext|
+          exe = @file.join(path, "#{cmd}#{ext}")
+          return exe if @file.executable?(exe) && !@file.directory?(exe)
+        end
+      end
+      nil
     end
-    return nil
   end
 end

data/quality.gemspec

@@ -30,7 +30,7 @@ Gem::Specification.new do |s|
   s.summary = 'Code quality tools for Ruby'
 
   s.add_runtime_dependency('activesupport')
-  s.add_runtime_dependency('source_finder', ['>=2.3.0'])
+  s.add_runtime_dependency('source_finder', ['>=2.4.1'])
   s.add_runtime_dependency('cane', ['>= 2.6'])
   s.add_runtime_dependency('reek', ['>= 1.3.4'])
   s.add_runtime_dependency('flog', ['>= 4.1.1'])

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 19.2.0
+  version: 19.2.1
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-29 00:00:00.000000000 Z
+date: 2016-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 2.4.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 2.4.1
 - !ruby/object:Gem::Dependency
   name: cane
   requirement: !ruby/object:Gem::Requirement